wine-devel February 2015

wine-devel@winehq.org

58 participants
166 discussions

Re: [5/5] comctl32: Implement the TaskDialog function
by Nikolay Sivov 19 Feb '15

19 Feb '15

On 19.02.2015 15:23, Joachim Priesner wrote: > } > > /*********************************************************************** > + * TaskDialog [COMCTL32.@] > + */ > +HRESULT WINAPI TaskDialog(HWND hWndParent, HINSTANCE hInstance, PCWSTR pszWindowTitle, > + PCWSTR pszMainInstruction, PCWSTR pszContent, > + TASKDIALOG_COMMON_BUTTON_FLAGS dwCommonButtons, PCWSTR pszIcon, > + int *pnButton) Please don't use prefixed notation for names. > +static void test_TaskDialog_ProcAddr(void) > +{ > + void *ptr = GetProcAddress(hComctl32, (const CHAR*)344); > + ok(ptr == pTaskDialog, "got wrong pointer for ordinal 344, %p expected %p\n", ptr, pTaskDialog); > +} > + This doesn't need its own test function. > START_TEST(taskdialog) > { > ULONG_PTR ctx_cookie; > @@ -80,11 +87,22 @@ START_TEST(taskdialog) > if (!pTaskDialogIndirect) > { > win_skip("TaskDialogIndirect() is missing. Skipping the tests\n"); > - return; > + } > + else > + { > + test_TaskDialogIndirect_ProcAddr(); > + test_TaskDialogIndirect_InvalidParameters(); > } > > - test_TaskDialogIndirect_ProcAddr(); > - test_TaskDialogIndirect_InvalidParameters(); > + pTaskDialog = (void*)GetProcAddress(hComctl32, "TaskDialog"); > + if (!pTaskDialog) > + { > + win_skip("TaskDialog() is missing. Skipping the tests\n"); > + } > + else > + { > + test_TaskDialog_ProcAddr(); > + } > I don't think you need two win_skip()'s here. If TaskDialogIndirect() is available, TaskDialog() is here too, right?

1 0

Re: [v2 1/4] reg: Add sane_path function to do preliniary key validation
by Stefan Dösinger 19 Feb '15

19 Feb '15

1 0

Re: [PATCH 1/3] ntdll/tests: Add tests for RtlIpv4StringToAddressEx, RtlIpv6StringToAddress (try 2)
by Stefan Dösinger 19 Feb '15

19 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I've already talked to Mark about this on #winehackers, just repeating it for the list: My remaining request with these tests is that I believe we should test the full set of inputs against the Ex and non-Ex versions and ideally reuse the test table (for base and ex, not for ipv4 and ipv6). That will tell us if there's any difference in the IP parsing part of the base and Ex functions. It'll also be interesting how the base function handles ports in the string, and, in case of ipv6, brackets around the IP. Other than that two minor style issues: Change the subject of patch one (it only handles RtlIpv4StringToAddressEx), and you still have different levels of indentation in the line continuations of some ok() statements. Cheers, Stefan Am 2015-02-15 um 18:02 schrieb Mark Jansen: > Add test for RtlIpv4StringToAddressEx > > --- dlls/ntdll/tests/rtl.c | 101 > +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, > 101 insertions(+) > > > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU4c5HAAoJEN0/YqbEcdMwnPIP/RT2i0fG4cPqKikwa26VbRyn EG2yeG78Wjx/vysLuQfGe8alhUycGrgMzW4N4m8QiAx/xNFv4eX0OdI+5gYMbSHK dYZSzTSKbqoJbnBlZwt1MoaaNceX/zIEy2WoaRCYpsUJfpscT/sOdJ+/gW55gDkH 605vvruhgJFSFVeZDVzfR9gQcY51iHB0KDemX2p1mwHElr6+HwYSHOQt+8KCL8YV wfC87NSMEAfEjIudYPL7SFHvUuLr3GoHBBt57R9p/2gNT7eJ7ll9ANvShFkRENjL jmKJQj7exehqrAGNWBqbeIPSjHBQoGl/UZPwIE39UioNhRo+sWi5A8tBbUMyL3o5 VENuxL987kU1L9Xpa6/jEcrQksgafCa742/wWSAjPGE0D2iTUr0hQN0zQoioTPA/ zuaDyDO3CBCyFaF0A9h9FzxOkuRAHo6TSKw0IYOrI2XENAoqQ+B+fX0ll9t/5Tu0 iUIea06yp2/fRButo58sJNAd3dUZpRKf1qT+Eu7Cn+AJfgi3TsKY/Lw0gvyb4XJh qOdp7EPzqY1PURn6+Z8aDwNZRA2du3NM91SSMfwz+qwZtakf8K/XtkpC1CpNLONJ kfltxHVALBKT0NTDzvprrSzvTVH90hJLE+nX/E5Qf6SzeRVqxsPomBtOj2VLuapZ 4ehIhXsaEJJz9jc31tr9 =E0dA -----END PGP SIGNATURE-----

2 2

Re: dlls/dsrole: Add undocumented api set
by Nikolay Sivov 19 Feb '15

19 Feb '15

On 19.02.2015 3:58, Andrew Cook wrote: > Required by native aclui.dll If it's the only user, it's questionable whether we need this module.

2 1

Re: [PATCH 4/5] wined3d: Reject unsupported pitches in wined3d_surface_update_desc().
by Stefan Dösinger 18 Feb '15

18 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-18 um 14:20 schrieb Matteo Bruni: > + if (pitch & (texture_resource->format->byte_count - 1)) > + { > + WARN("Pitch unsupported, not a multiple of the texture format byte width.\n"); > + return WINED3DERR_INVALIDCALL; > + } I'd prefer this to be an ERR instead, and the return statement removed. The idea is that since we don't ever expect this check to be true it shouldn't result in different behavior and can be compiled out in a build where debugging is disabled. The basic idea originated from Henri: https://www.winehq.org/pipermail/wine-devel/2013-August/100974.html . -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU5KrDAAoJEN0/YqbEcdMwdj0P/0kphTArNNtcxtIbt5noekiX wTwi7X6YhxkjryHENqvYKKO8ckBftBoxJHo9o4I82Cc+IRvj9GvrvvuZ5FuiMsJO 6dGmo5JSHnGGNG3rl/oZt31v3P/1LAba3GoFAgRwBfXCULue6gNRyC8+57ahlbLy xVWc2m249URRP3ML/O9+bXlzA61oQdS+5q54T+jmYv3X8K8AgDHATu114mcpxaAq hkHIKmW2WCoigCBrNHQTzcxMG3lsavMbnuMxSvQ/01/mwrKvmYYkvvBtR/AVI6W+ I7HLF4KZlz5BLZnS71joW2LLL35/z/3qtmaHi8dq/kCMaajow9dBQmstcUFvwJ4p UknSxgcCOgKreAZH3yTOH5LNgf8qZvB21wQ5Cn0NGEBW7bZKdUxfRftFN8IQY1Ht NhGB9cmvo3Ozv0z+i7wMfcXjntT9wL/2H77RqC4Xb9Z/igo+E2LJN0XqQYvwvtj7 wG4Fw5rH7vrO4g/IcfFYvbT7CMUYrPWtFaTfiMn5IOQZ4mx2gacktHcpZJnCUjw5 /uTQo+089YosnM+xY/WvDnjjI13svZt5c3gUMlvha30RjsX7PDfih/vNrr0qR5Y/ C6TLk8ffbmPOX6TTobndfZrWdb2sP3d7x1T1tx9nMAKJG0HFy5wvFoygEDOzFRYU tG/x7wnrmr3fYfUSEPJY =LuAf -----END PGP SIGNATURE-----

3 4

Re: [PATCH 4/5] wined3d: Set GL_UNPACK_ALIGNMENT to 1 when uploading surfaces from user memory.
by Henri Verbeet 18 Feb '15

18 Feb '15

On 10 February 2015 at 20:14, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > gl_info->gl_ops.gl.p_glPixelStorei(GL_UNPACK_ROW_LENGTH, src_pitch / format->byte_count); > + if (src_pitch & (surface_alignment - 1)) > + gl_info->gl_ops.gl.p_glPixelStorei(GL_UNPACK_ALIGNMENT, 1); What's a bit awkward about this is that if the pitch isn't a multiple of the pixel byte width it's still not going to work. But I guess this is the best we can do.

3 5

Re: icinfo: Do not output an extra space at end of line
by Stefan Dösinger 18 Feb '15

18 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-18 um 11:53 schrieb Hugh McMaster: > - if (ii.dwFlags & VIDCF_QUALITY) mywprintf(sspc_fmt, VIDCF_QUALITY_W); > + if (ii.dwFlags & VIDCF_QUALITY) mywprintf(s_fmt, VIDCF_QUALITY_W); > if (ii.dwFlags & VIDCF_CRUNCH) mywprintf(sspc_fmt, VIDCF_CRUNCH_W); I don't think this works. If VIDCF_QUALITY is not set, but any other flag is, it will now print a leading space. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU5IZUAAoJEN0/YqbEcdMwTg8QAI0rVUkh9r19pCZbCEPnk+AQ z5Da4dia28IpRlUYYW1bvZgxUpbWZi67NQr7oAs12fbhVMzyvoNxRI+J4bUpB/Rl sFxcNNIxwiJ47iVXzOQ54d4jO0SlhjsRB07hm9Z6o/DcNCPLXpq8UvDEErkHRHMp dZMF0D5dRTaxkqxXGIcks8kLT7yODKeCsG/T4oZ4D7eYMYoKaODmw7lUbcaRsTk1 hKcqdz9BfgmmwLk1xcs+Ssy/7sgN+smJPwGDWEWT2W0kto2M3OLb6Aot6olKncQo ngn1KIhPOzauomfW7+XFr6ezQZaBq4mPVqDYpN7ZHUewPl/1TUDYYIzMxDaXwZrx xcgNPcrKR3HQEF2JycYoWgxb3zTfn5h9M4Q5vtz218ytgD7h8dQGgGBBDnjhTnr6 JyJnvrj4OezLZF2BR4kDYfIKCSPk9VVfFiRe/b+HfcKH56Dv9ALcI8Dq0tk/G35G VY/4YQEselJ9P7KL/D4gqvl6pJLOwSU9162qUQzKEAktfzIREZqmyQQya1hgtwP3 TyY9rMJ8uubLh2Tqn0cUiZxQO7XjhTP1r/BSEyxrJkl3lAx/TCnIsBwNgd849JJK MVFHBFqzsvXdCG+CYU393HviueMdWnJ1nxZmhAIK9i/FpHRHw1fZtxUGlQYYiB28 sqoZ3ohbVUpuGCNjDRHI =+LZ8 -----END PGP SIGNATURE-----

2 1

Re: [PATCH] msvcr120: Implemented Concurrency::details::_Condition_variable.
by Piotr Caban 18 Feb '15

18 Feb '15

Hi, On 02/14/15 01:52, Yifu Wang wrote: > Implementation of Concurrency::details::_Condition_variable along with a producer-consumer test case. > The class is used in msvcp120.dll by _Cnd_t functions, which are used in std::condition_variable and std::thread. > --- > dlls/msvcr120/msvcr120.spec | 36 +++--- > dlls/msvcr120/tests/msvcr120.c | 277 +++++++++++++++++++++++++++++++++++++++++ > dlls/msvcrt/lock.c | 171 +++++++++++++++++++++++++ > 3 files changed, 466 insertions(+), 18 deletions(-) > Please also update msvcr110.spec and msvcr120_app.spec files. +@ thiscall -arch=i386 ?wait_for@_Condition_variable@details@Concurrency@@QAE_NAAVcritical_section@3@I@Z(ptr ptr ptr) _Condition_variable_wait_for The arguments types in spec file are incorrect (in this case there should be: ptr ptr long). I was not checking other entries. /* signal */ produced = consumed = 0; for(i = 0; i < NUM_PRODUCER; ++ i) t[i] = CreateThread(0, 0, producer_thread, (LPVOID)0, 0, 0); for(i = NUM_PRODUCER; i < NUM_PRODUCER + NUM_CONSUMER; ++ i) t[i] = CreateThread(0, 0, consumer_thread, (LPVOID)0, 0, 0); You don't need the (LPVOID)0 casts here. /* a quick sanity test on timed wait */ for(i = 0; i < 200; i += 10) { call_func1(p_critical_section_lock, &buf_cs); wake = (MSVCRT_bool)call_func3(p__Condition_variable_wait_for, &buf_not_empty, &buf_cs, i); ok(wake == FALSE, "_Condition_variable not supposed to wake\n"); call_func1(p_critical_section_unlock, &buf_cs); } I don't think that spending ~2 seconds on this tests is useful. It's enough to test it once (not in a loop). Cheers, Piotr

1 1

Re: version: Fix wrong length reported when selecting a block. (resend)
by Matteo Bruni 18 Feb '15

18 Feb '15

2015-02-18 8:49 GMT+01:00 Mark Jansen <learn0more+wine(a)gmail.com>: > You shouldnt make the buffer static or const, because the VerQuery > functions will write to it. Ah yes, you're right. Ignore that point then. BTW, adding back wine-devel to cc.

1 0

Re: kernel32/tests: Add tests for job objects (try 3)
by Andrew Cook 18 Feb '15

18 Feb '15

I'm never going to get this code in, am i? On Tue, 2015-02-17 at 11:00 +1100, Andrew Cook wrote: > Forgot a semicolon (i actually tested this one, it compiles) > > --- > dlls/kernel32/tests/Makefile.in | 1 + > dlls/kernel32/tests/job.c | 393 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 394 insertions(+) > create mode 100644 dlls/kernel32/tests/job.c > >

3 3

← Newer
1
...
4
5
6
7
8
9
10
...
17
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel February 2015