wine-devel February 2015

wine-devel@winehq.org

58 participants
166 discussions

Re: [PATCH] uxtheme: fix colour errors in UXTHEME_StretchBlt
by Nikolay Sivov 18 Feb '15

18 Feb '15

On 18.02.2015 3:59, Mark Harmstone wrote: > + old_stretch_mode = GetStretchBltMode(hdcDst); > + SetStretchBltMode(hdcDst, HALFTONE); This could be reduced to a single line.

1 0

Re: wininet: Include <unistd.h> in case we need off_t for zlib.
by Jacek Caban 18 Feb '15

18 Feb '15

Hi Gerald, On 02/15/15 17:16, Gerald Pfeifer wrote: > After commit 5436fef80722fe7896aed5e659c31fdade4ef5b3 > > Author: Jacek Caban <jacek(a)codeweavers.com> > Date: Fri Feb 13 12:12:29 2015 +0100 > > wininet: Always use winsock sockets. > > FreeBSD not longer builds due to the following change: > > #include "config.h" > -#include "wine/port.h" > > -#if defined(__MINGW32__) || defined (_MSC_VER) > -#include <ws2tcpip.h> … [View More]

2 1

Re: version: Fix wrong length reported when selecting a block. (resend)
by Stefan Dösinger 17 Feb '15

17 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-12 um 20:15 schrieb Mark Jansen: > LPWSTR lpSubBlockW; > + UINT dum = 0; > + if (!puLen) > + puLen = &dum; > > len = MultiByteToWideChar(CP_ACP, 0, lpSubBlock, -1, NULL, 0); > lpSubBlockW = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > @@ -965,7 +968,7 @@ BOOL WINAPI VerQueryValueA( LPCVOID pBlock, LPCSTR lpSubBlock, > > HeapFree(… [View More]

3 4

Re: [resend 1/8] reg: Add system error printing function
by Alexandre Julliard 17 Feb '15

17 Feb '15

Jonathan Vollebregt <jnvsor(a)gmail.com> writes: > +static void reg_print_error(LSTATUS error_code) > +{ > + switch (error_code) > + { > + case ERROR_SUCCESS: > + return; > + case ERROR_BAD_COMMAND: > + reg_message(STRING_INVALID_CMDLINE); > + return; > + default: > + { > + static const WCHAR error_string[] = {'%','0','5','d',':',' ','%','s',0}; > + WCHAR *… [View More]

2 3

Re: [PATCH (resend) 1/2] dpvoice/tests: Add GetCompressionTypes tests.
by Alexandre Julliard 17 Feb '15

17 Feb '15

Alex Henrie <alexhenrie24(a)gmail.com> writes: > @@ -343,6 +343,179 @@ static void create_voicetest(void) > } > } > > +static void test_GetCompressionTypes(HRESULT (__stdcall *GetCompressionTypes)(void*,void*,DWORD*,DWORD*,DWORD), > + void *iface, const char *name) These hacks with the void pointers are ugly. You should pass interface pointers and do a proper method call with one or the other, for instance something like this:… [View More]

1 0

Re: [PATCH] d3dx9_36: Consistently use 4 space indentation.
by Alexandre Julliard 17 Feb '15

17 Feb '15

Stefan Dösinger <stefan(a)codeweavers.com> writes: > Before the next guy copypastes the bottom code and adds more mess. Could you please stop with this code formatting obsession of yours? As long as the code is readable, it doesn't matter if there's a line here and there with slightly inconsistent formatting. I appreciate your helping with the code reviews, but please let's try to concentrate on the real problems. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/2] ddraw/tests: Port D3D1_ViewportClearTest to ddraw1.c (v2).
by Marvin 17 Feb '15

17 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11581 Your paranoid android. === w8 (32 bit visual) === visual.c:1617: Test failed: unexpected colortable on offscreen surface === wvistau64 (32 bit ddraw2) === ddraw2.c:2659: Test failed: Expected message 0x46, but didn't … [View More]

2 1

Re: [2/2] kernel32: force 4096 byte page alignment.
by Tijl Coosemans 17 Feb '15

17 Feb '15

On Mon, 02 Feb 2015 22:20:57 +0200 David Naylor <dbn(a)freebsd.org> wrote: > FreeBSD prefers to use a 0x200000 (super) page alignment however this causes > the image base to be displaced from the requested 0x7b800000. Forcing a > smaller page size ensures FreeBSD can place the image starting at 0x7b800000. Just to clarify, the output of "readelf -l kernel32.dll.so" gives this: Type Offset VirtAddr PhysAddr FileSiz MemSiz Flg Align LOAD 0x000000 0x7b800000 … [View More]

3 3

Re: version: partially implement GetFileVersionInfoSizeExA/W using GetFileVersionInfoSizeA/W (1/2)
by Nikolay Sivov 17 Feb '15

17 Feb '15

On 17.02.2015 7:04, Austin English wrote: > Fixes https://bugs.winehq.org/show_bug.cgi?id=38090 > > -- > -Austin > > > Why not the other way around - moving everything to *Ex, and forwarding to it?

2 1

Re: kernel32/tests: Add tests for job objects (try 3)
by Marvin 17 Feb '15

17 Feb '15

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
17
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel February 2015