- wine-devel - winehq.org

Re: crytpui: add CryptUIWizDigitalSign stub (try 2)
by Dmitry Timoshkov 12 Feb '15

12 Feb '15

Austin English <austinenglish(a)gmail.com> wrote: > +33 stdcall CryptUIWizDigitalSign(long ptr wstr ptr ptr) ... > +BOOL WINAPI CryptUIWizDigitalSign(DWORD flags, HWND parent, LPCWSTR title, PCCRYPTUI_WIZ_DIGITAL_SIGN_INFO info, > + PCCRYPTUI_WIZ_DIGITAL_SIGN_CONTEXT *context) What's the difference with previous version? -- Dmitry.

1 0

Re: [PATCH 5/6] d3d8/tests: Test rhw depth clip with z enabled but no depth buffer set.
by Marvin 11 Feb '15

11 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11495 Your paranoid android. === w8 (32 bit visual) === visual.c:4139: Test failed: Expected color 0x0000ff00 at 80, 60, got 0x00ff0000. visual.c:4139: Test failed: Expected color 0x0000ff00 at 560, 60, got 0x00ff0000. visual.c:4139: Test failed: Expected color 0x0000ff00 at 80, 180, got 0x00ff0000. visual.c:4139: Test failed: Expected color 0x0000ff00 at 560, 180, got 0x00ff0000. visual.c:4139: Test failed: Expected color 0x0000ff00 at 80, 300, got 0x00ff0000. visual.c:4139: Test failed: Expected color 0x0000ff00 at 560, 300, got 0x00ff0000. visual.c:4139: Test failed: Expected color 0x0000ff00 at 80, 420, got 0x00ff0000. visual.c:4139: Test failed: Expected color 0x0000ff00 at 560, 420, got 0x00ff0000.

1 0

Re: [PATCH 4/6] d3d9/tests: Test rhw depth clip with z enabled but no depth buffer set.
by Marvin 11 Feb '15

11 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11494 Your paranoid android. === w8 (32 bit visual) === visual.c:15503: Test failed: Expected color 0x0000ff00 at 80, 60, got 0x00ff0000, test 0. visual.c:15503: Test failed: Expected color 0x0000ff00 at 560, 60, got 0x00ff0000, test 0. visual.c:15503: Test failed: Expected color 0x0000ff00 at 80, 180, got 0x00ff0000, test 0. visual.c:15503: Test failed: Expected color 0x0000ff00 at 560, 180, got 0x00ff0000, test 0. visual.c:15503: Test failed: Expected color 0x0000ff00 at 80, 300, got 0x00ff0000, test 0. visual.c:15503: Test failed: Expected color 0x0000ff00 at 560, 300, got 0x00ff0000, test 0. visual.c:15503: Test failed: Expected color 0x0000ff00 at 80, 420, got 0x00ff0000, test 0. visual.c:15503: Test failed: Expected color 0x0000ff00 at 560, 420, got 0x00ff0000, test 0.

1 0

Re: [PATCH 2/6] dxgi: Add interface for IDXGISurface1 [try 2]
by Stefan Dösinger 11 Feb '15

11 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Martell, This patch (and http://source.winehq.org/patches/data/108999) look good to me from a content point of view. The E-Mail submission is a bit broken though. If I pipe the raw mail into git am I get a commit message that has some HTML and other junk in it. I recommend to set up git send-email. It will create the proper numbering for you and make sure that there are no line wraps or HTML junk in the mail. If you want to send only some part of your patches with send-email you can e.g. create a temporary branch, cherry-pick what you want to send, and then send from that branch. Also I recommend to send one patch after another, wait for it to be applied, then send the next one. Cheers, Stefan Am 2015-02-10 um 13:11 schrieb Martell Malone: > I'm going to take this slowly, with this there should be no issues > with he first 2 patches. > > I went with dxgi: in this commit message as that's what henri said > > The prefix for the dxgi IDL patches should be "dxgi:", for the > d3d11 one it should be "d3d11:". > > > Before I resubmit 4 and 6 however I need to know if I should have > "include:" or "dxgi:" + "d3d11:" in them as these create new files -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU20OEAAoJEN0/YqbEcdMwYhQP/3+K4X1/NH/K5ke0MdCCXzNO af8QxlcLJjNg6XH6bParDEDvs4u9pax3oGULzT07uu9hNpk1/zkssxV6tc3wJIs+ Sxx2A/EOU2ggtJJ5Dn3RPRKFJAiXJCwRClJcePj94lp5S11zNpoBcEJyn9Y9rZZc afvK2cPjj5w5ym8b2Ml9us16JbmN+JyAIr7gX59jZy+67+W6GpZdbB1/OV55Up4y bJH0Sl83vh6GzsZi0QyQ/oRE8OWxhYstOTmPEUMFX66qJh4wzgOy5+oRRmro0PoR X9bshnHGwQPEZs74UtCxpPusyGL6ApcZ5TAdsXiy+J6qhsnhv+bGLbQqwOp0RtPn mMs8V4S50h+84vvO/v/JhsPxMyKt0dC8HqhsHYn9Zl4Idv3bT6Q3wTbaovVKRbTM X0nB6HVoQPVKPRRXnRo2g8DTumrW4Qyg44Ymx3RsW8BNmnPy7YdJFjYIlW0fMwPP Q7MhrKv2lvJy7239Cm+iR1huYkMZgND+u7c45qTl+03SagOy5T+E4PzsZvAaf08O 89v1D1ogIgyvSnswuhY1o3XgQ4hMEm/I9BDespEXk9iedXwK9H4/+kvW+5kgvHJs TaDc0MNA97IiGz+Nvv4LEKk7kydqFmsIgaeKuTibrUs1+vyFWsCMHz+kcmxvA3Db uW3zEYIjKdG+i2xmwmmp =OaYZ -----END PGP SIGNATURE-----

1 0

Re: version: Fix wrong length reported when selecting a block.
by Stefan Dösinger 11 Feb '15

11 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, Am 2015-02-09 um 23:20 schrieb learn_more: > From: Mark <learn0more(a)gmail.com> We need to know your full name to accept your patch to be able to show where our code comes from. Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU2z8oAAoJEN0/YqbEcdMw/tYP/RxWhEnR4ZbwplYloK3vcq6H P08nlylTgQ+MfjUwReQxuPoVU3FNTx2+zD1omcJ37NJvorMONu6EUJ8OtCcBGmWO wmii92XCOZJkZOaOAO5pd/ziSamZeeQNVVG1fhW+NkcEF2Jp/PtuPwWF/eZ4UL9V Rz0mrf/BUZ6xCmCPz8hRO22foMCHpIArVtke1j/9GN0df5LB2bLpMlvcmQrR/YT2 r12xz4+z4FeyBFGS1wZ5s7U6LawlUVR6YUJtCwcBmxrmYAY3byiYoX8fXbYJt+CI rAoXo427GKLf27SArsT21Q2aFYzRff3hm5YQUDO2idm07bmiTTj5rdDAekq7DQKT 3m28wBBjrSyjbJCKAXRBJyvC2au0WdC0cTh/1Ji5FtOC0Csl6pJ2ST3iIrSvNgw/ AJgbizBGTsb9Wgtm1nH+AEJn9w7enqR1BGzIL4WNSNrsoyvSyO2WWR9Cc0demOle 2Z12gKTbiTWxssezxTqvpTWrX6Cqym2gJW8ZbRpK2J/INZbpqH889UwWC3LMw/8v rUDx23MV985/h2AS6h2takGDmvtKU/Wdv6zluaYdA9fpkmM7waLS5G5Lgrjx17rz H8JvB7VbLuf6eIzxVnlsZE6NJo+HXghoZyD00hKvM9zh1wRhNgMfcWgNfA47W1+w 9+id7LnpWmtcTEA99AuH =+oRF -----END PGP SIGNATURE-----

1 0

Re: setupapi: Implement SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW(), SetupCloseLog() (try 3)
by Nikolay Sivov 11 Feb '15

11 Feb '15

This is better, but still not quire right. > +CRITICAL_SECTION setuplog_critical; Take a look at how critical section data is initialized in wine code, name needs to be adjusted to let's say 'setupapi_cs'. > + if (MessageString) > + { > + len = lstrlenA(MessageString) + 1; > + msg = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + if (msg == NULL) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; > + } > + MultiByteToWideChar(CP_ACP, 0, MessageString, -1, msg, len); > + } That's not how A->W conversion works, we have tons of examples for that. > OsVersionInfo.dwOSVersionInfoSize = sizeof(OSVERSIONINFOW); > if (!GetVersionExW(&OsVersionInfo)) > return FALSE; > + InitializeCriticalSection(&setuplog_critical); > SETUPAPI_hInstance = hinstDLL; > break; > case DLL_PROCESS_DETACH: > if (lpvReserved) break; > + DeleteCriticalSection(&setuplog_critical); > if (CABINET_hInstance) FreeLibrary(CABINET_hInstance); > break; You won't need these calls once you init it like the rest of Wine code does. Also what about closing files on DLL_PROCESS_DETACH? > + SetLastError(ERROR_ALREADY_EXISTS); > + return TRUE; Is it really important for some application to set this error on success? In general you only need to set it if call failed. > + setupact = CreateFileW(path, GENERIC_WRITE, FILE_SHARE_WRITE | FILE_SHARE_READ, > + NULL, OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); Did you check what happens if multiple processes are logging?

2 3

Re: [PATCH 5/5] d3d9/tests: Test upload of user memory textures.
by Stefan Dösinger 11 Feb '15

11 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-10 um 20:14 schrieb Matteo Bruni: > + hr = IDirect3DDevice9Ex_CreateTexture(device, 33, 33, 1, 0, D3DFMT_L8, > + D3DPOOL_SYSTEMMEM, &texture, &mem); > ... > + hr = IDirect3DDevice9Ex_SetTexture(device, 0, (IDirect3DBaseTexture9 *)texture); > + ok(SUCCEEDED(hr), "SetTexture failed (0x%08x)\n", hr); Am I missing something, or are you texturing from system memory here? I am surprised this is working. I'll test it on my collection of Windows boxes to be sure. I think it would be a good idea to test the UpdateTexture / UpdateSurface codepath with user memory textures and a strange pitch like in your test. This doesn't have to be part of this patch though. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU2yz/AAoJEN0/YqbEcdMw/nMP/i61GWBL1ZajYzvS2iohebWp 6nE9k6Yh9OziU7LjJZfkWekvNPGPd8UYN2B5CzdqM6LPdBM3PFj3UFAROzECAPjn JpLHncb8gh25CXFAV0V/rdlaoXuYIKkxQDiZMyiDEP01gZNLTX+bt1rdWmK6JNtJ czFYyoSKyWyzbiUOQSAKponMxYbd2rK3B714Xsn50CRJdA6z26DSgqMfHabZcrl1 R+PWOfwDh7n6es7ax5rVWDNIvip1bFoU97wTahfIxIoL227eSTsFwwRo1pNsLnd4 9KsQmIWdKzIMZqPPkhnKGZz1Gu79Q3GJnlLjbWODYL5fgfbI+Bcv6npMZqHtctvb yFn86dVX2t6WTAMBmC4J3PVm+Igrzlk7nQt6l4X4KeMf7HYP9wDtOh/FIt4TV4qy 7Zu7JpuRDk5yKgnE/y7eew6YHyQGmVy59Y4IL7CR2EiwAevZr/HblvBjmsJ+CfSF NHF1QZkt/VH4v3D2XQzrW9Pln9H5m3luFTzA5cVOsv1v4r62uAY69tJLUmVRguyx icxFGbcuUKPtiFu4ER9Q0dZXx2gscy7agLYGbbwvsNFapBG2dTPaS1qJVyXe7/kD ML82rlfGImYupx6aSE/GAvD/IWaZgICt+XqPj5PnOIBz/mN9o9KziewCSg53Xp+2 Ai+BIdMBa8KOiK2MGPrH =Jvrb -----END PGP SIGNATURE-----

1 0

Re: [PATCH] user32: use InvalidateRect to repaint buttons
by Dmitry Timoshkov 11 Feb '15

11 Feb '15

Mark Harmstone <hellas(a)burntcomma.com> wrote: > At present, whenever a button needs to be redrawn user32 calls its own > internal function. This causes problems if the button is subclassed, as > the superclass then won't receive the WM_PAINT message - this is why > themed buttons lose their theme when you click on them. This patch changes > it to instead call InvalidateRect, which will force a WM_PAINT message > to be sent to the topmost class. Did you run 'make test' with your changes? -- Dmitry.

1 0

Re: [PATCH 3/5] wined3d: Set the surface pitch for user-memory surfaces.
by Henri Verbeet 10 Feb '15

10 Feb '15

On 10 February 2015 at 20:14, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + { > surface->resource.size = wined3d_format_calculate_size(texture_resource->format, > texture_resource->device->surface_alignment, width, height, 1); > + surface->pitch = wined3d_format_calculate_pitch(texture_resource->format, width); > + } > A small comment mentioning that user memory surfaces don't have the regular surface alignment probably wouldn't hurt.

1 0

Re: connect: add IsInternetConnectedStub
by Bruno Jesus 10 Feb '15

10 Feb '15

On Tue, Feb 10, 2015 at 4:03 PM, Austin English <austinenglish(a)gmail.com> wrote: > > https://bugs.winehq.org/show_bug.cgi?id=26759 Isn't it better to simply add a note like "faking success" and return S_OK? Because returning false will probably not have a useful effect in the application. I didn't test the application though. > -- > -Austin > Best regards, Bruno

2 1

Re: vbscript: Added InStrRev implementation.
by Marvin 10 Feb '15

10 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11485 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 2/6] dxgi: Add interface for IDXGISurface1 [try 2]
by Jacek Caban 10 Feb '15

10 Feb '15

On 02/10/15 13:11, Martell Malone wrote: > Before I resubmit 4 and 6 however I need to know if I should have > "include:" or "dxgi:" + "d3d11:" in them as these create new files We already have both variants in Git history and there was never a problem with it. If you ask me, use whatever you prefer. Jacek

3 2

Re: mshtml: Fix fire BeforeNavigate event for app: protocol
by Jacek Caban 10 Feb '15

10 Feb '15

On 02/09/15 07:08, Changhui Liu wrote: > - if(window->doc_obj && window->doc_obj->webbrowser && window == window->doc_obj->basedoc.window) { > + if(window->doc_obj && window->doc_obj->webbrowser && > + ((window == window->doc_obj->basedoc.window) || (window->parent == window->doc_obj->basedoc.window))) { > DWORD post_data_len = request_data ? request_data->post_data_len : 0; > void *post_data = post_data_len ? request_data->post_data : NULL; > const WCHAR *headers = request_data ? request_data->headers : NULL; The change on its own is wrong. There is nothing special about direct child of top HTML window. Ideally, we should call FireBeforeNavigate2 for all HTML windows, but use super_navigate only for the main one. This means that the if you change should not check which window we're in at all. However, for other windows, we need to pass proper frame name there. Let me know if you need more details. Cheers, Jacek

1 0

Re: [2/6] dxgi: Add interface for IDXGISurface1
by Stefan Dösinger 10 Feb '15

10 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Martell, There are a few things in Henri's list of fixes that are still missing here: Am 2015-02-09 um 10:28 schrieb Martell Malone: > Subject: [PATCH 2/6] dxgi: Add interface for IDXGISurface1 "include:" instead of "dxgi". > + uuid( 4ae63092-6327-4c1b-80ae-bfe12ea32b86), You have an extra space here. > + [out] HDC* hdc HDC *hdc, or even better HDC *dc. We avoid the Hungarian notification Microsoft once used, e.g. things like DWORD dwNumber. HDC hdc is the same kind of thing, although it's a bit of a special case. Patch 3: > +typedef struct DXGI_OUTDUPL_MOVE_RECT { > + POINT SourcePoint; > + RECT DestinationRect; > +} DXGI_OUTDUPL_MOVE_RECT; { placement . You also have FOO* bar; vs FOO *bar; issues in this patch. > + [in] IUnknown* pDevice, > + [in] IUnknown* pWindow, > + [in] const DXGI_SWAP_CHAIN_DESC1* pDesc, pStuff The same things also occur in patches 4, 5, and 6. Patch 4: > + [size_is(count_levels)] const D3D_FEATURE_LEVEL* levels, > + UINT count_levels, You are mixing count_* and *_count in patches 4, 5 and 6. For consistency's sake please make this *_count consistently. Patch 6: > +} > \ No newline at end of file Is this intentional? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU2eMXAAoJEN0/YqbEcdMwUmYP/A8I/1UBVqcynhIJ5qIvVTl4 sf3XQcWTmgI40JurL4D1mIaQMH+VeulQ7Jeroo9L9/WhIw1RRJ7R0jFULxZIu9tP VX5AyTVjd555jbt9DvlbmkaAicb0UuX7xSO5OelkkdwtdfuDCKnDq2+LxzXA2fXw y98vlT98meapIP5BzERMyAAyM0AkvpAMaxkBabE9w9Mj6IJUWteHQEwa2iavu0HR wBr/KotHXu/nqVD41PTYnAsyQoWeBNPBghg4RyqI42YKiOnDxuApOT9nAgewwHPA VghOW/hdlZahCZc+/Vst01pD7Sa7vS/Nuq4iDfJJVofSsXgwIdl5KT63eAOzR4Dl MefDKrEBmdTh44K/JeyCey1Rb4o6fNtPCQJV6lqXQkiHVeE/8IW8qPLectwuGPVd UtC7Fy38iR4UpDJBmPGypdZaFJzS2ZF1hO+mA/jJhOnefyL31vCeFWU+bf5ISuwo TDEGu7G/8yBpY+HKHr+++IwJlJKkEngf98ksjnyRC1PpIner05XHUDeu1PIll/FS T3aveyW5lWsyVGCyyovHLQIxfkaV6JPqR/AsuTuhDmhZu4ZQPoGLH5kpfrAhgVMA TeLGoR6RtTMOyFLob4sRI9nBR89H/UiEQ++fGbp/YXsOLnOZBJvn6y8AYh6zaeD5 6smvq4QiqsuQQS3tSC+f =CmBk -----END PGP SIGNATURE-----

2 3

Problem in compiling wine on 64 bit system
by Ali Aminian 10 Feb '15

10 Feb '15

Hello wine community I have some difficulty compiling wine on 64 bit ubuntu 14.04. I'm following the guide in http://wiki.winehq.org/Wine64 which i also replicate here: cd $HOME mkdir wine64 cd wine64 ../wine-git/configure --enable-win64 make > make.log 2>&1 cd .. mkdir wine32 cd wine32 ../wine-git/configure --with-wine64=../wine64 make > make.log 2>&1 #make install #cd ../wine64 #make install I can build the wine64 without any difficulty except that after configuration it prompts me that i don't have libhal, but i just ignored that. But when i get into win32 it gives me numerous warning that 32-bit development files not found, and some option will be disabled. for example: ************************************************************************************************** configure: OpenCL 32-bit development files not found, OpenCL won't be supported. configure: pcap 32-bit development files not found, wpcap won't be supported. configure: libdbus 32-bit development files not found, no dynamic device support. configure: lib(n)curses 32-bit development files not found, curses won't be supported. configure: libsane 32-bit development files not found, scanners won't be supported. configure: liblcms2 32-bit development files not found, Color Management won't be supported. configure: libz 32-bit development files not found, data compression won't be supported. configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled configure: libcapi20 32-bit development files not found, ISDN won't be supported. configure: libcups 32-bit development files not found, CUPS won't be supported. configure: fontconfig 32-bit development files not found, fontconfig won't be supported. configure: libgsm 32-bit development files not found, gsm 06.10 codec won't be supported. configure: libtiff 32-bit development files not found, TIFF won't be supported. configure: libmpg123 32-bit development files not found (or too old), mp3 codec won't be supported. configure: libopenal 32-bit development files not found (or too old), OpenAL won't be supported. configure: libldap (OpenLDAP) 32-bit development files not found, LDAP won't be supported. ******************************************************************************************************** [important] and when i try to install 32 bit version of these libraries using aptitude (since using apt-get just says unmet dependencies and exits) it tries to remove my 64 bit version of the same library. for example: ***************************************************************************************************** ali@ali-Vostro-1520:~/other_drive/wine32$ sudo aptitude install libxi-dev:i386 The following NEW packages will be installed: libxi-dev:i386{b} 0 packages upgraded, 1 newly installed, 0 to remove and 1 not upgraded. Need to get 204 kB of archives. After unpacking 638 kB will be used. The following packages have unmet dependencies: libxi-dev : Conflicts: libxi-dev:i386 but 2:1.7.1.901-1ubuntu1 is to be installed. libxi-dev:i386 : Conflicts: libxi-dev but 2:1.7.1.901-1ubuntu1 is installed. The following actions will resolve these dependencies: Remove the following packages: 1) libatspi2.0-dev 2) libgtk2.0-dev 3) libxi-dev 4) libxtst-dev Accept this solution? [Y/n/q/?] y ******************************************************************************************************** [important] In one of these 32 bit installation aptitude removed my wine1.7 package and now i can't even install wine from official wine repository. so my questions are: 1_how you guys setup your environment for wine development? 2_how you deal with package managers when it acts weird?

2 1

Re: [PATCH 3/5] opengl32: Introduce wrappers for glGetIntegerv and glGetStringi. (v2)
by Alexandre Julliard 10 Feb '15

10 Feb '15

Matteo Bruni <mbruni(a)codeweavers.com> writes: > @@ -834,6 +849,9 @@ PROC WINAPI wglGetProcAddress( LPCSTR name ) > *func_ptr = driver_func; > } > > + if (!strcmp(name, "glGetStringi")) > + return (void *)glGetStringi; It seems to me you could handle this one through the extension table instead of special casing it. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH] winecfg: Double click in dlls list to edit overides; fix indent. (try 2)
by Andrew Eikum 10 Feb '15

10 Feb '15

On Fri, Feb 06, 2015 at 10:23:15AM +0800, Hao Peng wrote: > Add a feature to winecfg. User can double click in dlls list to edit overides of selected item. > > the indent of code here mixed with tabs, 4 spaces and 8 space. I formated it to match the style of the rest code. > Usually we don't take patches that change nothing except formatting. I think your first patch was rejected because it adds even more inconsistent formatting. The indent is too small. The "case CBN_DBLCLK" line should be indented the same as the "case LBN_SELCHANGE" line. Instead it's indented 8 spaces when it should be indented 16 spaces. Andrew

1 0

Re: [2/6] dxgi: Add interface for IDXGISurface1
by Jacek Caban 10 Feb '15

10 Feb '15

Hi Martell, On 02/09/15 10:28, Martell Malone wrote: > + uuid( 4ae63092-6327-4c1b-80ae-bfe12ea32b86), > + local, > + pointer_default(unique) > +] > +interface IDXGISurface1 : IDXGISurface Once again, please make sure that your patches builds before sending patches. ../tools/widl/widl -o dxgi.h -m32 -I. -I../include -D__WINESRC__ dxgi.idl dxgi.idl:175: error: syntax error, unexpected aKNOWNTYPE, expecting tIMPORT Jacek

2 1

Re: rpcrt4: add a stub for I_RpcBindingInqLocalClientPID
by Dmitry Timoshkov 10 Feb '15

10 Feb '15

Austin English <austinenglish(a)gmail.com> wrote: > +RPC_STATUS WINAPI I_RpcBindingInqLocalClientPID(RPC_BINDING_HANDLE ClientBinding, unsigned long *ClientPID) > +{ > + FIXME("%p %p: stub\n", ClientBinding, ClientPID); > + return RPC_S_INVALID_BINDING; > +} This can't work under all platforms for obvious reasons. -- Dmitry.

2 1

Problem in compiling wine on 64 bit system
by Ali Aminian 10 Feb '15

10 Feb '15

Hello wine community I have some difficulty compiling wine on 64 bit ubuntu 14.04. I'm following the guide in http://wiki.winehq.org/Wine64 which i also replicate here: cd $HOME mkdir wine64 cd wine64 ../wine-git/configure --enable-win64 make > make.log 2>&1 cd .. mkdir wine32 cd wine32 ../wine-git/configure --with-wine64=../wine64 make > make.log 2>&1 #make install #cd ../wine64 #make install I can build the wine64 without any difficulty except that after configuration it prompts me that i don't have libhal, but i just ignored that. But when i get into win32 it gives me numerous warning that 32-bit development files not found, and some option will be disabled. for example: ************************************************************************************************** configure: OpenCL 32-bit development files not found, OpenCL won't be supported. configure: pcap 32-bit development files not found, wpcap won't be supported. configure: libdbus 32-bit development files not found, no dynamic device support. configure: lib(n)curses 32-bit development files not found, curses won't be supported. configure: libsane 32-bit development files not found, scanners won't be supported. configure: liblcms2 32-bit development files not found, Color Management won't be supported. configure: libz 32-bit development files not found, data compression won't be supported. configure: gstreamer-0.10 base plugins 32-bit development files not found, gstreamer support disabled configure: libcapi20 32-bit development files not found, ISDN won't be supported. configure: libcups 32-bit development files not found, CUPS won't be supported. configure: fontconfig 32-bit development files not found, fontconfig won't be supported. configure: libgsm 32-bit development files not found, gsm 06.10 codec won't be supported. configure: libtiff 32-bit development files not found, TIFF won't be supported. configure: libmpg123 32-bit development files not found (or too old), mp3 codec won't be supported. configure: libopenal 32-bit development files not found (or too old), OpenAL won't be supported. configure: libldap (OpenLDAP) 32-bit development files not found, LDAP won't be supported. ******************************************************************************************************** [important] and when i try to install 32 bit version of these libraries using aptitude (since using apt-get just says unmet dependencies and exits) it tries to remove my 64 bit version of the same library. for example: ***************************************************************************************************** ali@ali-Vostro-1520:~/other_drive/wine32$ sudo aptitude install libxi-dev:i386 The following NEW packages will be installed: libxi-dev:i386{b} 0 packages upgraded, 1 newly installed, 0 to remove and 1 not upgraded. Need to get 204 kB of archives. After unpacking 638 kB will be used. The following packages have unmet dependencies: libxi-dev : Conflicts: libxi-dev:i386 but 2:1.7.1.901-1ubuntu1 is to be installed. libxi-dev:i386 : Conflicts: libxi-dev but 2:1.7.1.901-1ubuntu1 is installed. The following actions will resolve these dependencies: Remove the following packages: 1) libatspi2.0-dev 2) libgtk2.0-dev 3) libxi-dev 4) libxtst-dev Accept this solution? [Y/n/q/?] y ******************************************************************************************************** [important] In one of these 32 bit installation aptitude removed my wine1.7 package and now i can't even install wine from official wine repository. so my questions are: 1_how you guys setup your environment for wine development? 2_how you deal with package managers when it acts weird?

1 0

(no subject)
by The Cheese 09 Feb '15

09 Feb '15

Hi, I'm a newbie. I would really like to help with the development of Wine in any capacity I can. The thing is, I looked over the bugzilla and various ways to get the stacktrace, etc. However, finding the cause simply by looking at address calls and returns eludes me. Is there something which might help me get there faster, for eg: reading up on instruction sets on x86 chipsets etc? I've already looked over the winedev-guide. Thanks for any help.

2 1

Re: [PATCH 1/4] wine-headers: add a winapifamily header
by Martell Malone 09 Feb '15

09 Feb '15

> > First, the 1/4 patch is really something you'll have to convince > Alexandre of it's the right thing to do. The easiest way is probably > to ask him about it on IRC. The amount of advice I can give on that > one is limited, but it would probably help if you could show why Wine > needs the winapifamily mechanism. The best way to do that may very > well just be to show that applications need e.g. the > WINAPI_FAMILY_DESKTOP_APP constant to compile against the Wine > headers. > I will ask him on IRC. Yes well it would be more correct to have the header in the case where a program uses that ifdef So this would match the official instructions from MS on using different api's I could also imagine that you'll be asked to partition the > other Wine headers as well if we're going to have this mechanism in > Wine. I.e., I don't think it makes a lot of sense to only do this for > a couple of dxgi headers, but not for anything else. The prefix for > the subject should be "include:". I'd move this patch to the end of > the series. > Initially I would have only done the dx stuff because mingw-w64 shares those headers. Essentially they Jacek Caban pulls in the d3d11 headers and idls from wine in to mingw-w64 to update. I could update the mingw-w64 project with the changes but I didn't want to leave wine out of the loop. I do understand that all headers would need to be partitioned to support this eventually. I was hoping the start would be with directx > The comment is pretty superfluous. > I can take it out. In patch 2/4, you have unrelated style changes for e.g. > IDXGIDevice2::OfferResources() > . I happen to like the new style better, > but please don't do that. First add the new stuff, then send a patch > to make the existing stuff consistent with dxgi.idl at the end of the > series. > Sure I can do that Some general style stuff: > - I think "{" on the same line for enum/struct/interface declarations is > ugly. > - Use "DXGI_OUTDUPL_DESC *desc" instead of "DXGI_OUTDUPL_DESC* desc", > etc. > - There are a couple of parameter naming issues. e.g. "pDevice", > "colorSpace", "pStats", "Data", etc. > - I prefer the order of things to be macros/constants, enums, > structs, interfaces, functions instead of having those interleaved > through the header. > - "FLOAT" -> "float", "LPCWSTR" -> "const WCHAR *" > - "num_*" -> "*_count" > > The prefix for the dxgi IDL patches should be "dxgi:", for the d3d11 > one it should be "d3d11:". > Seems easy enough to follow :) On Fri, Feb 6, 2015 at 1:05 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > I had a look at this series, and have a couple of comments. > > First, the 1/4 patch is really something you'll have to convince > Alexandre of it's the right thing to do. The easiest way is probably > to ask him about it on IRC. The amount of advice I can give on that > one is limited, but it would probably help if you could show why Wine > needs the winapifamily mechanism. The best way to do that may very > well just be to show that applications need e.g. the > WINAPI_FAMILY_DESKTOP_APP constant to compile against the Wine > headers. I could also imagine that you'll be asked to partition the > other Wine headers as well if we're going to have this mechanism in > Wine. I.e., I don't think it makes a lot of sense to only do this for > a couple of dxgi headers, but not for anything else. The prefix for > the subject should be "include:". I'd move this patch to the end of > the series. > > > +/* wine wants all the api's by default so we set to desktop + app */ > > +#ifndef WINAPI_FAMILY > > +#define WINAPI_FAMILY WINAPI_FAMILY_DESKTOP_APP > > +#endif > The comment is pretty superfluous. > > In patch 2/4, you have unrelated style changes for e.g. > IDXGIDevice2::OfferResources(). I happen to like the new style better, > but please don't do that. First add the new stuff, then send a patch > to make the existing stuff consistent with dxgi.idl at the end of the > series. > > Some general style stuff: > - I think "{" on the same line for enum/struct/interface declarations is > ugly. > - Use "DXGI_OUTDUPL_DESC *desc" instead of "DXGI_OUTDUPL_DESC* desc", > etc. > - There are a couple of parameter naming issues. e.g. "pDevice", > "colorSpace", "pStats", "Data", etc. > - I prefer the order of things to be macros/constants, enums, > structs, interfaces, functions instead of having those interleaved > through the header. > - "FLOAT" -> "float", "LPCWSTR" -> "const WCHAR *" > - "num_*" -> "*_count" > > The prefix for the dxgi IDL patches should be "dxgi:", for the d3d11 > one it should be "d3d11:". >

3 5

Re: setupapi: fix string conversion in SetupGetInfInformationA()
by Jacek Caban 08 Feb '15

08 Feb '15

Hi Pierre, On 02/08/15 19:59, Pierre Schweitzer wrote: > inf = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + if (!inf) > + { > + SetLastError(ERROR_NOT_ENOUGH_MEMORY); > + return FALSE; You don't need to call SetLastError here. It's already set by HeapAlloc on failure. Jacek

2 2

Re: setupapi: Implement SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW(), SetupCloseLog() (try 2)
by Nikolay Sivov 07 Feb '15

07 Feb '15

This one is clearly broken regarding critical section usage.

1 0

Re: setupapi: Implement SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW(), SetupCloseLog()
by Nikolay Sivov 07 Feb '15

07 Feb '15

Hi, Pierre. Some comments for your patch. > --- a/dlls/setupapi/Makefile.in > +++ b/dlls/setupapi/Makefile.in > @@ -11,6 +11,7 @@ C_SRCS = \ > diskspace.c \ > fakedll.c \ > install.c \ > + log.c \ > misc.c \ > parser.c \ > query.c \ I'm not sure you need a new file for that. It depends on how much will be possibly added in the future, but general rule I think is to try to find a room in existing files. > +#include "wine/debug.h" > +#include "windef.h" > +#include "winbase.h" > +#include "winuser.h" > +#include "winreg.h" > +#include "setupapi.h" > +#include "winnls.h" Looks like you don't need all of those. > +HANDLE setupact = INVALID_HANDLE_VALUE; > +HANDLE setuperr = INVALID_HANDLE_VALUE; Should be static. > + LPWSTR msg = (LPWSTR)MessageString; I see what you want to do, but it's a bit ugly imho. > + if (MessageString) > + { > + len = lstrlenA(MessageString) + 1; > + msg = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, MessageString, -1, msg, len); > + } Please check for memory allocation failure. > + ret = WriteFile(setupact, MessageString, lstrlenW(MessageString) * sizeof(WCHAR), NULL, NULL); > + ret = WriteFile(setuperr, MessageString, lstrlenW(MessageString) * sizeof(WCHAR), NULL, NULL); You can probably do strlenW() once. > + GetWindowsDirectoryW(path, MAX_PATH); Same, you need to get this path once. > + if (setupact != INVALID_HANDLE_VALUE) > + { > + CloseHandle(setupact); > + setupact = INVALID_HANDLE_VALUE; > + } > + > + if (setuperr != INVALID_HANDLE_VALUE) > + { > + CloseHandle(setuperr); > + setuperr = INVALID_HANDLE_VALUE; > + } You can just CloseHandle() unconditionally. I think it also makes sense to SetupCloseLog() on PROCESS_DETACH, but that's easy to test. Another thing to test is to see what happens in multithreaded case, if it works correctly on windows you need to protect those handles in SetupOpenLog/SetupCloseLog, maybe somewhere else too.

2 1

Re: setupapi: Implement SetupOpenLog(), SetupLogErrorA(), SetupLogErrorW(), SetupCloseLog()
by Marvin 07 Feb '15

07 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11472 Your paranoid android. === wvistau64 (32 bit log) === log.c:57: Test failed: SetupLogError succeeded log.c:58: Test failed: got wrong error: 87 === w2008s64 (32 bit log) === log.c:57: Test failed: SetupLogError succeeded log.c:58: Test failed: got wrong error: 87 === w7u (32 bit log) === log.c:57: Test failed: SetupLogError succeeded log.c:58: Test failed: got wrong error: 87 === w8 (32 bit log) === log.c:57: Test failed: SetupLogError succeeded log.c:58: Test failed: got wrong error: 87 === wvistau64 (64 bit log) === log.c:57: Test failed: SetupLogError succeeded log.c:58: Test failed: got wrong error: 87 === w2008s64 (64 bit log) === log.c:57: Test failed: SetupLogError succeeded log.c:58: Test failed: got wrong error: 87

1 0

Re: server: Filter WM_QUIT message in PeekMessage call if PM_QS_POSTMESSAGE was not specified
by Marvin 06 Feb '15

06 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11458 Your paranoid android. === w7u (32 bit msg) === msg.c:12112: Test failed: unexpected hwnd 0017014A msg.c:12134: Test failed: bad time 309ee/309fe

2 1

Re: ntdll load_dll broken WoW behavior
by Patrick Rudolph 06 Feb '15

06 Feb '15

Am 2015-02-06 12:07, schrieb Nikolay Sivov: > On 06.02.2015 14:02, Patrick Rudolph wrote: >> Am 2015-02-06 09:22, schrieb Nikolay Sivov: >>> On 06.02.2015 11:12, Patrick Rudolph wrote: >>>> Hi guys, >>>> I tried WoW as it seems to be in a good shape, but run into same >>>> issues. >>>> I hope you can clarify. >>>> I've got an game that has two executables, 32bit and 64bit. It >>>> places a >>>> 32bit version of xinput1_3.dll in the same folder on startup. >>>> Trying to start the 32bit version works fine, however starting the >>>> 64bit >>>> version doesn't work. >>>> For me it looks like the ntdll load_dll is the fault. >>>> It searches for builtin xinput1_3 and finds the 32bit dll in the >>>> game >>>> folder. It fails to open it (wrong ARCH) and that's it. >>>> Instead of trying other directories it tries to load native. >>>> Again it opens the first file found in the given path, it's the same >>>> file again, it fails to open it and the application terminates. >>>> >>>> Why doesn't it check for correct ARCH ? >>>> Why doesn't it walk all directories / all path given, instead of >>>> just >>>> using the first file found ? >>> >>> What do you mean by that? It doesn't check usual System32 dir for 64 >>> bit dll, is that what you expect? >>> >> Why doesn't it check for files in syswow64 ? > > Because syswow64 is a directory for 32bit system dlls/exes. So for > 64bit process it doesn't make much sense to look for dependencies > there. So system32 contains 64bit libraries and syswow64 32bit libraries... OK. then why doesn't it look into system32 for the correct dll ? > >>> >>>> Does Windows 64bits behave the same ? >>> >>> Does this game work in Windows with same conditions? Or any minimal >>> test case for that matter, like 64bit exe + 32bit dll with >>> appropriate >>> name, is that what you see? >>> >> I guess it is working, why should a vendor release a non functional >> game ? >> But I cannot test it, as I do not own a Windows. > > Maybe you just need 64bit version of xinput then? I can't place it in the same folder as there's already a 32bit version. Why doesn't it take the 64bit version in system32. > >>> >>>> Regards >>>> >>>> >>

3 2

Re: ntdll load_dll broken WoW behavior
by Patrick Rudolph 06 Feb '15

06 Feb '15

Am 2015-02-06 09:22, schrieb Nikolay Sivov: > On 06.02.2015 11:12, Patrick Rudolph wrote: >> Hi guys, >> I tried WoW as it seems to be in a good shape, but run into same >> issues. >> I hope you can clarify. >> I've got an game that has two executables, 32bit and 64bit. It places >> a >> 32bit version of xinput1_3.dll in the same folder on startup. >> Trying to start the 32bit version works fine, however starting the >> 64bit >> version doesn't work. >> For me it looks like the ntdll load_dll is the fault. >> It searches for builtin xinput1_3 and finds the 32bit dll in the game >> folder. It fails to open it (wrong ARCH) and that's it. >> Instead of trying other directories it tries to load native. >> Again it opens the first file found in the given path, it's the same >> file again, it fails to open it and the application terminates. >> >> Why doesn't it check for correct ARCH ? >> Why doesn't it walk all directories / all path given, instead of just >> using the first file found ? > > What do you mean by that? It doesn't check usual System32 dir for 64 > bit dll, is that what you expect? > Why doesn't it check for files in syswow64 ? > >> Does Windows 64bits behave the same ? > > Does this game work in Windows with same conditions? Or any minimal > test case for that matter, like 64bit exe + 32bit dll with appropriate > name, is that what you see? > I guess it is working, why should a vendor release a non functional game ? But I cannot test it, as I do not own a Windows. > >> Regards >> >>

2 1

How WINE implements BitBlt function?
by John Found 06 Feb '15

06 Feb '15

This question arouse when I have made some tests in assembly language. I have wrote a program that to allocate some memory bitmap, fill it with some image and then draw it on a window. The in-memory processing is pretty fast so the main time consuming operation is the drawing of the bitmap on the window. The code is the same for the Windows and Linux version of the program and only the code that draws the bitmap on the window differs. In the Windows version it uses DIB and BitBlt function and in the Linux version it uses XImage bitmap and XPutImage function from XLib. I expected to have some similar performance of both programs, but was surprised, that in WINE, the Windows version performs approximately by 50% faster (150fps) than the Linux version (90..100fps) and the Linux version loads the CPU much higher than the Windows one. So, the question: How in WINE is implemented BitBlt function in order to have so high performance and so low CPU load? -- John Found <johnfound(a)asm32.info>

4 11

ntdll load_dll broken WoW behavior
by Patrick Rudolph 06 Feb '15

06 Feb '15

Hi guys, I tried WoW as it seems to be in a good shape, but run into same issues. I hope you can clarify. I've got an game that has two executables, 32bit and 64bit. It places a 32bit version of xinput1_3.dll in the same folder on startup. Trying to start the 32bit version works fine, however starting the 64bit version doesn't work. For me it looks like the ntdll load_dll is the fault. It searches for builtin xinput1_3 and finds the 32bit dll in the game folder. It fails to open it (wrong ARCH) and that's it. Instead of trying other directories it tries to load native. Again it opens the first file found in the given path, it's the same file again, it fails to open it and the application terminates. Why doesn't it check for correct ARCH ? Why doesn't it walk all directories / all path given, instead of just using the first file found ? Does Windows 64bits behave the same ? Regards

2 1

Re: include: add msasn1.h
by Charles Davis 05 Feb '15

05 Feb '15

> On Feb 5, 2015, at 1:20 PM, Austin English <austinenglish(a)gmail.com> wrote: > +typedef unsigned long ASN1uint32_t; > +typedef signed long ASN1int32_t; This won’t do what you (apparently) expect on 64-bit. At the very least, you should use ULONG/DWORD and LONG here. > +#ifndef WINAPI > +#define WINAPI __stdcall > +#endif This is most certainly wrong for Wine. I think you should include “windef.h” if you need WINAPI. I’m beginning to wonder if you copied this header (as well as <hidpi.h>) directly from Microsoft’s SDKs. You’ve been around long enough to know that that’s a big no-no around here. Chip

2 3

Re: [PATCH] dsound/tests: Add a test for SetFX.
by Marvin 05 Feb '15

05 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11445 Your paranoid android. === w2000pro (32 bit dsound8) === dsound8.c:1282: Test failed: IDirectSoundBuffer8_Play() failed: 88780046 === wxppro (32 bit dsound8) === dsound8.c:1282: Test failed: IDirectSoundBuffer8_Play() failed: 88780046 === wvistau64 (32 bit dsound8) === dsound8.c:1187: Test failed: DirectSoundCreate8() failed: 88780078 === w2008s64 (32 bit dsound8) === dsound8.c:1187: Test failed: DirectSoundCreate8() failed: 88780078 === w7u (32 bit dsound8) === dsound8.c:1282: Test failed: IDirectSoundBuffer8_Play() failed: 88780046 === w8 (32 bit dsound8) === dsound8.c:1282: Test failed: IDirectSoundBuffer8_Play() failed: 88780046 === wvistau64 (64 bit dsound8) === dsound8.c:1187: Test failed: DirectSoundCreate8() failed: 88780078 === w2008s64 (64 bit dsound8) === dsound8.c:1187: Test failed: DirectSoundCreate8() failed: 88780078

1 0

Re: [PATCH 1/2] ntdll: Support 64-bit Mac OS. (try 2)
by Alexandre Julliard 05 Feb '15

05 Feb '15

Charles Davis <cdavis5x(a)gmail.com> writes: > +/********************************************************************** > + * NtCurrentTeb (NTDLL.@) > + * > + * FIXME: This isn't exported from NTDLL on real NT. This should be > + * removed if and when we can set the GSBASE MSR on Mac OS X. > + */ > +TEB * WINAPI NtCurrentTeb(void) > +{ > +#ifdef __APPLE__ > + return pthread_getspecific( teb_key ); > +#elif defined(__GNUC__) > + struct _TEB *teb; > + __asm__(".byte 0x65\n\tmovq (0x30),%0" : "=r" (teb)); > + return teb; > +#else > +# error Please define retrieving the current TEB for your platform > +#endif > +} You can't do it that way: ../../../wine/dlls/ntdll/signal_x86_64.c:3481:31: error: redefinition of ‘NtCurrentTeb’ In file included from ../../../wine/include/windef.h:258:0, from ../../../wine/dlls/ntdll/signal_x86_64.c:59: ../../../wine/include/winnt.h:2288:84: note: previous definition of ‘NtCurrentTeb’ was here -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/3] jscript: Don't use builtin property for a few more constructors.
by Marvin 05 Feb '15

05 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11440 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/4] wine-headers: add a winapifamily header
by Stefan Dösinger 05 Feb '15

05 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, These patches are much more readable than the previous submissions! Am 2015-02-05 um 11:48 schrieb Martell Malone: > +#define WINAPI_PARTITION_DESKTOP 0x1 > +#define WINAPI_PARTITION_APP 0x2 > + > +#define WINAPI_FAMILY_APP WINAPI_PARTITION_APP > +#define WINAPI_FAMILY_DESKTOP_APP (WINAPI_PARTITION_DESKTOP \ > + | WINAPI_PARTITION_APP) This matches the definition of the Windows Kit 8.0 headers. In Windows Kit 8.1 this header looks quite different. Do you know what the intention of this is? Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU01O3AAoJEN0/YqbEcdMwJp4P+QHvB3snnXN2MC17+ZZxsjIz ZyUB28KCTlZJnXhQKEA/VOAOLrgGZOYWLd/qkW7gfRt1BSyiSS7hkuJAsdSkH43C AvXtY+HOumbewEkLl/MHfdk2yUgyzrgmv629jimeb83HnlzQG++b77WFSOQsYe4n T0kSibogJteL0TMgfHI1W5KtRJe95z8JpxBtIiPHGMlSSZHKLPEBDN8Tv8xSpkcw rHFW/HBxqeWLSpaz/YUAcMNDYNrIMY7DzgPW0MQRBewmQxRFc3hotyV2fnv7nUyZ nhlFruERczDBVOVYG1WIZ+28zawqMC9G93n+Emjl6szWRr4I/JtuB+ewHejr8HF4 8H35Ein5kQHSgkIeKPEarp9JwgbWpGOaWInLi8Y6K597oGJknzSv2snhenbOvx2T OUfbdmTgcwlIDsCN1dFzlVoAMV7UExDvx10H7rmdM7Ls0nhsL5TO0/jT25nbKMJa 5pyag4LISSQmKqLXTy24gRk27NplpiTwXNi37BQSw5BV0HJndSMxXfZgWE4jxQrL 9xYPvtEgaHofqdL3eo1M3FDownTmj7RJ4OAVuqgdAqfl7PfTKukgXXPuz9pQUuHL VHJ8CaUYcT41pdspys3iEZWGUMAui0kCzoisOKJPQpoTQ499r0uQysBkwNBeqPyh qfVxUc/oUsQlGkQtaA/N =OVYb -----END PGP SIGNATURE-----

2 2

Re: d3dx9_36: add D3DXDisassembleShader stub (try 2)
by Stefan Dösinger 05 Feb '15

05 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-05 um 05:14 schrieb Austin English: > +HRESULT WINAPI D3DXDisassembleShader(const DWORD *shader, BOOL > colorcode, LPCSTR comments, LPD3DXBUFFER *disassembly) Please no LPCRAP: LPCSTR -> const char * LPD3DXBUFFER * -> ID3DXBuffer ** It is even written this way in our header. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0yySAAoJEN0/YqbEcdMwXNsP/RgpIfaoj7Xhc0QXmCfH4Idh 9A9ohj99ZYAgK4QRaxXwNU9Uoys4TpJVxTDZ31C8WgnSosY+RUPt5hHx64Qe7LY+ wCwDC4wGJGZGVdPmlmTdahhQi9G8BauTs9uHcVvMZThllgfhgGHPOjn90muzcSyx PcXd2cOVnzJwaUNmJ7BrFt1luzqdRUW+v0xu31a8wsFFeIMQGA99DEeDu2ZOiu6/ UWArtccpb0QrDP/A4C5+YAuMcQHeQvWbGMrsCnrm3DBCJN46AIlLcQzw73Leq17Q aY3g6uct8SpCXD8p+KNXfe6FU/qe52QFHjI6yVS9FgjYuHwkjUuIH2CN4au7Dq22 WMt9NZI/fys+MZ5ThKmd6W10kMUpbcHHQxWbDf2zbzaGOxWX+vULNVQhMoCppCF6 0PsYhz+A5HadKgbkk28bhoIVDLefEevw/ov4X1veXEwO/0Xyb/YeLF5XiykM2LQG q6cIAik1kpawJ+YIZYILSZUjgxFmR2q5UF+qotucNdQhbNwfai0MdMMxFZMtxeUD OWwEpILVCp8JLPnTaXYt7D231TPsvLdh0hWMUy6Sk0pOsi8wVf5tO21UO3UT9Vas 7GDaW04KyzKBfD6ArONETOKHGYeozvghmPCmTrA/c8JZ69JBCuA+qk4KdjJ4RvKB rTs9Aao9URRAA9Q4PBM/ =c5KR -----END PGP SIGNATURE-----

2 3

Re: d3dx9_36: add a stub for D3DXDisassembleShader
by Dmitry Timoshkov 05 Feb '15

05 Feb '15

Austin English <austinenglish(a)gmail.com> wrote: > +@ stdcall D3DXDisassembleShader(ptr long ptr ptr) ... > +HRESULT WINAPI D3DXDisassembleShader(const DWORD *shader, BOOL colorcode, LPCSTR comments, LPD3DXBUFFER *disassembly) LPCSTR -> spec -> str -- Dmitry.

2 1

Re: ieframe:add app: protocol support to make mshtml trigger BeforeNavigate2 event when handle app: hyperlink
by Jacek Caban 05 Feb '15

05 Feb '15

Hi Changhui, On 01/15/15 02:39, Changhui Liu wrote: > Hi, this verify test need the user click the app: hyperlink in browser, > so it is hard to write a test in dlls/ieframe/tests. > > I upload the test html file and a test exe here: > http://www.imakevideo.com/app.html > http://www.imakevideo.com/mfc_web.zip > > To run the test, extract mfc_web.zip, then run the mfc_web.exe, click > the Go button; > A message "BeforeNavigate2 app:xxx" will popup when click the > app: hyperlink > if the BeforeNavigate2 event was triggered as like IE in windows, or > nothing. It doesn't seem right. There is nothing special about app: protocol handling, BeforeNavigate2 should be called in this case the same way as for any other protocol. You need to find the real reason why it's not called instead of calling it in an error case. The bug is likely to be in mshtml. Jacek

2 4

Re: jscript: Don't use builtin property for exposing Boolean constructor.
by Marvin 04 Feb '15

04 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11427 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/3] dwrite/tests: Fix couple of leaks when creating test font instance (resent)
by Marvin 04 Feb '15

04 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11425 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [PATCH 1/3] dwrite: No need for return value in collection_find_family()
by Alexandre Julliard 04 Feb '15

04 Feb '15

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > @@ -1424,11 +1424,14 @@ static HRESULT WINAPI dwritefontcollection_GetFontFamily(IDWriteFontCollection * > return create_fontfamily(This->family_data[index], iface, family); > } > > -static HRESULT collection_find_family(struct dwrite_fontcollection *collection, const WCHAR *name, UINT32 *index, BOOL *exists) > +static void collection_find_family(struct dwrite_fontcollection *collection, const WCHAR *name, UINT32 *index, BOOL *exists) Returning the index instead would probably make the code cleaner. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/3] dwrite/tests: Fix couple of leaks when creating test font instance
by Marvin 04 Feb '15

04 Feb '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11424 Your paranoid android. === build (build) === Patch failed to apply

2 1

Re: [1/1] wine3d3: dxgi 1.2 add missing functions and structs to the idl
by Stefan Dösinger 04 Feb '15

04 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, On 02/04/15 11:11, Martell Malone wrote: > In terms of the order only the winapifamily.h patch needs to be > applied first. The rest can be applied in any order as they are > all independent of each other > > Is that okay of do you want me to resend them all with numbers ?? I'd say wait until tomorrow. Give Henri a chance to comment on what he wants regarding the code style inconsistencies, and give Alexandre a chance to state his opinion on winapifamily.h. Adding another copy of the patches to the list doesn't make it easier to follow them. If you have no reply by tomorrow resend them in a proper order and numbering. (Note that I haven't checked your header patches for correctness yet. I'll do that after I've retested the Marco d3d window minimization bug. It was a bit difficult to figure out which patches need review and which are outdated.) Also, please be careful about reply vs reply to list / all. You have dropped wine-devel from CC, that makes it impossible for others to follow the discussion. I've taken the liberty to re-add the CC. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0fcJAAoJEN0/YqbEcdMwbtsP/RE6rtCtTF7uR4VOVjPwTjMz gV8NLhpBHuyin0vGR19l2f3FPm5SmRs2kXx9IWHofiOP//9fgPq6UhEXbLTHNvr8 YPodrahaRgryH2EcCRqZyNIVsA2JfYtEoweYUFPavHuOF+bQRdXrVYhEAhWye78o jjY0v6j7xd2vhJZ0yy3bNWNqetOHbH7HxOcBUVn2m0vIvEimONLidbCce5nh+51G 7xPP1dLbhvrFTWn9105z+TE1ewKCH1sbWkiJCcS4s+BBawhYEd4JUout0zNPG2A5 kOjEOXn3Zbu9mCoZMhg8VsbpVnyXTziZizfQmRGYOl8W9KRzQj155w/MZw4OvUa7 szVXkrDLTaVC6Qiv0UdxvgdlQKEG7C7iXaMK3jyIYo/NdwWQ4tP+3sv0ABUgQym4 UB1Fh5n72EZQULmjayRssUaj9pIv8mp+qQaPN37XE92ltoGvZvJ508ByhWln5ISH 65SixDTcvwkodOhNwPJyu63xYl/XHTt8vmp165H/KbMjPnaLwh1gjKSKmDSthLcq wcoKEgA2Pinu0Nbu4moR8GalA5LJPn9DgGsIIQSLvswnfcEd2YtAElijZYGnDysz DR2m8yBwpIqKmwPc0CJCK902RkbhtEu2YlQI6LEpwsAqnjVp+E7S3Yug3LmzHx8N becMTAgSQ0QabsodzW5K =YbZR -----END PGP SIGNATURE-----

1 0

Re: [1/1] wine3d3: dxgi 1.2 add missing functions and structs to the idl
by Stefan Dösinger 04 Feb '15

04 Feb '15

Am 03.02.2015 um 20:02 schrieb Martell Malone <martellmalone(a)gmail.com>: > wined3d and not win3d3 in the commit message Actually, the proper thing would be "include". Your d3d11 patch should state "d3d11: ...", but you don't have to resend because of this. Overall your patch submissions are difficult to follow. It isn't really clear to me in which order they should be applied, and which patch supersedes which. Generally, when a patch supersedes a previous patch please state so in the header line, e.g. "Include: Add missing dxgi 1.2 functions and structs to the idl (try 2)" . When patches depend on each other, like the dxgi and winapifamily patches, submit them in a series and mark them [1/3], [2/3] and [3/3]. git-send-email takes care of that if you use it, and git-format-patch will also create appropriate headers.

1 0

Re: Add d3d11_CreateDeviceAndSwapChain
by Stefan Dösinger 04 Feb '15

04 Feb '15

Hi, Am 03.02.2015 um 18:38 schrieb Martell Malone <martellmalone(a)gmail.com>: > 3rd Revision of the patch with input from both > Stefan and Bruno > Thanks Guys Looks good to me. I noticed that the d3d11_main.c file does not follow the general d3d code style. Bleh. I think it's best to commit your patch, then I'll send a patch tomorrow that fixes the other function and the function headers while the file is still small. Henri Verbeet has the final word on changes to d3d code. I'll wait for a word from him.

1 0

Re: wine.inf: Add substitution for font MS Serif
by Dmitry Timoshkov 04 Feb '15

04 Feb '15

Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > --- a/loader/wine.inf.in > +++ b/loader/wine.inf.in > @@ -562,6 +562,7 @@ HKLM,%FontSubStr%,"Courier New Greek,161",,"Courier New,161" > HKLM,%FontSubStr%,"Courier New TUR,162",,"Courier New,162" > HKLM,%FontSubStr%,"Helv",,"MS Sans Serif" > HKLM,%FontSubStr%,"Helvetica",,"Arial" > +HKLM,%FontSubStr%,"MS Serif",,"Liberation Serif" > HKLM,%FontSubStr%,"MS Shell Dlg 2",,"Tahoma" > HKLM,%FontSubStr%,"Times",,"Times New Roman" > HKLM,%FontSubStr%,"Times New Roman Baltic,186",,"Times New Roman,186" Font substitutions are supposed to replicate what Windows have there and therefore list only fonts available under Windows. There is Wine\Fonts\Replacements for host to Wine font mappings. -- Dmitry.

1 0

Re: [PATCH 1/2] ntdll: Support 64-bit Mac OS.
by Alexandre Julliard 04 Feb '15

04 Feb '15

Charles Davis <cdavis5x(a)gmail.com> writes: > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index 51de6e7..acd0271 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -1429,6 +1429,7 @@ > > # signal handling > @ cdecl __wine_set_signal_handler(long ptr) > +@ cdecl -arch=x86_64 __wine_current_teb() That's not better than exporting NtCurrentTeb. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: Add d3d11_CreateDeviceAndSwapChain
by Stefan Dösinger 03 Feb '15

03 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-02-02 um 20:24 schrieb Martell Malone: > + FIXME("stub: adapter %p, driver_type %s, swrast %p, flags > %#x, feature_levels %p, levels %#x, sdk_version %d, " You're still printing sdk_version as a signed value. Please use %u instead of %d. Otherwise this looks good to me. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJU0IM3AAoJEN0/YqbEcdMw5v8P/3A5kt9fIPCVCTgXfM0A6uKS 8cCXPITuKmeub7obw7EiEhsQH/4pw80bKOhmFKZvpK0knrKeU7wZvojbP18n39j1 vVqpqvtzbkfsBwLZ/Z0AeC/evVACfMmw1Al3BMBTDhxFb+uv+rVI9spG06XRPx8P e3pWlzoGniaZG8YP6TguA0gfrcMcGWEOWT59nstWW0HXlMFdsE1OoMM5Wd+XrpB+ AuEHGNFiHacgNxVfpnk6wQw5TK2uXW79ZbjX2wnrDiXkYvUZBts34Xo5cTdXNMXp DugbwLQtoC3Yu4rHxymjZTNbJLDY0bAOgBo4YwMCVnfLj7zbwvNABqtEIKtVs5Mx XsovTKzLD5sPmWnCxMtC5Qmz/aQebOYWF9bB3vYju876h69J5aJt4OjGU0HfLd4g 26uQEWgT+UbU0Lavofn3w9jcO4qEBl3NbmTs4egsw8n5Ry5f+N58BX1OdaOSdkmy a3Io6NgV48I/FjbxdlqpMz10I+06VlWiMdlmQSKxWTN1t5AxTm8/dTHLMC4+D7nn FOeWvOr3Wy4ocBWoOpT94etIBxut8IMfSHzEKsoll7kib3daYVDPv97pAbKdV3fT tZhzhWif+sqneVpk9QnCqhd9v9Kd29axqTBy7JiZ9t8TYxFTrXu50ZgC5oX/zKBV 4jVGoA2kY+Gtv9KR6SH0 =R0+9 -----END PGP SIGNATURE-----

2 3

Directx 11.2 idl's created
by Martell Malone 03 Feb '15

03 Feb '15

Hi guys, I create 2 patches that I posted to win-patches. [1/2] Directx 11.2 idl's dxgi1_3.idl and [2/2] Directx 11.2 idl's d3d11_2.idl I can update the commit msg to "wind3d: Added x idl" As Bruno explained to me this is the structure. Other than that however does anyone have any feedback ? Kind Regards Martell

1 2

Re: Add d3d11_CreateDeviceAndSwapChain
by Martell Malone 03 Feb '15

03 Feb '15

Hi guys, I updated the patch on wine-patches to reflect bruno's input on the commit message and I changed the %d to %u. Thanks guys Martell On Tue, Feb 3, 2015 at 5:28 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Hi, this is just a hint. You are not following the standards for the > patch subject. If you see http://wiki.winehq.org/SubmittingPatches > There is: > > If you are fixing a specific component or part, write the component's > name followed by a colon: > > [1/2] msvcrt: First change... > [2/2] msvcrt: Second change... > wined3d: Separate change... > > Take a look at the patches list and you will see what I'm saying: > http://source.winehq.org/patches/ > > Best regards, > Bruno > > On Tue, Feb 3, 2015 at 3:22 PM, Martell Malone <martellmalone(a)gmail.com> > wrote: > > D3D11CreateDevice also has "sdk_version %d" > > I used that as a reference. > > Does this mean that the other stub is wrong also ?? > > > > On Tue, Feb 3, 2015 at 8:13 AM, Stefan Dösinger < > stefandoesinger(a)gmail.com> > > wrote: > >> > >> -----BEGIN PGP SIGNED MESSAGE----- > >> Hash: SHA1 > >> > >> Am 2015-02-02 um 20:24 schrieb Martell Malone: > >> > + FIXME("stub: adapter %p, driver_type %s, swrast %p, flags > >> > %#x, feature_levels %p, levels %#x, sdk_version %d, " > >> You're still printing sdk_version as a signed value. Please use %u > >> instead of %d. > >> > >> Otherwise this looks good to me. > >> > >> -----BEGIN PGP SIGNATURE----- > >> Version: GnuPG v2 > >> > >> iQIcBAEBAgAGBQJU0IM3AAoJEN0/YqbEcdMw5v8P/3A5kt9fIPCVCTgXfM0A6uKS > >> 8cCXPITuKmeub7obw7EiEhsQH/4pw80bKOhmFKZvpK0knrKeU7wZvojbP18n39j1 > >> vVqpqvtzbkfsBwLZ/Z0AeC/evVACfMmw1Al3BMBTDhxFb+uv+rVI9spG06XRPx8P > >> e3pWlzoGniaZG8YP6TguA0gfrcMcGWEOWT59nstWW0HXlMFdsE1OoMM5Wd+XrpB+ > >> AuEHGNFiHacgNxVfpnk6wQw5TK2uXW79ZbjX2wnrDiXkYvUZBts34Xo5cTdXNMXp > >> DugbwLQtoC3Yu4rHxymjZTNbJLDY0bAOgBo4YwMCVnfLj7zbwvNABqtEIKtVs5Mx > >> XsovTKzLD5sPmWnCxMtC5Qmz/aQebOYWF9bB3vYju876h69J5aJt4OjGU0HfLd4g > >> 26uQEWgT+UbU0Lavofn3w9jcO4qEBl3NbmTs4egsw8n5Ry5f+N58BX1OdaOSdkmy > >> a3Io6NgV48I/FjbxdlqpMz10I+06VlWiMdlmQSKxWTN1t5AxTm8/dTHLMC4+D7nn > >> FOeWvOr3Wy4ocBWoOpT94etIBxut8IMfSHzEKsoll7kib3daYVDPv97pAbKdV3fT > >> tZhzhWif+sqneVpk9QnCqhd9v9Kd29axqTBy7JiZ9t8TYxFTrXu50ZgC5oX/zKBV > >> 4jVGoA2kY+Gtv9KR6SH0 > >> =R0+9 > >> -----END PGP SIGNATURE----- > > > > > > > > > > >

1 0

Any interest for SOE Landmark?
by Joni Larsen-Haikarainen 03 Feb '15

03 Feb '15

Hi Question to the Wine developer community will follow. But first some background info: I bought in to the EverQuest Next Landmark Alpha just cus I wanted to support it. Did not expect it to run at all under Wine until long after official launch. But to my surprise the game ran just fine when it was in Alpha. (Videos of me running it can be found on Youtube under the Channel "Let's Play on Linux") After the game went in to closed beta I could only run the game on Low graphical settings. And after an update to the game late summer of 2014 I can not get in to the world at all. (See bug: http://bugs.winehq.org/show_bug.cgi?id=37853 ) The scroll wheel on my mouse would not work at all in game, but that's something I learned to live with. (See bug: http://bugs.winehq.org/show_bug.cgi?id=35542 ) Now to the question! I realize that it must be very hard to try to solve a problem that occurs in a software one might not have. Landmark is still closed beta, so one needs to pay to get access. Now, I really love Landmark. So I wonder is there any Wine developer that has any interest in trying to solve the problems with running it in Wine, IF you had Free (as in beer) access to it? If someone actually have an interest in the game, but doesn't want to buy in to the closed beta. I would consider gifting you a Closed Beta access. I'm not rich, so can't do this for many people. But one or two that find the game interesting I could do. Regards. Joni

3 2

Re: wintrust: Add more spec entries
by Alexandre Julliard 03 Feb '15

03 Feb '15

Andrey Gusev <andrey.goosev(a)gmail.com> writes: > @@ -9,6 +9,7 @@ > @ stdcall CryptCATAdminReleaseContext(long long) > @ stdcall CryptCATAdminRemoveCatalog(ptr wstr long) > @ stdcall CryptCATAdminResolveCatalogPath(ptr wstr ptr long) > +@ stub CryptCATAllocSortedMemberInfo > @ stdcall CryptCATCDFClose(ptr) > @ stub CryptCATCDFEnumAttributes > @ stub CryptCATCDFEnumAttributesWithCDFTag That's not a good idea. You should only add things that are needed by applications, or else add them commented out. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] loader: FreeBSD requires pre_exec() on x86_64
by André Hentschel 03 Feb '15

03 Feb '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 02.02.2015 um 21:20 schrieb David Naylor: > Just as with i386, FreeBSD requires the maximum size of the data segment to be > extended on x86_64 for Wine to work correctly. > --- > loader/main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/loader/main.c b/loader/main.c > index ac67290..bb4f949 100644 > --- a/loader/main.c > +++ b/loader/main.c > @@ -181,7 +181,7 @@ static int pre_exec(void) > return 1; /* we have a preloader on x86-64 */ > } > > -#elif (defined(__FreeBSD__) || defined (__FreeBSD_kernel__) || defined(__DragonFly__)) && defined(__i386__) > +#elif (defined(__FreeBSD__) || defined (__FreeBSD_kernel__) || defined(__DragonFly__)) && (defined(__i386__) || defined(__x86_64__)) > > static int pre_exec(void) > { > > > > This is already fixed for a while, see: https://www.winehq.org/wwn/383#Wine64%20on%20FreeBSD -> https://bugs.winehq.org/show_bug.cgi?id=34330 -> https://source.winehq.org/git/wine.git/blobdiff/036670810c7e8bf55a5ee0e71e3… -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQGcBAEBAgAGBQJUz+qIAAoJEGm5GZTakYssKKEL/1kc5U/Um4TIfoIWFCZZoenL XhlZwjyJ90hJDicOZAHCKZxIcpu5J0fld52FIB5JunJZGSVcIXtcwmp1OwiA1BT4 5QPGR1WJ2bL4MU2lWw6+IEFZoL92Z7EsFkKjEM5l+u0l/APXp/5pq7Tj61qYvyoI HWhgauD7oWSK9PThWVdT7KiLmWFMLL5Rt3wB4coVExOhNah2jfGsJUDQUW08fX6B wKIB2r+O0h7xaR+zjnZSdB8iBqSTuCasUcaq0YcT8NccPQedlKJswnVu809Ygdg4 5PDn89Y1MGbSBIlcM8PjRtQrfU7bWLqOXmbY5bpaJbRbABz39UryrW0RleDTWC/G 8sJ3jtF7sO3YILQeFaaLUc0lyD64uGnwEoeGTJjB6n4khSVG5ZCsbn+twU6TwlT4 JYRfCNLgAv/fr9LnoI54HmBuyOscpP/1k9UO/6w2mQvugLe5k6TBQoiUMkk5le93 TbyOop4cFqHXR6DPfaIRuJ1czdrqVrZ1kZySKXubSg== =gd3v -----END PGP SIGNATURE-----

2 1

[2/2] Directx 11.2 idl's d3d11_2.idl
by Martell Malone 03 Feb '15

03 Feb '15

The second idl needed for dx11.2 function and structure compliance. Please review :)

1 1

Fwd: Add d3d11_CreateDeviceAndSwapChain
by Martell Malone 02 Feb '15

02 Feb '15

This is the explanation for the d3d11 patch I submitted to wine-patches. Stefan said Henri might have an interest so I should post the explanation here Comments are welcome :) ---------- Forwarded message ---------- From: Martell Malone <martellmalone(a)gmail.com> Date: Mon, Feb 2, 2015 at 7:12 PM Subject: Re: Add d3d11_CreateDeviceAndSwapChain To: Stefan Dösinger <stefandoesinger(a)gmail.com> Whoops that sent without my comments In the d3d code we use use 8 byte extran indentation for continued lines: > > void function() > { > <4> FIXME("bla long text bla\n", > <4> <8> param1, param2); > } > I have sent an updated patch to reflect this. I'm curious, does this improve the behavior of some application? E.g. game > X now falls back to d3d9 without crashing due to the stub? > My main focus for writing this was for the mingw-w64 project that imports the headers and libs from wine. We were just casually missing 1 of the 3 most important functions so I sent in this patch :) There are 2 ways to create a device and swapchain however. You can do them seperatly or this function does them both at once. I assume that this returns the correct error like CreateDevice so that if the application has a fallback it can use it. So thats highly possible. Kind Regards Martell On Mon, Feb 2, 2015 at 7:06 PM, Martell Malone <martellmalone(a)gmail.com> wrote: > Hi Stefan, > > On Mon, Feb 2, 2015 at 6:33 PM, Stefan Dösinger <stefandoesinger(a)gmail.com > > wrote: > >> Hi, >> >> I'm curious, does this improve the behavior of some application? E.g. >> game X now falls back to d3d9 without crashing due to the stub? >> >> > +HRESULT WINAPI D3D11CreateDeviceAndSwapChain(IDXGIAdapter *adapter, >> D3D_DRIVER_TYPE driver, HMODULE swrast, UINT flags, >> > + const D3D_FEATURE_LEVEL >> *feature_levels, UINT levels, UINT sdk_version, >> > + const >> DXGI_SWAP_CHAIN_DESC *swapchain_desc, IDXGISwapChain ** swapchain, >> > + ID3D11Device **device, >> D3D_FEATURE_LEVEL *feature_level, ID3D11DeviceContext **context) >> > +{ >> > + FIXME("stub: adapter %p, driver_type %s, swrast %p, flags %#x, >> feature_levels %p, levels %#x, sdk_version %d, " >> > + "swapchain_desc %p, swapchain %p, device %p, feature_level >> %p, context %p\n", adapter, debug_d3d_driver_type(driver_type), swrast, >> > + flags, feature_levels, levels, sdk_version, swapchain_desc, >> swapchain, device, feature_level, context); >> > + return E_OUTOFMEMORY; >> sdk_version is an UINT, you need to print it with %u. >> >> In the d3d code we use use 8 byte extran indentation for continued lines: >> >> void function() >> { >> <4> FIXME("bla long text bla\n", >> <4> <8> param1, param2); >> } >> >> Cheers, >> Stefan >> >> >

1 0

Re: Add d3d11_CreateDeviceAndSwapChain
by Stefan Dösinger 02 Feb '15

02 Feb '15

Hi, I'm curious, does this improve the behavior of some application? E.g. game X now falls back to d3d9 without crashing due to the stub? > +HRESULT WINAPI D3D11CreateDeviceAndSwapChain(IDXGIAdapter *adapter, D3D_DRIVER_TYPE driver, HMODULE swrast, UINT flags, > + const D3D_FEATURE_LEVEL *feature_levels, UINT levels, UINT sdk_version, > + const DXGI_SWAP_CHAIN_DESC *swapchain_desc, IDXGISwapChain ** swapchain, > + ID3D11Device **device, D3D_FEATURE_LEVEL *feature_level, ID3D11DeviceContext **context) > +{ > + FIXME("stub: adapter %p, driver_type %s, swrast %p, flags %#x, feature_levels %p, levels %#x, sdk_version %d, " > + "swapchain_desc %p, swapchain %p, device %p, feature_level %p, context %p\n", adapter, debug_d3d_driver_type(driver_type), swrast, > + flags, feature_levels, levels, sdk_version, swapchain_desc, swapchain, device, feature_level, context); > + return E_OUTOFMEMORY; sdk_version is an UINT, you need to print it with %u. In the d3d code we use use 8 byte extran indentation for continued lines: void function() { <4> FIXME("bla long text bla\n", <4> <8> param1, param2); } Cheers, Stefan

1 0

D3d11 CreateDeviceAndSwapChain
by Martell Malone 01 Feb '15

01 Feb '15

Hi, I hope this is the right place to send this Jacek asked me to send d3d11 patches to wine and not mingw-w64 first. More will come so if this is the wrong place please correct me :) Kind Regards Martell

2 2

Re: [2/3] mciqtz32: "status mode" returns resource strings.
by Marvin 30 Jan '15

30 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11379 Your paranoid android. === wxppro (32 bit mci) === mci.c:1287: Test failed: mci capability device type returned MCIERR_DEVICE_LOCKED

1 0

Re: League of Legends shop in game fix
by Austin English 30 Jan '15

30 Jan '15

On Thu, Jan 29, 2015 at 9:19 AM, Monster <manuiglesias96(a)yahoo.es> wrote: > @@ -220,7 +220,10 @@ BOOL wined3d_resource_allocate_sysmem(struct > wined3d_resource *resource) > SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); > void *mem; > - if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > resource->size + align))) > + UINT size = resource->size; > + if (resource->width <= 128 && resource->height <= 128) > + size *= 2; > + if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size + > align))) > return FALSE; > p = (void **)(((ULONG_PTR)mem + align) & ~(RESOURCE_ALIGNMENT - 1)) - 1; > > > > Please use your real name when sending patches. -- -Austin

3 2

Re: [PATCH] winemac.drv: Always initialize a closure-captured object pointer.
by Ken Thomases 30 Jan '15

30 Jan '15

On Jan 29, 2015, at 5:23 PM, Charles Davis <cdavis5x(a)gmail.com> wrote: > You might argue that we don't need to do this because we only use it on > the control paths where we initialize it. Ah, but it *is* used on one of > the other paths: it is captured by the Block closure whether or not we > actually use it inside the Block. This means that, when we copy the > Block onto the heap in OnMainThreadAsync(), the runtime will attempt to > retain it. For some reason, we got away with this in 32-bit > land--probably because the pointer happened to be NULL anyway--but it > broke and died horribly on 64-bit. > > With this change, 64-bit winemac.drv is actually usable. Nice. I was aware of the warning but assumed that it was benign. I'm not sure it's a coincidence that it worked in 32-bit. I don't think that dispatch objects are actually automatically retained by blocks which reference them in 32-bit. It's not entirely related, but it's relatively recent that ARC started doing that and, of course, that requires the modern Objective-C runtime and thus 64-bit. Anyway, I'm glad the Mac driver crashiness in the 64-bit build stemmed from a single cause. I'm sure it wasn't fun to find it. Thanks for doing so. -Ken

1 0

Re: msvcrt: Bump MSVCRT_MB_LEN_MAX to 6 and use it in MSVCRT__wctomb_l for default buffer length
by Piotr Caban 29 Jan '15

29 Jan '15

On 01/23/15 18:38, Orion Poplawski wrote: > diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h > index 41f31b9..401628a 100644 > --- a/dlls/msvcrt/msvcrt.h > +++ b/dlls/msvcrt/msvcrt.h > @@ -47,7 +47,7 @@ > #define MSVCRT_I64_MAX (((__int64)0x7fffffff << 32) | 0xffffffff) > #define MSVCRT_I64_MIN (-MSVCRT_I64_MAX-1) > #define MSVCRT_UI64_MAX (((unsigned __int64)0xffffffff << 32) | 0xffffffff) > -#define MSVCRT_MB_LEN_MAX 2 > +#define MSVCRT_MB_LEN_MAX 6 MB_LEN_MAX equals 5 on windows. It should probably be set to 5 here as well. Probably include/msvcrt/limits.h should also be changed. Thanks, Piotr

2 2

Re: [PATCH 1/2] kernel32/tests: Make loader tests independent from each other
by Dmitry Timoshkov 28 Jan '15

28 Jan '15

> +const static IMAGE_NT_HEADERS nt_header_template = 'static const' is a commonly accepted order. There are various reasons of the current tests structure, if you are not planning to add new tests please leave the code as it is please. -- Dmitry.

2 4

Re: mshtml: Added support for _self target in IHTMLWindow2::open.
by Marvin 28 Jan '15

28 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11354 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: msvcrt: Fix inconsistent rounding behaviour for sprintf and add tests.
by Piotr Caban 28 Jan '15

28 Jan '15

On 01/26/15 12:29, YongHao Hu wrote: > + if(flags.Precision >= 0 && toupper(flags.Format)!='G') { > + temp = pow(10, flags.Precision); > + val = round(val * temp) / temp; > + } This is not correct, val may loose to much precision. Also temp can become INF (in your patch temp is int but I guess it's a mistake). I'm afraid that in order to fix this bug you'll need to stop using glibcs sprintf in wine's printf implementation. Your patch to msvcp tests depends on this patch. Please send patches that depend on each other in series. Thanks, Piotr

2 1

Re: [PATCH 3/3] winecfg: add speaker config controls to audio tab
by Andrew Eikum 27 Jan '15

27 Jan '15

I think you can squash the last two patches. No need to add symbols before they're used. Does it make sense to have a "system default" configuration as well? For example if the user changes which device ALSA's "default" points to from a 5.1 setup to a stereo setup, the "system default" setting should report the configurations correctly (or, as correctly as the backend allows, but you get the point). This might require storing the user-selected speaker configuration elsewhere in the registry, and updating the real registry entry on mmdevapi load. Couple notes below. On Mon, Jan 26, 2015 at 10:28:26PM +0000, Mark Harmstone wrote: > + info->speaker_config = 999; > + if(SUCCEEDED(hr) && pv.vt == VT_UI4){ > + i = 0; > + while (speaker_configs[i].text_id != 0 && info->speaker_config == 999) { > + if ((speaker_configs[i].speaker_mask & pv.u.ulVal) == speaker_configs[i].speaker_mask) > + info->speaker_config = i; > + i++; > + } > + } This is kind of awkward. Could be a for-loop and break early. > + > + /* fallback to stereo */ > + if(info->speaker_config == 999) > + info->speaker_config = 2; > + Yeah, I don't like 999 either. The "system default" would provide a reasonable fallback option here, too. > + IPropertyStore_Release(ps); > + > return TRUE; > + for (i = 0; i < num_render_devs; i++) { > + ERR("%s -> %u\n", wine_dbgstr_w(render_devs[i].id), speaker_configs[render_devs[i].speaker_config].speaker_mask); Looks like a debug line that should be removed or switched to TRACE. > + pv.u.ulVal = speaker_configs[render_devs[i].speaker_config].speaker_mask; > + WARN("speaker_config = %u\n", pv.u.ulVal); Another debug line? > + > + hr = IPropertyStore_SetValue(ps, &PKEY_AudioEndpoint_PhysicalSpeakers, &pv); > + > + if (FAILED(hr)) > + WARN("IPropertyStore_SetValue failed for %s: 0x%08x\n", wine_dbgstr_w(render_devs[i].id), hr); > + > + IPropertyStore_Commit(ps); This isn't actually implemented in mmdevapi, so we end up with noisy "stub" messages on the terminal. Best thing to do would be to fix the property store implementation, but in lieu of that, I'd just switch the FIXME in mmdevapi with a TRACE. Andrew

1 0

Re: shell32: Handle TRASH_EnumItems failures correctly
by Marvin 27 Jan '15

27 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11318 Your paranoid android. === wvistau64 (32 bit recyclebin) === recyclebin.c:98: Test failed: Expected recycle bin to have 0x8 bytes === wvistau64 (64 bit recyclebin) === recyclebin.c:98: Test failed: Expected recycle bin to have 0x8 bytes

1 0

Re: [PATCH 3/3] winecfg: add speaker config controls to audio tab
by André Hentschel 26 Jan '15

26 Jan '15

Hi, first, this should be merged with patch 2. (atomic changes) Am 26.01.2015 um 23:28 schrieb Mark Harmstone: > - IPropertyStore_Release(ps); > if(FAILED(hr)){ > CoTaskMemFree(info->id); > info->id = NULL; > + IPropertyStore_Release(ps); > return FALSE; > } This looks like a independent atomic fix... > + hr = IPropertyStore_GetValue(ps, > + &PKEY_AudioEndpoint_PhysicalSpeakers, &pv); > + > + info->speaker_config = 999; > + if(SUCCEEDED(hr) && pv.vt == VT_UI4){ minor whitespace issue(s) and seen some more whitespace issues, no need to keep consistent with existing code here i'd say > + > + /* fallback to stereo */ > + if(info->speaker_config == 999) my thoughts on this: not sure, maybe -1 is better, or ~0. maybe it should be unsigned... I hope my thoughts help anyway

1 0

Re: [PATCH 2/2] mshtml: Report about protocol as UI resource.
by Alexandre Julliard 26 Jan '15

26 Jan '15

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/nsio.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) This is apparently causing the script.c test to hang here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] d3d/tests: Show that WM_SYSCOMMAND(SC_RESTORE) is delivered only once.
by Marvin 26 Jan '15

26 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11305 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2557: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2562: Test failed: The focus window is active. device.c:2570: Test failed: Got unexpected hr 0x88760869. device.c:2576: Test failed: Got unexpect screen size 800x600. device.c:2591: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2600: Test failed: Got unexpect screen size 800x600. device.c:2613: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2621: Test failed: Got unexpect width 640. device.c:2622: Test failed: Got unexpect height 480.

1 0

Re: [PATCH 1/2] wined3d: Pass WM_SYSCOMMAND(SC_RESTORE) to DefWindowProc (v2).
by Marvin 26 Jan '15

26 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11303 Your paranoid android. === w8 (32 bit device) === device.c:1222: Test failed: TestCooperativeLevel failed, hr 0x88760868. device.c:1267: Test failed: Reset failed, hr 0x88760868. device.c:1269: Test failed: TestCooperativeLevel failed, hr 0x88760869. device.c:1273: Test failed: Got unexpected value 0 for D3DRS_LIGHTING. device.c:1280: Test failed: D3DVIEWPORT->X = 10, expected 0. device.c:1281: Test failed: D3DVIEWPORT->Y = 20, expected 0. device.c:1282: Test failed: D3DVIEWPORT->Width = 400, expected 800. device.c:1283: Test failed: D3DVIEWPORT->Height = 300, expected 600. device.c:1284: Test failed: D3DVIEWPORT->MinZ = 2.00000003e-001, expected 0. device.c:1285: Test failed: D3DVIEWPORT->MaxZ = 3.00000012e-001, expected 1. device.c:1290: Test failed: Screen width is 640, expected 800. device.c:1291: Test failed: Screen height is 480, expected 600. device.c:1297: Test failed: Back buffer width is 640, expected 800. device.c:1299: Test failed: Back buffer height is 480, expected 600. device.c:1329: Test failed: Screen width is 640, expected 1024. device.c:1330: Test failed: Screen height is 480, expected 768. device.c:2550: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2555: Test failed: The focus window is active. device.c:2563: Test failed: Got unexpected hr 0x88760869. device.c:2569: Test failed: Got unexpect screen size 800x600. device.c:2584: Test failed: Expected message 0x47 for window 0, but didn't receive it, i=1. device.c:2593: Test failed: Got unexpect screen size 800x600. device.c:2606: Test failed: Expected message 0x7e for window 0, but didn't receive it. device.c:2614: Test failed: Got unexpect width 640. device.c:2615: Test failed: Got unexpect height 480.

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 5)
by Stefan Dösinger 26 Jan '15

26 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, > +static void add_component(IDirectPlay8AddressImpl *This, struct component *item) > +{ > + if(!This->comp_count) > + This->components = HeapAlloc(GetProcessHeap(), 0, sizeof(struct component *) * This->comp_count+1 ); You can use your heap_alloc() helper here. The same applies to the HeapFree calls added in the patch. Other than that I think error handling would be a good idea. You can check for NULL (as well as in the place where you allocate storage for the component in AddComponent) and return from AddComponent with E_OUTOFMEMORY. The patch has a few formatting issues. Since it looks like dplay & friends will be mostly your reign I'll leave it up to you on how to handle formatting. Do you want me to continue pointing them out? In that case please send me a mail what your intended formatting is. (Obviously it'd be even better if you described your intended formatting to git in the form of a git pre-commit hook containing some regexes ;-) ). Other than this the patch looks good. The following is unrelated to this patch, I just noticed it (again?) while reading through it: Am 2015-01-23 um 08:10 schrieb Alistair Leslie-Hughes: > + case DPNA_DATATYPE_STRING: > + memcpy(pvBuffer, &entry->data.string, entry->size); > + break; Please add a test for a case where AddComponent is called with DPNA_DATATYPE_STRING where (strlen(string) + 1) * sizeof(WCHAR) != dwDataSize. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUxS4iAAoJEN0/YqbEcdMwvFkP/RF6kH1o1C4fQgfa/J+4j6zV kwp3M7rqU5VTasKYV+G0pdAQ+wvBzHpMPSqLRD/HfBWGf3dAPCk94C9d659enkJN Qhy7hhO6aazsXKq7iWVAgQrGJy59oBoL14Vg+44hUJIeu7qWv3uuqihVgKUqiG2K Bl235p9cM/WYLGXFEF4d1UFHBKZb0bhRudwuzRbuN8r3RLwpEhrKbbKg8yXOPjLq Vejc4d219iib3ZpbT13pq0j/+a+ox+R62+O9S5wGbu/G8IGxVPTgsY20mpFyPsHX DoedE56wfSSe5Psb78NVmC32bWY8nmUzJA9YBb26a0KPO9QZNVnJkkYkOKIFr6P/ ouVLfWbO4QV2dOPRbYnh+40XCIbPeatGMq9vE7TDZPtxLBkRTEl1GudZ5usFwCK7 XgTPjb+BIu37UCbt0hpWA4IH8UeyYue08DnGCWkMkGS6ClH9KCG2xVqL8F1gr8Bw W5iKcVVHFZzHS6D947nN17Fl6Rg4+oLui0zkgtveU/AY/ew8xptHt4rW6It3QU5t HkNce4St+2w1LErIuYRITrvQV6lrndDDgvvlPcK1P1zt2D1a9gpqnsPgKM/tZLu+ fO8P8Yjl81KZHlAVWMUutiDzlelUOJvaXnVNX5VVkyOajHDI569MKy4qOETSdiim gwulxslghTkPCsAa+LpB =iY0u -----END PGP SIGNATURE-----

1 1

Re: [PATCH 5/5] atl100/tests: Added initial interface tests for AtlAxAttachControl.
by Qian Hong 26 Jan '15

26 Jan '15

Please ignore this patch, I'm working on an improved version. On Fri, Jan 23, 2015 at 5:21 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > Test cases based on dlls/mshtml/tests/activex.c, thanks Jacek Caban for the > previous work. > > --- > dlls/atl100/tests/Makefile.in | 2 +- > dlls/atl100/tests/atl.c | 446 > ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 447 insertions(+), 1 deletion(-) > > > > > -- Regards, Qian Hong - http://www.codeweavers.com

1 0

Re: [3/3] cmd: implemented && and || functionality (try 2)
by Marvin 24 Jan '15

24 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11295 Your paranoid android. === build (build) === Patch failed to apply

1 0

Wine 1.7.35 source code scanning (Cppcheck)
by Игорь Чебаненко 24 Jan '15

24 Jan '15

1 0

Re: [PATCH 3/5] atl: Added stub AtlIPersistPropertyBag_Save.
by Jacek Caban 23 Jan '15

23 Jan '15

On 01/23/15 10:18, Qian Hong wrote: > +HRESULT WINAPI AtlIPersistPropertyBag_Save(LPPROPERTYBAG pPropBag, BOOL fClearDirty, BOOL fSaveAllProperties, > + ATL_PROPMAP_ENTRY *pMap, void *pThis, IUnknown *pUnk) > +{ > + > + FIXME("(%p, %x, %x, %p, %p, %p)\n", pPropBag, fClearDirty, fSaveAllProperties, pMap, pThis, pUnk); > + return S_OK; > +} It's a minor detail, but after two patches in series removing unnecessary empty lines, you add a new one here ;) Cheers, Jacek

2 1

Re: [PATCH 4/5] atl100: Implemented semi stub AtlAxCreateControlLic and AtlAxCreateControlLicEx.
by Jacek Caban 23 Jan '15

23 Jan '15

Hi Qian, On 01/23/15 10:19, Qian Hong wrote: > diff --git a/dlls/atl/atl_ax.c b/dlls/atl/atl_ax.c > index 15b0550..656165b 100644 > --- a/dlls/atl/atl_ax.c > +++ b/dlls/atl/atl_ax.c > @@ -1435,8 +1435,9 @@ INT_PTR WINAPI AtlAxDialogBoxA(HINSTANCE hInstance, LPCSTR lpTemplateName, HWND > */ > HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStream *stream, IUnknown **container, BSTR lic) > { > - FIXME("(%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic)); > - return E_NOTIMPL; > + if (lic) > + FIXME("semi stub (%s %p %p %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, debugstr_w(lic)); > + return AtlAxCreateControl(lpTricsData, hwnd, stream, container); > } > > /*********************************************************************** > @@ -1446,9 +1447,10 @@ HRESULT WINAPI AtlAxCreateControlLic(const WCHAR *lpTricsData, HWND hwnd, IStrea > HRESULT WINAPI AtlAxCreateControlLicEx(const WCHAR *lpTricsData, HWND hwnd, IStream *stream, > IUnknown **container, IUnknown **control, REFIID iidSink, IUnknown *punkSink, BSTR lic) > { > - FIXME("(%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control, > + if (lic) > + FIXME("semi stub (%s %p %p %p %p %s %p %s)\n", debugstr_w(lpTricsData), hwnd, stream, container, control, > debugstr_guid(iidSink), punkSink, debugstr_w(lic)); > - return E_NOTIMPL; > + return AtlAxCreateControlEx(lpTricsData, hwnd, stream, container, control, iidSink, punkSink); > } > > #endif Please forward AtlAxCreateControlEx to AtlAxCreateControlLicEx and add FIXME about unsupported argument instead of the other way around. Otherwise we'd have to do that later to support the argument anyway. Also AtlAxCreateControlLic would probably be better forwarded to AtlAxCreateControlLicEx. Cheers, Jacek

2 1

Re: [PATCH 5/5] wined3d: Use the core version of the shader object functions.
by Henri Verbeet 23 Jan '15

23 Jan '15

On 21 January 2015 at 18:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + typedef void (WINE_GLAPI *gl_shader_source_type)(GLuint, GLsizei, const GLchar * const *, const GLint*); > + ... > + #define MAP_GL_FUNCTION_CAST(core_func, cast, ext_func) \ > + do \ > + { \ > + if (!gl_info->gl_ops.ext.p_##core_func) \ > + gl_info->gl_ops.ext.p_##core_func = (cast)gl_info->gl_ops.ext.p_##ext_func; \ > + } while (0) ... > + MAP_GL_FUNCTION_CAST(glShaderSource, gl_shader_source_type, glShaderSourceARB); I'm not sure that's really much better than just adding a (void *) cast.

3 4

Re: shell32: Implement IApplicationAssociationRegistration, QueryCurrentDefault (try 6)
by Nikolay Sivov 23 Jan '15

23 Jan '15

On 23.01.2015 10:24, Alistair Leslie-Hughes wrote: > + ret = RegGetValueW(hkey, NULL, NULL, RRF_RT_REG_SZ, &keytype, NULL, &size); > + if(ret == ERROR_SUCCESS) > + { > + *association = CoTaskMemAlloc(size * sizeof(WCHAR)); Does it really return length in characters? I thought it's always in bytes. > + if(*association) > + { > + ret = RegGetValueW(hkey, NULL, NULL, RRF_RT_REG_SZ, &keytype, *association, &size); > + if(ret == ERROR_SUCCESS) > + hr = S_OK; > + } > + } In case of !*association please return earlier with E_OUTOFMEMORY.

1 0

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 5)
by Marvin 23 Jan '15

23 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11271 Your paranoid android. === w8 (32 bit address) === The test timed out

1 0

Re: WineHQ zh_CN Translation Patch Up
by Bruno Jesus 22 Jan '15

22 Jan '15

On Thu, Jan 22, 2015 at 2:10 PM, Jeff Bai <jeffbaichina(a)gmail.com> wrote: > Hello fellow developers > > Here is a copy of the patch of changed zh_CN localization from AOSC (Anthon > Open Source Community) L10n project. We've fixed the msgid width problem > which was addressed last time. The patch is large so we put this on our > public PasteBin site, as follows > > https://pastebin.anthonos.org/view/a0c1c1a3 > > Please mail back with any issue over this patch. Hi, please send the email again with the patch as an attachment and I think a more proper subject would be: po: Update Simplified Chinese translation > Keep up the good work! > > Jeff Bai > AOSC Best regards, Bruno

1 0

Re: WineHQ zh_CN Translation Patch Up
by Alex Henrie 22 Jan '15

22 Jan '15

Jeff, The best way to submit patches is with `git format-patch` and `git send-email`. It looks like Alexandre won't accept patches submitted via pastebin. -Alex

1 0

Re: ws2_32: Better trace setsockopt/getsockopt
by Bruno Jesus 22 Jan '15

22 Jan '15

On Tue, Jan 6, 2015 at 12:49 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > The intention of this patch is to make it easier to read winsock logs, > for setsockopt it even displays the value if its size is less than 5 > bytes. Hi, any complains about this patch? It's pending for 2 weeks now and I think this is a good waiting time to ask. Best Regards, Bruno

2 1

Re: [PATCH 3/5] wined3d: Initialize the last two components of R16G16_SINT attributes.
by Henri Verbeet 22 Jan '15

22 Jan '15

On 21 January 2015 at 18:32, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > - GL_EXTCALL(glVertexAttrib4svARB(index, ptr)); > + { > + GLshort s[4] = {((const GLshort *)ptr)[0], ((const GLshort *)ptr)[1], 0, 1}; > + GL_EXTCALL(glVertexAttrib4svARB(index, s)); > break; > + } Perhaps I'm missing something, but wouldn't it be much easier to just use glVertexAttrib2svARB() instead?

1 0

Re: [PATCH 6/6] kernel32: Invalid console handles for new processes are 0, not INVALID_HANDLE_VALUE.
by Alistair Leslie-Hughes 21 Jan '15

21 Jan '15

On 21/01/15 08:51, Erich E. Hoover wrote: > Several applications rely on the TEB value for fresh invalid console > handles to be zero instead of INVALID_HANDLE_VALUE (fixes Bug #36216 > and Bug #37914). > > +····if·(!params->hStdOutput·||·params->hStdOutput·==·INVALID_HANDLE_VALUE) > +········params->hStdOutput·=·0; The !params->hStdOutput check is redundant since it's already 0. Applies to the other places as well. Best Regards Alistair Leslie-Hughes

2 1

Wine Gecko 2.36-beta1
by Jacek Caban 21 Jan '15

21 Jan '15

Hi all, I just uploaded new Wine Gecko beta packages. This time it's based on Firefox 36 beta branch, so it should be pretty stable. To test it please use the attached patch. That's all you need, Wine will download Gecko automatically. Packages are also available on Wine SourceForge if you prefer to download it manually. All testing is appreciated. Regressions and build problems are most important, but all feedback is welcomed. I'm also sending this announcement mingw-w64 mailing list. I know that some distro package maintainers that maintain Wine Gecko packages read it. Beta releases are a good chance to make sure that it builds with toolchains available in distros. Note that the package requires very recent mingw-w64 Git version. A new release on mingw-w64 is planned, so hopefully it will be out before final Wine Gecko release (which is expected in 5-6 weeks). Thanks, Jacek

1 0

Re: msi: Add a partial implementation of MsiProvideComponent.
by Marvin 21 Jan '15

21 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11245 Your paranoid android. === wxppro (32 bit msi) === The test timed out === w7u (32 bit msi) === The test timed out

1 0

Re: msxml3/tests: Actually test the return values (PVS-Studio)
by Michael Stefaniuc 21 Jan '15

21 Jan '15

Please ignore, wrong resend. On 01/21/2015 10:48 AM, Michael Stefaniuc wrote: > --- > dlls/msxml3/tests/domdoc.c | 1 + > dlls/msxml3/tests/schema.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index a23fb66..e669de4 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -11085,6 +11085,7 @@ static void test_xmlns_attribute(void) > V_VT(&v) = VT_BSTR; > V_BSTR(&v) = _bstr_("urn:schemas-microsoft-com:datatypes"); > hr = IXMLDOMAttribute_put_nodeValue(pAttribute, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > > hr = IXMLDOMElement_setAttributeNode(root, pAttribute, NULL); > ok(hr == S_OK, "ret %08x\n", hr ); > diff --git a/dlls/msxml3/tests/schema.c b/dlls/msxml3/tests/schema.c > index f5d6fcd..be18fcf 100644 > --- a/dlls/msxml3/tests/schema.c > +++ b/dlls/msxml3/tests/schema.c > @@ -1292,6 +1292,7 @@ static void test_XDR_datatypes(void) > > VariantClear(&type); > hr = IXMLDOMNode_get_nodeTypedValue(node, &type); > + EXPECT_HR(hr, S_OK); > ok(V_VT(&type) == VT_BSTR, "got variant type %i\n", V_VT(&v)); > VariantClear(&type); > IXMLDOMNode_Release(node); >

1 0

Re: msxml3/tests: Remove an unused assignment (PVS-Studio)
by Michael Stefaniuc 21 Jan '15

21 Jan '15

*SIGH* please ignore this one as this is already commited. Pushed out the wrong mailbox. On 01/21/2015 10:43 AM, Michael Stefaniuc wrote: > --- dlls/msxml3/tests/domdoc.c | 1 - 1 file changed, 1 deletion(-) > > diff --git a/dlls/msxml3/tests/domdoc.c > b/dlls/msxml3/tests/domdoc.c index 1a73771..a23fb66 100644 --- > a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ > -4903,7 +4903,6 @@ static void test_xmlTypes(void) > > doc = create_document(&IID_IXMLDOMDocument); > > - pNextChild = (void*)0xdeadbeef; hr = > IXMLDOMDocument_get_nextSibling(doc, NULL); ok(hr == E_INVALIDARG, > "ret %08x\n", hr );

1 0

Re: msxml3/tests: Actually test the return values (PVS-Studio)
by Marvin 21 Jan '15

21 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11239 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: msxml3/tests: Remove an unused assignment (PVS-Studio)
by Marvin 21 Jan '15

21 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11238 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: user32/tests: Don't test function directly when reporting GetLastError()
by Marvin 21 Jan '15

21 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11234 Your paranoid android. === w7u (32 bit msg) === msg.c:12108: Test failed: unexpected hwnd 0014013C

1 0

About Patch 108345 Pending ( gdiplus: fix get_clip_hrgn when window origin point changed (try 2) )
by Changhui Liu 19 Jan '15

19 Jan '15

Hi, all, I reviewed this path http://source.winehq.org/patches/data/108345, I only found a code style problem: this: + if ( status == Ok && graphics->hdc)should :+ if (status == Ok && graphics->hdc) Could you help me point out the other mistake ? Thanks . ------------------ Regards, Changhui.

2 1

Re: gdi32: Do not enumerate fonts with names that are too long
by Dmitry Timoshkov 19 Jan '15

19 Jan '15

Aric Stewart <aric(a)codeweavers.com> wrote: > Both the FullName and the FamilyName need to fit in the LOGFONT > structure. What happens with such a font under Windows? I'd expect the name be simply truncated instead of the font being skipped. In the latter case the font should not be added to the list at all. -- Dmitry.

2 1

Re: [PATCH 8/9] wined3d: Filter messages generated by focus handling.
by Henri Verbeet 19 Jan '15

19 Jan '15

On 4 December 2014 at 21:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > We may want to consider moving mode changes, window setup and focus loss > handling into the client libs. With this patch and the next one we have > 3 wined3d flags just for focus loss handling. Furthermore, dxgi yet > again has different behavior - it doesn't hook the window procedure and Yeah, possibly, although I'd also like to keep the amount of Win32 specific stuff in the public wined3d API to a minimum, so I'd rather not have the client libs e.g. handle window messages directly. > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index ae6600e..89ec00a 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4961,7 +4961,7 @@ void device_invalidate_state(const struct wined3d_device *device, DWORD state) > LRESULT device_process_message(struct wined3d_device *device, HWND window, BOOL unicode, > UINT message, WPARAM wparam, LPARAM lparam, WNDPROC proc) > { > - if (device->filter_messages) > + if (device->filter_messages && message != WM_DISPLAYCHANGE) That seems pretty specific. I'd be curious how other broadcast messages are handled.

2 2

Re: [PATCH 9/9] wined3d: Pass WM_SYSCOMMAND(SC_RESTORE) to DefWindowProc.
by Henri Verbeet 19 Jan '15

19 Jan '15

On 4 December 2014 at 21:51, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c > index 89ec00a..51dabd4 100644 > --- a/dlls/wined3d/device.c > +++ b/dlls/wined3d/device.c > @@ -4992,6 +4992,16 @@ LRESULT device_process_message(struct wined3d_device *device, HWND window, BOOL > > device->device_parent->ops->activate(device->device_parent, wparam); > } > + else if (message == WM_SYSCOMMAND) > + { > + if (wparam == SC_RESTORE && !(device->wined3d->flags & WINED3D_NO_SYSCOMMAND_HANDLING)) I'm not really a fan of this kind of double negative. The way the flag is used, it also seems to be about restores in particular instead of syscommands in general. > + { > + if (unicode) > + DefWindowProcW(window, message, wparam, lparam); > + else > + DefWindowProcA(window, message, wparam, lparam); > + } > + } > > if (unicode) > return CallWindowProcW(proc, window, message, wparam, lparam); Is this really how it's supposed to work? In particular, should DefWindowProc really always get the message before the application does, or should we give the application a chance first, and only pass to DefWindowProc if it doesn't handle the message?

2 2

Re: [PATCH 2/5] wined3d: Handle the SM4 SV_POSITION pixel shader input semantic in the GLSL shader backend.
by Stefan Dösinger 19 Jan '15

19 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-01-19 um 13:44 schrieb Henri Verbeet: > This is (mostly) equivalent to the vPos register in SM3. > ... > + if (!strcmp(semantic_name, "SV_POSITION")) > + shader_addline(buffer, "ps_in[%u]%s = vpos%s;\n", > + shader->u.ps.input_reg_map[i], reg_mask, reg_mask); The vpos variable has the d3d9 0.5 pixel offset applied, which to my knowledge is not correct for d3d10. Is this intentional? (I guess yes, either for simplicity to make patch 3 work and / or because we're still adding the offset on the vertex side even in d3d10.) -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUvQcWAAoJEN0/YqbEcdMwutkP/irVdyJWjIwnAnwgltjehO9A Vp4CZneYnbnAP/SJjhvsY7RwhHdUelzhv8wX8m9q0Y92jPMtvTt6OMAdppxATSOY Bo70j7fpaMJbRG/GCrDSCp3geyzN/1p6CQu5JfahVuSBOGg7EIDdR0OA4hA9aDEE R/pzerlOuvIY8vMOejYk99wBWEOLWJUcWNfrRq30ASnyIK6wcBhr3QLdcRI8/57m +MtFG53+R6wGdRQih1PfmDP4CJnfhr33TQgKod9ezYGyNcS8X/rRTq3mE0uqq3TJ 7+S4A21o7j2nEBlEWlwt6op7Yg2xhMan5znQU/MwREFaGGPWdapNpl1NxpWM/wp0 zm992j3TgpCqHLCW0u8Z5t2fClWuyU8IcZWsLql2FVZa3DvG6QOeXS3oEVlw5jxu fU9iMiJeh7Aywt8tvro4kG5opA2CCUFUJu1Cf7FBQpAUtHYqY5B1vm67fzeMfLt5 C2XC6L79dK0L0YenFqrGWQOU5/u4skW5Cgi5Yt5AKx0Ifk4gTrPq1/pSCeEFUS+T H2ZjZCqCYYp7NCWSXQSpBSFcVE7bURfJNBC3j9TTBCoT/pCOTKr8vv6Dqn0pjxku 6hdmAEaW7vUKr6ucUopgDNQ6E+aCdaofUMqJuhlOAOL8arthwIPZbO2hb8lLTSBq Smb3+zJL2d2YBZZelE4f =0cAR -----END PGP SIGNATURE-----

2 1

ole32:fix CoWaitForMultipleHandles cause RPC hang (try 2)
by Changhui Liu 19 Jan '15

19 Jan '15

Dear Sebastian: I commit a new ole32 path last month at here: http://source.winehq.org/patches/data/108302. Could you help me review it again when you are free? Thank you. ------------------ Regards, Changhui.

1 0

Re: [PATCH (try 3) 2/2] dpvoice: Turn GetCompressionTypes into a semi-stub.
by Stefan Dösinger 18 Jan '15

18 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-01-16 um 08:44 schrieb Alex Henrie: > Star Trek Armada II needs GetCompressionTypes to return at least > one value, see https://bugs.winehq.org/show_bug.cgi?id=29238 Is the game happy if you return DV_OK and set *pdwNumElements = 0? > MS-PCM is guaranteed to be present on Windows XP, and it's already > implemented in Wine, so advertising this codec shouldn't cause any > trouble. Even though we have the codec we probably don't have the dpvoice infrastructure to hook up a dpvoice client to the codec, right? That's not necessarily a reason to reject the semi-stub though. > +extern HRESULT DPVOICE_GetCompressionTypes(DVCOMPRESSIONINFO > *pData, DWORD *pdwDataSize, DWORD *pdwNumElements, DWORD dwFlags) > DECLSPEC_HIDDEN; Please avoid hungarian notation names (dwThisIsAdWord, *pThisIsAPointer). > + string_loc = (LPWSTR)((char*)pData + sizeof(pcm_type)); + > memcpy(pData, &pcm_type, sizeof(pcm_type)); + memcpy(string_loc, > pcm_name, sizeof(pcm_name)); + pData->lpszName = string_loc; I think there should be a nicer way to do this. I didn't test this with the compiler, but I guess you can do something like this: struct { DVCOMPRESSIONINFO info; const WCHAR name[]; } codec = { {80, {0x8de12fd4,0x7cb3,0x48ce {0xa7,0xe8,0x9c,0x47,0xa2,0x2e,0x8a,0xc5}}, &codec.name, NULL, 0, 64000}}, {'M','S','-','P','C','M',' ','6','4',' ','k','b','i','t','/','s',0}; }; ... memcpy(pData, codec, sizeof(codec)); I don't know how well the variable-size array at the end of the struct works. It also won't easily work for more than one element. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUuUN7AAoJEN0/YqbEcdMwFwcP/iSIxX72VcW9TSqbWHnq1Pi6 7Yv9zcL3h/3Mx0rERFiaT15Tmz7+YNyKfngR6kZwM7ms5usqePHCW1y1dT7ImCfM gSAgd5WBTKuk5qpr0k2zLgl4O3TVJn4zTP8wKNa+lwGDJgY7d3ThcgDd/LI6kkiU KI2Uv+jyh00Co2G6egmhlZDfwWo3dI/b+7fndC1jnYCcyIIxjLywdiQ80SCi3IgB sktBaQW7mvzzQDtMKgwR/BNUSze6AQeWQ5+xmWivIm4jsPGETmr3r0VnRtxxMduA LzXJJewnGojJoaQ1dsjsXJJ+S+3rKCd5cKrbnlyFXJ2pqHGrBdkQwbFTWse+8Tsf +Au00otO85InuwenrvKutN92c4pP8hfyxAQbKJUjVCnD5ppMDXkRrx0xKfAy7SWB FpQuO6KLeWMotDYcC21kwY3jGLAxKOWGh02p7S5AUIlnZ0m1kJ3PK1DxhomRHYax 4pgQx0jb/MITw1/L5hJ8KlNcucLJxC2FBGpgRC32LAUHMVcNurs6bHQbgbl9UKUS zH4gOA7PzNTGG3G3To/IqmayhmzNMLk/b0XusIGKF1Ao3uyU3Yw+5RuzPlGaKOkT cAhRIl5Ujbcjt8JKgtdq4x1VeGMutHlePhPuUpgZX98n+/Bgk9uZ5rScVLW1ELGW XQ6zfKUWW2qirySBqy+A =StHs -----END PGP SIGNATURE-----

2 4

Re: [2/3] msi: Open 32-bit component registry keys with KEY_WOW64_32KEY flag. (try 2)
by Marvin 18 Jan '15

18 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11200 Your paranoid android. === wxppro (32 bit install) === The test timed out

1 0

Re: user32: Allocate memory based on HICON instead of DWORD to fix 64 bit problems
by Stefan Dösinger 18 Jan '15

18 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-01-17 um 23:51 schrieb Bruno Jesus: > - frames = HeapAlloc( GetProcessHeap(), 0, sizeof(DWORD)*header.num_frames ); > + frames = HeapAlloc( GetProcessHeap(), 0, sizeof(HICON)*header.num_frames ); sizeof(*frames)*header.num_frames would be better. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUu45mAAoJEN0/YqbEcdMwtrkP/2a+96GGXGtHq4g8P+UYBWjc AxGPcxAq5ND++lDYK22TyY1XC5ZXjByvxYOcrMsb4yhYRfJbPVgKx6gY+ALe6aog ilAFF0waM7kRPxXcNotcE9ZlXQpKAfLvTQajJSH9e1MgYUfcMbaSS8eSJMSNslcM Sa9rDDaeabp6wNymbvKOtpTjIOS767Jz9m7xCw+NtA9FFIHwrZsZ/LxeWiDQxDmR STNGPoEELt+vvAPB0K2Rnn/5AZrjekdYy0cUR78htsEqGIodBO86kD6K20r3cQ5s 7cmiAj8lHtUJ/6FPB54DynmSpNiPiXOlPc0dSL+ujsEEGJ/rI8wFtM/kCIzEe6GY 6sv881G8mXX8AMDgOg+O3Tlo0qprfWvVmkTE5ASGXGsdck04yPO4UfKvOon3IaXI dyrjRkBK8w2X63L5R39BzmKvtcZgKQj+r4M8is8Rn4hk2iAmz4ejFYlzcDVCJ0Zg W/kurjSSroUcOKsjcjMuB738W43mgHhh9xdbO/06FOYXULXOQVDFO7x19NI2ilpi VK5x6XRg4OxARuFU6tuSqll1a9PtNgIuzWc+BHDOS9Htc5WVpDTQvPUPtVif/6L/ 6MZbDeC9rm+IAytmXvpFDU+C6c2/axUMCfwB9idAKFaTKI5nemKLCeEPLiq1nVUh 5xulwJdbSnxoi7M72Vf6 =Tg70 -----END PGP SIGNATURE-----

1 0

Re: [PATCH (try 3) 2/2] dpvoice: Turn GetCompressionTypes into a semi-stub.
by Stefan Dösinger 16 Jan '15

16 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-01-16 um 08:44 schrieb Alex Henrie: > Star Trek Armada II needs GetCompressionTypes to return at least > one value, see https://bugs.winehq.org/show_bug.cgi?id=29238 Is the game happy if you return DV_OK and set *pdwNumElements = 0? > MS-PCM is guaranteed to be present on Windows XP, and it's already > implemented in Wine, so advertising this codec shouldn't cause any > trouble. Even though we have the codec we probably don't have the dpvoice infrastructure to hook up a dpvoice client to the codec, right? That's not necessarily a reason to reject the semi-stub though. > +extern HRESULT DPVOICE_GetCompressionTypes(DVCOMPRESSIONINFO > *pData, DWORD *pdwDataSize, DWORD *pdwNumElements, DWORD dwFlags) > DECLSPEC_HIDDEN; Please avoid hungarian notation names (dwThisIsAdWord, *pThisIsAPointer). > + string_loc = (LPWSTR)((char*)pData + sizeof(pcm_type)); + > memcpy(pData, &pcm_type, sizeof(pcm_type)); + memcpy(string_loc, > pcm_name, sizeof(pcm_name)); + pData->lpszName = string_loc; I think there should be a nicer way to do this. I didn't test this with the compiler, but I guess you can do something like this: struct { DVCOMPRESSIONINFO info; const WCHAR name[]; } codec = { {80, {0x8de12fd4,0x7cb3,0x48ce {0xa7,0xe8,0x9c,0x47,0xa2,0x2e,0x8a,0xc5}}, &codec.name, NULL, 0, 64000}}, {'M','S','-','P','C','M',' ','6','4',' ','k','b','i','t','/','s',0}; }; ... memcpy(pData, codec, sizeof(codec)); I don't know how well the variable-size array at the end of the struct works. It also won't easily work for more than one element. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUuUNyAAoJEN0/YqbEcdMwb/wP/3QuWJc0dQtO7tcPo/alre6S ASLeDH+5+F+LBTwFBnlNJhkizO7PtpRUCqH6k0fxGtSprsNMnyu3T/KqBPTku8kx XUhS4jNcV6lDzSvruKEHx4m+Lrpgs/onSK4pLUa9cP0FvZgKpLA+XTJtXgOuX40K 31/TOW/DRq6gXeGE11Oxz97Vx2mILfhmLfhtIeTRA4RpkGyMlWlKST9l3xyNn0dt ystZG62OWVnljq/g2U8Ce4n+zz97Hlxzkk7uB4ZI2/m8/EBdGEhOgGTsUdEulu6P cChWJqzJOo8zxJr+RXeWnQN38V2yKW6CwxnIQ90INKd1WV1NvGZfiYDMXdUBMrYm XrQ4A6xaLwfCIVgzJ1wyPDGYFb92sOr34ly3v/fTuQNb2DnamdgENhw/Gj9APsIS ErfHiTgoWGbh77WuRm2GC/GfxpOsK2lpnO2uwXcrWXyYy8u2GP9zEhHLl3ohcG2+ dEL7Q0MABEitbGQJ4qTbpNffFIbLwWdKcKEP67gBFM2T937/4z5ISce0WlI6SBHX l+yXKK/vSJ1U+/B2i+fsbyFOr0rQMCIt1k6uAOlnPM29uwZOjJtG3gCp6BbK+vqw Jc2yGJl3PdAjwfHuHGTakWx6EflZLLGqqcLXWnfs3gzgExHnbHGZaOdKDYx+qsqz cEUAmwJUxAcp6cMGiuQX =ue9K -----END PGP SIGNATURE-----

1 0

Re: [PATCH (try 2) 1/2] dpvoice/tests: Add GetCompressionTypes tests.
by Stefan Dösinger 16 Jan '15

16 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2015-01-15 um 12:55 schrieb Alex Henrie: > + DVCOMPRESSIONINFO data[32]; I can't really find any documentation about this. Is there a documented maximum number of elements returned? > + int i, j; Afaics you can make those unsigned. > + LPWSTR string_loc; Is the use of the LPFOO type intentional? > + if(GetCompressionTypes(iface, NULL, NULL, NULL, 0) == E_NOTIMPL) > + { > + skip("%s: GetCompressionTypes not implemented\n", name); > + return; > + } I think todo_wine ok(0, "GetCompressionTypes not implemented") is better here, but I don't particularly mind since you remove it in the next patch anyway. > + ok(data_size > sizeof(DVCOMPRESSIONINFO) && data_size < sizeof(data) - 1, > + "%s: tests[%i]: expected data_size between %i and %i got data_size=%i\n", > + name, i, sizeof(DVCOMPRESSIONINFO), sizeof(data) - 1, data_size); data_size is unsigned, you should use %u instead of %i. Same for i and j once you change them to unsigned. > + string_loc = (LPWSTR)((char*)data + num_elements * sizeof(DVCOMPRESSIONINFO)); It's interesting that native places the string in the same data blob, but it kinda makes sense. I think (WCHAR *)(data + num_elements) or (WCHAR *)&data[num_elements] should work as well. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUt7l0AAoJEN0/YqbEcdMwf/sQAIGsh8jbGM7AsbdeHt5uEJUD AGGg9OcqrDnW0PoCd5w36G70tNF/NFMRleNJ0tOL4r3HG8TD16BDXCkxW/U9hR7G 6c+DGAqnOFG0y6CjSAMGSvRh5VZVrD5OlI4XRTNFqYdL1QkVD0yQ/kXQl8YsvMUu x/sWJ1kF4FCcojmmhIP5tSo6AmZJlso18tlOReCBBnHDkdq+0ej8ltR/pG0NmZUp 3eOdSfyHd0Swc9P8nLossRKbieORr88fE0ZUBP7oOtg2JbLfs3l/F4fudbPoMF8v 5JbJXD+KuHdNvGYBJ2ppHEZCUC2ArHEYgMW0m2ffRoWfoXmrJCUE8AnJsyHsjaYI LFRiRGom7kRjoY8fhbTSJWdNTKLbW5swAiCzW7A+NkQvrXn5dcL2kZVpi2Z4x1gu 1JKYmb5G9G6SG+U4wblTWET4RWv5rAzoNeXvDZtznBW/KinnkNX2Ic7kug1/usqj ATJ9q8ARt+3DMPYRonk7sXzFdyRRXhlCROlBvqHBkPitVz3tLxvziB/4C1SZ9ybu wy28DMfEYfwbi/9iQnaHsn+811d7uf85QkKgiV6CBvS8XJ2xVzvHWnSWlbc0wNj1 /Gy5gCuKkluFWbJJjAliAf6+uHIypvBbFr85/Gn3gQy/tNUOH4FFSXPB18XrBXh3 CFH+vOFS/SN8fEA6WOtw =EJNM -----END PGP SIGNATURE-----

2 2

Re: [PATCH 4/5] opengl32: Store the OpenGL context version in the handle value.
by Alexandre Julliard 16 Jan '15

16 Jan '15

Matteo Bruni <mbruni(a)codeweavers.com> writes: > @@ -53,7 +53,14 @@ enum wgl_handle_type > { > HANDLE_CONTEXT = 0 << 12, > HANDLE_PBUFFER = 1 << 12, > - HANDLE_TYPE_MASK = 15 << 12 > + HANDLE_TYPE_MASK = 7 << 12 > +}; > + > +enum wgl_opengl_version > +{ > + OPENGL_1 = 0 << 15, > + OPENGL_3 = 1 << 15, > + OPENGL_VER_MASK = 1 << 15 > }; That's certainly acceptable, but since it only applies to contexts I'm wondering if it wouldn't be cleaner to add a CONTEXT_V3 type in the existing enum. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: iphlpapi: Set 0.0.0.0 as the IP and mask of disconnected interfaces
by Bruno Jesus 16 Jan '15

16 Jan '15

On Thu, Jan 15, 2015 at 10:13 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Superseeds 108610. > > In Windows if the eth cable is disconnected the interface returns > 0.0.0.0, when it's connected and using DHCP but no DHCP server is > found it returns an APIPA [1] address. In our case it's simpler to > assume that an IP less interface is a disconnected interface. > > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=32205 > > [1] http://www.webopedia.com/TERM/A/APIPA.html I see the patch is pending. In defense of the patch all I can do is say that I manually tested this in different Windows versions by disconnecting the interface (physical cable/wifi connection). If there is a specific concern about it please tell me so I can look for alternatives. Windows 98 connected (ETH): Adapter '', IP 172.16.204.135, Mask 255.255.255.0 Windows 98 disconnected (ETH): Adapter '', IP 0.0.0.0, Mask 0.0.0.0 Windows XP connected (ETH): Adapter '{02FB7145-66CB-4DF2-8975-BBCAC6044973}', IP 172.16.204.131, Mask 255.255.255.0 Windows XP disconnected (ETH): Adapter '{02FB7145-66CB-4DF2-8975-BBCAC6044973}', IP 0.0.0.0, Mask 0.0.0.0 Windows 8.1 connected (ETH): Adapter '{8973E4B8-0C69-45E0-85D0-EF4A71D6BD87}', IP 10.100.200.60, Mask 255.0.0.0 Windows 8.1 disconnected (ETH): Adapter '{8973E4B8-0C69-45E0-85D0-EF4A71D6BD87}', IP 0.0.0.0, Mask 0.0.0.0 Windows 8.1 connected (WIFI): Adapter '{1E13889D-F3CC-49BC-A750-FFBE451AC8E1}', IP 192.168.251.136, Mask 255.255.255.0 Windows 8.1 disconnected (WIFI): Adapter '{1E13889D-F3CC-49BC-A750-FFBE451AC8E1}', IP 0.0.0.0, Mask 0.0.0.0 Best Regards, Bruno

1 0

Re: [PATCH 3/5] opengl32: Update to GL 4.5.
by Alexandre Julliard 15 Jan '15

15 Jan '15

Matteo Bruni <mbruni(a)codeweavers.com> writes: > I fixed up manually a couple of misgenerated bits, my feeling is that > similar fixups were done last time too. I'm not aware that fixups have ever been done by hand, that doesn't sound like a good idea. Please try to fix the script instead. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: ntdll: Fixed buffer size checking for ProcessWow64Information on 64bit in NtQueryInformationProcess. (try 2)
by Alexandre Julliard 15 Jan '15

15 Jan '15

Qian Hong <qhong(a)codeweavers.com> writes: > @@ -403,12 +403,13 @@ NTSTATUS WINAPI NtQueryInformationProcess( > break; > > case ProcessWow64Information: > - len = sizeof(DWORD); > + len = sizeof(ULONG_PTR); You'd also have to write the correct size, and add tests demonstrating that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: iphlpapi: Set 0.0.0.0 as the IP and mask of disconnected interfaces
by Henri Verbeet 15 Jan '15

15 Jan '15

On 15 January 2015 at 13:13, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > 0.0.0.0, when it's connected and using DHCP but no DHCP server is > found it returns an APIPA [1] address. I think on Linux that's usually called an IPv4LL address, and it's set by the dhcp client if configured to do that.

2 1

Re: iphlpapi: Add a private network IP to interfaces without an IP address
by Bruno Jesus 15 Jan '15

15 Jan '15

On Thu, Jan 15, 2015 at 10:05 AM, Michael Stefaniuc <mstefani(a)redhat.com> wrote: > Hello Bruno, Hi =) > I know that Windows assigns by default APIPA to IPv4 enabled interfaces > that are up. But what does it do if you disable that and the up > interface has no IP address? Will it still enumerate the interface? I already dropped this patch in exchange for [1]. When the interface is disabled it is not displayed; When it is enabled but not physically connected it displays 0.0.0.0; When it is enabled and physically connected and configured for DHCP and DHCP server is not found it uses APIPA. [1] http://source.winehq.org/patches/data/108636 Best wishes, Bruno

1 0

Re: ntdll: Fix calculation of process and thread affinity masks on systems with a large number of processors.
by Jonas Maebe 15 Jan '15

15 Jan '15

On 15 Jan 2015, at 12:44, Hans Leidekker wrote: > + const DWORD shift = min(NtCurrentTeb()->Peb- > >NumberOfProcessors, sizeof(DWORD_PTR) * 8); > + const DWORD_PTR mask = (1 << shift) - 1; Note that this will result in a mask of 0 on i386 if NumberOfProcessors >= 32 (and on x86-64 if NumberProcessors >= 64). (1 << 32) == 1 on Intel if calculated as a 32 bit operation, and similarly (1 << 64) == 1 on 64 bit. Jonas

1 0

Re: iphlpapi: Add a private network IP to interfaces without an IP address
by Bruno Jesus 15 Jan '15

15 Jan '15

On Thu, Jan 15, 2015 at 12:25 AM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Explanation in a comment inside the patch. > > To test this in Linux for example I have eth0 and wlan0, I'm connected > by wifi so eth0 does not have an IP and currently wine returns an > empty IP making Youku Desktop unhappy. More at > https://bugs.winehq.org/show_bug.cgi?id=32205#c13. > > Fixes bug https://bugs.winehq.org/show_bug.cgi?id=32205 > > Bibliography: > http://www.webopedia.com/TERM/A/APIPA.html > http://packetlife.net/blog/2008/sep/24/169-254-0-0-addresses-explained/ > http://tools.ietf.org/html/rfc3927 (I didn't read this completely) Please ignore this patch. I found a simpler way.

1 0

Re: atl: Don't conflict GWLP_USERDATA with user applications.
by Marvin 15 Jan '15

15 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11160 Your paranoid android. === build (build) === Patch failed to apply

1 0

Re: [resend 1/8] reg: Add system error printing function
by Stefan Dösinger 15 Jan '15

15 Jan '15

1 0

Re: [PATCH 2/2] dpvoice: Turn GetCompressionTypes into a semi-stub.
by Marvin 15 Jan '15

15 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11157 Your paranoid android. === w2000pro (32 bit voice) === voice.c:415: Test failed: server: expected ret=8015001e got ret=80004003 === wxppro (32 bit voice) === voice.c:415: Test failed: server: expected ret=8015001e got ret=80004003

1 0

Re: [PATCH 1/2] dpvoice/tests: Add GetCompressionTypes tests.
by Marvin 15 Jan '15

15 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11156 Your paranoid android. === w2000pro (32 bit voice) === voice.c:421: Test failed: server: expected ret=8015001e got ret=80004003 === wxppro (32 bit voice) === voice.c:421: Test failed: server: expected ret=8015001e got ret=80004003

1 0

Re: vbscript: Support 'End If' for single line If statements
by Marvin 15 Jan '15

15 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11152 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: dplayx: Cache GUID values so they persist after enumeration
by Marvin 15 Jan '15

15 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11147 Your paranoid android. === w8 (32 bit dplayx) === The test timed out

1 0

Mac Driver's functionality on Snow Leopard/Lion
by António Sarmento 14 Jan '15

14 Jan '15

Hello everyone, I had a question about the functionality of the Mac Driver when I found out that winemac.drv.so wasn’t working on my machine with Snow Leopard with a Wine wrapper; this was partially discussed in another e-mail sent directly to Ken Thomases (I apologize for this, I should’ve found the use of this mailing list sooner), where I mentioned that the addition of kCGDisplayShowDuplicateLowResolutionModes was keeping Wine from creating windows on OS X 10.6 (building works, Wine just stops at loading winemac.drv.so), as specified in this log: err:module:load_builtin_dll failed to load .so lib for builtin L"winemac.drv": dlopen(/path/to/app/Contents/Frameworks/wswine.bundle/bin/../lib/wine/winemac.drv.so, 258): Symbol not found: _kCGDisplayShowDuplicateLowResolutionModes Referenced from: /path/to/app/Contents/Frameworks/wswine Application tried to create a window, but no driver could be loaded. Unknown error (127). wine: Unhandled exception 0x0eedfade in thread 9 at address 0x0000:0x7b82cda2 (thread 0009), starting debugger... Application tried to create a window, but no driver could be loaded. Unknown error (127). err:seh:setup_exception_record stack overflow 2016 bytes in thread 0009 eip 7bc3772c esp 00230b50 stack 0x230000-0x231000-0x330000 This, however, was a fault of my own since, as suggested by Ken, I should've included "-mmacosx-version-min=10.6" to the compiler flags if I wanted Snow Leopard to be included in the range of supported OS; The symbols that were causing trouble for me «might not be available at run time» now «resolve to a NULL address», so the driver is able to run (my app using winemac now crashes for another reason of which I shall make a proper research later). I doubt this particular log actually helps since it just further shows the problem trying to run winemac when it was not compiled for that OS. I shall ask more questions about the Mac Driver in the future, if there’s no problem with you. Thank you for your time! António

1 0

Re: dplayx/tests: Add DirectPlayEnumerate[A|W] tests
by Alexandre Julliard 14 Jan '15

14 Jan '15

Bruno Jesus <00cpxxx(a)gmail.com> writes: > Required for bug https://bugs.winehq.org/show_bug.cgi?id=37185 > > Manually tested in NT4 and 98. > > Windows 8 fails and I believe it's in a dialog box asking to install > direct play, the same issue already found by Alistair Leslie-Hughes > and that he is trying to fix. As soon as he fixes it in dpnet we will > be able to copy over dplayx too. It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M dplayx.dll -p dplayx_test.exe.so dplayx && touch dplayx.ok dplayx.c:826: Test succeeded inside todo block: Expected equal GUID values dplayx.c:858: Test succeeded inside todo block: Expected equal GUID values dplayx.c:6668: Tests skipped: Run in interactive mode to run dplayx tests. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: cmd: implemented && and || functionality
by Alexandre Julliard 14 Jan '15

14 Jan '15

Михаил Быстрянцев <ho-rr-or(a)mail.ru> writes: > Implemented expected behavior of && and || delimeters, https://bugs.winehq.org/show_bug.cgi?id=32679 It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M cmd.exe -p cmd.exe_test.exe.so batch && touch batch.ok batch.c:312: Test succeeded inside todo block: unexpected char 0x0 position -1 in line 398 (got 'foo3 not created', wanted 'foo3 not created') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 400 (got '--- on failure conditional or', wanted 'foo4') batch.c:304: Test failed: excess characters on line 134 (got '1 ', wanted '1') batch.c:304: Test failed: excess characters on line 137 (got '1 ', wanted '1') batch.c:304: Test failed: excess characters on line 139 (got '1 ', wanted '1') batch.c:304: Test failed: excess characters on line 141 (got '1 ', wanted '1') batch.c:304: Test failed: excess characters on line 142 (got '2 ', wanted '2') batch.c:304: Test failed: excess characters on line 144 (got '1 ', wanted '1') batch.c:304: Test failed: excess characters on line 145 (got '2 ', wanted '2') batch.c:304: Test failed: excess characters on line 148 (got '1 ', wanted '1') make[1]: *** [batch.ok] Error 10 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [resend 1/8] reg: Add system error printing function
by Jonathan Vollebregt 14 Jan '15

14 Jan '15

This patchset has fallen off the list twice now, though Stefan looked over and OKd it both times. I'd appreciate it if you guys could take a look so I don't have to resend them again next month - thanks!

1 0

Re: [2/4] wbemdisp: Implement ISWbemObjectSet::get__NewEnum.
by Nikolay Sivov 14 Jan '15

14 Jan '15

On 01/14/2015 05:36 PM, Hans Leidekker wrote: > --- > dlls/wbemdisp/locator.c | 156 +++++++++++++++++++++++++++++++++++++++-- > dlls/wbemdisp/tests/wbemdisp.c | 69 ++++++++++++++++++ > 2 files changed, 221 insertions(+), 4 deletions(-) > > +static HRESULT EnumVARIANT_create( ISWbemObjectSet *objectset, IEnumVARIANT **obj ) > +{ > + struct enumvar *enumvar; > + > + if (!(enumvar = heap_alloc( sizeof(*enumvar) ))) return E_OUTOFMEMORY; > + enumvar->IEnumVARIANT_iface.lpVtbl = &enumvar_vtbl; > + enumvar->refs = 1; > + enumvar->objectset = objectset; > + ISWbemObjectSet_AddRef( enumvar->objectset ); That means that all IEnumVARIANT instances share same ISWbemObjectSet, so they all depend on its current state and Next/Skip on one IEnumVARIANT affects every instance. I don't think that's how IEnumVARIANT is supposed to behave.

1 0

feedback on my valgrind related patches
by Marc Bessières 14 Jan '15

14 Jan '15

Hello, I know you are very busy, so sorry to disturb you. One month ago I submitted 2 valgrind related patches: http://source.winehq.org/patches/data/108226 and http://source.winehq.org/patches/data/108223 I also attach them to this mail. They are still in NEW, and I think after one month they go out of the queue. According to the legend it means they've not been looked at yet. Do you know what I can do to have some feedback for them? I tried to create commit messages as complete as possible to explain each change. I didn't add any regression test, because the valgrind errors were triggered by the existing tests. I presume that was not good enough though, but I'm willing to improve if I'm given some guidance. Cheers, Marc

1 0

Text run in DirectWrite
by Julian Rüger 14 Jan '15

14 Jan '15

Hi List, I'm having some trouble translating "text run" (in the current release notes "Better text run support in DirectWrite.") I would appreciate an explanation and/or suggestions for a German translation. Is it some kind of moving text? An iteration of some sorts over a given text or string(s)? Thanks and a happy new year to everyone! Best, Julian

2 2

Re: dplayx/tests: Add DirectPlayEnumerate[A|W] tests
by Marvin 14 Jan '15

14 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11134 Your paranoid android. === w8 (32 bit dplayx) === Failure running script in VM: timed out waiting for the child process

1 0

Re: [PATCH 2/5] winecfg: Bring back 32-bit Windows versions for 64-bit WINEPREFIXES
by Nikolay Sivov 13 Jan '15

13 Jan '15

On 10.01.2015 21:27, Ken Sharp wrote: > winecfg: Bring back 32-bit Windows versions for 64-bit WINEPREFIXES > > Having a 64-bit WINEPREFIX shouldn't exclude you from selecting 32-bit > versions of Windows. Yes, it should. There's no such thing as 64 bit win2k or winme.

6 7

Re: [PATCH] jscript: Don't allow function execution if script engine is not in started state.
by Alexandre Julliard 13 Jan '15

13 Jan '15

Jacek Caban <jacek(a)codeweavers.com> writes: > try2: Fixed tests on win2k > > --- > dlls/jscript/function.c | 5 +++ > dlls/jscript/jscript.c | 9 +----- > dlls/jscript/jscript.h | 7 ++++ > dlls/jscript/tests/run.c | 84 > ++++++++++++++++++++++++++++++++++++++++++------ > 4 files changed, 87 insertions(+), 18 deletions(-) It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M wscript.exe -p wscript.exe_test.exe.so run && touch run.ok run.c:366: Test failed: expected reportSuccess make: *** [run.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: jscript: Don't allow function execution if script engine is not in started state.
by Marvin 12 Jan '15

12 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11115 Your paranoid android. === w2000pro (32 bit run) === run.c:2072: Test failed: InvokeEx failed: 800a1393

1 0

[PATCH 5/5] winecfg: Distinguish between Windows XP and Windows XP x64
by Ken Sharp 12 Jan '15

12 Jan '15

winecfg: Distinguish between Windows XP and Windows XP x64 A 64-bit WINEPREFIX user may want to select XP or XP x64. The two have different kernel versions (NT 5.1 versus NT 5.2). I think this may confuse users though so I send it here (rather than wine-patches) just for the hell of it. Besides, I'm not aware of a use case.

3 7

Re: [PATCH 1/5] winecfg: Group together Windows server versions
by Nikolay Sivov 11 Jan '15

11 Jan '15

On 10.01.2015 21:24, Ken Sharp wrote: > winecfg: Group together Windows server versions > > With each new release of Windows comes a desktop and a server > version. This should make the list a bit more tidy. > I don't think such grouping makes much sense, a list is currently sorted by NT version, why mess it up?

3 4

About Bug 36092:dotnet 4.5 is supported on Wine?
by Akira Nakagawa 11 Jan '15

11 Jan '15

I think next problem is whether wine is usable for dotnet4.5 program to install Microsoft Office 2013, but in default Wine registory, what number of version dotnet is (looked by Windows apps.)to be installed? How can I change it?

1 0

Re: Add support for Windows Server 2012/R2 (plus clean-up) (try 2)
by Ken Sharp 09 Jan '15

09 Jan '15

Please disregard. I'll send these separately. There's an error and another change anyway. There may be a situation where you want to choose between XP and XP x64 in the same WINEPREFIX for different apps, though I'm ignoring that for now as I think it will be very rare. On 07/01/15 20:10, Ken Sharp wrote: > Please disregard previous patch for W2K8R2. > > Add support for Windows 2012/R2 (plus clean-up) > > 1. Add support for Windows 2012 and Windows 2012 R2. > Self explanatory. > > 2. #ifdef out Windows 2008 R2 for 32-bit. > Not available for 32-bit. > > 3. Reorder server versions in winecfg. > Move the server versions out of the way. It's unlikely a user will need > anything other than a workstation version, and number of options are > starting to build up! > > 4. Remove superfluous #else. > > I realise that these will probably need separate patches but it makes > sense giving all the changes are in the same area of the code. Just > shout and I'll send them separately, and try with the least mess possible. > > I could also add NT4 and 2000 server but I'm not sure that anything > actually checks for workstation/server. >

1 0

Re: ws2_32/tests: Show that send/recv functions set last error to zero on success
by Marvin 09 Jan '15

09 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11067 Your paranoid android. === wxppro (32 bit sock) === sock.c:610: Test failed: oob_server (674): unexpectedly at the OOB mark: 0

1 0

Re: [PATCH 2/5] winemac: Implement wglCreateContextAttribsARB. (v2)
by Ken Thomases 08 Jan '15

08 Jan '15

On Jan 8, 2015, at 8:07 AM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > It also allows to create core profile contexts. > > v2 should fix all the bits mentioned in the patch reviews, except for > the error conversion from CGL after CGLChoosePixelFormat and > CGLCreateContext. > --- > dlls/winemac.drv/opengl.c | 544 +++++++++++++++++++++++++++++++--------------- > 1 file changed, 366 insertions(+), 178 deletions(-) Looks good to me. Thanks! -Ken

1 0

Re: PATCH: imagehlp: handle security directories after the PE file
by Bruno Jesus 08 Jan '15

08 Jan '15

On Fri, Dec 12, 2014 at 6:07 PM, Marcus Meissner <meissner(a)suse.de> wrote: > Subject: [PATCH] imagehlp: handle security directories after the PE Image > > J-Link.exe (some kind of usb programmer?) has the certificate right > after the last PE section. Implement that case. How do you test this? By simply opening the application? There are dozens of different versions [1] of the application, it's used together with a J-Tag device to read/write flash memory from some processors. https://www.segger.com/j-link-older-versions.html Best Regards, Bruno

2 2

Re: fonts: Added glyphs handptleft, handptright and handptdwn for wingdings, fixed handptup.
by Qian Hong 08 Jan '15

08 Jan '15

On Wed, Dec 31, 2014 at 5:28 PM, Qian Hong <qhong(a)codeweavers.com> wrote: > However, I would like to bring a related discussion: > - Could we copy glyphs from GPL font like WenQuanYi Micro Hei and reuse in > Wine fonts? > - Could we copy glyphs from Apache license font like Adobe Source Han Sans > and reuse in Wine fonts? Anyone has comment on the above questions please? And one more: Could we copy glyphs from symbola font and reuse in Wine fonts? Symbola font is "offered free for any use", according to its official page: http://users.teilar.gr/~g1951d/ It also pass fedora's license review: https://bugzilla.redhat.com/show_bug.cgi?id=532819 FWIW, Yida Wang is working on an experiment program, using smart computer vision algorithm like PCANet ( http://arxiv.org/abs/1404.3606 ), to discover similar wingdings glyphs from symbola fonts automatically. So far the result is not bad, see the two attachments, windings.png is wingdings glyphs, and symbola.png is similar glyphs from symbola which map to wingdings glyphs. The result is not complete, it is just an experiment. Once the program is trained and optimized we could use it to discover more glyphs for wingdings/wingdings2/wingdings3/webdings/mtextra and even more, which are useful for not only Wine, but also Libreoffice, WPS and other Linux application. That might also bring a new question: would we want to redistribute Wingdings and similar fonts outsite of Wine, so that they could be installed to system directories like /usr/share/fonts/truetype and reused by application like WPS and Libreoffice? Any comment is still great appreciated! -- Regards, Qian Hong - http://www.codeweavers.com

2 2

Re: [PATCH 4/5] wined3d: Prefer the core glActiveTexture function. (v2)
by Henri Verbeet 08 Jan '15

08 Jan '15

On 8 January 2015 at 15:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > + #define MAP_GL_FUNCTION(core_func, ext_func) \ > + { \ > + if (!gl_info->gl_ops.ext.p_##core_func) \ > + gl_info->gl_ops.ext.p_##core_func = gl_info->gl_ops.ext.p_##ext_func; \ > + } > + > + MAP_GL_FUNCTION(glActiveTexture, glActiveTextureARB); > +#undef MAP_GL_FUNCTION That probably works here in practice, but in general you want to avoid defining macros like that. See e.g. https://gcc.gnu.org/onlinedocs/cpp/Swallowing-the-Semicolon.html for the explanation.

1 0

Re: [PATCH 3/5] wined3d: Inline GL_EXT_FUNCS_GEN in load_gl_funcs.
by Henri Verbeet 08 Jan '15

08 Jan '15

On 8 January 2015 at 15:07, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > #include "wined3d_private.h" > +#include "wine/wglext.h" > I'd probably either just keep that in wined3d_gl.h, perhaps moving it below the wine/wgl.h include. > - GL_EXT_FUNCS_GEN; > + /* GL_APPLE_fence */ \ > + USE_GL_FUNC(glDeleteFencesAPPLE) \ You shouldn't need the line-continuations.

1 0

Re: [PATCH 1/2] d3d9/tests: fix volume_dxt5_test getPixelColor check.
by Henri Verbeet 08 Jan '15

08 Jan '15

On 7 January 2015 at 14:21, Axel Davy <axel.davy(a)ens.fr> wrote: > getPixelColor should be called before Present, > because the device swapchain was created with discard mode. > Could you please fix the equivalent d3d8 tests as well?

1 0

About Wine Security
by Pierre Schweitzer 08 Jan '15

08 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Dear all, I'm coming to you after a short discussion with Alexandre on this topic. Wine gets more and more used, in various ways: either directly by users, or because it gets shipped in various form. It can packaged in a distribution, forked to suit a project needs (thinking about pipelight), or even shipped along with software to save native portage costs. Not to say that it's core of the ReactOS operating system itself. But as any other software, Wine can present security vulnerabilities. MITRE exposes some of the code defects pattern (known as CWE) that can lead to potential exploitation and thus to security vulnerabilities [1]. When such defect is found and looks potentially exploitable (either because a crash was reported, or because it directly deals with callers data), a vulnerability ID (CVE) can be assigned by MITRE to reference the potential security vulnerability and make it known to people using it. Some of them (buffer overflow, overrun, double-free, use-after-free, and so on) are sometimes found and fixed in Wine without further consideration regarding what it would imply for real Wine (mis-)usage. Even if no Proof of Concept is available at the time when the commit is made, it doesn't mean it cannot be exploited later on. With such exploits, it generally means that the attacker can target a Linux OS through a crafted PE binary. What I'm proposing here is that I start requesting CVE-ID for these findings when I find them in the commit logs of Wine and that they look exploitable. My hope is that it would allow distributions to repackage Wine taking care of these issues, but also to make people shipping Wine aware that the Wine they are shipping is likely vulnerable. This proposal it though limited in space & time: I wouldn't only do it starting in 2015 (I don't believe going backwards would make that much sense) and for 1.7 branch which is, I believe, the most used. I'm looking for your feedback on my proposal and how you believe such vulnerabilities in Wine can affect the host Linux (or Mac). This wouldn't involve more work on your side (excepted if I ask for more details to make sure I'm right in my analysis of the issue). With my best regards, [1]: https://cwe.mitre.org/ - -- Pierre Schweitzer <pierre at reactos.org> System & Network Administrator Senior Kernel Developer ReactOS Deutschland e.V. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJUrVTCAAoJEHVFVWw9WFsLPDgQAILhixxtba3y2qadCl+2dBWg 1v2qjsUouAJe7vq28tx63MNK0Tm6ykHB66SJuWWUTMwYAHIz+Uzr2PJMHCq0aZs+ dnGo4sTycEkuMNVC/i9zijJtCd7/r5v+VJBQNji1lVhwY+ZLsA8mlp+UKb9fjos6 wwMk+5lCsiqvPubKvVZ8qfXKD2xEBkjWu15JmivR6ZhaNm5vDXmNxtqVT590JowW WWmcn6GiWMQQgAj6CLzG9d8qaHiJiuNmHi0BtUPZ8e+9hfcl76DBMiy1L8M3PM0f 1YRWF1NMOTQOr6nqxuviPL5eO7DKUmsiNVK1KGnNXMbjf/8EwL03VobAFaPu0X55 6v3jcNdBq9NCcRpkzUVksSMOSlzj4S8lvLEFYY8mWYW/o3TfmdTbLqeO7UIVJJiP lx1Pth7WA03wqzvhm5+/sIavkDDn3Z6/TY9k0BVHzq3VahUx6TP59mYPjI9jUvwA /0HoCCaD6AcGnDf8fsTNkLgqtqD6s3iOMra0mpH7nUQoTUds82ehZXRJ4viWsHxj c0mfAy/3ct8uMZAbVwjnahrk/RrF6DzI3eKh/LI5l5rQ9COgPwE2Ij2IWnPRK2zv XJbG161RRQwZSSU8TeBr2I/OxxQ+VE2Z0E4xSZY4tjYhdk/i9Y32J9w68qquISlF 4wtw5d9I9DFwvxq/AnBV =auVK -----END PGP SIGNATURE-----

5 7

Re: cmd: implemented && and || functionality
by Marvin 07 Jan '15

07 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11049 Your paranoid android. === wxppro (32 bit) === batch.c:312: Test failed: unexpected char 0x47 position 0 in line 700 (got 'Got unexpected result: "C:\Documents"', wanted 'Plain directory enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 701 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 702 (got 'Got unexpected result: "C:\Documents"', wanted 'File enumeration from provided root') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 703 (got 'Got unexpected result: "C:\Documents"', wanted 'Mixed enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 704 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted 'Mixed enumeration from provided root') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 705 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted 'With duplicates enumeration') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 706 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted 'Strip missing wildcards, keep unwildcarded names') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 707 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted 'for /R passed') batch.c:312: Test failed: unexpected char 0x50 position 0 in line 708 (got 'Plain directory enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 709 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 710 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 711 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 712 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 713 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 714 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 715 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 716 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 717 (got 'File enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 718 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 719 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 720 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 721 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 722 (got 'File enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 723 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 724 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 725 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 726 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 727 (got 'Mixed enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 728 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 729 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 730 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 731 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 732 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 733 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 734 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 735 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 736 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 737 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 738 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 739 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x4d position 0 in line 740 (got 'Mixed enumeration from provided root', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 741 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 742 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 743 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 744 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 745 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 746 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 747 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 748 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 749 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 750 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 751 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 752 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\."', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x57 position 0 in line 753 (got 'With duplicates enumeration', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 754 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 755 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 756 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 757 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 758 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 759 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 760 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 761 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 762 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 763 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 764 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 765 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 766 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 767 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 768 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 769 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 770 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 771 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 772 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 773 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 774 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 775 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 776 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 777 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\fred"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x53 position 0 in line 778 (got 'Strip missing wildcards, keep unwildcarded names', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 779 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 780 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 781 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 782 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 783 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x47 position 0 in line 784 (got 'Got unexpected result: "C:\Documents"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 785 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 786 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 787 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\baz\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 788 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\bazbaz"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 789 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\foo\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 790 (got 'Found missing result: "C:\Documents and Settings\winetest\My Documents\foobar\jim"', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x66 position 0 in line 791 (got 'for /R passed', wanted '--- Complex wildcards unix and windows slash') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1375 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1376 (got 'value2', wanted '2set1endvalue1') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1377 (got 'C:\Documents and Settings\winetest\My Documents\foobar\foodir2', wanted '@drive@@path@foobar\foodir3') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1378 (got 'value1', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1379 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1380 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1381 (got '--- Extra endlocal in called batch', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1382 (got '--- Extra endlocal in called batch', wanted '@drive@@path@foobar') batch.c:312: Test failed: unexpected char 0x46 position 0 in line 1384 (got 'Finished:', wanted 'value2') batch.c:312: Test failed: unexpected char 0x76 position 0 in line 1387 (got 'value1', wanted 'value2') batch.c:312: Test failed: unexpected char 0x43 position 0 in line 1388 (got 'C:\Documents and Settings\winetest\My Documents\foobar', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1389 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'Finished:') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1390 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1391 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar\foodir2') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1392 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted 'value1') batch.c:312: Test failed: unexpected char 0x2d position 0 in line 1393 (got '--- endlocal in called function rather than batch pgm is ineffective', wanted '@drive@@path@foobar') === wvistau64 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 329 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'') === w8 (32 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 329 (got ''--a--------'', wanted ''--a------'@or_broken@'%~ai'') === wvistau64 (64 bit) === batch.c:312: Test failed: unexpected char 0x27 position 0 in line 329 (got ''--a--c---'', wanted ''--a------'@or_broken@'%~ai'')

1 0

Re: winex11.drv: Ignore ConfigureNotify events on hidden windows
by Alexandre Julliard 07 Jan '15

07 Jan '15

Piotr Caban <piotr(a)codeweavers.com> writes: > diff --git a/dlls/winex11.drv/event.c b/dlls/winex11.drv/event.c > index ea24471..1b8e568 100644 > --- a/dlls/winex11.drv/event.c > +++ b/dlls/winex11.drv/event.c > @@ -1075,6 +1075,10 @@ void X11DRV_ConfigureNotify( HWND hwnd, XEvent *xev ) > event->serial, data->configure_serial ); > goto done; > } > +#ifdef HAVE_LIBXSHAPE > + /* ignore notifications on hidden window */ > + if (IsRectEmpty( &data->window_rect )) goto done; > +#endif It shouldn't make a difference whether we have XShape or not. Also note that there's already a check later on, which is probably where you'd want to change something. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] msvcp120: Implemented xtime functions. (try 2)
by Alexandre Julliard 07 Jan '15

07 Jan '15

Yifu Wang <YWang(a)esri.com> writes: > @@ -33,6 +33,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(msvcp); > #define SECS_1601_TO_1970 ((369 * 365 + 89) * (ULONGLONG)SECSPERDAY) > #define TICKSPERSEC 10000000 > #define TICKS_1601_TO_1970 (SECS_1601_TO_1970 * TICKSPERSEC) > +#define NANOSEC_PER_MICROSEC 1000000 > +#define MICROSEC_PER_SEC 1000 Something's not quite right here ;-) -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/5] wbemdisp: Add IDispatch support to the services object.
by Nikolay Sivov 07 Jan '15

07 Jan '15

On 07.01.2015 12:58, Hans Leidekker wrote: > --- > dlls/wbemdisp/locator.c | 145 +++++++++++++++++++++++++++++------------------- > 1 file changed, 89 insertions(+), 56 deletions(-) > > + > +static HRESULT get_typeinfo( enum type_id tid, ITypeInfo **ret ) > +{ > ... > + } > + *ret = wbemdisp_typeinfo[tid]; > + return S_OK; > +} get_typeinfo() doesn't AddRef() returned pointer. > @@ -102,8 +155,10 @@ static HRESULT WINAPI services_GetTypeInfo( > LCID lcid, > ITypeInfo **info ) > { > - FIXME( "\n" ); > - return E_NOTIMPL; > + struct services *services = impl_from_ISWbemServices( iface ); > + TRACE( "%p, %u, %u, %p\n", services, index, lcid, info ); > + > + return get_typeinfo( ISWbemServices_tid, info ); > } That means you should AddRef() it here. > static HRESULT WINAPI services_GetIDsOfNames( > @@ -114,8 +169,21 @@ static HRESULT WINAPI services_GetIDsOfNames( > LCID lcid, > DISPID *dispid ) > { > - FIXME( "\n" ); > - return E_NOTIMPL; > + struct services *services = impl_from_ISWbemServices( iface ); > + ITypeInfo *typeinfo; > + HRESULT hr; > + > + TRACE( "%p, %s, %p, %u, %u, %p\n", services, debugstr_guid(riid), names, count, lcid, dispid ); > + > + if (!names || !count || !dispid) return E_INVALIDARG; > + > + hr = get_typeinfo( ISWbemServices_tid, &typeinfo ); > + if (SUCCEEDED(hr)) > + { > + hr = ITypeInfo_GetIDsOfNames( typeinfo, names, count, dispid ); > + ITypeInfo_Release( typeinfo ); > + } > + return hr; And remove Release() here. Or am I missing something?

1 0

Review request: New header for programs writing to the console
by Hugh McMaster 07 Jan '15

07 Jan '15

Wine has at least 11 programs that write output to the console. Each program, however, uses a different method to achieve the same purpose. These programs can be modified to use a unified console output method with only minor changes to each program's codebase. In anticipation of taking on this task, I've created a new header (output.h, attached) to contain the unified method. Before I submit the header to wine-patches, I'm asking for review by other developers. Any and all feedback/comments appreciated. -- Hugh

1 0

Re: [PATCH 4/4] dsound: support 5.1 sound
by Chris Robinson 07 Jan '15

07 Jan '15

On 01/06/2015 11:27 AM, Mark Harmstone wrote: > + case DSSPEAKER_5POINT1_BACK: > + device->speaker_angles[0] = M_PI/180.0f * -135.0f; > + device->speaker_angles[1] = M_PI/180.0f * -45.0f; > + device->speaker_angles[2] = M_PI/180.0f * 0.0f; > + device->speaker_angles[3] = M_PI/180.0f * 45.0f; > + device->speaker_angles[4] = M_PI/180.0f * 135.0f; > + device->speaker_angles[5] = 9999.0f; > + device->speaker_num[0] = 4; /* Rear left */ > + device->speaker_num[1] = 0; /* Front left */ > + device->speaker_num[2] = 2; /* Front centre */ > + device->speaker_num[3] = 1; /* Front right */ > + device->speaker_num[4] = 5; /* Rear right */ > + device->speaker_num[5] = 3; /* LFE */ > + device->num_speakers = 6; > + device->lfe_channel = 3; > + break; This doesn't look right. According to <http://www.dolby.com/us/en/guide/surround-sound-speaker-setup/5-1-setup.html>, 5.1 should have the front-right/right speakers between +/-30 degrees max and +/-22 degrees min, and the back (surround) speakers between +/-110 degrees max, +/-90 degrees min. > + case DSSPEAKER_5POINT1_SURROUND: > + device->speaker_angles[0] = M_PI/180.0f * -90.0f; > + device->speaker_angles[1] = M_PI/180.0f * -30.0f; > + device->speaker_angles[2] = M_PI/180.0f * 0.0f; > + device->speaker_angles[3] = M_PI/180.0f * 30.0f; > + device->speaker_angles[4] = M_PI/180.0f * 90.0f; > + device->speaker_angles[5] = 9999.0f; > + device->speaker_num[0] = 4; /* Rear left */ > + device->speaker_num[1] = 0; /* Front left */ > + device->speaker_num[2] = 2; /* Front centre */ > + device->speaker_num[3] = 1; /* Front right */ > + device->speaker_num[4] = 5; /* Rear right */ > + device->speaker_num[5] = 3; /* LFE */ > + device->num_speakers = 6; > + device->lfe_channel = 3; > + break; This looks like it's based on OpenAL Soft (which is fine), which originally had 5.1side using 90 degrees. However I'm not sure it's really necessary for the two modes to use different angles. The current Git version of OpenAL Soft was changed so both 5.1 modes use 110 degree angles for the rear/side speakers, and the only difference is which output speakers they're mapped to. It's not exactly wrong to put 5POINT1_BACK at 110 degrees and 5POINT1_SURROUND at 90 (they're both within spec), but I think the intended difference is only for physical speaker mapping rather than positioning.

1 0

Re: [resend 04/10] reg: Add sane_path function to do preliniary key validation
by Stefan Dösinger 06 Jan '15

06 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I was on holiday when you sent these patches, sorry for the late review. Am 2014-12-13 um 18:06 schrieb Jonathan Vollebregt: > +static LSTATUS sane_path(const WCHAR *key) > +{ > + if (key[0] == '\\' && key[1] == '\\' && key[2] != '\\') > + return ERROR_NO_REMOTE; > + > + return ERROR_SUCCESS; > +} This adds (or rather extends) a possible out of bound array access. Otherwise these patches look reasonable to me and worth review by others. A general note on the error handling code for other reviewers: Native reg.exe has very limited error reporting. With a few exceptions it just prints a generic message like "ERROR: INVALID SYNTAX" or something similar. I guess there are also some possible improvements on the output code as Bruno mentioned, but I think patch 3 is OK until (if ever) we have unified console output handling for all command line programs. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUrEB5AAoJEN0/YqbEcdMw8bUP/1dhlLDCE2kOZhLkhVXg0RVa BckpiGygdwfIIvGoyCaj6ObtgvrnYr7OMzZsruytK/X5UUvl+KsObctp8g1zjNY1 dFPQeBsra9TRtbtKTMX2pIdZS1wSNwWaOYrdZcKn5IkQfDWN0rwdKNujT8pAf+Ik 8dpFJUYtMjd6N0avPqphglRbW8rFhLhqYOlYuPjvzuEtBM11vGfy9mAp+sPA1ekX 8sRqGtn65w1JsT3cg054DvtY2xHNmRE5eTnrsbL7gqD/oljdPyU470eY6Vwofo3Z frAF8OKemJsU6MrxZLXe1US5GzyvvCRRpIBNcfrO6qzTTdio0/LBe77VDq9J0jAa GUWYFUtxIXw7Ccw1tNrxYp1JPo9bZnk5yONMMEAPfw2ij2iQCTvpv0lY9Kk58mqF kKzWrqzhVdi5aFGOGhnmrk7NZ4l8paA7Gk2S1c8IukWubww0hlOclrhrWDYpuEfJ ZKyGG8jFUvSjW3iTEES7NHMnCd+lWgaf+3TODrSGD5J/wdP6GQT9S78/HZ+SbM8m fxnvnDLylq9arQm3bh0wQy9ZoMCTMx4YtbTouQBpLZBDKAgZNK1BUC5sxP1NlO9P eP5JAZFHTzpGXCADkL+4OI4+ImG9mAMWGYytHGEQ3kwvAucNwTWP00twzMbSjHEX +8k+frQxyupijPZrL4vo =PJFk -----END PGP SIGNATURE-----

1 1

Re: [PATCH 2/5] winemac: Implement wglCreateContextAttribsARB.
by cdavis5x＠gmail.com 06 Jan '15

06 Jan '15

> On Jan 5, 2015, at 9:17 AM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > > As an aside, reported WGL extensions don't depend on the specific > GL context (e.g. WGL_ARB_pbuffer is reported as supported even on core > profile contexts). Do real Windows drivers behave like this? > @@ -1272,6 +1273,175 @@ static BOOL init_gl_info(void) […] > +/********************************************************************** > + * create_context > + */ > +static BOOL create_context(struct wgl_context *context, CGLContextObj share, BOOL core) > +{ […] > + attribs[n++] = kCGLPFAAuxBuffers; > + attribs[n++] = pf->aux_buffers; You must reject any pixel format with >0 auxiliary buffers when creating a core profile context. CGL will specifically fail the ChoosePixelFormat (with error 10000, kCGLBadAttribute) if you specify both a GL version >= 3.2 and a non-zero number of auxiliary buffers. > + > + attribs[n++] = kCGLPFAColorSize; > + attribs[n++] = color_modes[pf->color_mode].color_bits; > + attribs[n++] = kCGLPFAAlphaSize; > + attribs[n++] = color_modes[pf->color_mode].alpha_bits; > + if (color_modes[pf->color_mode].is_float) > + attribs[n++] = kCGLPFAColorFloat; > + > + attribs[n++] = kCGLPFADepthSize; > + attribs[n++] = pf->depth_bits; > + > + attribs[n++] = kCGLPFAStencilSize; > + attribs[n++] = pf->stencil_bits; > + > + if (pf->stereo) > + attribs[n++] = kCGLPFAStereo; > + > + if (pf->accum_mode) > + { > + attribs[n++] = kCGLPFAAccumSize; > + attribs[n++] = color_modes[pf->accum_mode - 1].color_bits; > + } You must also reject any pixel format with an accumulation buffer when creating a core profile context, for the same reason. > + > + /* Explicitly requesting pbuffers in CGLChoosePixelFormat fails with core contexts. */ > + if (pf->pbuffer && !core) > + attribs[n++] = kCGLPFAPBuffer; > + > + if (pf->sample_buffers && pf->samples) > + { > + attribs[n++] = kCGLPFASampleBuffers; > + attribs[n++] = pf->sample_buffers; > + attribs[n++] = kCGLPFASamples; > + attribs[n++] = pf->samples; > + } > + > + if (pf->backing_store) > + attribs[n++] = kCGLPFABackingStore; > + > + if (core) > + { > + attribs[n++] = kCGLPFAOpenGLProfile; > + attribs[n++] = (int)kCGLOGLPVersion_3_2_Core; > + } There’s a constant for requesting a 4.x core context, too. (But it’s only defined in the 10.9 and 10.10 SDKs.) You might consider using it if the requested version is >= 4.0. That way, creation will fail if the system doesn’t support it. > + > + attribs[n] = 0; > + > + err = CGLChoosePixelFormat(attribs, &pix, &virtualScreens); > + if (err != kCGLNoError || !pix) > + { > + WARN("CGLChoosePixelFormat() failed with error %d %s\n", err, CGLErrorString(err)); > + SetLastError(ERROR_INVALID_OPERATION); This is somewhat nitpicking, but one thing you might consider is setting the last error based on what CGL returned. For example, if you get the error kCGLBadAlloc, you could set the last error to ERROR_NO_SYSTEM_RESOURCES. > + return FALSE; > + } > + > + err = CGLCreateContext(pix, share, &context->cglcontext); > + CGLReleasePixelFormat(pix); > + if (err != kCGLNoError || !context->cglcontext) > + { > + context->cglcontext = NULL; > + WARN("CGLCreateContext() failed with error %d %s\n", err, CGLErrorString(err)); > + SetLastError(ERROR_INVALID_OPERATION); Ditto. > @@ -2076,6 +2246,133 @@ cant_match: […] > +/*********************************************************************** > + * macdrv_wglCreateContextAttribsARB > + * > + * WGL_ARB_create_context: wglCreateContextAttribsARB > + */ > +static struct wgl_context *macdrv_wglCreateContextAttribsARB(HDC hdc, > + struct wgl_context *share_context, > + const int *attrib_list) > +{ […] > + if (major > 3 || (major == 3 && minor >= 2)) > + { > + if (!(flags & WGL_CONTEXT_FORWARD_COMPATIBLE_BIT_ARB)) > + { > + WARN("OS X only supports forward-compatible 3.2+ contexts\n"); > + SetLastError(ERROR_INVALID_VERSION_ARB); > + return NULL; > + } Just so you know, a side effect of this is that our GL 3.x tests get skipped here, because they don’t specify the FOWARD_COMPATIBLE bit. Also, you should consider rejecting the DEBUG flag, if it’s set: OS X never returns that flag. (Or do you want to hook glGetInteger(3G) to return the debug flag if it’s set?) > + if (profile != WGL_CONTEXT_CORE_PROFILE_BIT_ARB) > + { > + WARN("Compatibility profiles for GL version >= 3.2 not supported\n"); > + SetLastError(ERROR_INVALID_PROFILE_ARB); > + return NULL; > + } > + core = TRUE; > + } > + else if (major == 3) > + { > + WARN("OS X doesn't support 3.0 or 3.1 contexts\n"); > + SetLastError(ERROR_INVALID_VERSION_ARB); > + return NULL; > + } I think we can support requests for 3.1 contexts, if the FORWARD_COMPATIBLE bit is set; we just won’t advertise GL_ARB_compatibility. Chip

3 5

Re: loader: More generic pre_exec for Linux (try 2)
by André Hentschel 06 Jan '15

06 Jan '15

Am 29.12.2014 um 23:03 schrieb André Hentschel: > --- > loader/main.c | 26 ++++++++++++++++++-------- > 1 file changed, 18 insertions(+), 8 deletions(-) [After a small IRC discussion] My main goal is to also get the 2G/2G vmsplit warning on ARM, too. (and potential other platforms) There are still many ARM kernels out there with a 2G split. The problem is that Wine can't start on 2G/2G, it seems there are too much assumptions in the code for a 3G split. e.g. for shared user data. We can't allocate 0x7ffe0000-0x7fff0000 on 2G split, most likely something else is already there, idk

2 3

Re: dpnet: Implement IDirectPlay8Address GetComponentByIndex (try 4)
by Stefan Dösinger 06 Jan '15

06 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, You have style inconsistencies in the patch. I won't point them out individually and just focus on suggestions on the code itself. Overall: Is there a way to remove components? I don't see a method that supports that, and AddComponent with a NULL pointer returns an error, so I guess components can't be removed. Am 2015-01-06 um 08:59 schrieb Alistair Leslie-Hughes:> +static void add_component(IDirectPlay8AddressImpl *This, struct component *item) > +{ > + if(!This->comp_count) > + This->components = HeapAlloc( GetProcessHeap(), 0, sizeof(struct component *) * This->comp_count+1 ); > + else > + This->components = HeapReAlloc( GetProcessHeap(), 0, This->components, sizeof(struct component *) * This->comp_count+1 ); How many components are usually added? If it is just a small number (say, < 10) this is OK. Otherwise it would be more efficient to grow the array by a factor (e.g. duplicate the array size each time you grow it), so you make growing an O(log(n)) instead of O(n). > + int i; > + struct component *entry; > > - LIST_FOR_EACH_ENTRY_SAFE(entry, entry2, &This->components, struct component, entry) > + for(i=0; i < This->comp_count; i++) Mismatching data type. This->comp_count is a DWORD, i is an int. Please use DWORD consistently. (Using DWORD for the component is mandated by the parameters to GetComponentByIndex and return value of GetNumComponents) > + switch (entry->type) > + { > + case DPNA_DATATYPE_DWORD: > + memcpy(pvBuffer, &entry->data.value, sizeof(DWORD)); > + break; > + case DPNA_DATATYPE_GUID: > + memcpy(pvBuffer, &entry->data.guid, sizeof(GUID)); > + break; > + case DPNA_DATATYPE_STRING: > + memcpy(pvBuffer, &entry->data.string, entry->size); > + break; > + case DPNA_DATATYPE_STRING_ANSI: > + memcpy(pvBuffer, &entry->data.ansi, entry->size); > + break; > + case DPNA_DATATYPE_BINARY: > + memcpy(pvBuffer, &entry->data.binary, entry->size); > + break; > + } You can use assignments for DPNA_DATATYPE_DWORD and DPNA_DATATYPE_GUID. The same applies to the existing code in GetComponentByName. AddComponent already uses assignments. > --- a/dlls/dpnet/dpnet_private.h > +++ b/dlls/dpnet/dpnet_private.h > @@ -94,7 +94,8 @@ struct IDirectPlay8AddressImpl > GUID SP_guid; > BOOL init; > > - struct list components; > + struct component **components; > + DWORD comp_count; Do you need the extra indirection? If the number of components is small you can work without it I think. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUq/bOAAoJEN0/YqbEcdMwOnMP/RnnAWVfyTuK2ABnRqDLW9/1 DydTHhjeOpm1FDKJTy7ebzqU76HDL7YWJOqwSNYPhtr8e3omXt5nApptwVjOBst0 lpRxDju4sPGo9GYePy5w39TI/w78gPLEGLVHpIiV5GlMz+YRpgxKI05Q90jkGtfo whPpQ9ns1xiXz+d07iJnPn8GnEjWeTkIN2NnY6Nj+ARQ8rmUNSn3YR4ZGtZfuzrt nKUurOt04FUAqQzDNYNbdtpybYQq7SSVQr8vWpJAJOpedq7oNyCEdjC8Zl5Yitl5 bg6a4oTvl7PgGmYOSvNVzsh6L0dYv0HpjLZsfLUo97ULXRsCFgfX8yNogrCSq8o0 2KoZSWEhehn1RV+WCywMbxHxly5ZvkyEr9g9/h+8+7cpPrdg8TeoaMUjtjUxrqra fLDfLtGnMGs4DGiFmleRR3lBFmr8UMVkP4/YLEJ1HPKNdAAwXfQso6/ODmdvC78W 5sRfY/pSlLEn93szGfx+hunpUX30c2XkGmuBElLJQsQgVeoijmsNhUNOLUdhTx9k wPhslaQ+HCtR76KVghvQzN3iBHPuO+O0dfH4PWz5/7Grq5/pIhfbWcMCVJJM3d9u CNjKAOkw+NzPPsdLyJZsmMWWvv+BJ039l15xjMTmWxG2uH/QgaiBtvDyD2/u3KxJ MgsfOYAWEYondC/Jllaz =uIjr -----END PGP SIGNATURE-----

1 0

Re: windowscodecs: DibDecoder_CreateInstance() is unused so remove it.
by Vincent Povirk 06 Jan '15

06 Jan '15

The original intent was that this could be used by d3dx9 to implement reading of the DIB format, but I didn't have the knowledge of d3dx9 to test that this really does what is needed.

2 1

Re: [PATCH] xaudio2_7: add stub DLL
by Alexandre Julliard 06 Jan '15

06 Jan '15

Mark Harmstone <hellas(a)burntcomma.com> writes: > diff --git a/dlls/xaudio2_7/xaudio2_7.spec b/dlls/xaudio2_7/xaudio2_7.spec > new file mode 100644 > index 0000000..e69de29 Please list stubs for all the exported functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 3/5] opengl32: Fix extension checks on OpenGL core profile contexts.
by Henri Verbeet 06 Jan '15

06 Jan '15

On 5 January 2015 at 17:17, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > static BOOL has_extension( const char *list, const char *ext, size_t len ) > { > + if (!list) > + { > + const struct opengl_funcs *funcs = NtCurrentTeb()->glTable; > + const char *gl_ext; > + unsigned int i; > + GLint extensions_count; > + > + glGetIntegerv(GL_NUM_EXTENSIONS, &extensions_count); > + for (i = 0; i < extensions_count; ++i) > + { > + gl_ext = (const char *)funcs->ext.p_glGetStringi(GL_EXTENSIONS, i); > + if (!strncmp(gl_ext, ext, len) && !gl_ext[len]) > + return TRUE; > + } > + return FALSE; > + } > + If I'm reading this correctly, this effectively ignores DisabledExtensions for anything newer than GL 3.0. (And at least as far as wglGetProcAddress() is concerned it affects both compatibility and core contexts.) > + gl_version = (const char *)glGetString(GL_VERSION); > + sscanf(gl_version, "%u", &major); > + if (major >= 3) > + { It seems tempting to just flag the context in wglCreateContextAttribsARB() under the appropriate conditions, perhaps in a similar way to wgl_handle_type. Not sure if it would really make it better though. As an aside, note that winex11.drv also uses "glGetString(GL_EXTENSIONS);" in X11DRV_WineGL_InitOpenglInfo().

3 4

Re: [PATCH 2/5] winemac: Implement wglCreateContextAttribsARB.
by Ken Thomases 05 Jan '15

05 Jan '15

On Jan 5, 2015, at 10:17 AM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#if !defined(MAC_OS_X_VERSION_10_7) || MAC_OS_X_VERSION_MAX_ALLOWED < MAC_OS_X_VERSION_10_7 > + if (core) > + { > + WARN("OS X version >= 10.7 is required to be able to create core contexts\n", > + err, CGLErrorString(err)); The "err, CGLErrorString(err)" arguments are superfluous. > + return FALSE; > + } > + if (core) > + { > + attribs[n++] = kCGLPFAOpenGLProfile; > + attribs[n++] = (int)kCGLOGLPVersion_3_2_Core; > + } These lines won't compile when the SDK is earlier than 10.7. So, they also need to be guarded with the appropriate #if. > + case WGL_CONTEXT_PROFILE_MASK_ARB: > + if ((value & ~VALID_PROFILE_BITS_MASK) || !value || > + (value & VALID_PROFILE_BITS_MASK) == VALID_PROFILE_BITS_MASK) I think it would be better to simply do: if (value != WGL_CONTEXT_CORE_PROFILE_BIT_ARB && value != WGL_CONTEXT_COMPATIBILITY_PROFILE_BIT_ARB) Or did I miss something about the logic you used? > + { > + WARN("WGL_CONTEXT_PROFILE_MASK_ARB bits %#x invalid\n", value); > + SetLastError(ERROR_INVALID_PROFILE_ARB); > + return NULL; > + } > + profile = value; > + break; > + register_extension("WGL_ARB_create_context"); > + register_extension("WGL_ARB_create_context_profile"); > + opengl_funcs.ext.p_wglCreateContextAttribsARB = macdrv_wglCreateContextAttribsARB; These should only be advertised when building against the 10.7 SDK or later. So, this should be guarded by the SDK #if directive. Also, given that it's possible to build against a 10.7+ SDK but target deployment back to 10.6, I'm tempted to say we should determine if core profiles are actually available and only advertise those extensions if so. Basically, call CGLChoosePixelFormat() with the simplest set of attributes that specify the core profile and see if it succeeds. -Ken

2 2

Re: [PATCH 5/5] wined3d: Prefer the core glActiveTexture function.
by Henri Verbeet 05 Jan '15

05 Jan '15

On 5 January 2015 at 17:17, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > +#define MAP_GL_FUNCTION(core_func, ext_func) \ > + { \ > + if (!gl_info->gl_ops.ext.p_##core_func) \ > + gl_info->gl_ops.ext.p_##core_func = gl_info->gl_ops.ext.p_##ext_func; \ > + } > + > + MAP_GL_FUNCTION(glActiveTexture, glActiveTextureARB); > +#undef MAP_GL_FUNCTION > + This kind of thing doesn't exactly fill me with joy, but I guess the alternatives wouldn't be much better. Any reason this can't be part of load_gl_funcs()? (And while we're touching load_gl_funcs(), I don't see much of a reason we couldn't just inline GL_EXT_FUNCS_GEN these days.) > + /* Newer core functions */ \ > + USE_GL_FUNC(glActiveTexture) \ It would probably be nice to note the exact GL version where the function entered core GL.

2 3

Re: [PATCH 1/5] winemac: Make the implementation of clearToBlackIfNeeded compatible with core contexts.
by Ken Thomases 05 Jan '15

05 Jan '15

On Jan 5, 2015, at 10:17 AM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > --- > dlls/winemac.drv/cocoa_opengl.m | 29 +++++++++++++++++++++++++++-- > 1 file changed, 27 insertions(+), 2 deletions(-) Looks OK to me. -Ken

1 0

Re: dwrite: release_freetype() is unused so remove it.
by Nikolay Sivov 05 Jan '15

05 Jan '15

I'll send a patch to make it used.

1 0

Re: [PATCH 5/5] wined3d: Prefer the core glActiveTexture function.
by Wojciech Arabczyk 05 Jan '15

05 Jan '15

On 5 January 2015 at 17:17, Matteo Bruni <mbruni(a)codeweavers.com> wrote: > diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c > index 4da8c7d..023bcbf 100644 > --- a/dlls/wined3d/context.c > +++ b/dlls/wined3d/context.c > @@ -1328,8 +1328,8 @@ static void bind_dummy_textures(const struct wined3d_device *device, const struc > > for (i = 0; i < count; ++i) > { > - GL_EXTCALL(glActiveTextureARB(GL_TEXTURE0_ARB + i)); > - checkGLcall("glActiveTextureARB"); > + GL_EXTCALL(glActiveTexture(GL_TEXTURE0_ARB + i)); > + checkGLcall("glActiveTexture"); Per analogy, shouldn't this be GL_TEXTURE0 instead? > { > - GL_EXTCALL(glActiveTextureARB(GL_TEXTURE0 + unit)); > - checkGLcall("glActiveTextureARB"); > + GL_EXTCALL(glActiveTexture(GL_TEXTURE0 + unit)); > + checkGLcall("glActiveTexture"); > context->active_texture = unit; > } > -- With kind regards Wojciech Arabczyk

2 2

Re: [PATCH 4/5] d3d9/tests: Remove a couple duplicate lines.
by Bruno Jesus 05 Jan '15

05 Jan '15

On Mon, Jan 5, 2015 at 2:17 PM, Matteo Bruni <mbruni(a)codeweavers.com> wrote: Ciao, Matteo. > --- > dlls/d3d9/tests/visual.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c > index d1aa3d4..acc3a44 100644 > --- a/dlls/d3d9/tests/visual.c > +++ b/dlls/d3d9/tests/visual.c > @@ -6775,8 +6775,6 @@ static void pretransformed_varying_test(void) > hr = IDirect3DDevice9_SetVertexDeclaration(device, decl); > ok(hr == D3D_OK, "IDirect3DDevice9_SetVertexDeclaration returned %08x\n", hr); > > - hr = IDirect3DDevice9_SetVertexDeclaration(device, decl); > - ok(hr == D3D_OK, "IDirect3DDevice9_SetVertexDeclaration returned %08x\n", hr); Isn't this done on purpose to check if double setting works? Distinti Saluti, Bruno

2 1

Re: winhttp/tests: Use a wait event instead of an unconditional sleep in the server thread.
by Marvin 05 Jan '15

05 Jan '15

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11019 Your paranoid android. === w8 (32 bit winhttp) === winhttp.c:2042: Test failed: failed to receive response 12152 winhttp.c:2047: Test failed: request failed unexpectedly 327681

1 0

Re: dplayx: Cache the results of DirectPlayEnumerateAW()
by Stefan Dösinger 05 Jan '15

05 Jan '15

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Bruno, Some tests for this behavior would be useful. Also consider adding tests that check if DirectPlayEnumerate always enumerates the same pointers. Am 2015-01-04 um 23:05 schrieb Bruno Jesus: > + static struct _data > + { > + GUID guid; > + WCHAR descriptionW[256]; > + char descriptionA[256]; > + } *providers_cache; You don't have to give this structure a name. (i.e., remove "_data"). > + /* Some applications require that the data returned through the callback persist after the callbacks > + * are called, so we buffer the information first and do the callbacks later. We will always rewrite > + * the buffer as some applications may change it (on purpose or due to bugs). > + */ Please name the application. 2 years from now nobody will remember it, and a search through wine-patches might not be successful. > + HeapFree(GetProcessHeap(), 0, providers_cache); > + providers_cache = HeapAlloc(GetProcessHeap(), 0, sizeof(*providers_cache) * dwIndex); > + if (!providers_cache) > + { > + ERR(": failed to alloc required memory.\n"); > + return DPERR_EXCEPTION; > + } Does the registry data change during runtime? I think it is created during prefix creation and then never touched again. > + if (sizeOfDescription > max_sizeOfDescriptionW) > + { > + HeapFree(GetProcessHeap(), 0, descriptionW); > + max_sizeOfDescriptionW = sizeOfDescription; > + } > + descriptionW = HeapAlloc(GetProcessHeap(), 0, sizeOfDescription); This can leak descriptionW. You're also hard-coding a size limit of 256 in providers_cache. One of the two isn't right, most likely the hard-coded limit. > + RegQueryValueExW(hkServiceProvider, descW, > + NULL, NULL, (LPBYTE) descriptionW, &sizeOfDescription); > + > + lstrcpynW(providers_cache[dwIndex].descriptionW, descriptionW, sizeof(providers_cache[0].descriptionW)); > + WideCharToMultiByte(CP_ACP, 0, providers_cache[dwIndex].descriptionW, -1, providers_cache[dwIndex].descriptionA, > + sizeof(providers_cache[0].descriptionA), NULL, NULL); The old code queries two different values, "DescriptionA" and "DescriptionW". Your code queries "DescriptionW" and converts the content to ASCII. Do DescriptionA and DescriptionW always contain the same content? -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUqlckAAoJEN0/YqbEcdMwPYcP/1zJL5U+YlDNVLsjHaiZQClj x0gyVMUcAB/0IH5QA1l37o0OChMgPg+xjkKuHfV9yx1ESFiulbm6bb1Qc1MfHmSO KB0hswxd1G9LVw8VUcbfCMmS3LK4JQl/Ha8Zj2RcFpcU+xIRc+p0LY+bg0QJyML2 i0XYSomKubZoKDeW1ZW8oAGXHc67kT2kBVXoZ9jCThjob8Lzy0bsZaKqEGiEjm5v UqGCjfv7wLsd3egEAA6WBa/sxmV5pGUqPbYe0OLNxExtOOHmZE7u0Ti9bAdGLZLE FnEB46IW6ECgMbdizIh9yZU/1pNB1AjVXKC1nhJevPPA4Bbln+4OkOrjKuYSQyqq lITarHscB9wnDdhXc3iwvi1vOB1B0v0X7CvTSAc+xBkx7gjK8/pyRSShcm6ho7yj 7UeKJuTqZ/+WRoMX2ariim7vzSzedWw+P1V0vcO/J5bA6icWpAxoivihSM7OzXFT lFYAr98BwlwVljr7QYKMtC1CkmBHIXIaaIoV7c6miTounpwXGvI4BdXvOt679jTV bKfMo7p5rx9n2K2cro7/J/g0bPcIX6PAg0ay9g+jD7XzhWkxQTjzHQF79uko3XG7 U3Y3ApC1dRwzJ7PzDIiS3F0t1Bk1+PcaMK269cOISni9odiODz1I7uzQFsVJE0S8 H9a8YJIdWhzvjszLKn44 =76/t -----END PGP SIGNATURE-----

2 1

Re: kernel32: Implement Get{Time,Date}FormatEx
by Nikolay Sivov 04 Jan '15

04 Jan '15

On 30.12.2014 2:06, Sean Burke wrote: > Provides an implementation of time and date format functions added in > Vista sufficient to allow some basic applications requiring them to run. > Includes necessary tests and header defs. > > > Sean Burke > > > Hi, Sean. As you can see tests are failing on win2000 and winxp because these calls are not available on these platforms. You should use GetProcAddress() to fix that. > +@ stdcall GetDateFormatEx(ptr long ptr wstr ptr long ptr) First argument should be 'wstr' as well. > +@ stdcall GetTimeFormatEx(ptr long ptr wstr ptr long) Same. > +INT WINAPI GetDateFormatEx(LPCWSTR lpLocaleName, DWORD dwFlags, > + const SYSTEMTIME* lpDate, LPCWSTR lpFormat, > + LPWSTR lpDateStr, INT cchDate, LPCWSTR lpCalendar) Please use cleaner argument names, like 'localename', 'flags', 'date', 'format', etc. So lowercase, no prefix. > + lcid = LocaleNameToLCID(lpLocaleName, 0); > + > + return NLS_GetDateTimeFormatW(lcid, dwFlags | DATE_DATEVARSONLY, lpDate, > + lpFormat, lpDateStr, cchDate); No real need for temporary 'lcid' variable.

2 2

Re: secur32: Add support for ECDHE algorithms using gnutls
by Jacek Caban 04 Jan '15

04 Jan '15

Hi Sean, On 12/30/14 00:08, Sean Burke wrote: > diff --git a/dlls/secur32/schannel_gnutls.c b/dlls/secur32/schannel_gnutls.c > index 638b3c5..810c598 100644 > --- a/dlls/secur32/schannel_gnutls.c > +++ b/dlls/secur32/schannel_gnutls.c > @@ -328,6 +328,8 @@ static ALG_ID schannel_get_kx_algid(gnutls_kx_algorithm_t kx) > switch (kx) > { > case GNUTLS_KX_RSA: return CALG_RSA_KEYX; > + case GNUTLS_KX_ECDHE_ECDSA: Shouldn't this case use CALG_ECDSA? > + case GNUTLS_KX_ECDHE_RSA: return CALG_ECDH; > case GNUTLS_KX_DHE_DSS: > case GNUTLS_KX_DHE_RSA: return CALG_DH_EPHEM; > default: Cheers, Jacek

2 1

Re: Unicode Support in wine-devel
by Akira Nakagawa 02 Jan '15

02 Jan '15

>I can see those working fine on this mailing list both through my mail client and through both of the online mailing list browsers ( https://www.winehq.org/pipermail/wine-devel/ && http://news.gmane.org/gmane.comp.emulators.wine.devel ) So, are You sure there is an actual problem? Probably the encoding of the mail sent by wine-devel-digest is not formatted as Unicode. It doesn't problem of server, but the mail. All chinese characters are viewed as ??????? in my gmail. It is a SMTP's problem,isn't it?

1 0

Re: [PATCH] winealsa: support up to 6 channels
by Chris Robinson 02 Jan '15

02 Jan '15

On 12/31/2014 01:34 PM, Mark Harmstone wrote: > Needed for surround sound. ALSA uses a different channel mapping for 5.1 than Windows. Windows wants: front-left, front-right, front-center, lfe, back-left*, back-right* while ALSA wants: front-left, front-right, back-left*, back-right*, front-center, lfe So you can't just pass the samples through without swapping them. * This is complicated by the fact that some 5.1 setups use the side channels instead of the back channels, and with the side channels the mappings are the same for both: front-left, front-right, front-center, lfe, side-left, side-right Technically 5.1 is supposed to use the side channels according to Dolby, but until recently Windows has used back and many speakers are color-coded to match the surround speakers to the back speaker jacks. The newer enumerant DSSPEAKER_5POINT1_SURROUND indicates it's using side channels, while the older DSSPEAKER_5POINT1 (aka DSSPEAKER_5POINT1_BACK) indicates the back channels.

2 1

Re: [PATCH] msvcr120: Fixed bugs in Concurrency::critical_section.
by Piotr Caban 02 Jan '15

02 Jan '15

Hi, the tests are failing on both wine and windows with following message: msvcr120.c:303: Test failed: execution timed out, critical section probably not functioning correctly msvcr120: 155 tests executed (0 marked as todo, 1 failure), 0 skipped. It takes ~14 seconds to run the tests here. You also left "#include "stdio.h" line in the tests. The change in critical_section class implementation looks good for me. Cheers, Piotr

1 0

Re: po: Update Portuguese translation
by Bruno Jesus 31 Dec '14

31 Dec '14

On Wed, Mar 5, 2014 at 9:48 PM, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Sorry, the subtitle is wrong. Please prefer the update version.

1 1

Unicode Support in wine-devel
by 中川祥 31 Dec '14

31 Dec '14

This mailing list does not support any chinise and japanese character, so we cannot help feeling discriminated.

2 1

FOSDEM 2015
by Stefan Dösinger 31 Dec '14

31 Dec '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, I've been asked by the gallium nine devs and a developer of one of the proprietary drivers if any one of us will be at FOSDEM in a month. Since we won't have a full-blown Wine room I'm wondering if the Wine Party Fund has enough resources to send myself (and/or Henri and Matteo if they're interested) to FOSDEM. My main agenda is to sit in the Xorg room for smalltalk. If there's interest on part of the Xorg developers I can give an updated performance talk like the last two years. If anyone is planning a Wine table I can help out with it, or talk to other upstream projects if anyone else here has any errands to take care of. Cheers, Stefan -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJUoQCDAAoJEN0/YqbEcdMwiT0QAIGfxFvIiTwt3QeRaMiIc/07 AMnQ7/xCIj63hYUzAcR8Z0wzfGG1JH/nQmhu+tkNhCU4XMj8nZt0nD6YC/GGOytU 6mOFpbF902sbW4mtT18w0ZTIsZhU9rl6sufsPQiNnNRZGP61bo432NwYYlO29EKh n/rUO8WESxSzQjN73bF14J1r5d0GGB8q9cakkqi5zfQhOgBJHT3wijfumR/6wJI/ Xkccdzn4on0yaDLmnWQgpwu+kwDaZ5a48J48BlwFXi6zGoUmY/wIJPcdB9mwXm42 +k6lBmPyv5iPCbiMje6lvZajKdayKSc4MNyuURwrl3nBdtuXIFpQwrtJsjjILm3B CwL660h8yTbuFaGJQTY7fKyy8YxDGDnKKscrWzTyyFGe75I6eo4w1iMIsAy9dF9Q VP9J4+j2NYMozzxxB8nhrjvN7Cf67hKtvhJepeGDG6/JIMLR+ryksFhvMRNlDpjq 5gJOdWBqJJO/ODdzlhaUuqKfTyDGciwO6mljzyuWcnOA4eEd6fMVLkOpkvBvzQCc fGiV7nMjUi0aSkoctjgh7UNHFfqSbAnNfVum5h+iEYP/wdch2HBiZX5jbbjn3XzX ktkzcGN+Av+yfkB1AfNAWcSyaEGthzeEONtxduvoEgKH640tU2PhLOWLoyKNNaS2 xkRhiL5U4QV0cF7pFhSm =//r+ -----END PGP SIGNATURE-----

4 4

Re: [PATCH] msvcr120: Fixed a race condition in Concurrency::critical_section.
by Piotr Caban 31 Dec '14

31 Dec '14

On 12/31/14 00:45, Yifu Wang wrote: > @@ -380,11 +393,18 @@ void __thiscall critical_section_lock(critical_section *this) > memset(&q, 0, sizeof(q)); > last = InterlockedExchangePointer(&this->tail, &q); > if(last) { > + /* If last == &this->unk_active, the current thread might be racing setting > + * unk_active.next with another thread calling cs_set_head(). If the current > + * thread sets unk_active.next first, the data structure would be left in an > + * inconsistent state and causes hang. Spin waiting until unk_active.next > + * becomes NULL solves the race condition. > + */ > + if(last == &this->unk_active) > + spin_wait_for_next_null(&this->unk_active); > last->next = &q; > NtWaitForKeyedEvent(keyed_event, &q, 0, NULL); > } > > - this->unk_active.next = NULL; > if(InterlockedCompareExchangePointer(&this->tail, &this->unk_active, &q) != &q) > spin_wait_for_next_cs(&q); > cs_set_head(this, &q); There's still a race with your patch. There's no guarantee that this->unk_active.next != NULL before cs_set_head(this, &q) is called. Changing the place where cs_set_head is called should fix the issue in cleaner way: diff --git a/dlls/msvcrt/lock.c b/dlls/msvcrt/lock.c index 328b5b5..e2ebef3 100644 --- a/dlls/msvcrt/lock.c +++ b/dlls/msvcrt/lock.c @@ -384,10 +397,11 @@ void __thiscall critical_section_lock(critical_section *this) NtWaitForKeyedEvent(keyed_event, &q, 0, NULL); } - this->unk_active.next = NULL; - if(InterlockedCompareExchangePointer(&this->tail, &this->unk_active, &q) != &q) - spin_wait_for_next_cs(&q); cs_set_head(this, &q); + if(InterlockedCompareExchangePointer(&this->tail, &this->unk_active, &q) != &q) { + spin_wait_for_next_cs(&q); + this->unk_active.next = q.next; + } } /* ?try_lock@critical_section@Concurrency@@QAE_NXZ */ There's also similar race in critical_section_try_lock and critical_section_try_lock_for function. Could you please also fix it there? Thank you, Piotr

1 0

Re: wininet: Handle CERT_TRUST_IS_NOT_SIGNATURE_VALID in netconn_verify_cert()
by 中川祥 31 Dec '14

31 Dec '14

Yes.it will fix, but the function is not implemented yet,too. On 2014年12月31日(水) PM2:47 Bruno Jesus <00cpxxx(a)gmail.com> wrote: > The application hits a CERT_TRUST_IS_NOT_SIGNATURE_VALID, and only > passes the flag SECURITY_FLAG_IGNORE_UNKNOWN_CA. Currently wine is not > able to ignore this error and aborts. > > This is an extension to the work added by commit > http://source.winehq.org/git/wine.git/commitdiff/ > e2a9511b30e5b68eb328c08ffecf56dcc91bce0b > > Fixes https://bugs.winehq.org/show_bug.cgi?id=36785 > >

1 0

Re: 答复: zh_CN Translation Submittion
by Jactry Zeng 30 Dec '14

30 Dec '14

Hi Jeff, Thanks for your work! Most of them look good to me. I would like to discuss these cases with you guys :) : 1. #: crypt32.rc:30 msgid "Authority Key Identifier" -msgstr "" +msgstr "权限键值辨识" #: crypt32.rc:31 msgid "Key Attributes" -msgstr "" +msgstr "键值属性" #: crypt32.rc:32 msgid "Key Usage Restriction" -msgstr "" +msgstr "键值使用限制" #: crypt32.rc:36 msgid "Key Usage" -msgstr "" +msgstr "键值使用" #: crypt32.rc:38 msgid "Subject Key Identifier" -msgstr "" +msgstr "对象键值辨识" #: crypt32.rc:41 msgid "Enhanced Key Usage" -msgstr "" +msgstr "高级键值使用" I'm not sure is 'key' here same as 'key'(秘钥) in 'Public Key', or 'key value'(键) in Registry. 2. #: crypt32.rc:52 msgid "Challenge Password" -msgstr "" +msgstr "Challenge Password" Don't modify it if you didn't translate it. 3. #: crypt32.rc:54 msgid "S/MIME Capabilities" -msgstr "" +msgstr "S/MIME 能力" Maybe '功能' is better than '能力' ? 4. #: crypt32.rc:57 cryptdlg.rc:35 msgid "User Notice" -msgstr "" +msgstr "用户告示" I'll prefer '用户通知' here. ;) 5. #: crypt32.rc:72 msgid "Organization" -msgstr "" +msgstr "阻止" Typo. 6. #: crypt32.rc:74 msgid "Common Name" -msgstr "" +msgstr "统称" Do you think '常用名' will be more proper? 7. #: crypt32.rc:91 msgid "Enrollment CSP" -msgstr "" +msgstr "招入 CSP" I prefer '注册' which you did in line 381. 8. #: crypt32.rc:93 msgid "Delta CRL Indicator" -msgstr "" +msgstr "增量 CRL 指示器" '指示器' or '指示符', which will be better? I'm not sure, but you can find some documents with 'CRL 指示符' with Google. 9. #: crypt32.rc:104 msgid "CMC Response" -msgstr "" +msgstr "CMC 回应" I'll prefer 'CMC 响应'. 10. #: crypt32.rc:193 msgid "Unknown Key Usage" -msgstr "" +msgstr "未知密钥使用" What about '未知密钥用法'? 11. #: cryptui.rc:192 msgid "Issuer &Statement" -msgstr "" +msgstr "颁发者陈述 (&S)" One more unnecessary space after '述'? 12. #: cryptui.rc:408 msgid "&DER-encoded X.509 (*.cer)" -msgstr "" +msgstr "&DER 编码的 X.509 (*.cer) (&D)" #: cryptui.rc:410 msgid "Ba&se64-encoded X.509 (*.cer):" -msgstr "" +msgstr "Ba&se64 编码的 X.509 (*.cer): (&S)" #: cryptui.rc:412 msgid "&Cryptographic Message Syntax Standard/PKCS #7 Message (*.p7b)" -msgstr "" +msgstr "加密消息语法标准/PKCS #7 消息 (*.p7b) (&C)" #: cryptui.rc:414 msgid "&Include all certificates in the certification path if possible" -msgstr "" +msgstr "如果可能，将所有证书包含在证书目录 (&I)" #: cryptui.rc:416 msgid "&Personal Information Exchange/PKCS #12 (*.pfx)" -msgstr "" +msgstr "个人信息交换/PKCS #12 (*.pfx) (&P)" Should we use brackets in SBC case here? It'll be "+msgstr "个人信息交换/PKCS #12（*.pfx） (&P)" . 13. #: cryptui.rc:61 msgid "%1 (%2!d! bits)" -msgstr "" +msgstr "%1 (%2!d! 位)" Ditto. 14. #: cryptui.rc:67 msgid "Please enter an OID in the form 1.2.3.4" -msgstr "" +msgstr "请在表单 1.2.3.4 输入对象 ID (OID)" #: cryptui.rc:68 msgid "The OID you entered already exists." -msgstr "" +msgstr "你输入的对象 ID (OID) 已经存在" Ditto. 15. #: cryptui.rc:77 msgid "X.509 Certificate (*.cer; *.crt)" -msgstr "" +msgstr "X.509 证书 (*.cer; *.crt)" #: cryptui.rc:78 msgid "Personal Information Exchange (*.pfx; *.p12)" -msgstr "" +msgstr "个人信息交换 (*.pfx; *.p12)" #: cryptui.rc:79 cryptui.rc:158 msgid "Certificate Revocation List (*.crl)" -msgstr "" +msgstr "证书吊销列表 (*.crl)" #: cryptui.rc:80 cryptui.rc:159 msgid "Certificate Trust List (*.stl)" -msgstr "" +msgstr "证书信任列表 (*.stl)" #: cryptui.rc:82 msgid "CMS/PKCS #7 Messages (*.spc; *.p7b)" -msgstr "" +msgstr "CMS/PKCS #7 消息 (*.spc; *.p7b)" Ditto. 16. #: cryptui.rc:114 msgid "" @@ -2678,6 +2693,8 @@ "trusted.\n" "Are you sure you want to remove this certificate?" msgstr "" +"用此证书颁发机构颁发的证书将不会被继续信任。\n" +"你确定要移除此证书吗？" #: cryptui.rc:115 msgid "" @@ -2685,6 +2702,8 @@ "trusted.\n" "Are you sure you want to remove these certificates?" msgstr "" +"用这些证书颁发机构颁发的证书将不会被继续信任。\n" +"你确定要移除这些证书吗？" #: cryptui.rc:116 msgid "" @@ -2692,6 +2711,8 @@ "certification authorities it issued, will no longer be trusted.\n" "Are you sure you want to remove this trusted root certificate?" msgstr "" +"用此根证书颁发机构颁发的或任何受颁发的证书颁发机构的证书将不会被继续信任。\n" +"你确定要移除这个受信任的根证书吗？" #: cryptui.rc:117 msgid "" @@ -2699,6 +2720,8 @@ "certification authorities they issued, will no longer be trusted.\n" "Are you sure you want to remove these trusted root certificates?" msgstr "" +"用这些根证书颁发机构颁发的或任何受颁发的证书颁发机构的证书将不会被继续信任。\n" +"你确定要移除这些受信任的根证书吗？" Is '用' a typo of '由' here? 17. #: cryptui.rc:156 msgid "DER-Encoded Binary X.509 (*.cer)" -msgstr "" +msgstr "DER 编码的二进制 X.509 (*.cer)" #: cryptui.rc:157 msgid "Base64-Encoded X.509 (*.cer)" -msgstr "" +msgstr "Ba&se64 编码的 X.509 (*.cer)" #: cryptui.rc:160 msgid "CMS/PKCS #7 Messages (*.p7b)" -msgstr "" +msgstr "CMS/PKCS #7 消息 (*.p7b)" #: cryptui.rc:161 msgid "Personal Information Exchange (*.pfx)" -msgstr "" +msgstr "个人信息交换 (*.pfx)" Same as 12. 18. #: gdi32.rc:42 msgid "Hangul(Johab)" -msgstr "" +msgstr "韩文（裘哈）" Is '裘哈' typo of '朝鲜语'? 19. #: inetcpl.rc:32 msgid "Configure Wine Internet Browser and related settings" -msgstr "" +msgstr "配置 Wine Internet Explorer 以及相关设置" Here is 'Wine Internet Browser', I think 'Wine Internet 浏览器' will be better. What about you? 20. #: inetcpl.rc:35 msgid "Very Low" -msgstr "" +msgstr "非常低" What about '极低' ? When 'Medium' is '中等' and 'Increased' is '较高'. 21. #: winecfg.rc:227 msgid "" @@ -12790,8 +12734,7 @@ msgstr "" "你确定要删除 C 盘吗？\n" "\n" -"大部分 Windows 程序都假定 C 盘存在，在没有它时会死得很难看。如果要继续，请记" -"得重新建立一个！" +"大部分 Windows 程序都假定 C 盘存在，在没有它时会死得很难看。如果要继续，请记得重新建立一个！" Translation here is facetious but I don't think it's appropriate. :-p Can we translate '死得很难看' to "严重出错" ? Finally, you should resend the patch to wine-patches, not provide a link of the patch. The wiki page provided by Nikolay may help. Thanks again! 2014-12-16 8:24 GMT+08:00 Jeff Bai <jeffbaichina(a)gmail.com>: > > ---------- Forwarded message ---------- > From: Jeff Bai <jeffbaichina(a)gmail.com> > Date: Mon, Dec 15, 2014 at 5:02 PM > Subject: Re: 答复: zh_CN Translation Submittion > To: Nikolay Sivov <bunglehead(a)gmail.com> > > Okay, got the part fixed. Sorry about that. More translation will be > coming and I will be editing them with a text editor instead. > > https://pastebin.anthonos.org/view/30fbda6b > > Regards, > Jeff Bai > > On Mon, Dec 15, 2014 at 2:42 PM, Nikolay Sivov <bunglehead(a)gmail.com> > wrote: >> >> On 16.12.2014 0:01, Jeff Bai wrote: >> >>> The problem is I'm not sure how to fix them. >>> >> >> How to fix what? Just open a file in a text editor and make changes there. >> >> ------------------------------------------------------------------------ >>> 发件人: Nikolay Sivov <mailto:bunglehead@gmail.com> >>> 发送时间: ‎2014/‎12/‎15 13:08 >>> 收件人: Jeff Bai <mailto:jeffbaichina@gmail.com> >>> 抄送: wine-devel(a)winehq.org <mailto:wine-devel@winehq.org> >>> >>> 主题: Re: zh_CN Translation Submittion >>> >>> >>> On 15.12.2014 17:39, Jeff Bai wrote: >>> > Umm... I think POEdit is the one who made these changes... Not sure >>> if it's my settings or what. >>> >>> Yes, it's mostly likely it. But you don't have to use it, your favorite >>> text editor will work just fine. >>> >>> > >>> > >>> >> 在 2014年12月15日，上午12:01，Nikolay Sivov <bunglehead(a)gmail.com> >>> 写道： >>> >> >>> >>> On 15.12.2014 7:53, Jeff Bai wrote: >>> >>> Hello, fellow developers. >>> >>> >>> >>> I've got several hundred strings translated to zh_CN, and according >>> to >>> >>> you guys' wiki I am supposed to submit a patch of what I've changed. >>> >>> >>> >>> So here it is (too long, used PasteBin) >>> >>> >>> >>> https://pastebin.anthonos.org/view/bb82ca07 >>> >>> >>> >>> Also, I am not sure if I would be fast enough to get them all done >>> by >>> >>> 1.7.34 (nearly two weeks apart?), so is it Okay for me to submit >>> them >>> >>> bit by bit, like this time, several hundred? There's still about 950 >>> >>> left as I can see on POEdit - and I think I can push this to 100% >>> after >>> >>> my high school final four days later. >>> >>> >>> >>> Thanks everyone, Wine is AWESOME. >>> >>> >>> >>> Regards, >>> >>> >>> >>> Jeff Bai (白铭骢) >>> >> >>> >> Hi, Jeff. >>> >> >>> >> I think it's okay to submit full diff at once. But please avoid >>> changing original messages like you do here (or maybe not you directly >>> but poedit): >>> >> >>> >>> #: oleview.rc:121 >>> >>> -msgid "" >>> >>> -"Toggle the display of component categories that are not meant to >>> be visible" >>> >>> +msgid "Toggle the display of component categories that are not >>> meant to be visible" >>> >>> msgstr "切换隐藏组件类显示" >>> >> >>> >> So keep msgid part as it is and touch only msgstr part, this will >>> also help reducing resulting diff. >>> >> >>> >> And once you fixed that you should send a patch to >>> wine-patches(a)winehq.org as it says here >>> http://wiki.winehq.org/SubmittingPatches. >>> >>> >> > > > -- Regards, Jactry Zeng

2 1

Re: kernel32: Implement Get{Time,Date}FormatEx
by Marvin 30 Dec '14

30 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10947 Your paranoid android. === w2000pro (32 bit locale) === The test timed out === wxppro (32 bit locale) === The test timed out

1 0

Any last UTF-7 comments?
by Alex Henrie 29 Dec '14

29 Dec '14

Now that Alexandre has merged a complete set of UTF-7 tests, are there any more comments on the two implementation patches before I submit those as well? https://github.com/alexhenrie/wine/commits/master -Alex

1 0

Re: [PATCH] dsound: allow LOCHARDWARE flag
by Alexandre Julliard 29 Dec '14

29 Dec '14

Mark Harmstone <hellas(a)burntcomma.com> writes: > @@ -975,12 +975,6 @@ HRESULT DirectSoundDevice_CreateSoundBuffer( > TRACE("(lpwfxFormat=%p)\n",dsbd->lpwfxFormat); > } > > - if (dsbd->dwFlags & DSBCAPS_LOCHARDWARE && > - !(dsbd->dwFlags & DSBCAPS_PRIMARYBUFFER)) { > - TRACE("LOCHARDWARE is not supported, returning E_NOTIMPL\n"); > - return E_NOTIMPL; > - } > - It breaks the tests: ../../../tools/runtest -q -P wine -T ../../.. -M dsound.dll -p dsound_test.exe.so dsound && touch dsound.ok dsound.c:1705: Test failed: CreateSoundBuffer(1) gave wrong error: 00000000 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll: fix read_directory_getdirentries() under FreeBSD.
by André Hentschel 29 Dec '14

29 Dec '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 28.12.2014 um 21:09 schrieb David Naylor: > > Change the handling of getdirentries(2) by: - tracking the data pointer instead of subtracting 'res' - simplify rewind by skipping re-appending entries onto the list - try make the logic easier to follow --- dlls/ntdll/directory.c | 73 +++++++++++++++++++------------------------------- 1 file changed, 28 insertions(+), 45 deletions(-) Hi and welcome to Wine development, maybe it's just me, but the patch is not easy to review. Is it possible to split the patch into multiple atomic patches (maybe three, as in the change list you provided)? Also, how does the patch fix Wine on FreeBSD? A quick look at the patch itself: You missed a whitespace at the last lseek call. You're adding a FIXME comment, but you should rather clarify your question, use wine-devel and/or IRC and/or "git blame" for that. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQGcBAEBAgAGBQJUoVfbAAoJEGm5GZTakYssGkoMAIfOM3ulOIh28PKA3RS0IByC sEk8AerEkKyN2nS4d2hNRU/kHIFlW+wHfi8Ah7FhBGepZ0HIHrWqZhuMmZsYx1W/ MeYyW+bROa+uCGWYvz7w9aaXW+xOIKDaJ7mIQrJKnkMgOQ3FFI8yKa6tRSSAm6iA Xg2porB96Ov+lLcl6zq0UATuVgqENhzSRrMxHh/YhVwK3xO7hSQ4ysgMJj2cBg7A XX7cEdxys1X5kSAO10I/gucmtKe3GrQi++DWx6VUd1O4WIEtm86c1gO2UtbUxYNf p9q5feajTJLscWOKpaC032fLrfFcnkhSS1ZwyIl7TfICaWW6u+8zfrcrVG8xfPkR MfbCRrJpkCFXsa5bYJLTPdD+0LETPlJ48zkyRyny56XYwgkBlgPirVlCeYnSZs9t CCOaHYYrMePAyB1DLZeJIdCCmyy8gLlY9cu28SgbN/oaHuYtwfrPbXKt30fwhZyM cOcTZnZZuYSeb5oVt72O+j0GbkSW2x+juFuVhyBvlw== =RACU -----END PGP SIGNATURE-----

2 3

Re: secur32: Always tell the user that libgnutls could not be loaded
by Henri Verbeet 29 Dec '14

29 Dec '14

On 28 December 2014 at 13:00, Bruno Jesus <00cpxxx(a)gmail.com> wrote: > Ensures a message is printed in the standard output to make the > problem obvious. Will solve problems like the one in > https://bugs.winehq.org/show_bug.cgi?id=35180#c4: > You'd probably want that to go to the winediag channel then.

1 0

Re: [PATCH] dsound: allow LOCHARDWARE flag
by Andrew Eikum 29 Dec '14

29 Dec '14

Mark's dsound and alsa patches look OK to me. Andrew On Sun, Dec 28, 2014 at 01:54:27PM +0000, Mark Harmstone wrote: > Patch to allow DSound buffers to be created with the DSBCAPS_LOCHARDWARE > flag. There's been no audio hardware acceleration on Windows since XP, so > this flag is meaningless nowadays anyway - but X3DAudio will refuse to > create a buffer of more than two channels if it's not accepted. > > --- > dlls/dsound/dsound.c | 6 ------ > 1 file changed, 6 deletions(-) > > > diff --git a/dlls/dsound/dsound.c b/dlls/dsound/dsound.c > index 8df778a..eaa4247 100644 > --- a/dlls/dsound/dsound.c > +++ b/dlls/dsound/dsound.c > @@ -975,12 +975,6 @@ HRESULT DirectSoundDevice_CreateSoundBuffer( > TRACE("(lpwfxFormat=%p)\n",dsbd->lpwfxFormat); > } > > - if (dsbd->dwFlags & DSBCAPS_LOCHARDWARE && > - !(dsbd->dwFlags & DSBCAPS_PRIMARYBUFFER)) { > - TRACE("LOCHARDWARE is not supported, returning E_NOTIMPL\n"); > - return E_NOTIMPL; > - } > - > if (dsbd->dwFlags & DSBCAPS_PRIMARYBUFFER) { > if (dsbd->lpwfxFormat != NULL) { > WARN("invalid parameter: dsbd->lpwfxFormat must be NULL for " > >

1 0

Re: [PATCH] dsound: convert freqAdjust and freqAcc to integers
by Andrew Eikum 29 Dec '14

29 Dec '14

On Sat, Dec 27, 2014 at 11:41:07PM +0100, Marton Balint wrote: > Fixes resamping errors caused by truncating floating point numbers. These > errors were responsible for clicking noises when resampling from 44100 to 48000 > Hz, as mentioned in bug 35971. > I was able to reproduce this, and this patch fixes it. Looks good to me. Andrew

1 0

Re: [PATCH] msvcr120: Implemented Concurrency::details::_Condition_variable. (try 2)
by Piotr Caban 29 Dec '14

29 Dec '14

On 12/26/14 20:20, Yifu Wang wrote: > --- > dlls/msvcp90/msvcp90.h | 23 ++++ > dlls/msvcr120/msvcr120.spec | 36 +++--- > dlls/msvcr120/tests/msvcr120.c | 267 ++++++++++++++++++++++++++++++++++++++-- > dlls/msvcrt/lock.c | 172 ++++++++++++++++++++++++++ > 4 files changed, 471 insertions(+), 27 deletions(-) The tests are sometimes failing for me (on windows): msvcr120: 74522 tests executed (0 marked as todo, 0 failures), 0 skipped. msvcr120.c:381: Test failed: produced != consumed msvcr120: 108919 tests executed (0 marked as todo, 1 failure), 0 skipped. Thanks, Piotr

1 0

Re: iphlpapi: add FreeMibTable implementation (try 2)
by Nikolay Sivov 28 Dec '14

28 Dec '14

On 27.12.2014 7:04, Austin English wrote: > > +/****************************************************************** > + * FreeMibTable (IPHLPAPI.@) > + * > + * Free buffer allocated by network functions > + * > + * PARAMS > + * ptr [In] pointer to the buffer to free > + * > + * RETURNS > + * Success: TRUE > + * Failure: FALSE As Thomas pointed out, this is wrong. > + */ > +void WINAPI FreeMibTable (PVOID *ptr) > +{ > + TRACE("(ptr %p): stub\n", ptr); > + HeapFree(GetProcessHeap(), 0, ptr); > +} Argument type should be 'void *'. Trace message could be just '(%p)\n'.

1 0

Re: iphlpapi: add FreeMibTable implementation (try 2)
by Thomas Faber 28 Dec '14

28 Dec '14

> Try 2: fixed specfile, comment Actually the fixed comment still seems wrong since the function returns void ;)

1 0

CSMT patch
by Emanuele Oriani 28 Dec '14

28 Dec '14

Hi Wine Devs/Stefan, Can you please give us an update in regards to the CSMT patch? Do you plan to integrate it in mainline? If not "officially", would be possible to have it in as an experimental code-path (default off)? What are the obstacles of making this happen? What is your view? Again, I believe this patch is superior to just NVIDIA Threaded Optimizations; on applications such as Starcraft II I get +150% FPS and performance is comparable to windows (if not better). I believe many other games would benefit from this great improvement. Cheers, Emanuele

5 6

Re: iphlpapi: add FreeMibTable implementation
by Dmitry Timoshkov 27 Dec '14

27 Dec '14

Austin English <austinenglish(a)gmail.com> wrote: > -#@ stub FreeMibTable > +@ stub FreeMibTable( ptr ) This won't work as expected. -- Dmitry.

2 1

Re: gdi32: add FreeMibtable implementation
by Bruno Jesus 27 Dec '14

27 Dec '14

On Sat, Dec 27, 2014 at 12:51 AM, Austin English <austinenglish(a)gmail.com> wrote: > https://bugs.winehq.org/show_bug.cgi?id=36092 Wrong patch subject? Shouldn't it be: iphlpapi: Add FreeMibTable implementation > -- > -Austin > > >

2 1

Re: [PATCH (resend)] kernel32/tests: Add tabular UTF-7 encoding tests.
by Alex Henrie 24 Dec '14

24 Dec '14

Alexandre, I need to know why you are ignoring this patch so that I can improve it to meet your standards. -Alex

1 1

Holidays
by Alexandre Julliard 24 Dec '14

24 Dec '14

Folks, Like probably most of you, I will be out for a few days for the holidays, so I'm going to skip this week's release. I expect things to be fairly slow next week too. I'll still commit patches when I'm around, but the next release will be on January 9. Enjoy your holidays! -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] dsound: do not allow adding a NULL ptr as buffer in DirectSoundDevice_AddBuffer()
by Nikolay Sivov 24 Dec '14

24 Dec '14

On 12/24/2014 04:55 PM, Pierre Schweitzer wrote: > Dear all, > > Please find attach a patch which prevents DirectSoundDevice_AddBuffer() > from accepting NULL pointers. > It results from a bugfix & testing here. While trying to start Steam > Lego Star Wars, I was experiencing an invalid address dereference in > DSOUND_ChangeListener() (line 312). > > Adding this check makes the game work properly (with sound). I tested it. > > Cheers, > Please add a test for that.

2 2

Re: mshtml: Allow '#' to be the first char of resource name in res protocol.
by Marvin 24 Dec '14

24 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10902 Your paranoid android. === w2000pro (32 bit protocol) === protocol.c:259: Test failed: expected ReportProgress protocol.c:259: Test failed: expected ReportProgress

1 0

Re: [PATCH 4/4] mshtml: Added script element readyState and onreadystatechange tests.
by Marvin 24 Dec '14

24 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10901 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: [PATCH] msvcp120: Implemented xtime functions.
by Piotr Caban 23 Dec '14

23 Dec '14

Hi, the tests are failing on windows (and sometimes on wine). Please also test return value of xtime_get and check if values returned by it are similar to what native does. Thanks, Piotr

1 0

Re: [PATCH] msvcr120: Implemented Concurrency::details::_Condition_variable.
by Piotr Caban 23 Dec '14

23 Dec '14

Hi, I was not really looking on this patches yet but I've seen few issues: - you forgot to call init_thiscall_thunk function - there are some compilation warnings - the tests are not passing on windows Thanks, Piotr

1 0

Re: [PATCH 2/3] gdiplus: fix get_clip_hrgn when window origin point changed
by Dmitry Timoshkov 23 Dec '14

23 Dec '14

"Changhui Liu" <liuchanghui(a)linuxdeepin.com> wrote: > --- a/dlls/gdiplus/graphics.c > +++ b/dlls/gdiplus/graphics.c > @@ -350,7 +350,18 @@ static void gdi_alpha_blend(GpGraphics *graphics, INT dst_x, INT dst_y, INT dst_ > static GpStatus get_clip_hrgn(GpGraphics *graphics, HRGN *hrgn) > { > /* clipping region is in device coords */ > - return GdipGetRegionHRgn(graphics->clip, NULL, hrgn); > + GpStatus state = GdipGetRegionHRgn(graphics->clip, NULL, hrgn); Please use 'status' instead of 'state'. > + if (graphics->hdc) > + { This should be if (status == Ok && graphics->hdc) > --- a/dlls/gdiplus/tests/graphics.c > +++ b/dlls/gdiplus/tests/graphics.c > @@ -5603,6 +5603,95 @@ static void test_GdipGetVisibleClipBounds_memoryDC(void) > ReleaseDC(hwnd, dc); > } > > +#define BLUE_COLOR (0xff0000ff) > +#define IsBlue(color) ( ((color) & 0x00ffffff) == 0xff ) > +#define GetBitmapPixel(x,y) pixel[(y)*(width) + (x)] Inline helpers without Win32 API resembling names would be better. Something like is_blue_color, get_bitmap_pixel. Same applies for remaining code. -- Dmitry.

1 0

Re: [PATCH 1/3] gdiplus: fix get_graphics_bounds when window origin point changed
by Dmitry Timoshkov 23 Dec '14

23 Dec '14

"Changhui Liu" <liuchanghui(a)linuxdeepin.com> wrote: > @@ -5619,7 +5674,7 @@ START_TEST(graphics) > test_alpha_hdc(); > test_bitmapfromgraphics(); > test_GdipFillRectangles(); > - > + test_GdipGetVisibleClipBounds_memoryDC(); > GdiplusShutdown(gdiplusToken); > DestroyWindow( hwnd ); > } An empty line before GdiplusShutdown is intentional and makes it clearer to separate tests from the clean up. Please keep it that way. -- Dmitry.

1 0

Re: gdiplus: fix GdipFillRectangleI no effect on memoryDCwhosewindoworiginpoint has changed
by Changhui Liu 23 Dec '14

23 Dec '14

Hi, > I would prefer that you use the expect() macro when comparing integers in tests. > >If you don't expect a function (in this case GetDIBits, in patch 2) to >fail when running a test, use ok() to check that it succeeded. It's OK >if the test will crash when the ok() check fails. > >If GetDIBits really does fail sometimes, we need to understand why >that happens and document it in the test. > >When writing comments about this, make sure you specify that you are >talking about gdi32 device coordinates, which are different from >gdiplus device coordinates. I have modified, please see the new patch file. >+ status = GdipSetClipRectI(graphics, rect.left+width/2, rect.top+height/2, >+ rect.right, rect.bottom, CombineModeReplace); > >This looks wrong to me. GdipSetClipRectI takes a width and height, not >right and bottom. The above statement is setting a clip range: (rect.left+width/2, rect.top+height/2) - (rect.left+rect.right+width/2, rect.top+rect.bottom+height/2). Because the rect is {100, 100, 180, 180}, so the clip range is: (140,140) - (320,320). In fact GdipSetClipRectI can take any int value to specify a clip region. But according to your advice, I have changed to take a width and height . For helping review, I attached a BMP file which is the output of each test_GdipFillRectangle drawing on Memory DC. Thank you. ------------------ Regards.

3 4

Re: [PATCH 2/3] urlmon: Skip query and hash part in find_mime_from_url.
by Marvin 22 Dec '14

22 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10873 Your paranoid android. === w2000pro (32 bit misc) === misc.c:723: Test failed: [5] wrong mime: L"text/plain" === wxppro (32 bit misc) === misc.c:723: Test failed: [5] wrong mime: L"text/plain"

1 0

Re: mshtml: Added IHTMLDOMTextNode::splitText implementation.
by Marvin 21 Dec '14

21 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10849 Your paranoid android. === w2000pro (32 bit) === No test summary line found === wxppro (32 bit) === No test summary line found === wvistau64 (32 bit) === No test summary line found === w2008s64 (32 bit) === No test summary line found === w7u (32 bit) === No test summary line found === w8 (32 bit) === No test summary line found === wvistau64 (64 bit) === No test summary line found === w2008s64 (64 bit) === No test summary line found

1 0

Re: shell32: Added stub IPropertyStore for a shell link object
by Marvin 20 Dec '14

20 Dec '14

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=10846 Your paranoid android. === wxppro (32 bit shelllink) === shelllink.c:1170: Test failed: got 0x80004002 shelllink: unhandled exception c0000005 at 0041529E

1 0

Re: [PATCH] libs/wine/string.c: Duplicate Windows behaviour in vsnprintfW
by Hugh McMaster 20 Dec '14

20 Dec '14

Sorry, I didn't see your message as it was sent to wine-patches. On Thursday, 18 Dec 2014 18:09:01 +0100, Jonathan Vollebregt wrote: >> If buffer or format is NULL, or if count is less than or equal to zero, these functions invoke the invalid parameter handler, as described in Parameter Validation. If execution is allowed to continue, these functions return -1 and set errno to EINVAL. >This doc says that vsnprintf *should* always return -1 given your example. Yes, MSDN does say that. >Is there a test that shows the MSDN docs are wrong? I'm not sure if Wine has one, but I'll check. Running multiple tests with Visual Studio 2013 on Windows 7 64-bit returns the number of chars that would be written for vsnprintf(NULL, 0, fmt, args). -1 is returned in cases when "the number of characters to write is greater than count". So some examples would be vsnprintf(valid buffer, 0, fmt, args) or vsnprintf(very small buffer, 8, fmt, args). >On 12/18/2014 11:57 AM, Hugh McMaster wrote: >> Recent discussions on the wine-devel mailing list conclude that Wine's vsnprintfW must duplicate Windows' vsnprintf behaviourW[1]. >> >> Currently, there are two issues. >> >> 1. vsnprintfW(NULL, 0, fmt, args). Both Windows and GCC allow these arguments. Both return the number of chars that would be written in this instance. Wine returns -1, which is incorrect. >> >> 2. vsnprintfW(some buffer, 0, fmt, args). Both Windows and Wine return -1, but in this case, Wine does this by default. We need to maintain this behaviour. >> >> To fix these inconsistencies, we need to add an 'else' block to the check for len (i.e. checking for a non-zero value). Then we check for a NULL pointer. If true, we return (int)written, like Windows and GCC do, because vsnprintfW(NULL, 0, fmt, args) was called. >> >> This patch fixes these issues. >> >> [1] https://www.winehq.org/pipermail/wine-devel/2014-December/106066.html

3 3

Re: gdiplus: fix GdipFillRectangleI no effect on memory DC whose windoworigin point has changed
by Vincent Povirk 19 Dec '14

19 Dec '14

- rect->X = 0; - rect->Y = 0; + /*The user maybe has called SetWindowOrgEx to change origin point*/ + POINT pt = {0, 0}; + GetWindowOrgEx(graphics->hdc, &pt); + rect->X = pt.x; + rect->Y = pt.y; I don't think we should use GetWindowOrgEx in gdiplus. There are too many ways to change the mapping of co-ordinates for an HDC, and it doesn't make sense to specifically account for them all. In get_graphics_bounds, we already have code that accounts for the HDC transform using DPtoLP. Maybe we should do that even when GetMapMode == MM_TEXT. Transforming the region in alpha_blend_pixels_hrgn looks wrong to me, because we can't do that in the general case. Logical coordinates on the HDC may not be pixels. Your test is very unclear. A good test for this should make it obvious how the HDC's transform affects GDI+ world coordinates. If I fill a rectangle at (0,0) using GDI+, on an HDC with window origin (5,5), what is the origin of that rectangle on the screen?

3 7

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel