wine-devel

wine-devel@winehq.org

2 participants
84471 discussions

Re: Questions for developing functions
by David Elliott 20 Jan '02

20 Jan '02

On 2002.01.20 12:46 Gerhard W. Gruber wrote: > On Sun, 20 Jan 2002 11:38:48 -0500, David Elliott <dfe(a)tgwbd.org> wrote: > > >Well, if the code you contribute could be considered a derived work of > the > >code you disassembled then you'd have problems. But for instance if you > > >disassembled for the purposes of figuring out how many arguments the > >function takes and what not but didn't actually directly write your code > > >based on the disassembly, then you should be in the clear as far as that > > >is concerned. > > Of course I primarily use that insight to get information on what > arguments > are used. I don't intend to make a 1:1 representation of the binary code > to C. > :) > > >Now, as for the breaking of the license agreement on your software. > That > >mostly concerns you as you are the person under the license, not the > Wine > >project. So if you feel like you would get into legal trouble by even > >disassembling something to simply see what types of parameters it takes, > > >then I would suggest that you didn't do it. However if you feel that > you > >would not get into legal trouble, and assuming you don't create your > >implementation directly from the disassembly (i.e. you reimplement from > >scratch, but just use the disassembly to get some ideas of function > >parameters) then you should be very much in the clear, and so should the > > >wine project. > > Thanks. :) > Remember though.. I am not a lawyer, and I am not Alexandre Julliard. > >Hey man, if no one responds in this mailing list within a reasonable > >timeframe then probably no-one is working on it. Just have a go and if > >someone else beats you to it without saying anything you can always do a > > >peer-review of the code and see if maybe something should be done > >different. Two pairs of eyes are better than one. > > OK. Sorry to bother you with this, but I'm just starting out, so I don't > know > much about the procedure on how to contribute a bit. :) I'd also hate to > start > investingating when a few days later a patch is thrown at the list that > does > what I just started out to do. :) I also think that it wasted time on > behalf > of wine if many developers work on the same things and leave other areas > to > its own. > No, it's not a bother.. the fact that you just posted saying that you were gonna work on it is desirable. -Dave

1 0

Questions for developing functions
by Gerhard W. Gruber 20 Jan '02

20 Jan '02

I have already posted this in the NG but I was told that this would be more appropriate here. One of my questions is how wine developers actualy develop their functions. I'm aware that some functions are (rather) easily determind just because of their name (i.e. CreateFile). Other functions can be derived from reading the documentation but there is quite a number of functions that arenot documented and some are not even mentioned anywhere (like functions in the rpcnt.dll). Now I wonder how you go about this. My approach would be to disassemble such functions and see how they work. Of course I know that in some countries this will be illegal while it is not in others. If I live in a country where this is legal would it still be a problem for the maintainer if I submit a function that is written based on the method I used to get the knowledge to write it? How do you circumvent that problem that you might infringe copyright as reverse engineering is usually prohibited by the licence where this licence is actually legally binding. Another question is concerning the function CreateDispTypeInfo. I'd like to work on Hotline which uses this function. As I noticed, this function is stubbed but not implemented and the last time it was worked on was somewhere in 2000, so I'd like to know if somebody is working on this. If I start work on it, do I have to submit this info somewhere in order to avoid duplicate work? Thanks. -- Bye, Gerhard If you think education is expensive, try ignorance.

2 1

Int 09 keyboard handler?
by Nog 20 Jan '02

20 Jan '02

Hi there, For 3 days now I have been trying to get Monkey Island 2 to work with wine, but I just can't seem to make it respond to keyboard input. The game installs a keyboard handler on int 09 which works. When a key gets pressed on the keyboard the key does get queued and then Monkey Island reads the key from port 0x60, which returns the correct key. So everything seems to work on the wine side of things but the game does not respond in any way. I have attached a +int,+io trace if that helps anyone. nog.

1 0

Full screen, always on top window doesn't get keyboard input
by Ori Pessach 19 Jan '02

19 Jan '02

Hello, While playing some more with Pajama Sam (for those of you who are wondering: yes, that's all I ever play. Pajama Sam Rocks!), I noticed the following bug: The game opens a full screen window, which doesn't get keyboard input. Furthermore, under RedHat 7.2's KDE 2 window manager, managed game dialog boxes appear BELOW the game window. The dialogs, even though they're invisible, respond to keyboard input. For example, it is possible to exit the game by clicking the exit icon, and pressing "Y", for Yes, on the dialog. Under Gnome's window manager (Sawfish?) the dialogs appear in front of the game window, but the game window still doesn't accept keyboard input. Under KDE, I can't get any other window to appear in front of the game window, nor can I minimize it. I looked at dlls/x11drv, and didn't see any WM hints being set that are obviously bad. Chances are that I wouldn't recognize bad WM hints even if they jumped up and bit me on the forehead, though. I've also poked around the system with xwininfo, and found out that the game has a full screen window, named "Pajama Sam", which has a nameless child window, which is also full window and visible. Only the parent window has any WM hints set. I seem to remember some discussion a while ago, about similar problems with installers (???). Could that be related? Bye, Ori _________________________________________________________ Do You Yahoo!? Get your free @yahoo.com address at http://mail.yahoo.com

1 0

WinProc recursion
by Niclas Carlsson 19 Jan '02

19 Jan '02

Hi! The 7 year old incarnation of m$word currently causes some weird problems. What happens is that a certain dlgproc (or winproc?) WM_NCPAINT handler calls DefWindowProc and then UpdateWindow. This last call causes Wine to emit a WM_PAINT which calls BeginPaint which emits a WM_NCPAINT etc ad nauseum. ==> Recursion until the stack overflows. Of course, other things may have made the logic in the winproc go haywire, but doing the same thing (calling DefWindowProc followed by UpdateWindow in WM_NCPAINT) under win95 works just fine. The same application bombs under Wine. I'm using CVS as of yesterday (20020118). Here's the relevant part of the word backtrace: 146 0x406450d5 (RedrawWindow+0x3b1(hwnd=0x1002a, rectUpdate=0x0, hrgnUpdate=0x0, flags=0x180) [painting.c:787] in libuser32.so) (ebp=40419b0c) 147 0x40645129 (UpdateWindow+0x21(hwnd=0x1002a) [painting.c:802] in libuser32.so) (ebp=40419b28) 148 0x500236e8 (winword.exe.PvAllocStack+0x10755 in D:\Program\office95\Winword\winword.exe) (ebp=40419ba8) 149 0x40656257 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=40419bcc) 150 0x406562ed (WINPROC_CallWndProc+0x8d(proc=0x50023491, hwnd=0x1002a, msg=0x85, wParam=0xbe76, lParam=0x0) [winproc.c:167] in libuser32.so) (ebp=40419bfc) 151 0x4065bb0b (CallWindowProcA+0x3b(func=0x50023491, hwnd=0x1002a, msg=0x85, wParam=0xbe76, lParam=0x0) [winproc.c:2594] in libuser32.so) (ebp=40419c24) 152 0x405f8df3 (call_window_proc+0xf3(hwnd=0x1002a, msg=0x85, wparam=0xbe76, lparam=0x0, unicode=0x0) [message.c:1106] in libuser32.so) (ebp=40419c74) 153 0x405f99c6 (SendMessageTimeoutA+0xea(hwnd=0x1002a, msg=0x85, wparam=0xbe76, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x40419cf4, hwnd=0x1002a) [message.c:1502] in libuser32.so) (ebp=40419ccc) 154 0x405f9b1f (SendMessageA+0x33(hwnd=0x1002a, msg=0x85, wparam=0xbe76, lparam=0x0) [message.c:1547] in libuser32.so) (ebp=40419cf8) 155 0x405fc29c (begin_ncpaint+0x90(hwnd=0x1002a) [painting.c:116] in libuser32.so) (ebp=40419d24) 156 0x405fc3a9 (BeginPaint+0x6d(hwnd=0x1002a, lps=0x40419da8) [painting.c:157] in libuser32.so) (ebp=40419d64) 157 0x50023575 (winword.exe.PvAllocStack+0x105e2 in D:\Program\office95\Winword\winword.exe) (ebp=40419de8) 158 0x40656257 (WINPROC_wrapper+0x17 in libuser32.so) (ebp=40419e0c) 159 0x406562ed (WINPROC_CallWndProc+0x8d(proc=0x50023491, hwnd=0x1002a, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:167] in libuser32.so) (ebp=40419e3c) 160 0x4065b7a6 (WINPROC_CallProc32WTo32A+0x8a(func=0x50023491, hwnd=0x1002a, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2438] in libuser32.so) (ebp=40419e64) 161 0x4065bc38 (CallWindowProcW+0x88(func=0x409b090e, hwnd=0x1002a, msg=0xf, wParam=0x0, lParam=0x0) [winproc.c:2645] in libuser32.so) (ebp=40419e8c) 162 0x405f8dce (call_window_proc+0xce(hwnd=0x1002a, msg=0xf, wparam=0x0, lparam=0x0, unicode=0x1) [message.c:1102] in libuser32.so) (ebp=40419edc) 163 0x405f986d (SendMessageTimeoutW+0xdd(hwnd=0x1002a, msg=0xf, wparam=0x0, lparam=0x0, flags=0x0, timeout=0xffffffff, res_ptr=0x40419f58) [message.c:1454] in libuser32.so) (ebp=40419f30) 164 0x405f9adf (SendMessageW+0x33(hwnd=0x1002a, msg=0xf, wparam=0x0, lparam=0x0) [message.c:1536] in libuser32.so) (ebp=40419f5c) 165 0x40644b9c (RDW_Paint+0xbc(wndPtr=0x40345d6c, hrgn=0x0, flags=0x180, ex=0x0) [painting.c:599] in libuser32.so) (ebp=40419f90) 166 0x406450d5 (RedrawWindow+0x3b1(hwnd=0x1002a, rectUpdate=0x0, hrgnUpdate=0x0, flags=0x180) [painting.c:787] in libuser32.so) (ebp=40419ffc) 167 0x40645129 (UpdateWindow+0x21(hwnd=0x1002a) [painting.c:802] in libuser32.so) (ebp=4041a018) Here's a corresponding relay trace: 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_PAINT,wp=00000000,lp=00000000) 0806e328:Call user32.GetWindowLongA(0001002a,00000000) ret=500238be 0806e328:Ret user32.GetWindowLongA() retval=4031ecfc ret=500238be 0806e328:Call user32.BeginPaint(0001002a,40524d1c) ret=50023575 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_NCPAINT,wp=00001abe,lp=00000000) 0806e328:Call user32.GetWindowLongA(0001002a,00000000) ret=500238be 0806e328:Ret user32.GetWindowLongA() retval=4031ecfc ret=500238be 0806e328:Call user32.DefWindowProcA(0001002a,00000085,00001abe,00000000) ret=500236d3 0806e328:Call x11drv.GetDC(0001002a,0000091c,00001abe,00050093) ret=4062f66c 0806e328:Call x11drv.SetDeviceClipping(4033f59c) ret=40702c4b 0806e328:Ret x11drv.SetDeviceClipping() retval=00000000 ret=40702c4b 0806e328:Ret x11drv.GetDC() retval=00000001 ret=4062f66c 0806e328:Call x11drv.SetDeviceClipping(4033f59c) ret=40702c4b 0806e328:Ret x11drv.SetDeviceClipping() retval=00000000 ret=40702c4b 0806e328:Call x11drv.SelectObject(4033f59c,000000e6) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=0000008a ret=4070f7fa 0806e328:Call x11drv.SetDeviceClipping(4033f59c) ret=40702c4b 0806e328:Ret x11drv.SetDeviceClipping() retval=00000000 ret=40702c4b 0806e328:Call x11drv.SelectObject(4033f59c,00000000) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=00000000 ret=4070f7fa 0806e328:Call x11drv.SelectObject(4033f59c,0000006e) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=0000006e ret=4070f7fa 0806e328:Call x11drv.GetDeviceCaps(4033f59c,00000022) ret=407057c8 0806e328:Ret x11drv.GetDeviceCaps() retval=000039f7 ret=407057c8 0806e328:Call x11drv.SelectObject(4033f59c,000000a2) ret=4070f6f9 0806e328:Ret x11drv.SelectObject() retval=00000001 ret=4070f6f9 0806e328:Call x11drv.SelectObject(4033f59c,0000008a) ret=4070f7fa 0806e328:Ret x11drv.SelectObject() retval=000000e6 ret=4070f7fa 0806e328:Call x11drv.SetBkColor(4033f59c,00ffffff) ret=40705846 0806e328:Ret x11drv.SetBkColor() retval=00ffffff ret=40705846 0806e328:Call x11drv.SetTextColor(4033f59c,00000000) ret=407058da 0806e328:Ret x11drv.SetTextColor() retval=00000000 ret=407058da 0806e328:Ret user32.DefWindowProcA() retval=00000000 ret=500236d3 0806e328:Call user32.UpdateWindow(0001002a) ret=500236e8 0806e328:Call x11drv.MsgWaitForMultipleObjectsEx(00000001,405247bc,00000000,000000ff,00000000) ret=4063ebcd 0806e328:Ret x11drv.MsgWaitForMultipleObjectsEx() retval=00000000 ret=4063ebcd 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_PAINT,wp=00000000,lp=00000000) 0806e328:Call user32.GetWindowLongA(0001002a,00000000) ret=500238be 0806e328:Ret user32.GetWindowLongA() retval=4031ecfc ret=500238be 0806e328:Call user32.BeginPaint(0001002a,405246e8) ret=50023575 0806e328:Call window proc 0x50023491 (hwnd=0001002a,msg=WM_NCPAINT,wp=00001ac6,lp=00000000) Cheers, Nicke -- -[ nkarlsso(a)abo.fi ]- Seek simplicity, and distrust it. (A. Whitehead)

1 0

Re: common controls updown patch
by David Elliott 19 Jan '02

19 Jan '02

On 2002.01.19 04:37 Shane Shields wrote: > On Saturday 19 January 2002 12:23, you wrote: > > to realize that almost no other programming language does things like > > BASIC. > > you got that right! > > > Might I suggest Python if you are in the process of learning > programming. > > isnt programming a never ending learning experience? > Oh yeah it is. :-) > > Python is an extremely elegant language, interfaces well with C code, > and > > at the moment i am really concentrating on C. most of my C experience is > with > STL which again forces a different mind set. but once i clean my mind of > misconceptions then i can really start doing things ;-) > Don't forget, C++ and C are two different languages no matter how much all the marketing suggests that they aren't. They are close, but not quite the same. Wine is all C code with no C++ code. There have been several times when I wished Alexandre would accept C++ code into the source tree. The Windows API is fairly heavily object oriented with a C interface. Sometimes it would seem to make sense to actually use an OO language to do the OO programming. But in reality C can be easily coaxed into an OO programming style even though it is a functional language. As for Python... well, I'd really suggest taking a look at it. I was of the mindset that C and C++ were so great why bother with anything else. Then earlier last year I took a look at Python and was absolutely amazed. Looking at python code will help you out with the core concepts of programming in any lanuage. That specifically includes C and C++. Python just lends itself to good programming style. Of course any bad progrmamer can still write a bad program in it though. > > has several GUI toolkits. I think the default toolkit is Tk (yuk) but > > what do you think of QT (KDE's gui) > Well, I have mixed feelings about it. I dislike the fact that you must run all of your code through the MOC to compile it. My understanding of this is that it is done so that the event system can pass pointers to the various objects around. I think wxWindows has a by far more elegant event system. For ease of programming along with power I don't think you can beat wxWindows. wxWindows also has a non-STL but still typesafe implementation of lists and arrays! Basically all you have to do is declare that you're going to need a list or array that holds items of "SomeType" and you give it a name such as "SomeTypeList" (can be called anything though). I am thoroughly impressed with the thought that has gone into this toolkit. Plus writing to it means you get Windows, Linux, and Mac (mac support is beta) for free. This was an instant sell for my boss, which made me happy because I really didn't feel like screwing with the beast that is MFC. As for some of the other toolkits. GTK is nice and they did a really good job hacking OO code into C, a non-OO language. Supposedly this helps them because it makes it easier to do language bindings. Maybe when they started, yes. If I were to write GTK today I would do it in C++. GNU C++ has come a long way and GCC 3.0.3 is a very nice compiler. I am using linux-cross-mingw32 GCC 3.0.3 along with wxWindows to write a GUI app for work and it has been going great. The only gripe I have is that GCC takes a very long time to compile what is fairly minimal C++ code. This is on an Athlon 1.4 Ghz machine! I have watched the GCC2.96 from RH compile C code on the same machine faster than I can figure out what the hell its compiling. Took like 10 minutes to build the GCC3.0.3 cross compiler with it after I spent much longer than that fixing the bugs in the GCC3.0.3 source. > > The general form is booleanexpression?then:else > > things like that would never occur to the basic mind (there are two forms > of > basic mind if you think about it) ;-) > Yeah, I tripped over that one many a time. Eventually I started using it frequently because in many cases it makes the code so much more readable. And with C++ it's almost a requirement that you use it sometimes. > > > To drink the WINE of success you must first seek the > > > sayings of source. > > > > hehe.. how true. Do you know the author of that quote? We should put > it > > on the webpage. > > yes i know the author...........and its me! :-) If you want you can put > it on > the web page (cool!) > hehe.. thought so, I just wondered if it was a paraphrase of some other more well known quote. Anyway... this is getting to be offtopic and this message barely has anything to do with Wine, so if you reply and it doesn't have anything at all to do with Wine, please send directly. -Dave

1 0

Re: common controls updown patch
by Shane Shields 19 Jan '02

19 Jan '02

On Thursday 17 January 2002 4:13, you wrote: > The remainder of any even number divided by two is 0, the remainder of any > odd number divided by two is 1. > > Knowing this doesn't: > > len+=(len%2); > > make more sense. Leave the comment as is for clarity if you wish. > > -Dave thanks Dave, its also a lot more elegant and will work faster too. i will generate a patch for it to be applied on top of the first one. as my biggest strength is visual basic things like this dont come to me straight away. im still trying to work out what this means (delta < 0 ? 1 : -1) its got me stuck. im currently looking at the wine install script as it doesnt find the windows registry when installing wine with an existing windows installation. Shane To drink the WINE of success you must first seek the sayings of source. __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

2 2

Re: _UNICODE vs UNICODE
by Francois Gouget 19 Jan '02

19 Jan '02

On Fri, 18 Jan 2002, Andriy Palamarchuk wrote: > Using macro name "UNICODE" instead of "_UNICODE" is a > typo, right? No, not necessarily. Windows has both and dinput.h, for instance, uses UNICODE, not _UNICODE. But I have no idea why they have two. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

2 1

Re: C testing framewok. Updated. SystemParametersInfo unit test.
by Andriy Palamarchuk 18 Jan '02

18 Jan '02

Alexandre Julliard wrote: > You don't need to > set the variable when running make test, but you have the possibility > to set it if you want to override the default for whatever reason. > I don't see why we should impose a less flexible solution that won't > be more robust anyway. Alexandre, by your suggestion I implemented the switch, but left automated platform detection in place. Platform detection will work when the environment variable is not set or set to unknown value. Can you suggest more reliable way to detect if test runs on Wine? One more important change in C framework is support of Unicode in testing. Dimitry, can you look at it? See how it is used in sysparams.c, search for "has_unicode" function call. I'm interested in your comments. Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

5 14

Re: wine-patches@winehq.com
by Alexandre Julliard 18 Jan '02

18 Jan '02

Shane Shields <locutusenterprises(a)yahoo.com> writes: > just a little improvement suggested by dave elliot on > the updown.c patch > that i posted before. it doesnt change the > functionality but is more elegant > coding. to be installed on top of the previous patch. I must confess I still don't see the reason for your patch in the first place. Unless I missed something the behavior should be exactly the same before and after your change (I mean the first one, not the cosmetic improvement). What is it supposed to fix? -- Alexandre Julliard julliard(a)winehq.com

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel