wine-devel

wine-devel@winehq.org

2 participants
84471 discussions

Re: C testing framewok. Updated. SystemParametersInfo unit test.
by Andriy Palamarchuk 18 Jan '02

18 Jan '02

Alexandre Julliard wrote: > It's not enough to simply pass converted ASCII strings > to the W functions, > we have to test with real Unicode to check for > lossy W->A->W conversions, surrogate handling, non-spacing chars, etc. Aren't all these requirements just additional to testing with converted ASCII strings? At least we'll have minimal tests of W functions without spending much time. One more advantage in creation TCHAR-portable code - we can eventually test with it multibyte character set support. We still can have specific A and W tests sections, enclosed in #ifdef _UNICODE. Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Send FREE video emails in Yahoo! Mail! http://promo.yahoo.com/videomail/

1 0

XP registry
by Eric Pouech 18 Jan '02

18 Jan '02

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/appendix/h… this may answer the latest question from Andi A+ --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle ____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

1 0

Wine "Please Report" Error
by Scott Sipe 18 Jan '02

18 Jan '02

Hi, I'm running wine20011226 compiled on FreeBSD 4.5 rc recent build, built wine from the ports collection. When I start wine, it says: scott@dragon> wine Could not stat /mnt/fd0 (No such file or directory), ignoring drive A: err:reg:_nt_dump_lf unknown node id 0x686c, please report! err:reg:_nt_dump_lf unknown node id 0x686c, please report! err:reg:_nt_dump_lf unknown node id 0x686c, please report! Wine release 20011226 So, what should I report? thanks, Scott

2 1

License problem with files in dlls/icmp/
by Ilja Kamps 18 Jan '02

18 Jan '02

It appaers that files under dlls/icmp/ are licensed under the BSD license and not the X11 license, this might be a problem as wine does not honor the advertisment part and also it makes wine GPL incompaitible, I would consider this a serious problem. Either we honor the advertisment part and note that wine is not directly GPL compaitible (GPL doesn't allow such texts) or we reimplement that dll. I hope I got it right.

3 3

RE: What are you really aiming to do with winetest?
by Patrik Stridvall 17 Jan '02

17 Jan '02

> Patrik Stridvall <ps(a)leissner.se> writes: > > > So what you basicly want is something like: > > > > my %return_type_exceptions; > > > > $return_type_exceptions{"foo"} = { > > Bar => "str", > > Baz => "ptr" > > }; > > > > $return_type_exceptions{"bar"} = { > > Foo => "str" > > }; > > > Yes, that would work fine for now. OK. I made a script (adapted winapi_extract) to do this (attached). Output attached as well, but you can regenerate it by doing tools/winapi/winapi_extract in the topsrcdir. I realized that when I was at it I could output the argument types as well and thus having a hash table that can be given to wine::declare directly. Here is also a script make_modules that generates modules to use this directly and thus there is no need to any spec2pm any longer. However I'm not postive that we want to have seperate include for constants and functions. Perhaps it would be better if people used to C could just do use winuser; instead of #include "winuser.h" and not have to do any additional use user32; as well. Oh, well, I don't really have any strong feelings in any direction. But it would be easier if you told me how you wanted it. Oh BTW: What is your opinion on having special Perl adapted versions of some functions like: sub GlobalGetAtomNameA { my $atom = shift; my $buffer = "\0" x 256; # FIXME: Fixed buffer length my $length = &kernel32::GlobalGetAtomNameA($atom, \$buffer, length($buffer)); return substr($buffer, 0, $length); } Should we have them as the default imported function in say kernel32.pm or should each test that wants a easier to use version declare it in the test itself.

2 1

HEAP_ZERO_MEMORY was: Re: Prevent passing uninitialised string to WARN
by Uwe Bonnes 17 Jan '02

17 Jan '02

>>>>> "Medland," == Medland, Bill <Bill.Medland(a)accpac.com> writes: Medland,> Bill Medland (medbi01(a)accpac.com) Prevent trying to handle Medland,> uninitialised memory as a string. Medland,> Index: wine/loader/module.c Medland,> =================================================================== Medland,> RCS file: /home/wine/wine/loader/module.c,v retrieving Medland,> revision 1.144 diff -u -r1.144 module.c --- Medland,> wine/loader/module.c 2001/12/20 00:19:42 1.144 +++ Medland,> wine/loader/module.c 2002/01/17 13:45:52 @@ -1379,6 +1379,7 @@ Medland,> filename = HeapAlloc ( GetProcessHeap(), 0, MAX_PATH + 1 ); Medland,> if ( !filename ) return NULL; Medland,> + *filename = 0; /* Just in case Wouldn't HEAP_ZERO_MEMORY be a better argument to HeapAlloc then 0? This would apply to many places. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 2

Re: Filesystem Regression Test, was: Re: RESEND: Fix return value ...
by Dmitry Timoshkov 17 Jan '02

17 Jan '02

"Andriy Palamarchuk" <apa3a(a)yahoo.com> wrote: > For me it looks like we need to keep both tests > together, because we'll want to compare results of W > and A versions. One more advantage - it is easier to > make changes because both versions are in one place. Then we should invent some approach to easily compare two strings: ANSI and Unicode. > What approach we will use with UNICODE tests on Win95 > platform? There is no difference in API between emulated Windows versions from the Wine point of view. -- Dmitry.

2 3

Re: DOSFS_ToFCBFormat Bug Fix
by Ove Kaaven 17 Jan '02

17 Jan '02

On Sun, 13 Jan 2002 ccrayne(a)crayne.org wrote: > Change Log: > files/dos_fs.c > ccrayne(a)crayne.org > Fixed bug in DOSFS_ToFCBFormat which caused "*" to parse as "*." instead > of as "*.*" This sounds like intended behaviour. Under real DOS, "*" really means "*.". The user must type "*.*" to get all files. (This is the stuff that used to confuse DOS users converting to Linux - "*.*" no longer meant all files...) Also, your mailer seems to mangle your patches. You may want to attach them instead of pasting them to avoid that.

4 4

Re: user32.TrackMouseEvent
by David Elliott 17 Jan '02

17 Jan '02

On 2002.01.15 11:37 Rein Klazes wrote: > hi, > > to implement user32.TrackMouseEvent: > > Changelog: > dlls/comctl32/ : commctrl.c > dlls/user/ : user32.spec > windows/ : input.c > include/ : winuser.h > > Move the implementation of comctl32._TrackMouseEvent to > user32.TrackMouseEvent and call this function in accordance > with the specs. > Man, it must not be my week. I did the exact same thing two days ago ('cept I put the TME stuff into windows/tme.c instead of adding it to input.c). Was part of making IE work as mentioned in my last mail regarding the stumbling block I hit with DPA that Aric has figured out. That'll teach me to leave patches sitting around in my tree for a couple days. -Dave

1 0

Re: common controls updown patch
by David Elliott 17 Jan '02

17 Jan '02

On 2002.01.14 14:45 Shane Shields wrote: > hi all > > this is just a little patch to fix the UPDOWN_GetArrowRect function where > the > midpoint is calculated by adding 1 to odd numbers. before it just added 1 > to > every number now it tests for odd numbers before adding. > > Shane > > Thanks Dan for the tips > > Changelog: > > Shane Shields locutus(a)all.at > > updown.c UPDOWN_GetArrowRect function > added odd number checking > --- ./dlls/comctl32/updown.c.orig Mon Jan 14 20:35:07 2002 > +++ ./dlls/comctl32/updown.c Sun Jan 13 17:28:18 2002 > @@ -1,4 +1,4 @@ > -/* > +/* > * Updown control > * > * Copyright 1997 Dimitrie O. Paun > @@ -176,14 +176,16 @@ > * round the uneven numbers by adding 1. > */ > if (dwStyle & UDS_HORZ) { > - len = rect->right - rect->left + 1; /* compute the width */ > + len = rect->right - rect->left; /* compute the width */ > + if (len % 2 != 0 ) len ++; /* if not an even number then add 1 */ > if (incr) > - rect->left = rect->left + len/2; > + rect->left = rect->left + len/2; > else > rect->right = rect->left + len/2; > } > else { > - len = rect->bottom - rect->top + 1; /* compute the height */ > + len = rect->bottom - rect->top; /* compute the height */ > + if (len % 2 != 0 ) len ++; /* if not an even number then add 1 */ > if (incr) > rect->bottom = rect->top + len/2; > else > The remainder of any even number divided by two is 0, the remainder of any odd number divided by two is 1. Knowing this doesn't: len+=(len%2); make more sense. Leave the comment as is for clarity if you wish. -Dave

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-devel