On Fri Jun 9 11:59:33 2023 +0000, Huw Davies wrote:
> There's a lot of new things going on here and in subsequent commits.
> They need to be split like you've just done for the main_loop bits.
> It may be better to reduce the scope of this MR to just the main_loop stuff.
Agreed, `Initialize()` carries a lot of stuff with it and as a result the changes lines are way too many.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35279
> (and in the next commit)
I'm wondering why the OSS failure was not reported, are we not testing for *BSD on CI?
> But also there seem to be a lot of small pointless differences (mainly in whitespace) between the new implementations in the non-pulse drivers and the existing one in the pulse driver. That means the merge commits have unnecessary changes.
Right, the non-pulse drivers also have a different code style (e.g. opening bracket attached to `if`) I would like to adhere to, for consistency.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35278