June 2023 - wine-gitlab

[PATCH v3 0/7] MR216: vkd3d: Prepare for tiled resource support.
by Conor McCarthy (＠cmccarthy) 09 Jun '23

09 Jun '23

-- v3: vkd3d: Append CopyTileMappings() commands to the command queue op array. vkd3d: Append UpdateTileMappings() commands to the command queue op array. vkd3d: Add missing const attributes to ID3D12CommandQueue::UpdateTileMappings() parameters. vkd3d: Validate plane count for tiled textures. vkd3d: Validate tiled resources tier for 3D textures. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/216

3 15

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) 09 Jun '23

09 Jun '23

Huw Davies (@huw) commented about dlls/mmdevapi/client.c: > extern void sessions_unlock(void) DECLSPEC_HIDDEN; > > +extern HRESULT get_audio_session(const GUID *sessionguid, IMMDevice *device, UINT channels, > + struct audio_session **out) DECLSPEC_HIDDEN; > extern struct audio_session_wrapper *session_wrapper_create(struct audio_client *client) DECLSPEC_HIDDEN; > > +static HANDLE main_loop_thread; > + > +void stop_main_loop(void) > +{ > + if (main_loop_thread) { > + WaitForSingleObject(main_loop_thread, INFINITE); > + CloseHandle(main_loop_thread); > + } > +} > + There's a lot of new things going on here and in subsequent commits. They need to be split like you've just done for the main_loop bits. It may be better to reduce the scope of this MR to just the main_loop stuff. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35263

1 0

Re: [PATCH v4 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Huw Davies (＠huw) 09 Jun '23

09 Jun '23

Huw Davies (@huw) commented about dlls/winecoreaudio.drv/mmdevdrv.c: > + > DeleteCriticalSection(&g_sessions_lock); > break; > } > return TRUE; > } > > +static DWORD CALLBACK main_loop_func(void *event) > +{ > + struct main_loop_params params; > + > + SetThreadDescription(GetCurrentThread(), L"coreaudio_main"); > + > + params.event = event; > + > + ALSA_CALL(main_loop, &params); ```suggestion:-0+0 UNIX_CALL(main_loop, &params); ``` (and in the next commit) But also there seem to be a lot of small pointless differences (mainly in whitespace) between the new implementations in the non-pulse drivers and the existing one in the pulse driver. That means the merge commits have unnecessary changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027#note_35262

1 0

[PATCH v3 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- v3: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

3 9

[PATCH v2 0/7] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- v2: wineoss: Use mmdevapi's AudioClient's Initialize. winecoreaudio: Use mmdevapi's AudioClient's Initialize. winealsa: Use mmdevapi's AudioClient's Initialize. winepulse: Move AudioClient's Initialize into mmdevapi. wineoss: Implement main_loop in unixlib. winecoreaudio: Implement main_loop in unixlib. winealsa: Implement main_loop in unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

3 11

[PATCH 0/4] MR3027: wine{alsa,coreaudio,oss,pulse}: Move AudioClient's Initialize into mmdevapi.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3027

4 8

[PATCH v8 0/1] MR2941: Prevent NULL pointer in editor_ensure_visible when retrieving row from cursor.
by Santino Mazza (＠tati1454) 09 Jun '23

09 Jun '23

This is to prevent NULL pointers when creating a TextService with no rows in it. This NULL pointers doesn't happen when creating a richedit windows, because it sets an empty text when the richedit window procedure handles the WM_CREATE event. -- v8: riched20: Call ME_UpdateRepaint instead of editor_ensure_visible in set_selection. https://gitlab.winehq.org/wine/wine/-/merge_requests/2941

3 2

[PATCH 0/5] MR3028: Add more tests for IShellFolder_ParseDisplayName() and add localized strings for CLSID_Printers and CLSID_Internet.
by Jactry Zeng (＠jactry) 09 Jun '23

09 Jun '23

[5/5] is actually not relevant to this serial, but my next serial will depend on it, so I submit it by the way first, so that I can avoid maintaining too many patches locally. :D -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3028

2 5

[PATCH 0/1] MR3008: mmdevapi: Handle CreateThread() failure in AudioClient's Start.
by Davide Beatrici (＠davidebeatrici) 09 Jun '23

09 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3008

4 3

[PATCH v2 0/1] MR3020: riched20: Update paragraph position in marked tree.
by Daniel Lehman (＠dlehman25) 09 Jun '23

09 Jun '23

nCharOfs is the key for paragraphs added to the marked tree If it is updated, re-add the entry to update its position -- v2: riched20: Update paragraph position in marked tree. https://gitlab.winehq.org/wine/wine/-/merge_requests/3020

3 3

2025

2024

2023

2022

wine-gitlab June 2023