On Thu May 22 12:47:26 2025 +0000, Hans Leidekker wrote:
> That was my first guess too :) Perhaps I'm missing something but this
> appears to encrypt in-place. It seems to me that you would need to pass
> a separate SECBUFFER_STREAM buffer that is large enough to hold data + token.
Shouldn't also work {NULL,0} as a SECBUFFER_STREAM output?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104216
Windows uses a smaller alignment than gstreamer for some formats, for
example NV12. This means we cannot use MFCalculateImageSize() to get the
output sample size. Commit 7b79e3a87b1e switched to calling it instead of
GetOutputStreamInfo() to fix some game bugs.
--
v2: mfplat/tests: Add NV12 650 x 850 to image_size_tests.
mf/tests: Add a video processor NV12 test with a width alignment of 2.
https://gitlab.winehq.org/wine/wine/-/merge_requests/8034
On Thu May 22 12:41:19 2025 +0000, Dmitry Timoshkov wrote:
> I was mentioning the part about using SECBUFFER_STREAM in
> DecryptMessage(). It was my guess that EncryptMessage() is supposed to
> support the mirroring logic of using SECBUFFER_DATA as input and
> SECBUFFER_STREAM as output buffers.
That was my first guess too :) Perhaps I'm missing something but this appears to encrypt in-place. It seems to me that you would need to pass a separate SECBUFFER_STREAM buffer that is large enough to hold data + token.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104208
On Thu May 22 12:32:42 2025 +0000, Hans Leidekker wrote:
> They don't pass a SECBUFFER_STREAM buffer in that sample.
I was mentioning the part about using SECBUFFER_STREAM in DecryptMessage(). It was my guess that EncryptMessage() is supposed to support the mirroring logic of using SECBUFFER_DATA as input and SECBUFFER_STREAM as output buffers.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104207
On Thu May 22 11:10:27 2025 +0000, Dmitry Timoshkov wrote:
> Why not? EncryptMessage() would get SECBUFFER_DATA as input and
> SECBUFFER_STREAM as output buffers.
They don't pass a SECBUFFER_STREAM buffer in that sample.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/8020#note_104206