- wine-gitlab - winehq.org

[PATCH 0/1] MR9360: d3dx9_36/tests: Add end marker to the invalid tests (ASan).
by Bernhard Übelacker (＠bernhardu) 04 Nov '25

04 Nov '25

This is to avoid reading beyond the intput buffer in `get_shader_semantics`. [Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=160604) <details> <summary>ASan report details</summary> ``` ================================================================= ==1268==ERROR: AddressSanitizer: global-buffer-overflow on address 0x000140212064 at pc 0x6ffffad7854b bp 0x7ffffe1ff740 sp 0x7ffffe1ff788 READ of size 4 at 0x000140212064 thread T0 #0 0x6ffffad7854a in get_shader_semantics .../wine/dlls/d3dx9_36/shader.c:2842 #1 0x6ffffad77c3b in D3DXGetShaderInputSemantics .../wine/dlls/d3dx9_36/shader.c:3008 #2 0x0001400c9006 in test_shader_semantics .../wine/dlls/d3dx9_36/tests/shader.c:6754 #3 0x0001400c1925 in func_shader .../wine/dlls/d3dx9_36/tests/shader.c:6983 #4 0x000140127d92 in run_test .../wine/include/wine/test.h:768 #5 0x00014012779b in main .../wine/include/wine/test.h:888 #6 0x000140129a6a in mainCRTStartup .../wine/dlls/msvcrt/crt_main.c:62 #7 0x6fffffc67a74 in BaseThreadInitThunk (C:\windows\system32\kernel32.dll+0x178027a74) #8 0x6fffffde06a6 in RtlUserThreadStart (C:\windows\system32\ntdll.dll+0x1700506a6) 0x000140212064 is located 60 bytes before global variable 'test_shader_semantics.vs_1_1' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6650' (0x0001402120a0) of size 116 0x000140212064 is located 28 bytes before global variable 'test_shader_semantics.invalid_3' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6646' (0x000140212080) of size 4 0x000140212064 is located 0 bytes after global variable 'test_shader_semantics.invalid_2' defined in '.../wine/dlls/d3dx9_36/tests/shader.c:6642' (0x000140212060) of size 4 SUMMARY: AddressSanitizer: global-buffer-overflow .../wine/dlls/d3dx9_36/shader.c:2842 in get_shader_semantics Shadow bytes around the buggy address: 0x000140211d80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211e00: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211e80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211f00: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 0x000140211f80: f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 f9 =>0x000140212000: f9 f9 f9 f9 f9 f9 f9 f9 04 f9 f9 f9[04]f9 f9 f9 0x000140212080: 04 f9 f9 f9 00 00 00 00 00 00 00 00 00 00 00 00 0x000140212100: 00 00 04 f9 f9 f9 f9 f9 00 00 00 00 00 00 00 00 0x000140212180: 00 00 00 00 00 00 04 f9 f9 f9 f9 f9 00 00 00 00 0x000140212200: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x000140212280: 00 00 00 04 f9 f9 f9 f9 00 00 00 00 f9 f9 f9 f9 Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==1268==ABORTING ``` </details> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9360

3 3

[PATCH 0/2] MR9311: dwrite, win32u: Stop supporting very old FreeType versions.
by Brendan Shanks (＠bshanks) 04 Nov '25

04 Nov '25

The new requirement is v2.5.0 (released in June 2013). If we wanted to go farther, the next stop would be v2.8.1 (released September 2017). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9311

4 6

[PATCH v19 0/11] MR9209: vccorlib140: Implement Platform::Exceptions.
by Vibhav Pant (＠vibhavp) 04 Nov '25

04 Nov '25

-- v19: vccorlib140: Implement __abi_translateCurrentException. vccorlib140: Throw exceptions on error paths. vccorlib140: Add Platform::Exception::CreateException() implementation. vccorlib140: Add Platform::Exception::Message::get() implementation. vccorlib140: Add Platform::COMException constructor implementation. vccorlib140: Add Platform::Exception(HSTRING) constructor implementation. msvcrt: Sync cxx.h file with msvcp90 and vccorlib140. vccorlib140: Add Platform::Exception constructor implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/9209

5 15

[PATCH v3 0/4] MR9354: ntdll: Fix a couple of epilogue unwind issues on x64.
by Paul Gofman (＠gofman) 04 Nov '25

04 Nov '25

-- v3: ntdll: Handle 0xff jump opcode in epilogue unwind on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/9354

2 5

[PATCH v2 0/4] MR9354: ntdll: Fix a couple of epilogue unwind issues on x64.
by Paul Gofman (＠gofman) 04 Nov '25

04 Nov '25

-- v2: ntdll: Handle 0xff jump opcode in epilogue unwind on x64. https://gitlab.winehq.org/wine/wine/-/merge_requests/9354

2 5

[PATCH 0/4] MR9348: comctl32/imagelist: Pre-multiply rgb by the alpha channel in add_dib_bits for v6.
by Ziqing Hui (＠zhui) 04 Nov '25

04 Nov '25

We used to do this when drawing the image. But our tests show that for v6, the image bitmaps have been alpha pre-multiplied before drawing. So we should do this when adding images. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9348

3 6

[PATCH v10 0/2] MR9351: msvcrt: Correctly handle refcounts for WinRT exceptions
by Vibhav Pant (＠vibhavp) 04 Nov '25

04 Nov '25

Follow up to https://gitlab.winehq.org/wine/wine/-/merge_requests/9209#note_120396 -- v10: ucrtbase: Add __C_specific_handler tests. msvcrt: Call the destructor for C++ exceptions in __C_specific_handler. https://gitlab.winehq.org/wine/wine/-/merge_requests/9351

4 3

[PATCH 0/1] MR9350: shell32: Fix a memory leak issue.
by Zhao Yi (＠Zhaoyi) 04 Nov '25

04 Nov '25

Signed-off-by: Zhao Yi <zhaoyi(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9350

2 2

Re: [PATCH v3 0/2] MR9287: uxtheme: Handle NULL options in DrawThemeTextEx().
by Zhiyi Zhang (＠zhiyi) 04 Nov '25

04 Nov '25

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > + hdc = GetDC(hwnd); > + SetRect(&rect, 0, 0, 1, 1); > + > + hr = DrawThemeTextEx(NULL, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == E_HANDLE, "Got unexpected hr %#lx.\n", hr); > + > + hr = DrawThemeTextEx(htheme, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); > + > + options.dwSize = sizeof(options); > + options.dwFlags = DTT_VALIDBITS; > + options.iFontPropId = TMT_BODYFONT; > + hr = DrawThemeTextEx(htheme, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, &options); > + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); > + > + options.crText = CLR_INVALID; Same here. You should specify DTT_TEXTCOLOR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9287#note_120702

1 0

Re: [PATCH v3 0/2] MR9287: uxtheme: Handle NULL options in DrawThemeTextEx().
by Zhiyi Zhang (＠zhiyi) 04 Nov '25

04 Nov '25

Zhiyi Zhang (@zhiyi) commented about dlls/uxtheme/tests/system.c: > + skip("Theming is inactive.\n"); > + DestroyWindow(hwnd); > + return; > + } > + > + hdc = GetDC(hwnd); > + SetRect(&rect, 0, 0, 1, 1); > + > + hr = DrawThemeTextEx(NULL, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == E_HANDLE, "Got unexpected hr %#lx.\n", hr); > + > + hr = DrawThemeTextEx(htheme, hdc, 0, 0, L"Wine", -1, DT_CENTER, &rect, NULL); > + ok(hr == S_OK, "Got unexpected hr %#lx.\n", hr); > + > + options.dwSize = sizeof(options); > + options.dwFlags = DTT_VALIDBITS; You're not supposed to use DTT_VALIDBITS here. DTT_VALIDBITS means all member values are valid. See https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/ns-uxtheme-dtto…. You should specify DTT_FONTPROP here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9287#note_120701

1 0

2025

2024

2023

2022

wine-gitlab