- wine-gitlab - winehq.org

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Bernhard Übelacker (＠bernhardu) 31 Aug '25

31 Aug '25

On Sun Aug 31 11:46:59 2025 +0000, Vibhav Pant wrote: > Yes, I think `IPropertyValueStatics::CreateString` should use > `WindowsDuplicateString`. Could you replace the code > [here](https://gitlab.winehq.org/wine/wine/-/blob/1d1e5fb3e51b2acb0143e86c16… > with > ```c > { > HSTRING value; > HRESULT hr; > TRACE("iface %p, value %s, property_value %p.\n", iface, > debugstr_hstring(value_str), property_value); > *property_value = NULL; > if (FAILED(hr = WindowsDuplicateString(value_str, &value))) return hr; > create_primitive_property_value_iref(PropertyType_String, > irefs.hstring_iface.lpVtbl, iref_hstring_vtbl); > } > ``` > and see if it resolves the issue? I'll create an MR in that case. Thanks for looking into it. By replacing the body of property_value_statics_CreateString with above version (and renaming the parameter value to value_str) ASan stays silent and the test succeeds here. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114358

1 0

[PATCH v8 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) 31 Aug '25

31 Aug '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v8: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v7 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) 31 Aug '25

31 Aug '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v7: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH v6 0/13] MR8829: windows.media.playback.mediaplayer: Return S_OK from IMediaPlayer2::get_SystemMediaTransportControls().
by Mohamad Al-Jaf (＠maljaf) 31 Aug '25

31 Aug '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=58631 -- v6: windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::put/get_Thumbnail(). windows.media.mediacontrol: Implement ISystemMediaTransportControls::put/get_IsStopEnabled(). windows.media.mediacontrol: Stub ISystemMediaTransportControlsDisplayUpdater::ClearAll(). windows.media.mediacontrol: Stub ISystemMediaTransportControls::add/remove_ButtonPressed(). windows.media.playback.mediaplayer: Implement IMediaPlayer2::get_SystemMediaTransportControls(). windows.media.playback.mediaplayer: Add IMediaPlayer2 stub. include: Add IMediaPlayer2 definition. windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current(). windows.media.playback.mediaplayer: Implement IActivationFactory::ActivateInstance(). windows.media.playback.backgroundmediaplayer: Add IBackgroundMediaPlayerStatics stub. include: Add IMediaPlayer definition. windows.media.playback.backgroundmediaplayer: Add stub dll. include: Add windows.media.playback.idl. https://gitlab.winehq.org/wine/wine/-/merge_requests/8829

2 13

[PATCH 0/2] MR8861: shell32: Accept CSIDL values in SHBrowseForFolderW().
by Attila Fidan (＠atticf) 31 Aug '25

31 Aug '25

This fixes an access violation when clicking the button to browse for an installation directory in some installers using the BURIKO (BGI/Ethornell) engine. The affected applications call `SHBrowseForFolderA(&bi)` with `bi.pidlRoot` being 0x11, which causes wine to dereference 0x11 inside InitializeTreeView. On native, this opens the treeview from My Computer. 0x11 is the CSIDL value for My Computer, and passing any pidlRoot from 0 to 2^16 will not crash on native like resource IDs. If an invalid folder value is used then native returns 0 without showing a window. If I delete the My Pictures folder then use `CSIDL_MYPICTURES`, the folder gets recreated. None of this works if `BIF_NEWDIALOGSTYLE` is used, native crashes with access violation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8861

2 3

[PATCH v8 0/7] MR8857: Update fr.po
by Allan Rémy (＠remy) 31 Aug '25

31 Aug '25

-- v8: Resource pending for “Open with” on file association https://gitlab.winehq.org/wine/wine/-/merge_requests/8857

2 7

[PATCH 0/1] MR8862: mmdevapi/tests: Rewrite capturing tests.
by Giovanni Mascellani (＠giomasce) 31 Aug '25

31 Aug '25

I began working on this to address some flakyness (see e.g. https://gitlab.winehq.org/wine/wine/-/jobs/183916), and eventually I ended up rewriting `test_capture()` because the previous implementation looked somewhat incomplete. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8862

2 1

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Vibhav Pant (＠vibhavp) 31 Aug '25

31 Aug '25

On Sun Aug 31 09:30:40 2025 +0000, Bernhard Übelacker wrote: > @vibhavp, in my latest ASan run the vccorlib140:vccorlib tests shows up > with a heap-use-after-free in WindowsGetStringRawBuffer in line 951. Is > `str` supposed to be a new allocation after line 948? > ``` > ==vccorlib140_test.exe==1096==ERROR: AddressSanitizer: > heap-use-after-free on address 0x7f6707c03ba0 at pc 0x6ffffccb8d13 bp > 0x7ffffe1ffa20 sp 0x7ffffe1ffa68 > READ of size 8 at 0x7f6707c03ba0 thread T0 > #0 0x6ffffccb8d12 in WindowsGetStringRawBuffer /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:277:25 > #1 0x000140004458 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:951:15 > 0x7f6707c03ba0 is located 16 bytes inside of 36-byte region [0x7f6707c03b90,0x7f6707c03bb4) > freed by thread T0 here: > #0 0x6ffffe86bb31 in free C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:71:3 > #1 0x6ffffccb8762 in WindowsDeleteString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:154:9 > #2 0x00014000431c in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:939:5 > previously allocated by thread T0 here: > #0 0x6ffffe86bc41 in malloc C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:80:3 > #1 0x6ffffccb844b in alloc_string /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:69:12 > #2 0x6ffffccb825b in WindowsCreateString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:103:10 > #3 0x0001400042c9 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:936:10 > ``` > [full ASan output](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_… Yes, I think `IPropertyValueStatics::CreateString` should use `WindowsDuplicateString`. Could you replace the code [here](https://gitlab.winehq.org/wine/wine/-/blob/1d1e5fb3e51b2acb0143e86c16… with ```c { HSTRING value; HRESULT hr; TRACE("iface %p, value %s, property_value %p.\n", iface, debugstr_hstring(value_str), property_value); *property_value = NULL; if (FAILED(hr = WindowsDuplicateString(value_str, &value))) return hr; create_primitive_property_value_iref(PropertyType_String, irefs.hstring_iface.lpVtbl, iref_hstring_vtbl); } ``` and see if it resolves the issue? I'll create an MR in that case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114348

1 0

[PATCH 0/1] MR8849: cmd: Treat COPY from CON or CON: as ASCII operation.
by Joe Souza (＠JoeS209) 31 Aug '25

31 Aug '25

This should fix the remaining issues in bug #16214. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8849

3 8

Re: [PATCH v10 0/6] MR8831: vccorlib140: Implement support for boxed values (aka IPropertyValue)
by Bernhard Übelacker (＠bernhardu) 31 Aug '25

31 Aug '25

Bernhard Übelacker (@bernhardu) commented about dlls/vccorlib140/tests/vccorlib.c: > + obj = pCreateValue(TYPECODE_STRING, &str); > + WindowsDeleteString(str); > + ok(obj != NULL || broken(obj == NULL), "got obj %p\n", obj); /* Returns NULL on i386 Windows 10. */ > + if (obj) > + { > + type = PropertyType_Empty; > + hr = IPropertyValue_get_Type(obj, &type); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(type == PropertyType_String, "got type %d\n", type); > + str = NULL; > + hr = IPropertyValue_GetString(obj, &str); > + ok(hr == S_OK, "got hr %#lx\n", hr); > + ok(str != NULL, "got str %p\n", str); > + buf = WindowsGetStringRawBuffer(str, NULL); > + ok(buf && !wcscmp(buf, L"foo"), "got buf %s\n", debugstr_w(buf)); > + WindowsDeleteString(str); @vibhavp, in my latest ASan run the vccorlib140:vccorlib tests shows up with a heap-use-after-free in WindowsGetStringRawBuffer in line 951. Is `str` supposed to be a new allocation after line 948? ``` ==vccorlib140_test.exe==1096==ERROR: AddressSanitizer: heap-use-after-free on address 0x7f6707c03ba0 at pc 0x6ffffccb8d13 bp 0x7ffffe1ffa20 sp 0x7ffffe1ffa68 READ of size 8 at 0x7f6707c03ba0 thread T0 #0 0x6ffffccb8d12 in WindowsGetStringRawBuffer /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:277:25 #1 0x000140004458 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:951:15 0x7f6707c03ba0 is located 16 bytes inside of 36-byte region [0x7f6707c03b90,0x7f6707c03bb4) freed by thread T0 here: #0 0x6ffffe86bb31 in free C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:71:3 #1 0x6ffffccb8762 in WindowsDeleteString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:154:9 #2 0x00014000431c in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:939:5 previously allocated by thread T0 here: #0 0x6ffffe86bc41 in malloc C:/llvm-project-main/compiler-rt/lib/asan/asan_malloc_win.cpp:80:3 #1 0x6ffffccb844b in alloc_string /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:69:12 #2 0x6ffffccb825b in WindowsCreateString /home/benutzer/wine-asan-pe/wine/dlls/combase/string.c:103:10 #3 0x0001400042c9 in test_CreateValue /home/benutzer/wine-asan-pe/wine/dlls/vccorlib140/tests/vccorlib.c:936:10 ``` [full ASan output](https://gitlab.winehq.org/bernhardu/wine/-/blob/asan-pe_2025-08-17_… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8831#note_114345

1 0

2025

2024

2023

2022

wine-gitlab