April 2024 - Wine-GitLab - list.winehq.org

[PATCH 0/5] MR775: hlsl: Avoid HLSL_CLASS_OBJECT, part 3.
by Zebediah Figura (＠zfigura) April 10, 2024

April 10, 2024

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/775

2 5

Re: [PATCH v3 0/1] MR761: tests/shader_runner: Report compilation errors on the block's starting line.
by Francisco Casas (＠fcasas) April 9, 2024

April 9, 2024

On Tue Apr 9 22:59:29 2024 +0000, Henri Verbeet wrote: > > > This seems a little fragile. > > > > I don't think it is that fragile, currently we handle directives in 3 > points in run_shader_tests(): > > > > 1. The first switch, where we detect that we stopped reading the block > because a new block starts or the file ended. > > 2. The reading of the tags at the beginning of new blocks. > > 3. The reading of individual lines using a second switch. > > > > We don't need to call update_line_number_context() in 1, and we always > have to call it in 2 so we don't have to worry about forgetting to do so > we add new functionalities. > > > > It is only in 3 that we have to remember to call > update_line_number_context() for the switch cases when we want to update > the line number context for each line instead of presenting it at the > beginning of the block, but even if we forget, the error will be > reported at the beginning of the block because of 2. > Sure, the impact of messing up isn't going to very bad. Fundamentally > though, this commit puts the burden of calling > update_line_number_context() on the "normal" cases instead of on the > exceptional cases. > > > Could we just track the starting line for things touching > "shader_source" and then setup/restore the test context in e.g. compile_shader()? > > > > Here is a patch for that proposal (how I see it), but I find it more complex. > > > > [0001-tests-shader-runner-Report-compilation-errors-on-the.patch](https://gi… > I think that's closer to what I had in mind. How do you feel about [this patch](/uploads/e4b238bc14f76573c5eea824d660402f/patch.diff)? While that patch moves the burden to the _exceptional_ cases, with it we have to do many things for them now: - Set `current_source.start_line = runner->current_line` on 2. - Call `update_line_number_context(runner, source->start_line)` before performing the operations. - Call `update_line_number_context(runner, runner->current_line)` after performing the operations. - Call `clear_shader_source(&current_source)` after the source is stored in the `runner->XX_source` field I still think that only remembering to call `update_line_number_context()` on _normal_ cases is simpler, and not so hard to forget. When implementing new cases, at least I, take a look to other cases in the same switch for reference. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/761#note_67443

1 0

Re: [PATCH v2 0/1] MR770: tests/test-driver: Avoid "head" with negative line count. - approved
by Alexandre Julliard (＠julliard) April 9, 2024

April 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/770

1 0

Re: [PATCH v6 0/1] MR762: ci: Delimit building each commit with a collapsible section. - approved
by Alexandre Julliard (＠julliard) April 9, 2024

April 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/762

1 0

Re: [PATCH v2 0/1] MR763: vkd3d-shader/hlsl: Properly release string buffer on write_atan_or_atan2(). - approved
by Alexandre Julliard (＠julliard) April 9, 2024

April 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/763

1 0

Re: [PATCH v5 0/8] MR757: hlsl: Avoid HLSL_CLASS_OBJECT, part 2. - approved
by Alexandre Julliard (＠julliard) April 9, 2024

April 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/757

1 0

Re: [PATCH v6 0/3] MR750: vkd3d-shader/dxil: TGSM part 3. - approved
by Alexandre Julliard (＠julliard) April 9, 2024

April 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/750

1 0

Re: [PATCH v9 0/5] MR749: vkd3d-shader/ir: Minimise temp usage. - approved
by Alexandre Julliard (＠julliard) April 9, 2024

April 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/749

1 0

Re: [PATCH v6 0/9] MR744: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 5. - approved
by Alexandre Julliard (＠julliard) April 9, 2024

April 9, 2024

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/744

1 0

[PATCH v16 0/3] MR734: vkd3d-shader/dxil: SamplePosition and SampleCount.
by Conor McCarthy (＠cmccarthy) April 9, 2024

April 9, 2024

-- v16: vkd3d-shader/dxil: Implement DX intrinsic RenderTargetGetSampleCount. vkd3d-shader/dxil: Implement DX intrinsics Texture2DMSGetSamplePosition and RenderTargetGetSamplePosition. tests/hlsl: Add tests for GetSamplePosition() and GetSampleCount(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/734

4 5