October 2023 - wine-gitlab

Re: [PATCH v20 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 31 Oct '23

31 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c: > > #define ALIGN(n, alignment) (((n) + (alignment) - 1) & ~((alignment) - 1)) > > +unsigned int wg_format_get_bytes_for_uncompressed(wg_video_format format, unsigned int width, unsigned int height) This can be static now. Let's use enum wg_video_format instead of wg_video_format; the latter is a typedef of UINT32 and therefore the compiler won't recognize it as an enum. I don't particularly like the naming "get_bytes"; that sounds like it's retrieving the actual data in some sense. How about "wg_format_get_max_size_video_raw()", matching the naming scheme for wg_format_to_caps()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_50375

1 0

Re: [PATCH v20 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 31 Oct '23

31 Oct '23

Zebediah Figura (@zfigura) commented about dlls/winegstreamer/quartz_parser.c: > { > - FIXME("iface %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, stub!\n", > - iface, index, mt, flags, lcid, group, name, object, unknown); > - return E_NOTIMPL; > + struct parser *filter = impl_from_IAMStreamSelect(iface); > + wg_parser_stream_t stream = wg_parser_get_stream(filter->wg_parser, index); > + HRESULT hr = S_OK; > + > + FIXME("filter %p, index %ld, mt %p, flags %p, lcid %p, group %p, name %p, object %p, unknown %p, semi-stub!\n", > + filter, index, mt, flags, lcid, group, name, object, unknown); > + EnterCriticalSection(&filter->filter.filter_cs); > + > + if (!filter->sink.pin.peer) > + return VFW_E_NOT_CONNECTED; > + if (index < 0 || index >= wg_parser_get_stream_count(filter->wg_parser)) > + return S_FALSE; We need to leave the CS on these return paths. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_50374

1 0

Re: [PATCH v20 0/14] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Zebediah Figura (＠zfigura) 31 Oct '23

31 Oct '23

On Tue Oct 31 18:32:42 2023 +0000, Alfred Agrell wrote: > No, sorry, my bad, I cleaned up those logs too hard. > ``` > 01e4:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 1000, late -0.4180444, timestamp -0.2. > 01e4:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 1.0000000000000000e+00, diff 0, timestamp 0. > 0:00:00.153596244 5139 0x7fba10037860 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=0 stream_time=-1 diff=0 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 1000, late -0.4443777, timestamp -0.193. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 1.0000000000000000e+00, diff 0, timestamp 0. > 0:00:00.160425790 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=0 stream_time=-1 diff=0 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.063711, timestamp 0.221. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -637110, timestamp 2210000. > 0:00:00.574499800 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=221000000 stream_time=-1 diff=-63711000 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.0640444, timestamp 0.254. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -640444, timestamp 2540000. > 0:00:00.607456059 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=254000000 stream_time=27955556 diff=-64044400 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.0633777, timestamp 0.288. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -633777, timestamp 2880000. > 0:00:00.640834761 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=288000000 stream_time=61955556 diff=-63377700 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.062711, timestamp 0.322. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -627110, timestamp 3220000. > 0:00:00.674681804 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=322000000 stream_time=95955556 diff=-62711000 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.0640444, timestamp 0.354. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -640444, timestamp 3540000. > 0:00:00.707600604 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=354000000 stream_time=127955556 diff=-64044400 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.0633777, timestamp 0.388. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -633777, timestamp 3880000. > 0:00:00.741135357 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=388000000 stream_time=161955556 diff=-63377700 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.063711, timestamp 0.421. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -637110, timestamp 4210000. > 0:00:00.774577068 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=421000000 stream_time=194955556 diff=-63711000 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.0590443, timestamp 0.459. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -590443, timestamp 4590000. > 0:00:00.812276144 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=459000000 stream_time=232955556 diff=-59044300 > 01dc:trace:quartz:source_quality_control_Notify filter 00379A98, sender > 0AAB11EC, type 0, proportion 2000, late -0.0553776, timestamp 0.496. > 01dc:trace:quartz:wg_parser_stream_notify_qos stream 0x7fba100afe30, > underflow 0, proportion 5.0000000000000000e-01, diff -553776, timestamp 4960000. > 0:00:00.849423973 5139 0x7fba1004a2f0 ERROR WINE > dlls/winegstreamer/wg_parser.c:477:wg_parser_stream_notify_qos: > timestamp*100=496000000 stream_time=269955556 diff=-55377600 > ``` > The third wg_parser_stream_notify_qos call has timestamp\*100 = > 221000000, 0.221 seconds. But the stream_time is only 27955556, which is > 0.027 seconds; adding a -0.063 seconds diff to that goes out of bounds. > I have the offending mpeg file extracted; should I upload it somewhere, > or is that copyrightly improper? It's 518148 bytes. Copying offline discussion here; yes, this is coming from the application sink, not ours, and I think clamping is probably the right thing to do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_50373

1 0

[PATCH v2 0/1] MR4111: winegstreamer: Implement IWMResamplerProps
by Fabian Maurer (＠DarkShadow44) 31 Oct '23

31 Oct '23

Some programs just assume this interface exists, this fixes the resulting crash. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55789 -- v2: winegstreamer: Implement IWMResamplerProps https://gitlab.winehq.org/wine/wine/-/merge_requests/4111

3 7

[PATCH v2 0/6] MR4195: winegstreamer: Introduce some helper functions and implement add_stream.
by Ziqing Hui (＠zhui) 31 Oct '23

31 Oct '23

This MR is splitted from !3810 -- v2: winegstreamer: Implement wg_muxer_add_stream. winegstreamer: Introduce factory_create_element. winegstreamer: Introduce find_element_factories. https://gitlab.winehq.org/wine/wine/-/merge_requests/4195

3 7

[PATCH 0/2] MR4240: server: Only set sock->event when the event is first noticed.
by Zebediah Figura (＠zfigura) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4240

3 3

Re: [PATCH v4 0/1] MR423: ieframe fix - approved
by Zebediah Figura (＠zfigura) 31 Oct '23

31 Oct '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/423

1 0

[PATCH 0/1] MR4230: shell32: Fix string size condition check (Coverity).
by Nikolay Sivov (＠nsivov) 31 Oct '23

31 Oct '23

The issue was introduced by 68fd74e7f9bdd2310aebeb59bc86754271cdc063. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4230

3 3

[PATCH v2 0/5] MR2781: mfplat: Optimize sample copy to d3d buffer.
by Paul Gofman (＠gofman) 31 Oct '23

31 Oct '23

This is ultimately a follow up for introducing d3d manager support in h264 decoder transform. The last patch avoids unneeded GPU to CPU copy when copying a memory sample to GPU sample (in particular, when sample copier is involved). There are a couple of things to fix on the way. Patch 1 fixes the crash which otherwise happens in the test introduced in patch 2 due to memory corruption. Flipping the image instead of using absolute pitch will break the test in patch 2. Patch 3 contradicts to what MS docs says [1] for MFCreate2DMediaBuffer, fBottomUp parameter: "If TRUE, the buffer's IMF2DBuffer::ContiguousCopyTo method copies the buffer into a bottom-up format.". That doesn't match the tests in patch 2. So far I see that fBottomUp parameter only affects what is returned from Lock2D as scanline0 and pitch. Thinking of it, the behaviour of ContiguousCopyFrom makes some sense to me as Lock2D (unlike Lock which converts to contiguous buffer) is not supposed to perform any copies and flips and return the underlying representation as is. And once scanline0 and pitch for that 2d buffer indicate it should be copied bottom up additionally flipping when converting from contiguous buffer wouldn't make much sense. Then, ContiguousCopyTo could flip it actually as the docs suggest, but the test seems to clearly show that it doesn't happen (there is a separate test for clarity showing that ContiguousCopyFrom / ContiguousCopyTo yields the same data). 1. https://learn.microsoft.com/en-us/windows/win32/api/mfapi/nf-mfapi-mfcreate… -- v2: mfplat/sample: Optimize copying to 2d buffer. mfplat/sample: Refactor sample_CopyToBuffer(). mfplat/buffer: Do not flip in memory_2d_buffer_ContiguousCopy{From|To}(). mfplat/tests: Add more tests for copying 2d buffers. mfplat/buffer: Use absolute pitch in memory_1d_2d_buffer_[Un]Lock(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2781

3 6

[PATCH 0/1] MR4217: dxgi/tests: Use CRT allocation functions.
by Alex Henrie (＠alexhenrie) 31 Oct '23

31 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4217

4 3

2025

2024

2023

2022

wine-gitlab October 2023