November 2001 - Wine-Devel - list.winehq.org

Re: audio.c converted from WaitForSingleObject to poll

by eric pouech

> wodGetPosition doesn't keep pace with how much has > actually been played. This causes sound to fail in > HalfLife. who does it cause to fail ? > Looking at the code, it appears at first blush that we > may simply remove the SetEvent() and the > WaitForSingleObject() calls to remove this race > condition. It seems unlikely that this will cause any > problems. well, from a pure semantic point of view, I think we have to wait. for example, for a wodReset, the application would expect all queued wavehdr to be returned (in a notification) before the wodReset returns. not synchronizing, would loose this part for wodGetPosition, it currently returns the position of data which have been notified to the app (and which has been actually played). What's the exact issue on HL ? A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

Nov. 1, 2001

Re: L"YES" is a NO NO!!!

by Dmitry Timoshkov

"Francois Gouget" <fgouget(a)free.fr> wrote: > Wine cannot use Unicode strings literals. When you write L"YES" this > is a 32bit Unicode string, not a 16bit unicode string. This means that > when you pass it to lstrcmpiW, which expects 16bit Unicode strings like > all the APIs in Wine, what it sees is this: "Y\0E\0S\0\0\0". And this is > obviously different from "YES". > > > I guess it pays to check the warnings form time to time! Sure. Why not to change L'\0' to a simple 0 in your patch then? @@ -447,10 +451,10 @@ switch (type) { case REG_SZ: data[9] = L'\0'; /* set end of string */ ^^^^^^^^^^^^^^^ -- Dmitry.

Nov. 1, 2001

Duplicate StrRetToStr function in commdlg

by Francois Gouget

Yes, yet another duplicated StrRetToStr function: COMDLG32_StrRetToStrNW in dlls/commdlg/filedlgbrowser.c. At least this time it says that it's a copy. I guess it would be better if the implementations were pointing to each other. It would at least make it easier to maintain. But this case is not as easy as the shell32 case: * first the implementation is slightly different: the SHFree is not commented out in this one. I don't think the difference is intentional. So who is right? * commdlg is not supposed to import shell32. But it already imports a couple of other functions from shell32 so why not this one? It would be better than have another inconsisten implementation. * except that StrRetToStrNW is not exported. It is StrRetToStrN which is exported. So is it ok to call StrRetToStrN? Is StrRetToStrNW really more correct? Well, here is a proposed patch that imports StrRetToStrN from shell32 via the already-in-place GPA mechanism and removes COMDLG32_StrRetToStrNW. Comments? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ La terre est une bêta...

Nov. 1, 2001