May 2024 - Wine-Devel - list.winehq.org

Re: Implementing NtGetSystemInformation(SystemProcessorIdleInformation)

by Niko Patterson

Apologies, I thought that I had my mail client set up to automatically add the mailing list email on replies here, all that was discussed was trying to figure out if resources like geoffchappel.com are ok to use. I've avoided it as of now because I believe what's on that website was made from research on windows public debug symbols, and I worry that may violate the clean room guidelines. For now I'm going to go over my code/conformance tests a few more times and submit a patch with what I have. ~Niko On Wednesday, May 29th, 2024 at 9:17 PM, Niko Patterson <npatt(a)proton.me> wrote: > > > Hello, for the past couple of days I've been trying to get a program to run under wine, everything seems to function correctly except for a CPU stats window that errors every time it updates. After a few hours of debugging I traced it to NtGetSystemInformation and have been trying to write patches for wine to implement it. My only issue is that the program only uses certain parts of the output, and I'm not sure how to put together the structure for it, should I just name the unknown fields "ReservedX"? I'm also not 100% sure where to put the structure afterwards, since it doesn't seem to show up anywhere in MSDN (I may be using the wrong name, I assumed the structure name is just the enum name in title case like the ones that are documented). > > I apologize if I sent this to the wrong list, this is my first time contributing to wine and I'm still trying to figure things out. > > ~Niko

May 31, 2024

Re: Missing macro in commctrl.h

by Michael Dluhosch

Nice. Thank you :) Am Fr., 31. Mai 2024 um 13:44 Uhr schrieb Nikolay Sivov < nsivov(a)codeweavers.com>: > Sure. Alistair already made one [1]. > > [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/5765 > > On 5/31/24 1:42 PM, Michael Dluhosch wrote: > > Hi Nikolay, > > Okay Thanks. So if the application will work with those Macros I can > create a pull request to add them? > > Am Do., 30. Mai 2024 um 21:33 Uhr schrieb Nikolay Sivov < > nsivov(a)codeweavers.com>: > >> On 5/30/24 9:22 PM, Michael Dluhosch wrote: >> > Hi, >> > >> > is there a reason why this macro >> > >> https://learn.microsoft.com/en-us/windows/win32/api/commctrl/nf-commctrl-tr… >> > is not defined in the wine version of commctrl.h? >> > I currently try to compile windows sources with winegcc which need >> > this macro. >> > >> > Kind Regards >> > Michael >> >> Hi, Michael. >> >> There is no reason we can't have it in our header. We don't use those >> macros in wine code because of SendMessage, instead we always use >> explicit -A or -W functions, and explicit types. that's one of the >> reason those macros might be missing or broken. >> >> >

May 31, 2024

Re: Missing macro in commctrl.h

by Nikolay Sivov

Sure. Alistair already made one [1]. [1] https://gitlab.winehq.org/wine/wine/-/merge_requests/5765 On 5/31/24 1:42 PM, Michael Dluhosch wrote: > Hi Nikolay, > > Okay Thanks. So if the application will work with those Macros I can > create a pull request to add them? > > Am Do., 30. Mai 2024 um 21:33 Uhr schrieb Nikolay Sivov > <nsivov(a)codeweavers.com>: > > On 5/30/24 9:22 PM, Michael Dluhosch wrote: > > Hi, > > > > is there a reason why this macro > > > https://learn.microsoft.com/en-us/windows/win32/api/commctrl/nf-commctrl-tr… > > > is not defined in the wine version of commctrl.h? > > I currently try to compile windows sources with winegcc which need > > this macro. > > > > Kind Regards > > Michael > > Hi, Michael. > > There is no reason we can't have it in our header. We don't use those > macros in wine code because of SendMessage, instead we always use > explicit -A or -W functions, and explicit types. that's one of the > reason those macros might be missing or broken. >

May 31, 2024

Re: Missing macro in commctrl.h

by Michael Dluhosch

Hi Nikolay, Okay Thanks. So if the application will work with those Macros I can create a pull request to add them? Am Do., 30. Mai 2024 um 21:33 Uhr schrieb Nikolay Sivov < nsivov(a)codeweavers.com>: > On 5/30/24 9:22 PM, Michael Dluhosch wrote: > > Hi, > > > > is there a reason why this macro > > > https://learn.microsoft.com/en-us/windows/win32/api/commctrl/nf-commctrl-tr… > > is not defined in the wine version of commctrl.h? > > I currently try to compile windows sources with winegcc which need > > this macro. > > > > Kind Regards > > Michael > > Hi, Michael. > > There is no reason we can't have it in our header. We don't use those > macros in wine code because of SendMessage, instead we always use > explicit -A or -W functions, and explicit types. that's one of the > reason those macros might be missing or broken. > >

May 31, 2024

Re: Missing macro in commctrl.h

by Nikolay Sivov

On 5/30/24 9:22 PM, Michael Dluhosch wrote: > Hi, > > is there a reason why this macro > https://learn.microsoft.com/en-us/windows/win32/api/commctrl/nf-commctrl-tr… > is not defined in the wine version of commctrl.h? > I currently try to compile windows sources with winegcc which need > this macro. > > Kind Regards > Michael Hi, Michael. There is no reason we can't have it in our header. We don't use those macros in wine code because of SendMessage, instead we always use explicit -A or -W functions, and explicit types. that's one of the reason those macros might be missing or broken.

May 30, 2024

Missing macro in commctrl.h

by Michael Dluhosch

Hi, is there a reason why this macro https://learn.microsoft.com/en-us/windows/win32/api/commctrl/nf-commctrl-tr… is not defined in the wine version of commctrl.h? I currently try to compile windows sources with winegcc which need this macro. Kind Regards Michael

May 30, 2024

Re: Implementing NtGetSystemInformation(SystemProcessorIdleInformation)

by Fabian Maurer

Hello Niko, there's already people who have reverse engineered those Nt* structures in detail, but I'm not sure if we're allowed to use them. Alexandre said that we can't use ReactOS code because "A lot of it was reverse-engineered using methods that are not appropriate for Wine" but I don't think those other resources like like geoffchappell.com are created a different way. Regards, Fabian Maurer

May 30, 2024

Implementing NtGetSystemInformation(SystemProcessorIdleInformation)

by Niko Patterson

Hello, for the past couple of days I've been trying to get a program to run under wine, everything seems to function correctly except for a CPU stats window that errors every time it updates. After a few hours of debugging I traced it to NtGetSystemInformation and have been trying to write patches for wine to implement it. My only issue is that the program only uses certain parts of the output, and I'm not sure how to put together the structure for it, should I just name the unknown fields "ReservedX"? I'm also not 100% sure where to put the structure afterwards, since it doesn't seem to show up anywhere in MSDN (I may be using the wrong name, I assumed the structure name is just the enum name in title case like the ones that are documented). I apologize if I sent this to the wrong list, this is my first time contributing to wine and I'm still trying to figure things out. ~Niko

May 30, 2024

Re: Proposal: changing the default bug status (from 'UNCONFIRMED' to 'NEW')

by abbypra28＠gmail.com

Discover the latest TRB crypto price data on Toobit, including real-time market updates and comprehensive news coverage to keep you informed about the TRB market cap and trends. https://www.toobit.com/en-US/price/TRB

May 22, 2024

Re: Proposal: changing the default bug status (from 'UNCONFIRMED' to 'NEW')

by Gerald Pfeifer

On Wed, 15 May 2024, Jinoh Kang wrote: >> I do agree that the 'UNCONFIRMED' & 'NEW' statuses lead to confusion. I >> opened bug 50815[1] in 2021 for this reason. No agreement was reached, >> however. >> >> Having some sort of 'TRIAGED' status or something similar, does seem >> like a good idea. At least to have some sort of status that reflects >> that the bug has been looked at/triaged. > > Maybe we can then: > 1. Rename 'NEW' -> 'TRIANGED', and then > 2. Rename 'UNCONFIRMED' -> 'NEW'. "Unconfirmed" is common in Bugzilla settings, so I'd leave that instead of it meaning something commonly associated with something else. Gerald

May 21, 2024