August 2013 - Wine-Devel - list.winehq.org

Re: iphlpapi: Add AllocateAndGetTcpExTableFromStack().

by Bruno Jesus

On Sat, Aug 31, 2013 at 9:16 AM, Ralf Habacker <ralf.habacker(a)freenet.de> wrote: > new > - add doc for family parameter > - add doc for additional return code > - sorting in c file fixed > > Signed-off-by: Ralf Habacker <ralf.habacker(a)freenet.de> I guess the patch was marked as pending because you didn't add any tests. You are also missing the (try X) at the end of the subject. Regards, Bruno

Aug. 31, 2013

Re: [PATCH 3/3] ws2_32: Implement get socket option SO_PROTOCOL_INFO

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://newtestbot.winehq.org/JobDetails.pl?Key=1945 Your paranoid android. === wxppro (32 bit sock) === sock: unhandled exception c0000005 at 00000000

Aug. 31, 2013

Re: [PATCH] widl: Limit recursion deepth within structs to 1 for checking for full-pointers.

by Kai Tietz

Ups, sorry 2013/8/30 Paul Chitescu <paulc(a)voip.null.ro>: > Hi! > > It would help to attach the patch, not your editor's swap file. > > Paul > > > On Friday 30 August 2013 10:57:26 pm Kai Tietz wrote: >> Hello, >> >> attached patch limits recursion in type_has_full_pointer-function to a >> deeth of 1. By this all necessary checks should be possible, but >> endless-recursion due diamond/cycle type-declarations are avoided. >> I was finding this issue by working on propidl.idl rework, and hit >> such an endless recursion. >> >> Regards, >> Kai >

Aug. 30, 2013

Re: [PATCH] widl: Limit recursion deepth within structs to 1 for checking for full-pointers.

by Paul Chitescu

Hi! It would help to attach the patch, not your editor's swap file. Paul On Friday 30 August 2013 10:57:26 pm Kai Tietz wrote: > Hello, > > attached patch limits recursion in type_has_full_pointer-function to a > deeth of 1. By this all necessary checks should be possible, but > endless-recursion due diamond/cycle type-declarations are avoided. > I was finding this issue by working on propidl.idl rework, and hit > such an endless recursion. > > Regards, > Kai

Aug. 30, 2013

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-08-30 17:50, schrieb Henri Verbeet: > Well, regardless of which one it is, I don't see a similar check > for 2D and cube textures at the moment. I think some tests would > be welcome. You are right, there's neither a check nor tests. I am certain I have written and sent some in the past. I suspect they got lost in the discussions about how to best handle non-compressed block formats like YUV. Ignore this for now, I'll resubmit it together with the tests I have. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSIMIbAAoJEN0/YqbEcdMw6ykP/3vdOX0PWbC5drr3LRcOu+2p sUBc4A+uq/Si8rEQz4XGqjrPSYavIrtjO/LMk5aQ1CrB/K0fAne25mxf+A0f5g/b yMlia2UfAOIoSEpu/XkdtqPRx/VOC0002YhLA4VTkchCTHdmvsnsO6JyNIXmUjmz Ts4ubUVG0c6eGS/ABw36oSZk3vYL66rd8B1jvfXhVEt1FqKeBQIqqbBT1PGRRJKr H2aVjFuiz/elSSk6IBfztbcLb5DV46dP9h7PF2xR+YhLfGZnl0UgHj0r6GyfabrF TwUOqzsDkjwBH8mZVcWaciLBBqXTaGgLrSX8zpsjNTgXdpeARNRHbZeXdB0MmLA3 EZ77EiThhqmxDQNUGrLEl9AVhHASlbv7MLKQDlPqpQS1Ai7AJxTdSnt6ff7YyMNC YBEYn8KQG2C0mVdwFeN0wqcOZYquO1MpXspB2ouGjzUzay2yFPRSmcol/s48Opyw V7t9q1EoMmnG8Hw3QjFa4bYXwyfcChQsk/mLbK76e0iGGi1gw1uo7Hwr//M8xKrM 8JTdJhyKNsdH9miLHFlWZ3NFhne/cQwVf7GmZvhtfMBEot5sAWraTsZIuNYYj9RY RcEXsO9YpsZLHwqw/hCZ9/uDzpttxC/05dGucnK7+EDu5P5XwEdzzYD6VqRpSYHM FuD3i6T9Yy8+oEHj0FZ1 =q9pg -----END PGP SIGNATURE-----

Aug. 30, 2013

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

by Henri Verbeet

On 30 August 2013 17:35, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Am 2013-08-30 17:31, schrieb Henri Verbeet: >> Is this different from surfaces? IIRC surfaces are padded up to >> the next multiple of the block size, although I may have that >> wrong. Not a fan of the "(%p) : " trace formatting. > Padding happens with mipmaps and stand-alone surfaces. Level 0 of a 2D > and cube texture has to consist of at least one full block. (If my > memory serves me right.) > Well, regardless of which one it is, I don't see a similar check for 2D and cube textures at the moment. I think some tests would be welcome.

Aug. 30, 2013

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-08-30 17:31, schrieb Henri Verbeet: > On 30 August 2013 00:19, Stefan Dösinger <stefan(a)codeweavers.com> > wrote: >> + if (format->flags & WINED3DFMT_FLAG_BLOCKS) + { + >> UINT width_mask = format->block_width - 1; + UINT >> height_mask = format->block_height - 1; + if (desc->width >> & width_mask || desc->height & height_mask) + { + >> WARN("(%p) : Texture cannot be created - width or height not >> block size aligned.\n", texture); + return >> WINED3DERR_INVALIDCALL; + } + } + > Is this different from surfaces? IIRC surfaces are padded up to > the next multiple of the block size, although I may have that > wrong. Not a fan of the "(%p) : " trace formatting. Padding happens with mipmaps and stand-alone surfaces. Level 0 of a 2D and cube texture has to consist of at least one full block. (If my memory serves me right.) There are no stand-alone volumes. This patch only restricts the creation of full textures, not mipmap sublevels. Mapping of blocked volumes (part-block mipmaps and full ones) is part of a different patch and set of tests. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSILvEAAoJEN0/YqbEcdMwV5YQAJF74cyIS4XTQArXg4Zb8QeV PXva1oNZdUnuDcJFtSY8O5FORyY7Z/xcxA8Paf1GlNXios8griZNdab/RVcsaFDY pV5xng1xm4dPI8yTGPZJlW9sXs9L91idDGR/NTRYbGOvoa1xXZkToGDUPKOOCfU+ jdUMGJXu7FAz83R4RJ73d/b/LMgguyrw+okYpXcOwjxKbLLt9x6phyw3SfLPPcKz qKEBxM3H6v3U1FwUOzoh4OpM3fiZdEtFGxZvl1Q75fqmvnx6kXIxChM7TWKIgniK 3g9xGjPDciKdXZCnBww0M9RN45HvVQOSELAj59UBuRgJOZaLg2eReRPeVx09aW/t Ff34nInTDjL/YML9bgbvJNxC0f1W8OCRiReITujMBkeaoOQ4bRSAbDHHABrEAQJP eNTYKSgysIAdgaNmguAiJcQ4X+JvkkcaOXsXmEwQj+p9HTC9xLt1NC3L7bCLt+eL vpS81ve/U+sZgezneihwzQOtmW96I7eC5POAmAk1XodsO+EdkYRdyhOFKg7gXDCq D7Ge9OkOh9kyHm8qIgzdsO01RPH0el3SFNFTteynBSLTO5TdsEDlyUbsQPX4mk7C HWQkozpcT8THqes93e4077FpE4cGjCGU/kHbY6Z1jfxDJnl8RpHLrV8gfqxzjedp 4xjEhXWpkiLEvOUXnUuO =O9F7 -----END PGP SIGNATURE-----

Aug. 30, 2013

Re: [PATCH 3/5] d3d9/tests: Add a DXT5 volume test

by Stefan Dösinger

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 2013-08-30 17:31, schrieb Henri Verbeet: > On 30 August 2013 00:19, Stefan Dösinger <stefan(a)codeweavers.com> > wrote: >> + /* A 8x4x2 texture consisting of 4 4x4 blocks. The >> colors of the blocks are red, green, blue and white. */ + >> 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x00, >> 0xF8, 0x00, 0x00, 0x00, 0x00, + 0xff, 0xff, 0x00, 0x00, >> 0x00, 0x00, 0x00, 0x00, 0xE0, 0x07, 0xE0, 0x07, 0x00, 0x00, 0x00, >> 0x00, + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, >> 0x1F, 0x00, 0x1F, 0x00, 0x00, 0x00, 0x00, 0x00, + 0xff, >> 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xFF, 0xFF, 0xFF, >> 0x00, 0x00, 0x00, 0x00 > > In general we're using lower-case hex in wined3d, but I think it > should at least be consistent within the same test. Bleh, that's what happens when you mix copypasting from a hex editor with typing off certain parts :-\ -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSILsbAAoJEN0/YqbEcdMwUqYP/i6zGdefv7x8VPNpuutNbPu0 mFFBGmmVjMVp8jrj38jjck1E2MHyB9qETp0oG6RJAg0oizPWOtomE8L97ifh6uKb N5/GXnlg745DMzgKrx6AtH73bJl1V6yft7COUFECWX6plLQWF+a4KLfIG/Wko/88 1evSuqhqlHzTz03BUKgurqC3s+IZbc3fIbYvwibCjGTYzCqNxkncWyNhRUNeHHuo 4t7tMv5/oh3w5lkS43Bl8EoJC9RcGzODFqR64qMXQA6MECCaXu0oFOqOGVjHmQN0 ZxBk41Oz0an5Jk5fW4hJXozpUkMXzxTj+8me+Jnxw/4b2X5zaaT3v7mDQZan6NJJ rHFEDHqr5W3fphHQQ140EGnERbYExKe85Brze0+CL8OHIehTe4XiP6Xg4cmd3Ozs z5A9hUVZWF6QS06tSJxQ16+6SXQ+3YbWHA93EdWaYmlnnXqVyz/6U0e9yYc8d7yq tpo/y80Bs5KhxTXNO5NMa9OuXNwvQy/Zcx+cS92oW50/y+FWv/0xCNpaCfmpBNFE cgdP2CoDBUTKQrFLYFO5f3hld2r+NIXGzlkr/mv0iYhvZbMTUuNiQ/T+H/S27NkT ZIJjcsGqzAGaeQoVKjUhc8lPMmYIeR0vxmh9Z0k9FZ+iCIJ03RJAfNx8RafjZwdb yd3yMXM8VPSBw8qk44jS =gtFo -----END PGP SIGNATURE-----

Aug. 30, 2013

Re: [PATCH 5/5] wined3d: Enforce volume texture block restrictions

by Henri Verbeet

On 30 August 2013 00:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if (format->flags & WINED3DFMT_FLAG_BLOCKS) > + { > + UINT width_mask = format->block_width - 1; > + UINT height_mask = format->block_height - 1; > + if (desc->width & width_mask || desc->height & height_mask) > + { > + WARN("(%p) : Texture cannot be created - width or height not block size aligned.\n", texture); > + return WINED3DERR_INVALIDCALL; > + } > + } > + Is this different from surfaces? IIRC surfaces are padded up to the next multiple of the block size, although I may have that wrong. Not a fan of the "(%p) : " trace formatting.

Aug. 30, 2013

Re: [PATCH 3/5] d3d9/tests: Add a DXT5 volume test

by Henri Verbeet

On 30 August 2013 00:19, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + /* A 8x4x2 texture consisting of 4 4x4 blocks. The colors of the blocks are red, green, blue and white. */ > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xF8, 0x00, 0xF8, 0x00, 0x00, 0x00, 0x00, > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xE0, 0x07, 0xE0, 0x07, 0x00, 0x00, 0x00, 0x00, > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x1F, 0x00, 0x1F, 0x00, 0x00, 0x00, 0x00, 0x00, > + 0xff, 0xff, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xFF, 0xFF, 0xFF, 0xFF, 0x00, 0x00, 0x00, 0x00 In general we're using lower-case hex in wined3d, but I think it should at least be consistent within the same test.

Aug. 30, 2013