August 2020 - Wine-Devel - list.winehq.org

[PATCH] kernel32/tests: Pass the correct size for PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE.

by Zebediah Figura

Fixes test failures on 64-bit Wine and Windows 10. Signed-off-by: Zebediah Figura <z.figura12(a)gmail.com> --- dlls/kernel32/tests/process.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index b794c8f0c09..b2441019e34 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -3887,7 +3887,7 @@ static void test_ProcThreadAttributeList(void) expect_list.count++; } - ret = pUpdateProcThreadAttribute(&list, 0, PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE, handles, sizeof(PROCESSOR_NUMBER), NULL, NULL); + ret = pUpdateProcThreadAttribute(&list, 0, PROC_THREAD_ATTRIBUTE_PSEUDOCONSOLE, handles, sizeof(handles[0]), NULL, NULL); ok(ret || broken(GetLastError() == ERROR_NOT_SUPPORTED), "got %d gle %d\n", ret, GetLastError()); if (ret) -- 2.28.0

Aug. 31, 2020

[PATCH 2/2] winecfg: Add /v parameter to display current Windows version.

by Owen Rudge

This patch allows winecfg to be called with the "/v" parameter to display the current Windows version. "/v winver" will continue to allow the Windows version to be updated. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49242 Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> --- programs/winecfg/appdefaults.c | 24 +++++++++++++++++++++++- programs/winecfg/main.c | 9 +++++++-- programs/winecfg/winecfg.h | 1 + 3 files changed, 31 insertions(+), 3 deletions(-)

Aug. 31, 2020

[PATCH 1/2] winecfg: Ensure registry key is initialised before updating Windows version.

by Owen Rudge

Signed-off-by: Owen Rudge <orudge(a)codeweavers.com> --- programs/winecfg/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

Aug. 31, 2020

[PATCH] wbemprox: Provide semi-stub implementation for client_security_QueryBlanket().

by Paul Gofman

Horizon Zero Dawn fails to query system memory size if CoQueryProxyBlanket() fails for wbem services. Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- dlls/wbemprox/services.c | 20 ++++++++++++++++++-- dlls/wbemprox/tests/query.c | 7 +++++++ 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/dlls/wbemprox/services.c b/dlls/wbemprox/services.c index 3a0963e1f6c..ab7146db2d8 100644 --- a/dlls/wbemprox/services.c +++ b/dlls/wbemprox/services.c @@ -88,8 +88,24 @@ static HRESULT WINAPI client_security_QueryBlanket( void **pAuthInfo, DWORD *pCapabilities ) { - FIXME("\n"); - return WBEM_E_FAILED; + FIXME("semi-stub.\n"); + + if (pAuthnSvc) + *pAuthnSvc = RPC_C_AUTHN_NONE; + if (pAuthzSvc) + *pAuthzSvc = RPC_C_AUTHZ_NONE; + if (pServerPrincName) + *pServerPrincName = NULL; + if (pAuthnLevel) + *pAuthnLevel = RPC_C_AUTHN_LEVEL_NONE; + if (pImpLevel) + *pImpLevel = RPC_C_IMP_LEVEL_DEFAULT; + if (pAuthInfo) + *pAuthInfo = NULL; + if (pCapabilities) + *pCapabilities = 0; + + return WBEM_NO_ERROR; } static HRESULT WINAPI client_security_SetBlanket( diff --git a/dlls/wbemprox/tests/query.c b/dlls/wbemprox/tests/query.c index 17942cd89ae..74fdfaa9bc8 100644 --- a/dlls/wbemprox/tests/query.c +++ b/dlls/wbemprox/tests/query.c @@ -1713,6 +1713,7 @@ START_TEST(query) BSTR path = SysAllocString( L"ROOT\\CIMV2" ); IWbemLocator *locator; IWbemServices *services; + DWORD authn_svc; HRESULT hr; CoInitialize( NULL ); @@ -1728,6 +1729,12 @@ START_TEST(query) hr = IWbemLocator_ConnectServer( locator, path, NULL, NULL, NULL, 0, NULL, NULL, &services ); ok( hr == S_OK, "failed to get IWbemServices interface %08x\n", hr ); + hr = CoQueryProxyBlanket( (IUnknown *)services, NULL, NULL, NULL, NULL, NULL, NULL, NULL ); + ok( hr == S_OK, "failed to query proxy blanket %08x\n", hr ); + + hr = CoQueryProxyBlanket( (IUnknown *)services, &authn_svc, NULL, NULL, NULL, NULL, NULL, NULL ); + ok( hr == S_OK, "failed to query proxy blanket %08x\n", hr ); + hr = CoSetProxyBlanket( (IUnknown *)services, RPC_C_AUTHN_WINNT, RPC_C_AUTHZ_NONE, NULL, RPC_C_AUTHN_LEVEL_CALL, RPC_C_IMP_LEVEL_IMPERSONATE, NULL, EOAC_NONE ); ok( hr == S_OK, "failed to set proxy blanket %08x\n", hr ); -- 2.26.2

Aug. 31, 2020

Re: [PATCH] ntdll: Clear CONTEXT_XSTATE flag in RtlUnwindEx().

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=77808 Your paranoid android. === debiant (32 bit Chinese:China report) === ntdll: threadpool.c:1904: Test failed: WaitForSingleObject returned 258

Aug. 31, 2020

[PATCH] ntdll: Clear CONTEXT_XSTATE flag in RtlUnwindEx().

by Paul Gofman

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49749 Signed-off-by: Paul Gofman <pgofman(a)codeweavers.com> --- The unwind handler which is called from Windows clr.dll which after processing ACCESS_VIOLATION exception sets the CONTEXT_XSTATE flag in unwind context (probably just copis the original exception context at some moment which has this flag since 16ed88a95234d844fee9fc19053c5c7f618f92ba). Meanwhile the CONTEXT_EX structure is garbage. The consequet NtSetContextThread() is crashing trying to restore xstate from invalid location. dlls/ntdll/signal_x86_64.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c index ba91cc13dfe..6fbb612825b 100644 --- a/dlls/ntdll/signal_x86_64.c +++ b/dlls/ntdll/signal_x86_64.c @@ -1244,7 +1244,9 @@ void WINAPI RtlUnwindEx( PVOID end_frame, PVOID target_ip, EXCEPTION_RECORD *rec { ULONG64 frame; - *context = new_context = *dispatch.ContextRecord; + new_context = *dispatch.ContextRecord; + new_context.ContextFlags &= ~0x40; + *context = new_context; dispatch.ContextRecord = context; RtlVirtualUnwind( UNW_FLAG_NHANDLER, dispatch.ImageBase, dispatch.ControlPc, dispatch.FunctionEntry, @@ -1267,7 +1269,9 @@ void WINAPI RtlUnwindEx( PVOID end_frame, PVOID target_ip, EXCEPTION_RECORD *rec teb_frame = __wine_pop_frame( teb_frame ); - *context = new_context = *dispatch.ContextRecord; + new_context = *dispatch.ContextRecord; + new_context.ContextFlags &= ~0x40; + *context = new_context; dispatch.ContextRecord = context; RtlVirtualUnwind( UNW_FLAG_NHANDLER, dispatch.ImageBase, dispatch.ControlPc, dispatch.FunctionEntry, -- 2.26.2

Aug. 31, 2020

Re: ReactOS regression inrpcrt4

by Zebediah Figura

Hello Fabian, On 8/31/20 11:59 AM, Fabian Maurer wrote: > Hello Zebediah, > > starting with commit https://github.com/wine-mirror/wine/commit/9271efc0c746 > there's a lot of log spam in ReactOS: > "RpcBindingFree returned 0x6a6" > So far I couldn't reproduce the error in Wine though. > > I'm attaching a proposed patch that fixes the issue. Could you please take a > look on whether the attached patch would be suitable for inclusion into Wine, > or whether that problem points to another underlying issue? I don't think the patch is correct as given. I'm not very knowledgeable in binding handles, but as far as I'm aware they are allowed to be NULL. Working from -Os output, for the following IDL: [ uuid(deadbeef-0000-0000-0000-000000000000), version(1.0), ] interface test { struct apple { int i; }; typedef [handle] struct apple * apple_handle; void a([unique] apple_handle binding); } MIDL generates the following (trimmed) output: void a( /* [unique] */ apple_handle binding) { RPC_BINDING_HANDLE _Handle = 0; /* ... */ RpcTryFinally { /* ... */ _Handle = apple_handle_bind(binding);; if(( _Handle == 0 ) ) { RpcRaiseException(RPC_S_INVALID_BINDING); } /* ... */ } RpcFinally { NdrFreeBuffer( (PMIDL_STUB_MESSAGE) &_StubMsg ); if(_Handle) { apple_handle_unbind(binding,_Handle); } } RpcEndFinally } We're missing a NULL check for "_Handle" (i.e. "hbinding" in our code), but there's no check for "binding". Is there actually a bug, or just added console output? > > Regards, > Fabian Maurer >

Aug. 31, 2020

ReactOS regression inrpcrt4

by Fabian Maurer

Hello Zebediah, starting with commit https://github.com/wine-mirror/wine/commit/9271efc0c746 there's a lot of log spam in ReactOS: "RpcBindingFree returned 0x6a6" So far I couldn't reproduce the error in Wine though. I'm attaching a proposed patch that fixes the issue. Could you please take a look on whether the attached patch would be suitable for inclusion into Wine, or whether that problem points to another underlying issue? Regards, Fabian Maurer

Aug. 31, 2020

Re: [PATCH 2/2] gdi32/tests: Test extended TTF font names and collisions.

by Rémi Bernon

On 2020-08-31 17:15, Marvin wrote: > Hi, > > While running your changed tests, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > > Full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=77800 > > Your paranoid android. > > > === debiant (32 bit report) === > > gdi32: > font.c:7001: Test failed: RemoveFontResourceEx() failed > > === debiant (32 bit French report) === > > gdi32: > font.c:7001: Test failed: RemoveFontResourceEx() failed > > === debiant (32 bit Japanese:Japan report) === > > gdi32: > font.c:7001: Test failed: RemoveFontResourceEx() failed > > === debiant (32 bit Chinese:China report) === > > gdi32: > font.c:7001: Test failed: RemoveFontResourceEx() failed > > === debiant (32 bit WoW report) === > > gdi32: > font.c:7001: Test failed: RemoveFontResourceEx() failed > > === debiant (64 bit WoW report) === > > gdi32: > font.c:7001: Test failed: RemoveFontResourceEx() failed > Well, I missed those, I guess that because wine discards one of the font, it only has one font resource to remove in the end. I'll add the todo_wine too. -- Rémi Bernon <rbernon(a)codeweavers.com>

Aug. 31, 2020

Re: [PATCH 2/2] gdi32/tests: Test extended TTF font names and collisions.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=77800 Your paranoid android. === debiant (32 bit report) === gdi32: font.c:7001: Test failed: RemoveFontResourceEx() failed === debiant (32 bit French report) === gdi32: font.c:7001: Test failed: RemoveFontResourceEx() failed === debiant (32 bit Japanese:Japan report) === gdi32: font.c:7001: Test failed: RemoveFontResourceEx() failed === debiant (32 bit Chinese:China report) === gdi32: font.c:7001: Test failed: RemoveFontResourceEx() failed === debiant (32 bit WoW report) === gdi32: font.c:7001: Test failed: RemoveFontResourceEx() failed === debiant (64 bit WoW report) === gdi32: font.c:7001: Test failed: RemoveFontResourceEx() failed

Aug. 31, 2020