December 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] dsound: rework ugly mixer logic

by Andrew Eikum

On Mon, Dec 31, 2012 at 07:03:31PM +0100, Maarten Lankhorst wrote: > Op 31-12-12 17:59, Andrew Eikum schreef: > > On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote: > >> + if(!maxq){ > >> + /* nothing to do! */ > >> + LeaveCriticalSection(&device->mixlock); > >> + return; > >> } > > This was removed in 8ba4090fc304993. It breaks starting the device in > > some situations (write primary mode iirc). > Writeprimary dsound tests still worked for me, I don't particulary care though, if you want I'll zap it. > After rework fail it should no longer matter.. > Zaxxon (see Bug 30836) shows the problem on some, but not all, systems. Anyway, PerformMix() does more than just mix and write data, so returning early only because we have no frames to write is not always correct. > >> + if (native) { > >> + void *buffer = NULL; > >> + > >> + hr = IAudioRenderClient_GetBuffer(device->render, maxq / block, (void*)&buffer); > >> + if(FAILED(hr)){ > >> + WARN("GetBuffer failed: %08x\n", hr); > >> + LeaveCriticalSection(&device->mixlock); > >> + return; > >> + } > > I think this (mixing directly to RenderClient and skipping WaveQueue) > > could be split into a separate patch. > Hate to sound like a broken record here, but the whole mixer logic breaks if you touch that code. :/ > Really? It looks like an optimization to me: mix directly into the RenderClient buffer instead of to the intermediary buffer if the target format is float. What breaks if we use the intermediary buffer in every case? > >> hres = IAudioClient_Initialize(device->client, > >> AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | > >> - AUDCLNT_STREAMFLAGS_EVENTCALLBACK, prebuf_rt, 0, device->pwfx, NULL); > >> + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, 800000, 0, device->pwfx, NULL); > > ... > >> + frames = (UINT64)device->pwfx->nSamplesPerSec * 800000 / 10000000; > > Could you #define the 800000? > This is a very temporary solution as that call should not fail, and the branch will be killed off in the rework fail patch, > where it'll be treated like any other error. > > As such the only place to get that variable would be IAudioClient::Initialize, which I think would be overkill to #define somewhere, > the rest will just use buffer length as returned by the driver, instead of making a temporary guess. > Okay, fair enough. Andrew

Dec. 31, 2012

Re: [PATCH] dsound: rework ugly mixer logic

by Maarten Lankhorst

Op 31-12-12 17:59, Andrew Eikum schreef: > On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote: >> + if(!maxq){ >> + /* nothing to do! */ >> + LeaveCriticalSection(&device->mixlock); >> + return; >> } > This was removed in 8ba4090fc304993. It breaks starting the device in > some situations (write primary mode iirc). Writeprimary dsound tests still worked for me, I don't particulary care though, if you want I'll zap it. After rework fail it should no longer matter.. >> + if (native) { >> + void *buffer = NULL; >> + >> + hr = IAudioRenderClient_GetBuffer(device->render, maxq / block, (void*)&buffer); >> + if(FAILED(hr)){ >> + WARN("GetBuffer failed: %08x\n", hr); >> + LeaveCriticalSection(&device->mixlock); >> + return; >> + } > I think this (mixing directly to RenderClient and skipping WaveQueue) > could be split into a separate patch. Hate to sound like a broken record here, but the whole mixer logic breaks if you touch that code. :/ >> hres = IAudioClient_Initialize(device->client, >> AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | >> - AUDCLNT_STREAMFLAGS_EVENTCALLBACK, prebuf_rt, 0, device->pwfx, NULL); >> + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, 800000, 0, device->pwfx, NULL); > ... >> + frames = (UINT64)device->pwfx->nSamplesPerSec * 800000 / 10000000; > Could you #define the 800000? This is a very temporary solution as that call should not fail, and the branch will be killed off in the rework fail patch, where it'll be treated like any other error. As such the only place to get that variable would be IAudioClient::Initialize, which I think would be overkill to #define somewhere, the rest will just use buffer length as returned by the driver, instead of making a temporary guess. > Anyway, I gave it a test on ALSA+Pulse and didn't find any issues. > I'll test the other backends when you resubmit. > > Andrew >

Dec. 31, 2012

Re: Mail problems for wine-patches

by Jeremy White

> I also unsubscribed and subscribed again to the wine-patches list. > > Any ideas? > > Has wine-patches a whitelist? We use an exim rule to screen out IP addresses flagged in the SORBS database. Unfortunately, the outbound mailer for your domain is listed; here is the exim error report: 212.227.17.11 is listed at dnsbl.sorbs.net (127.0.0.6: Currently Sending Spam See: http://www.sorbs.net/lookup.shtml?212.227.17.11) I have temporarily added *.web.de to the whitelist which should, in theory, allow these emails through. I'll allow Jeremy Newman to comment on what he thinks would be a better long term solution. (It looks like it's touch and go, because you go this email through somehow :-/). Cheers, Jeremy

Dec. 31, 2012

Re: [PATCH] dsound: rework ugly mixer logic

by Andrew Eikum

On Sat, Dec 29, 2012 at 01:24:03AM +0100, Maarten Lankhorst wrote: > + if(!maxq){ > + /* nothing to do! */ > + LeaveCriticalSection(&device->mixlock); > + return; > } This was removed in 8ba4090fc304993. It breaks starting the device in some situations (write primary mode iirc). > + if (native) { > + void *buffer = NULL; > + > + hr = IAudioRenderClient_GetBuffer(device->render, maxq / block, (void*)&buffer); > + if(FAILED(hr)){ > + WARN("GetBuffer failed: %08x\n", hr); > + LeaveCriticalSection(&device->mixlock); > + return; > + } I think this (mixing directly to RenderClient and skipping WaveQueue) could be split into a separate patch. > hres = IAudioClient_Initialize(device->client, > AUDCLNT_SHAREMODE_SHARED, AUDCLNT_STREAMFLAGS_NOPERSIST | > - AUDCLNT_STREAMFLAGS_EVENTCALLBACK, prebuf_rt, 0, device->pwfx, NULL); > + AUDCLNT_STREAMFLAGS_EVENTCALLBACK, 800000, 0, device->pwfx, NULL); ... > + frames = (UINT64)device->pwfx->nSamplesPerSec * 800000 / 10000000; Could you #define the 800000? Anyway, I gave it a test on ALSA+Pulse and didn't find any issues. I'll test the other backends when you resubmit. Andrew

Dec. 31, 2012

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

Dec. 31, 2012

Re: atl100: Fixed NULL catmap handling in AtlRegisterClassCategoriesHelper

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23671 Your paranoid android. === WXPPROSP3 (32 bit atl) === Timeout === W2K3R2SESP2 (32 bit atl) === Timeout

Dec. 31, 2012

Re: Help Splitting Patches

by Eric Pouech

Le 30/12/2012 22:52, Adam Martinson a écrit : > Looking for some help splitting patch 3, not sure how I can cut it > down any more without breaking stuff. I'm guessing patch 9 will need > splitting too, same problem. > I haven't checked whether it's really possible, but one way to go would be to: - create a dedicated structure like server_end for the server end-point (instead of directly reusing the existing pipe_end) - then patch by patch move elements from pipe_instance to server_end + options + fd + ... - finally, when server_end and pipe_end have the same fields, just drop server_end for pipe_end HTH A+

Dec. 31, 2012

[AppDB] Cannot submit rejected Test results after change

by Joerg Schiermeier

¡Hola! In AppDB I got a problem, exactly with one of my maintained applications: some days ago someone filed a test about the mail program 'The Bat!'. This test has this URL: <http://appdb.winehq.org/objectManager.php?sClass=version&iId=23662&iTesting…> So AppDB sent me an email about this test and I went to its web interface. There I rejected this test result because of some incorrect version numberings. Than I got some days later a mail about a new submitted test. I logged into AppDB again to my control panel but I didn't saw this new submitted test there. So I had and have no change to commit this test results. If you follow the link above you will see: the test results are still there. So my conclusion: 1.) Someone, maybe you will have to commit this test. 2.) Something went wrong with the AppDB. Thanks for your attention and your help! -- Kindly regards Joerg Schiermeier Bielefeld/Germany

Dec. 31, 2012

Help Splitting Patches

by Adam Martinson

Looking for some help splitting patch 3, not sure how I can cut it down any more without breaking stuff. I'm guessing patch 9 will need splitting too, same problem. ~Adam

Dec. 30, 2012

Re: d3dx9: Implement D3DXSHEvalConeLight [try 4]

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23666 Your paranoid android. === WXPPROSP3 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K3R2SESP2 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === WVISTAADM (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W2K8SE (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PRO (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === TEST64_W7SP1 (32 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556320 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556320 === W7PROX64 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351 === TEST64_W7SP1 (64 bit math) === math.c:2578: Test failed: Red: case 0, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 0, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 4, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 6, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 7, order 6: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 4: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 5: expected[12] = 1137.556274, received 137.556351 math.c:2578: Test failed: Red: case 8, order 6: expected[12] = 1137.556274, received 137.556351

Dec. 30, 2012