December 2005 - Wine-Devel - list.winehq.org

Re: On creating 16bit windows convert null instances to current process

by Joseph Garvin

Dmitry Timoshkov wrote: > > And GlobalUnlock(tdb) is not right at all, you want > GlobalUnlock16(hTask). I resent it a second later with the 'x' fix. That does look more correct, but strangely the patch as is works. If I make your change the application I'm trying to fix gives this: err:heap:GlobalUnlock page fault occurred ! Caused by bug ? err:heap:GlobalUnlock page fault occurred ! Caused by bug ? Mike walked me through the patch, I'm not sure what his reasoning was on unlocking tdb versus hTask.

Dec. 31, 2005

re: What operating systems will Winelib run on non-x86 systems?

by Dan Kegel

Hi Wei Li, last year, you asked in http://www.winehq.org/hypermail/wine-users/2004/06/0086.html > I could not find the info regarding what operating systems > (such as AIX 5L v5.2, HP-UX 11i, Solaris Release Level > 9) will Winelib run on non-x86 machines. I'll really > appreciate it if someone can provide my related link or > info. I can only find the following link regarding the > supporting OS but it does not provide Winelib's supporting > OS info: > http://www.winehq.org/site/docs/wine-faq/index 3.1. > Under what hardware > platform(s) and operating system(s) will Wine(Lib) run? I'm sorry nobody got back to you -- the wine-devel mailing list might have been a better place to ask. I believe winelib runs on the following non-x86 operating systems: Linux, Solaris, Mac OS X, and FreeBSD. There's no reason in principle it couldn't run on AIX or HP/UX. Some work has been done on an HP/UX port, but some assembly would be required to complete it: http://www.winehq.com/site/?issue=241#HP-UX%20Port Cheers, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

Dec. 31, 2005

Re: WININET: lpvStatusInfo in INTERNET_STATUS_NAME_RESOLVED, INTERNET_STATUS_CONNECTING_TO_SERVER, and INTERNET_STATUS_CONNECTED_TO_SERVER should be strings, not sockaddr_in.

by Robert Shearman

Jacek Caban wrote: >+ /* FIXME: inet_ntoa is not thread safe. */ >+ szaddr = WININET_strdup_AtoW(inet_ntoa(lpwhs->socketAddress.sin_addr)); > INTERNET_SendCallback(&lpwhr->hdr, lpwhr->hdr.dwContext, > INTERNET_STATUS_NAME_RESOLVED, >- &(lpwhs->socketAddress), >- sizeof(struct sockaddr_in)); >+ szaddr, strlenW(szaddr)); >+ HeapFree(GetProcessHeap(), 0, szaddr); > > Like the comment says, it is not thread-safe. I don't think it is wise to delibrately introduce race conditions like this and it tends to cause problems with applications that rely heavily on multiple threads (such as iTunes). It would be better to use the thread-safe inet_ntop (which also has the bonus of supporting IPv6) or the ws2_32 version of inet_ntoa. -- Rob Shearman

Dec. 31, 2005

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

by Daniel Calviño Sánchez

2005/12/31, Marcus Meissner <marcus(a)jet.franken.de>: > > Thanks a lot, this is the patch I was looking for. I'm going to fill a > > bug report now. > > Its already fixed in current CVS... I have just seen the fix. I tested with an updated CVS and it works fine again. Thanks for the help, and sorry for wasting your time :$

Dec. 31, 2005

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

by Marcus Meissner

On Sat, Dec 31, 2005 at 03:48:16PM +0100, Daniel Calviño Sánchez wrote: > 2005/12/31, Marcus Meissner <marcus(a)jet.franken.de>: > > There is a CVS commit that has: > > revision 1.24 > > date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; lines: +2 -0 > > Marcus Meissner <marcus(a)jet.franken.de> > > msvcrt: Implemented wctime(), wasctime(). > > Free thread data in DLL_THREAD_DETACH. > > But, where can the information about CVS commits be seen? Perhaps I > sound somewhat silly... but I can't find it. > I mean, I know where I can see the changes made to a specific file. > But I don't know where can I see a list with all the changes made in > the CVS or something like that (I think you didn't get the information > about this CVS commit looking every file in the CVS :) ) log for a file: cvs log file.c to see diff between dates: cvs diff -u -D "time1" -D "time2" > Thanks a lot, this is the patch I was looking for. I'm going to fill a > bug report now. Its already fixed in current CVS... Ciao, Marcus

Dec. 31, 2005

Re: [Darwine] Re: Preliminary CD-Rom support on MacOS X #2

by emmanuel maillard

Thanks, i will take a look at git. Emmanuel Le 31 déc. 05 à 13:38, Pierre d'Herbemont a écrit : > > > emmanuel maillard wrote: >> On 30 déc. 05, at 13:08, Robert Shearman wrote: >>> I appreciate you splitting up your patches for easier review, but >>> patches are meant to be independent atomic changes that improve >>> the code. However, if Alexandre applied this patch alone then >>> Wine wouldn't compile any more and this isn't acceptable. > >> Any tricks are welcome. > > Use git to create your separate patches (git format-patch) [1] from > the small incremental changes you've committed to your own git > repository. > > Pierre. > > [1] http://wiki.winehq.org/GitWine

Dec. 31, 2005

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

by James Hawkins

On 12/31/05, Daniel Calviño Sánchez <danxuliu(a)gmail.com> wrote: > > But, where can the information about CVS commits be seen? Perhaps I > sound somewhat silly... but I can't find it. > I mean, I know where I can see the changes made to a specific file. > But I don't know where can I see a list with all the changes made in > the CVS or something like that (I think you didn't get the information > about this CVS commit looking every file in the CVS :) ) cvs.winehq.org/cvsweb/wine -- James Hawkins

Dec. 31, 2005

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

by Daniel Calviño Sánchez

2005/12/31, Marcus Meissner <marcus(a)jet.franken.de>: > There is a CVS commit that has: > revision 1.24 > date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; lines: +2 -0 > Marcus Meissner <marcus(a)jet.franken.de> > msvcrt: Implemented wctime(), wasctime(). > Free thread data in DLL_THREAD_DETACH. But, where can the information about CVS commits be seen? Perhaps I sound somewhat silly... but I can't find it. I mean, I know where I can see the changes made to a specific file. But I don't know where can I see a list with all the changes made in the CVS or something like that (I think you didn't get the information about this CVS commit looking every file in the CVS :) ) > So you are looking for this: > http://www.winehq.org/pipermail/wine-cvs/2005-December/019937.html > http://source.winehq.org/git/?p=wine.git;a=commit;h=9a583763eefb7cec46e0b4b… > (1 hour before approximately) > > Its likely that there is a delay between the GIT commit and the CVS integration. > > Ciao, Marcus Thanks a lot, this is the patch I was looking for. I'm going to fill a bug report now.

Dec. 31, 2005

Re: Finding patches in wine-cvs mailing list for regression tests using CVS dates

by Marcus Meissner

On Sat, Dec 31, 2005 at 01:45:04PM +0100, Daniel Calviño Sánchez wrote: > Hello. First of all, I'm not sure if this message should be posted > here, so sorry if it isn't the correct place. > > I found a regression and made some test to find the patch that caused > the problem. I followed the "How to do regression testing using CVS" > section in Wine documentation > http://winehq.org/site/docs/winedev-guide/x1344, but I think it's > outdated. > > The wine-cvs archive mailing list linked in the documentation is > http://www.winehq.org/hypermail/wine-cvs This archive ends in August > 2005. > > I think the archive linked should be http://www.winehq.org/pipermail/wine-cvs/ > > But the main problem comes now. I used CVS to make the regression > test. But when looking in the mailing list messages, the date in them > isn't the CVS commit date. Instead, it is the Git commit date (or at > least I think so). The Git to CVS gateway seems to get some time to > commit the changes to the CVS. > > So I don't know how can I get the exact patch that caused the problem. > > I'll try to explain it with my problem. When I update the CVS to > "2005-12-21 21:29:02 +0100", the game runs perfectly. However, if I > update the CVS to "2005-12-21 21:29:03 +0100", it crashes. However, > looking in the mailing list, there are no commits at "2005-12-21 > 21:29:03 +0100" (the previous was made at "2005-12-21 21:19:47 > +0100"). > > Is there something I'm missing? How could I proceed? Thanks. There is a CVS commit that has: revision 1.24 date: 2005-12-21 21:29:03 +0100; author: julliard; state: Exp; lines: +2 -0 Marcus Meissner <marcus(a)jet.franken.de> msvcrt: Implemented wctime(), wasctime(). Free thread data in DLL_THREAD_DETACH. So you are looking for this: http://www.winehq.org/pipermail/wine-cvs/2005-December/019937.html http://source.winehq.org/git/?p=wine.git;a=commit;h=9a583763eefb7cec46e0b4b… (1 hour before approximately) Its likely that there is a delay between the GIT commit and the CVS integration. Ciao, Marcus

Dec. 31, 2005

Finding patches in wine-cvs mailing list for regression tests using CVS dates

by Daniel Calviño Sánchez

Hello. First of all, I'm not sure if this message should be posted here, so sorry if it isn't the correct place. I found a regression and made some test to find the patch that caused the problem. I followed the "How to do regression testing using CVS" section in Wine documentation http://winehq.org/site/docs/winedev-guide/x1344, but I think it's outdated. The wine-cvs archive mailing list linked in the documentation is http://www.winehq.org/hypermail/wine-cvs This archive ends in August 2005. I think the archive linked should be http://www.winehq.org/pipermail/wine-cvs/ But the main problem comes now. I used CVS to make the regression test. But when looking in the mailing list messages, the date in them isn't the CVS commit date. Instead, it is the Git commit date (or at least I think so). The Git to CVS gateway seems to get some time to commit the changes to the CVS. So I don't know how can I get the exact patch that caused the problem. I'll try to explain it with my problem. When I update the CVS to "2005-12-21 21:29:02 +0100", the game runs perfectly. However, if I update the CVS to "2005-12-21 21:29:03 +0100", it crashes. However, looking in the mailing list, there are no commits at "2005-12-21 21:29:03 +0100" (the previous was made at "2005-12-21 21:19:47 +0100"). Is there something I'm missing? How could I proceed? Thanks. P.D: I didn't give more information about the crash because the message was mainly focused to the dates in the mailing list question. Of course, I'll fill a bug report when I find the patch that caused the problem.

Dec. 31, 2005