September 2019 - Wine-Devel

Re: [PATCH 4/5] d3d11: Set context to NULL in CreateDeferredContext() stub.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=57186 Your paranoid android. === debian10 (32 bit report) === d3d11: d3d11.c:6109: Test succeeded inside todo block: Got unexpected PrimitivesStorageNeeded: 0. user32: msg.c:8716: Test failed: WaitForSingleObject failed 102 msg.c:8722: Test failed: destroy child on thread exit: 0: the msg 0x0082 was expected, but got msg 0x000f instead msg.c:8722: Test failed: destroy child on thread exit: 1: the msg 0x000f was expected, but got msg 0x0014 instead msg.c:8722: Test failed: destroy child on thread exit: 2: the msg sequence is not complete: expected 0014 - actual 0000 === debian10 (32 bit Chinese:China report) === d3d11: d3d11.c:6109: Test succeeded inside todo block: Got unexpected PrimitivesStorageNeeded: 0. d3d11.c:6119: Test succeeded inside todo block: Got unexpected PrimitivesStorageNeeded: 0. d3d11.c:17941: Test failed: Got {0x00000000, 0x00000000, 0x00000000, 0x00000000}, expected {0x00000000, 0xffffffff, 0x00000000, 0x00000000} at (0, 0), sub-resource 0. user32: msg.c:8716: Test failed: WaitForSingleObject failed 102 msg.c:8722: Test failed: destroy child on thread exit: 0: the msg 0x0082 was expected, but got msg 0x000f instead msg.c:8722: Test failed: destroy child on thread exit: 1: the msg 0x000f was expected, but got msg 0x0014 instead msg.c:8722: Test failed: destroy child on thread exit: 2: the msg sequence is not complete: expected 0014 - actual 0000 === debian10 (32 bit WoW report) === d3d11: d3d11.c:6109: Test succeeded inside todo block: Got unexpected PrimitivesStorageNeeded: 0. d3d11.c:6119: Test succeeded inside todo block: Got unexpected PrimitivesStorageNeeded: 0. === debian10 (64 bit WoW report) === d3d11: d3d11.c:6109: Test succeeded inside todo block: Got unexpected PrimitivesStorageNeeded: 0. d3d11.c:6119: Test succeeded inside todo block: Got unexpected PrimitivesStorageNeeded: 0.

Sept. 30, 2019

[PATCH v3] x3daudio: fix lib exports

by Rafał Mużyło

x3daudio: fix lib exports 1. in case of x3daudio1_{0,1,2}, two exported functions are for some reason decorated (though only on 32bit) 2. tests show these functions should be stdcall, not cdecl; more exactly, header for 1.1 shows that too (1.7 header shows that changed at some point) Signed-off-by: Rafał Mużyło <galtgendo(a)o2.pl>

Sept. 30, 2019

[PATCH v2 5/5] include: Get rid of raster caps bits not available in the SDK version of d3d9caps.h.

by Matteo Bruni

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- v2: Avoid test failures on AMD. dlls/d3d9/tests/d3d9ex.c | 9 +++++---- dlls/d3d9/tests/device.c | 9 +++++---- include/d3d9caps.h | 3 --- 3 files changed, 10 insertions(+), 11 deletions(-) diff --git a/dlls/d3d9/tests/d3d9ex.c b/dlls/d3d9/tests/d3d9ex.c index 2639d20332b..38f49572fe4 100644 --- a/dlls/d3d9/tests/d3d9ex.c +++ b/dlls/d3d9/tests/d3d9ex.c @@ -4025,13 +4025,14 @@ static void test_device_caps(void) | D3DPMISCCAPS_MRTPOSTPIXELSHADERBLENDING | D3DPMISCCAPS_FOGVERTEXCLAMPED | D3DPMISCCAPS_POSTBLENDSRGBCONVERT)), "PrimitiveMiscCaps field has unexpected flags %#x.\n", caps.PrimitiveMiscCaps); - ok(!(caps.RasterCaps & ~(D3DPRASTERCAPS_DITHER | D3DPRASTERCAPS_PAT | D3DPRASTERCAPS_ZTEST - | D3DPRASTERCAPS_FOGVERTEX | D3DPRASTERCAPS_FOGTABLE | D3DPRASTERCAPS_ANTIALIASEDGES - | D3DPRASTERCAPS_MIPMAPLODBIAS | D3DPRASTERCAPS_ZBIAS | D3DPRASTERCAPS_ZBUFFERLESSHSR + ok(!(caps.RasterCaps & ~(D3DPRASTERCAPS_DITHER | D3DPRASTERCAPS_ZTEST + | D3DPRASTERCAPS_FOGVERTEX | D3DPRASTERCAPS_FOGTABLE + | D3DPRASTERCAPS_MIPMAPLODBIAS | D3DPRASTERCAPS_ZBUFFERLESSHSR | D3DPRASTERCAPS_FOGRANGE | D3DPRASTERCAPS_ANISOTROPY | D3DPRASTERCAPS_WBUFFER | D3DPRASTERCAPS_WFOG | D3DPRASTERCAPS_ZFOG | D3DPRASTERCAPS_COLORPERSPECTIVE | D3DPRASTERCAPS_SCISSORTEST | D3DPRASTERCAPS_SLOPESCALEDEPTHBIAS - | D3DPRASTERCAPS_DEPTHBIAS | D3DPRASTERCAPS_MULTISAMPLE_TOGGLE)), + | D3DPRASTERCAPS_DEPTHBIAS | D3DPRASTERCAPS_MULTISAMPLE_TOGGLE)) + || broken(!(caps.RasterCaps & ~0x0f736191)), "RasterCaps field has unexpected flags %#x.\n", caps.RasterCaps); /* D3DPBLENDCAPS_SRCCOLOR2 and D3DPBLENDCAPS_INVSRCCOLOR2 are only * advertised on the reference rasterizer and WARP. */ diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 1e8133b0c8e..170ad571246 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -12644,13 +12644,14 @@ static void test_device_caps(void) | D3DPMISCCAPS_MRTPOSTPIXELSHADERBLENDING | D3DPMISCCAPS_FOGVERTEXCLAMPED | D3DPMISCCAPS_POSTBLENDSRGBCONVERT)), "PrimitiveMiscCaps field has unexpected flags %#x.\n", caps.PrimitiveMiscCaps); - ok(!(caps.RasterCaps & ~(D3DPRASTERCAPS_DITHER | D3DPRASTERCAPS_PAT | D3DPRASTERCAPS_ZTEST - | D3DPRASTERCAPS_FOGVERTEX | D3DPRASTERCAPS_FOGTABLE | D3DPRASTERCAPS_ANTIALIASEDGES - | D3DPRASTERCAPS_MIPMAPLODBIAS | D3DPRASTERCAPS_ZBIAS | D3DPRASTERCAPS_ZBUFFERLESSHSR + ok(!(caps.RasterCaps & ~(D3DPRASTERCAPS_DITHER | D3DPRASTERCAPS_ZTEST + | D3DPRASTERCAPS_FOGVERTEX | D3DPRASTERCAPS_FOGTABLE + | D3DPRASTERCAPS_MIPMAPLODBIAS | D3DPRASTERCAPS_ZBUFFERLESSHSR | D3DPRASTERCAPS_FOGRANGE | D3DPRASTERCAPS_ANISOTROPY | D3DPRASTERCAPS_WBUFFER | D3DPRASTERCAPS_WFOG | D3DPRASTERCAPS_ZFOG | D3DPRASTERCAPS_COLORPERSPECTIVE | D3DPRASTERCAPS_SCISSORTEST | D3DPRASTERCAPS_SLOPESCALEDEPTHBIAS - | D3DPRASTERCAPS_DEPTHBIAS | D3DPRASTERCAPS_MULTISAMPLE_TOGGLE)), + | D3DPRASTERCAPS_DEPTHBIAS | D3DPRASTERCAPS_MULTISAMPLE_TOGGLE)) + || broken(!(caps.RasterCaps & ~0x0f736191)), "RasterCaps field has unexpected flags %#x.\n", caps.RasterCaps); /* D3DPBLENDCAPS_SRCCOLOR2 and D3DPBLENDCAPS_INVSRCCOLOR2 are only * advertised on the reference rasterizer and WARP. */ diff --git a/include/d3d9caps.h b/include/d3d9caps.h index 58fd3d91d01..feee0d4ce55 100644 --- a/include/d3d9caps.h +++ b/include/d3d9caps.h @@ -125,13 +125,10 @@ #endif #define D3DPRASTERCAPS_DITHER __MSABI_LONG(0x00000001) -#define D3DPRASTERCAPS_PAT __MSABI_LONG(0x00000008) #define D3DPRASTERCAPS_ZTEST __MSABI_LONG(0x00000010) #define D3DPRASTERCAPS_FOGVERTEX __MSABI_LONG(0x00000080) #define D3DPRASTERCAPS_FOGTABLE __MSABI_LONG(0x00000100) -#define D3DPRASTERCAPS_ANTIALIASEDGES __MSABI_LONG(0x00001000) #define D3DPRASTERCAPS_MIPMAPLODBIAS __MSABI_LONG(0x00002000) -#define D3DPRASTERCAPS_ZBIAS __MSABI_LONG(0x00004000) #define D3DPRASTERCAPS_ZBUFFERLESSHSR __MSABI_LONG(0x00008000) #define D3DPRASTERCAPS_FOGRANGE __MSABI_LONG(0x00010000) #define D3DPRASTERCAPS_ANISOTROPY __MSABI_LONG(0x00020000) -- 2.21.0

Sept. 30, 2019

[PATCH 4/5] d3d11: Set context to NULL in CreateDeferredContext() stub.

by Matteo Bruni

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- Applications often times don't check the return value of CreateDeferredContext() and might or might not check the returned pointer. I'd argue that crashing with a NULL pointer exception is better than executing random code or getting inconsistent behavior depending on the pointer's uninitialized content. dlls/d3d11/device.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c index 5fac1172ca9..212881a9b71 100644 --- a/dlls/d3d11/device.c +++ b/dlls/d3d11/device.c @@ -3358,6 +3358,7 @@ static HRESULT STDMETHODCALLTYPE d3d11_device_CreateDeferredContext(ID3D11Device { FIXME("iface %p, flags %#x, context %p stub!\n", iface, flags, context); + *context = NULL; return E_NOTIMPL; } -- 2.21.0

Sept. 30, 2019

[PATCH 3/5] user32: Don't go past the end of the animated cursor data.

by Matteo Bruni

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- Found while testing bug 43246. dlls/user32/cursoricon.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/user32/cursoricon.c b/dlls/user32/cursoricon.c index 3214746664c..9c61d7ff300 100644 --- a/dlls/user32/cursoricon.c +++ b/dlls/user32/cursoricon.c @@ -1451,6 +1451,8 @@ static void riff_find_chunk( DWORD chunk_id, DWORD chunk_type, const riff_chunk_ } ptr += sizeof(DWORD); + if (ptr >= end) + break; ptr += (*(const DWORD *)ptr + 1) & ~1; ptr += sizeof(DWORD); } -- 2.21.0

Sept. 30, 2019

[PATCH 2/5] d3dx9: Add a trace to D3DXCreateBuffer.

by Matteo Bruni

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- dlls/d3dx9_36/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/d3dx9_36/core.c b/dlls/d3dx9_36/core.c index 75a0e84772e..4c8070711c4 100644 --- a/dlls/d3dx9_36/core.c +++ b/dlls/d3dx9_36/core.c @@ -129,6 +129,8 @@ HRESULT WINAPI D3DXCreateBuffer(DWORD size, ID3DXBuffer **buffer) struct ID3DXBufferImpl *object; HRESULT hr; + TRACE("size %u, buffer %p.\n", size, buffer); + if (!buffer) { WARN("Invalid buffer specified.\n"); -- 2.21.0

Sept. 30, 2019

[PATCH 1/5] d3dx9: WARN when the file doesn't exist in D3DXCreateTextureFromFileExW().

by Matteo Bruni

Signed-off-by: Matteo Bruni <mbruni(a)codeweavers.com> --- dlls/d3dx9_36/texture.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/d3dx9_36/texture.c b/dlls/d3dx9_36/texture.c index 022b32bcd8c..8708ed702fd 100644 --- a/dlls/d3dx9_36/texture.c +++ b/dlls/d3dx9_36/texture.c @@ -773,7 +773,10 @@ HRESULT WINAPI D3DXCreateTextureFromFileExW(struct IDirect3DDevice9 *device, con hr = map_view_of_file(srcfile, &buffer, &size); if (FAILED(hr)) + { + WARN("Failed to open file.\n"); return D3DXERR_INVALIDDATA; + } hr = D3DXCreateTextureFromFileInMemoryEx(device, buffer, size, width, height, miplevels, usage, format, pool, filter, mipfilter, colorkey, srcinfo, palette, texture); -- 2.21.0

Sept. 30, 2019

Re: [PATCH] wbemprox: Implement Win32_QuickFixEngineering.

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=57163 Your paranoid android. === wvistau64_zh_CN (32 bit report) === Report errors: wbemprox:query has unaccounted for skip messages The report seems to have been truncated === wvistau64_zh_CN (task log) === Task errors: An error occurred while waiting for the test to complete: network read timed out (wait2/connect:AgentVersion.h:0/9) The test VM has crashed, rebooted or lost connectivity (or the TestAgent server died) The previous 2 run(s) terminated abnormally === wvistau64_fr (task log) === Task errors: The previous 1 run(s) terminated abnormally === w7u (32 bit report) === wbemprox: query: Timeout

Sept. 30, 2019

TestBot News

by Francois Gouget

I updated the debian10 and w1064 VMs so let me know if there are problems. For now they are not base VMs yet, I'ĺl promote them after their first WineTest run. Here's what's new (tl;dr;-style): debian10: OSS4, dual-screen, Spice vdagent, ich9 sound card. (and likely wrong CPU) w1064: New locale snapshots, a dual-screen snapshot (QXL), metered network connection. cw-rx460: New AMD RX 460 GPU - Debian: OSS4, Vulkan, win32 trouble. - Windows: New graphics driver, partial Windows upgrades, some missing disk images. The TestBot feels a bit slow today, maybe because it fell behind while I was working on the VMs. If it continues being slow I may have to rebalance the VMs a bit. debian10 -------- This VM now has two screens. A side effect is that screenshots will sometimes not work. That's only one of many annoyances with multi-head support for Unix guests. You can read all about it there: https://bugs.winehq.org/show_bug.cgi?id=47844 With Unix guests, multi-head support requires installing and running Spice's VDAgent in the guest. The VDAgent servers are meant to integrate the guest environment with the host to simplify copy/paste between them, resizing the guest desktop by resizing the Spice window, etc. Hopefully none of that will interfere with the Wine tests but if it does, let me know. Also if we need to test both single and dual screen configurations then we'll need to duplicate that VM. So let me know if that's needed. In the process upgraded the virtual hardware the VM runs on from QEmu's i440FX to the Q35 platform which is the default nowadays. This should not have any impact on the tests except that the sound card changed from ich6 to ich9. Last thing, when rebuilding the VM I picked the 'Hypervisor default' for the emulated CPU. It's missing support for sse3 which, if I recall correctly, was causing bcrypt failures on Wine. And sure enough the failures are back. So I probably need to tweak the CPU configuration. w1064 ----- This VM has a new snapshot with a dual screen configuration. On windows this is only possible with the QXL graphics card whereas we normally use the VGA one. So this is likely to have an impact on the Direct 3D tests in that snapshot. Details: https://bugs.winehq.org/show_bug.cgi?id=47838 On Windows too the dual-screen configuration may cause the TestBot to 'fail' to produce a useful screenshot from time to time: https://testbot.winehq.org/JobDetails.pl?Key=57142&s205=1#k205 Also one needs to have one graphics cards per screen. So this is slightly different from the debian10 setup where there is a single graphics card with two screens. I also added five new locales: Arabic, French, Hebrew, Japanese and Simplified Chinese. Recreating the live snapshots was almost a breeze thanks to the recent TestBot work. The snag is that it turns out setting the location to a European country causes Windows 10 to through a 'Privacy wizard' when rebooting to have the new locale take effect. Of course that impacted the first locale I tested, French, and broke the automatically created live snapshot. Fortunately now I know what's causing the problem and only one snapshot needs to be created manually. Eventually I will probably demote the wvistau64 locale configurations to only run the daily WineTests or even just deal with jobs that developer manually pick for them. Another change I made is to put the network connection in metered mode. Before this I was blocking the Windows Updates simply by disabling the corresponding service. That worked fine in version 1507 but did not work so well with more recent versions. In particular a reboot would reenable the Windows Update service leading to upgrades takign place. Putting the network connection in metered mode seems to reliably stop Windows update in its tracks and is now easy in 1809 (and a bit more hidden in 1703). However I probably went overboard by setting a 1GB limit (a 100GB limit seems to work just as well) so there are notifications that the quota is exceeded. Let me know if this change is causing problems. Details: https://bugs.winehq.org/show_bug.cgi?id=47854 By the way only the new dual-screen and locale snapshots have the metere network connection. So comparing the results there with those of the old snapshots can help detect issues. If this is not causing trouble I'll eventually go back and do the same change in the other snapshots. cw-rx-460 --------- Not quite part of the TestBot but provides daily real hardware WineTest results. The AMD HD6800 graphics card died so it got replaced by an AMD RX 460 graphics card. On the Debian side I added OSS4 (Faudio is present too) and the new graphics card gains us Vulkan support. Yay! The WineTest results are not great. In particular the wow32 results look ok, but half the time WineTest / the system seems to crash in the middle of the win32 ones. It may just be that it reboots to Windows at the wrong time. The rest of the time the win32 results are on par with the wow32/wow64 ones. I did not have time to dig into this yet. On the Windows side the graphics driver has to be updated for each test configuration of course :-( And while that happens Windows Update starts applying updates :-(( But if the metered network connection trick works out I should be able to make clean updates to the windows images. In the meantime only the Windows 8.1 and Windows 10 1809 configurations are operational. -- Francois Gouget <fgouget(a)codeweavers.com>

Sept. 30, 2019

Re: [PATCH 2/2 v2] msvcrt: Implement %R format for strftime

by Marvin

Hi, While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=57161 Your paranoid android. === w2003std (32 bit report) === msvcrt: time.c:900: Test failed: clock() = 515, expected 625

Sept. 30, 2019