October 2006 - Wine-Devel - list.winehq.org

Re: rpcrt4: Set the socket back to blocking in rpcrt4_conn_tcp_handoff as the read and write function for the protseq assume that syscalls will block.

by Juan Lang

+ /* reset to non-blocking behaviour */ + fcntl(ret, F_SETFL, 0); Shouldn't that read "reset to blocking behaviour" then? --Juan ____________________________________________________________________________________ We have the perfect Group for you. Check out the handy changes to Yahoo! Groups (http://groups.yahoo.com)

Oct. 31, 2006

Re: cmd: Check for argument in copy, mkdir, delete, goto, move, rmdir, rename, type.

by Alexandre Julliard

Markus Amsler <markus.amsler(a)oribi.org> writes: > This fixes bug http://bugs.winehq.org/show_bug.cgi?id=6286 > --- > programs/cmd/builtins.c | 22 ++++++++++++++++++++++ > 1 files changed, 22 insertions(+), 0 deletions(-) > diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c > index 3329a0b..0732170 100644 > --- a/programs/cmd/builtins.c > +++ b/programs/cmd/builtins.c > @@ -36,6 +36,12 @@ #define WIN32_LEAN_AND_MEAN > > #include "wcmd.h" > > +#define CHECK_FOR_ARGUMENT \ > + if (param1[0] == 0x00) { \ > + WCMD_output ("Argument missing\n"); \ > + return; \ > + } > + > void WCMD_execute (char *orig_command, char *parameter, char *substitution); > > struct env_stack > @@ -110,6 +116,8 @@ BOOL force, status; > static const char overwrite[] = "Overwrite file (Y/N)?"; > char string[8], outpath[MAX_PATH], inpath[MAX_PATH], *infile; > > + CHECK_FOR_ARGUMENT > + > if ((strchr(param1,'*') != NULL) && (strchr(param1,'%') != NULL)) { This is ugly, you should use a normal function instead of a macro and do the return explicitly instead of hiding it in the macro (or even put the code in as is, it's only a couple of lines). -- Alexandre Julliard julliard(a)winehq.org

Oct. 31, 2006

Re: [advpack] Fix typo's

by James Hawkins

On 10/31/06, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > most likely lstrcat was intended. I haven't checked why this lead to errors on > Windows and not on Wine. > It works in XP, at least, because you don't have to specify a full pathname to the INF file. The test that shows that is just a couple lines up. Wine's implementation matches XP. -- James Hawkins

Oct. 31, 2006

rotated text in ExtTextOut

by Carl-Daniel Hailfinger

Hi, I have a problem displaying rotated text in Wine where the rotation under Windows is counterclockwise, but the rotation in Wine is clockwise. The patch I came up with rotates the text in the right direction, but the individual characters are still rotated in the wrong direction. The attached WMF file shows the bug. Any help/criticism would be appreciated. diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 24f16dd..24dac20 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -1820,6 +1820,11 @@ BOOL WINAPI ExtTextOutW( HDC hdc, INT x, { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + FIXME("rotated text flag with flag CLIP_LH_ANGLES unimplemented, trying to fix it up\n"); + sinEsc = - sinEsc; + } } else { diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index 1fe30f6..21eaad6 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -1135,6 +1135,11 @@ BOOL X11DRV_XRender_ExtTextOut( X11DRV_P if(lf.lfEscapement != 0) { cosEsc = cos(lf.lfEscapement * M_PI / 1800); sinEsc = sin(lf.lfEscapement * M_PI / 1800); + if (lf.lfClipPrecision & CLIP_LH_ANGLES) + { + FIXME("rotated text flag with flag CLIP_LH_ANGLES unimplemented, trying to fix it up\n"); + sinEsc = - sinEsc; + } } else { cosEsc = 1; sinEsc = 0; Regards, Carl-Daniel

Oct. 31, 2006

Re: [PATCH 5/5] quartzdrv: Implement MsgWaitForMultipleObjectsEx and initial Carbon event handling.

by Alexandre Julliard

Pierre d'Herbemont <pdherbemont(a)free.fr> writes: > 2) Launch a 'carbon' thread which will run the carbon run loop (which > does not poll), and writes to a fd as soon as it receive events. > > I think 2) may be preferred but to have a separate thread that watch > event and an other that act on the UI tends to be tricky. In any case you need to support multiple threads acting on the UI, so that shouldn't be much of an issue. Note that the event thread should be posting messages, not writing to an fd. It probably means that the design of many bits of the user code need to be different from x11drv, which is why I think it's important to get this right before writing tons of code. -- Alexandre Julliard julliard(a)winehq.org

Oct. 31, 2006

Re: gdi32: Cast-qual warnings fix (1 of 3)

by Alexandre Julliard

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > @@ -1779,16 +1779,17 @@ > > if (!lprect) > flags &= ~ETO_CLIPPED; > - > + > + reordered_str = HeapAlloc(GetProcessHeap(), 0, count * sizeof(WCHAR)); > + lstrcpynW(reordered_str, str, count); The input string is not necessarily null-terminated, and in any case you shouldn't allocate a copy unless it's really necessary. -- Alexandre Julliard julliard(a)winehq.org

Oct. 31, 2006

Re: Failing shlfolder test

by Francois Gouget

On Sat, 28 Oct 2006, martin pilka wrote: > > Actually the shlfolder test seems to succeed on your machine and > > it is the shlexec and shlfileop tests that are failing (and are working > > for me). > > Are you using a freshly generated ~/.wine directory? > > Before each "make test", ~/.wine dir is erased and generated again. Is that > enough? Yes. Maybe this is caused by some uninitialized variable so that the bug is triggered by the memory layout or some such. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Lotto: A tax on people who are bad at math." -- unknown "Windows: Microsoft's tax on computer illiterates." -- WE7U

Oct. 31, 2006

Re: [secur32] Remove test that crashes on Win2k

by Mike McCormack

James Hawkins wrote: >> + /* Crashes on Win2K >> st = pAcquireCredentialsHandleA(NULL, unisp_name_a, 0, NULL, >> NULL, NULL, >> NULL, NULL, NULL); >> ok(st == SEC_E_NO_CREDENTIALS, "Expected SEC_E_NO_CREDENTIALS, >> got %08x\n", >> st); >> + */ > > Please use #if 0/#endif to comment out pieces of code. Or even better use if (0) { } so compile problems don't creep in... Mike

Oct. 31, 2006

Re: [secur32] Remove test that crashes on Win2k

by James Hawkins

On 10/30/06, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > On Mon, 2006-10-30 at 23:44 -0800, James Hawkins wrote: > > On 10/30/06, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > > > Hi, > > > > > > makes sure the other tests are run. > > > > > > Changelog > > > Remove test that crashes on Win2k > > > > > > Cheers, > > > > > > Paul. > > > > > > --- > > > dlls/secur32/tests/schannel.c | 2 ++ > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > diff --git a/dlls/secur32/tests/schannel.c b/dlls/secur32/tests/schannel.c > > > index 23e2a0a..95669fe 100644 > > > --- a/dlls/secur32/tests/schannel.c > > > +++ b/dlls/secur32/tests/schannel.c > > > @@ -140,10 +140,12 @@ static void testAcquireSecurityContext(v > > > NULL); > > > ok(st == SEC_E_SECPKG_NOT_FOUND, > > > "Expected SEC_E_SECPKG_NOT_FOUND, got %08x\n", st); > > > + /* Crashes on Win2K > > > st = pAcquireCredentialsHandleA(NULL, unisp_name_a, 0, NULL, NULL, NULL, > > > NULL, NULL, NULL); > > > ok(st == SEC_E_NO_CREDENTIALS, "Expected SEC_E_NO_CREDENTIALS, got %08x\n", > > > st); > > > + */ > > > > Please use #if 0/#endif to comment out pieces of code. > > > Hi James, > > there is a commented out test a few lines below. I thought I'd stick to > how it's done in this file. > In this case, it's not really a 'style' issue, where we keep the style the same in the file. We shouldn't be using actual comments to disable code. If you want to change the other case to #if 0, I wouldn't have a problem with that, but we shouldn't be adding more comments -- James Hawkins

Oct. 31, 2006

Re: [secur32] Remove test that crashes on Win2k

by Paul Vriens

On Mon, 2006-10-30 at 23:44 -0800, James Hawkins wrote: > On 10/30/06, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > > Hi, > > > > makes sure the other tests are run. > > > > Changelog > > Remove test that crashes on Win2k > > > > Cheers, > > > > Paul. > > > > --- > > dlls/secur32/tests/schannel.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/dlls/secur32/tests/schannel.c b/dlls/secur32/tests/schannel.c > > index 23e2a0a..95669fe 100644 > > --- a/dlls/secur32/tests/schannel.c > > +++ b/dlls/secur32/tests/schannel.c > > @@ -140,10 +140,12 @@ static void testAcquireSecurityContext(v > > NULL); > > ok(st == SEC_E_SECPKG_NOT_FOUND, > > "Expected SEC_E_SECPKG_NOT_FOUND, got %08x\n", st); > > + /* Crashes on Win2K > > st = pAcquireCredentialsHandleA(NULL, unisp_name_a, 0, NULL, NULL, NULL, > > NULL, NULL, NULL); > > ok(st == SEC_E_NO_CREDENTIALS, "Expected SEC_E_NO_CREDENTIALS, got %08x\n", > > st); > > + */ > > Please use #if 0/#endif to comment out pieces of code. > Hi James, there is a commented out test a few lines below. I thought I'd stick to how it's done in this file. Cheers, Paul.

Oct. 31, 2006