February 2011 - Wine-Devel - list.winehq.org

Re: shlwapi/tests: remove win9x hacks (try 2)

by Nikolay Sivov

On 3/1/2011 01:28, Austin English wrote: > Apparently it's flaky on win2k...cleared WTB: > https://testbot.winehq.org/JobDetails.pl?Key=9585 > - /* shlwapi on Win98 SE does not appear to apply delimiters to the output > - * and does not correctly handle extremely large values. */ > - ok(!strcmp(result->kb_size, szBuff) || > - (result->kb_size_broken&& !strcmp(result->kb_size2, szBuff)), > - "Formatted %x%08x wrong: got %s, expected %s\n", > + ok(!strcmp(result->kb_size, szBuff), "Formatted %x%08x wrong: got %s, expected %s\n", > (LONG)(result->value>> 32), (LONG)result->value, szBuff, result->kb_size); I think it's better to keep comments that describe version dependent behaviour even if it's not tested by default now.

Feb. 28, 2011

Re: ntprint/tests: remove win9x hacks

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9577 Your paranoid android. === WNT4WSSP6 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2KPROSP4 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === WXPPROSP3 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2K3R2SESP2 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === WVISTAADM (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W2K8SE (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PRO (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PROX64 (32 bit ntprint) === ntprint: unhandled exception c0000005 at 00000000 === W7PROX64 (64 bit ntprint) === Timeout

Feb. 28, 2011

Re: shlwapi/tests: remove win9x hacks

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=9576 Your paranoid android. === W2KPROSP4 (32 bit string) === string: unhandled exception c0000005 at 77C84DD7

Feb. 28, 2011

Fwd: Applications for Mentoring Organizations Now Being Accepted

by Dan Kegel

So, shall I do the honors? ---------- Forwarded message ---------- From: Carol Smith <carols(a)google.com> Date: Mon, Feb 28, 2011 at 12:35 PM Subject: Applications for Mentoring Organizations Now Being Accepted To: Google Summer of Code Announce <google-summer-of-code-announce(a)googlegroups.com> Hi all, We're pleased to announce the applications for mentoring organizations for Google Summer of Code 2011 are now being accepted [1]. Please go Melange [2] to apply on behalf of your organization. Please note that the application period [3] closes on 11 March at 23:00 UTC [4]. [1] - http://google-opensource.blogspot.com/2011/02/mentoring-organization-applic… [2] - http://www.google-melange.com [3] - http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/ti… [4] - http://goo.gl/paMZU Cheers, Carol -- You received this message because you are subscribed to the Google Groups "Google Summer of Code Announce" group. To post to this group, send email to google-summer-of-code-announce(a)googlegroups.com. To unsubscribe from this group, send email to google-summer-of-code-announce+unsubscribe(a)googlegroups.com. For more options, visit this group at http://groups.google.com/group/google-summer-of-code-announce?hl=en.

Feb. 28, 2011

Re: Please help me with document extraction.

by Alexandre Julliard

Max TenEyck Woodbury <max(a)mtew.isa-geek.net> writes: > Frankly, I believe embedded documentation is the way to go. It is _not_ > a panacea, but it is better than trying to maintain a separate set of > functional documentation. I have seen cases where it worked. Not great > but OK. I tried the separate document approach and got _very_ > frustrated, and _no_one_ was really interested. As I've explained, embedded documentation is not going to happen. And the reason no one is interested is not because it's separate from the source, it's because documenting the Windows API is a huge and boring task, and there's no real need for it. -- Alexandre Julliard julliard(a)winehq.org

Feb. 28, 2011

Re: Please help me with document extraction.

by André Hentschel

Am 28.02.2011 17:20, schrieb Max TenEyck Woodbury: >> I think the idea of building upon the existing "documentation" somewhere else >> has a better chance than the "deal on the 100" >> > Frankly, I believe embedded documentation is the way to go. It is _not_ > a panacea, but it is better than trying to maintain a separate set of > functional documentation. I have seen cases where it worked. Not great > but OK. I tried the separate document approach and got _very_ > frustrated, and _no_one_ was really interested. Yeah, so let's see how interested people will be in the new aproach. (Also OK might not be enough for Wine) -- Best Regards, André Hentschel

Feb. 28, 2011

Re: Please help me with document extraction.

by Max TenEyck Woodbury

On 02/28/2011 08:08 AM, André Hentschel wrote: > Am 27.02.2011 20:37, schrieb Max TenEyck Woodbury: >> I've picked up Perl in the last couple weeks. An interesting language >> with lots of adopted features. It's been easy to learn, so I think I >> will _not_ need help with the language itself, but I will listen to any >> advice. > > When i started with Wine developing i tackled winemaker which is also in perl. > I also had to learn Perl for it, so i know you situation. Perl is truely cool, > but the "inline" use of RegEx is sometimes confusing (So are $_ and friends) > and i hate to use curly brackets for every "if". > Perl's focus seems to be on compact code. Since I have an existing program to work from, I don't have to learn it all at once. The Perl regex is quite a bit more advanced than some others and I'm happy to learn the new features it present. I find it easy to learn. Curlies are frustrating if you insist on a style that emphasize them, but I think that is due to the conflict between a 'lots of white space' style and the compact philosophy built into the language. The focus should be on the purpose of the code, not on the syntax of the language. >> The c2man.pl code is extensive and sparsely commented. In order to >> understand what it does, I've made a transcription of it with a more >> compact style and lots more comments. I check the rewrite against the >> source code so there should not be any serious errors. There are also a >> number of what I believe to be defects in the original and places where >> my comments may be inappropriate or my style may be very objectionable. >> _This_ is what I need help with. >> >> Would someone be willing to review my rewrite? If so, send me e-mail so >> I can arrange to get a copy of it to you. > > Remember that you won't get one big patch in at once, you need to split it up later. > I was going to try for a whole hog replacement, call it c2man2 or something like that, but I can retro-fit as needed. >> P.S. to AJ et al. >> >> There is a _lot_ of documentation embedded in the wine code, but it is >> hard to find at the moment. I'd like to see it indexed and this is the >> program that does the extraction and indexing. Advice on making this >> new version available and active are in order. >> > > I think the idea of building upon the existing "documentation" somewhere else > has a better chance than the "deal on the 100" > Frankly, I believe embedded documentation is the way to go. It is _not_ a panacea, but it is better than trying to maintain a separate set of functional documentation. I have seen cases where it worked. Not great but OK. I tried the separate document approach and got _very_ frustrated, and _no_one_ was really interested. Max

Feb. 28, 2011

Re: gdi32: Fixes GetDIBits for top-down destination bitmaps (Bug #26236).

by Alexandre Julliard

John Edmonds <pocketcookies2(a)gmail.com> writes: > Resolves Bug #26236. Please update the test cases to catch this. -- Alexandre Julliard julliard(a)winehq.org

Feb. 28, 2011

Re: Please help me with document extraction.

by André Hentschel

Am 27.02.2011 20:37, schrieb Max TenEyck Woodbury: > I've picked up Perl in the last couple weeks. An interesting language > with lots of adopted features. It's been easy to learn, so I think I > will _not_ need help with the language itself, but I will listen to any > advice. When i started with Wine developing i tackled winemaker which is also in perl. I also had to learn Perl for it, so i know you situation. Perl is truely cool, but the "inline" use of RegEx is sometimes confusing (So are $_ and friends) and i hate to use curly brackets for every "if". > The c2man.pl code is extensive and sparsely commented. In order to > understand what it does, I've made a transcription of it with a more > compact style and lots more comments. I check the rewrite against the > source code so there should not be any serious errors. There are also a > number of what I believe to be defects in the original and places where > my comments may be inappropriate or my style may be very objectionable. > _This_ is what I need help with. > > Would someone be willing to review my rewrite? If so, send me e-mail so > I can arrange to get a copy of it to you. Remember that you won't get one big patch in at once, you need to split it up later. > P.S. to AJ et al. > > There is a _lot_ of documentation embedded in the wine code, but it is > hard to find at the moment. I'd like to see it indexed and this is the > program that does the extraction and indexing. Advice on making this > new version available and active are in order. > I think the idea of building upon the existing "documentation" somewhere else has a better chance than the "deal on the 100" -- Best Regards, André Hentschel

Feb. 28, 2011

Re: d3dx9_36: Stub ID3DXRenderToSurface, with tests

by Henri Verbeet

On 27 February 2011 20:22, Misha Koshelev <misha680(a)gmail.com> wrote: > +static HRESULT WINAPI ID3DXRenderToSurfaceImpl_QueryInterface(ID3DXRenderToSurface *iface, REFIID riid, void **ppobj) > +{ > + ID3DXRenderToSurfaceImpl *This = impl_from_ID3DXRenderToSurface(iface); You don't actually need "This" here. > + return D3D_OK; S_OK is more appropriate for QueryInterface. > + WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj); > + return E_NOINTERFACE; > +} You should set "*ppobj" to NULL here, unless there's a reason not to.

Feb. 28, 2011