September 2017 - Wine-Devel

Re: Please change WINE logo

by Farhad Mohammadi Majd

On Wed, 2017-09-27 at 07:45 -0500, Aric Stewart wrote: > ...... > OK, I wait to see a good designed logo and icon, but just don't forget this issue, thanks and good bye. .

Sept. 30, 2017

Re: [PATCH] midimap: Add warning for user in case midi won't work

by Fabian Maurer

> Oh, if you're intentionally just checking for the prefix then it's > fine as it is. I wasn't sure how certain the name of the port is, so I just checked the prefix. I initially wanted to use StrStrI, but this would mean linking against shlwapi, and I didn't want to add that dependency. Regards, Fabian Maurer

Sept. 29, 2017

Re: [PATCH] midimap: Add warning for user in case midi won't work

by Matteo Bruni

2017-09-29 21:17 GMT+02:00 Fabian Maurer <dark.shadow4(a)web.de>: > Thanks, you mean I should check whether the whole string equals "midi through > port" or what it is? Oh, if you're intentionally just checking for the prefix then it's fine as it is.

Sept. 29, 2017

Re: [PATCH] midimap: Add warning for user in case midi won't work

by Fabian Maurer

Thanks, you mean I should check whether the whole string equals "midi through port" or what it is? Regards, Fabian Maurer

Sept. 29, 2017

Re: [PATCH 3/3] mshtml/tests: Run events tests in IE9 mode.

by Jacek Caban

On 29.09.2017 19:50, Alexandre Julliard wrote: > Jacek Caban <jacek(a)codeweavers.com> writes: > >> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> >> --- >> dlls/mshtml/tests/events.c | 132 >> +++++++++++++++++++++++++++++++++++---------- >> 1 file changed, 103 insertions(+), 29 deletions(-) > It doesn't work here: Sorry about that, I sent the right version. Jacek

Sept. 29, 2017

Re: [PATCH 3/3] mshtml/tests: Run events tests in IE9 mode.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> > --- > dlls/mshtml/tests/events.c | 132 > +++++++++++++++++++++++++++++++++++---------- > 1 file changed, 103 insertions(+), 29 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -T ../../.. -M mshtml.dll -p mshtml_test.exe.so events && touch events.ok events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:917: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:954: Test failed: pdp->cArgs = 1 events.c:903: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1218: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1218: Test failed: pdp->cArgs = 1 events.c:1242: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1060: Test failed: pdp->cArgs = 1 events.c:1085: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1085: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1060: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1151: Test failed: pdp->cArgs = 1 events.c:1074: Test failed: pdp->cArgs = 1 events.c:1191: Test failed: pdp->cArgs = 1 Makefile:267: recipe for target 'events.ok' failed make[1]: *** [events.ok] Error 37 -- Alexandre Julliard julliard(a)winehq.org

Sept. 29, 2017

Re: [PATCH 1/3] mshtml: Inherit document mode from parent document.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=33334 Your paranoid android. === w7u (32 bit htmldoc) === htmldoc.c:2682: Test failed: unexpected call GetOverrideKeyPath htmldoc.c:5092: Test failed: unexpected call {d9befc84-f21e-4166-874b-a8d3010dc764}

Sept. 29, 2017

Re: mshtml: Inherit document mode from parent document.

by Jacek Caban

On 28.09.2017 21:11, Gijs Vermeulen wrote: > Hi, > > 2017-09-28 19:50 GMT+02:00 Jacek Caban <jacek(a)codeweavers.com > <mailto:jacek(a)codeweavers.com>>: > > + TRACE("parnet mode %u\n", parent_mode); > > > There seems to be a typo here. Good catch, thanks. Jacek

Sept. 29, 2017

Re: [v7 1/5] server: Named pipe query SD from pipe object

by Jacek Caban

Hi Jonathan, On 29.09.2017 14:35, Jonathan Doron wrote: > Hi Jackek, > > I went over your patch but I believe it might have few issues that i > wanted to raise before we change anything > 1. For some reason when you are doing the "ok" test after > CreateNamedPipe you do against != NULL should != INVALID_HANDLE_VALUE > this is critical... since the 2nd server might have failed with > OBJECT_NAME_ALREADY_EXISTS > 2. When you create the 2nd server instance against the "ok" check is > against NULL but not only that, you check against "server" and not > "server2" Good catch, thanks. > The reason I'm raising these issues is because from my understanding > of Windows, there can be only 1 instance for a given named pipe instance, There may be as many instances as you specify in CreateNamedPipe call. I fixed tests to handle that properly (see attachment). And, indeed, it looks like SD is shared between all pipe instances. Thanks, Jacek

Sept. 29, 2017

Re: [v7 1/5] server: Named pipe query SD from pipe object

by Jonathan Doron

Hi Jackek, I went over your patch but I believe it might have few issues that i wanted to raise before we change anything 1. For some reason when you are doing the "ok" test after CreateNamedPipe you do against != NULL should != INVALID_HANDLE_VALUE this is critical... since the 2nd server might have failed with OBJECT_NAME_ALREADY_EXISTS 2. When you create the 2nd server instance against the "ok" check is against NULL but not only that, you check against "server" and not "server2" The reason I'm raising these issues is because from my understanding of Windows, there can be only 1 instance for a given named pipe instance, Please see that once you change these things, my logic remains correct... and that simply server2 was never created and got INVALID_HANDLE_VALUE with a should be GLE of 231 aka ERROR_PIPE_BUSY. Please let me know how it goes so we will know how to continue. Thanks and I hope you have a great weekend, -- Jon. On Wed, Sep 27, 2017 at 6:33 PM, Jacek Caban <jacek(a)codeweavers.com> wrote: > Hi Jonathan, > > Your tests still don't really show intended behaviour. Your calls that > set security descriptor use new SD that has the same tested values as > before the call, then what's the point in setting it? Anyway, I cleaned > it up and changed a bit to see how it's really supposed to work. See the > attachment. > > It looks like client and served should indeed share security descriptor, > but pipe object should not, so that part is wrong. > > Thanks, > Jacek >

Sept. 29, 2017