November 2004 - Wine-Devel - list.winehq.org

which classes support aggregation?

by James Hawkins

IClassFactory->CreateInstance aggregation check: "The CreateInstance method of IClassFactory takes pUnkOuter as the second member. This parameter must be null unless the class supports aggregation, which many don't." Where can I find out which classes support aggregation? -- James Hawkins

Nov. 30, 2004

Re: implementing DllCanUnloadNow questions

by James Hawkins

On Tue, 30 Nov 2004 15:34:50 -0600, Robert Shearman <rob(a)codeweavers.com> wrote: > James Hawkins wrote: > > >I would like to work on the DllCanUnloadNow janitorial task, but I was > >wondering if there are any patches or examples of dll's that correctly > >implement this so that I can do it right. > > > > > > I don't know of any examples so far, but Mike Hearn and I will be > tackling OLE soon, so that will involve cleaning up ole32. However, that > probably won't happen until we've done some groundwork on COM first, so > feel free to beat us to it and make a shining example of a DLL that > correctly implements DllCanUnloadNow. > > > > >Is LockServer(TRUE/FALSE) the same as this example? > > > >static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { > > IClassFactoryImpl *This = (IClassFactoryImpl *)iface; > > FIXME("(%p)->(%d),stub!\n",This,dolock); > > return S_OK; > >} > > > >If they are the same, what is needed to complete this stub? I would > >think that there would be a refCount variable that is incremented if > >dolock is true and decremented if dolock is false. Also, should the > >LockServer functions be listed in the spec files of the dlls? > > > > > > No, the LockServer functions are part of IClassFactory vtables. Only > DllCanUnloadNow needs to be exported. > > >After implementing LockServer, it should be an easy matter to do a > >check for refCount == 0 to see if the dll can be unloaded or not. Am > >I heading in the right direction? > > > > > > To implement DllCanUnloadNow properly you need to do the following: > 1. Add a variable "LONG cLocks" and two function for manipulating it: > void LockModule() > { > InterlockedIncrement(&cLocks); > } > > void UnlockModule() > { > InterlockedDecrement(&cLocks); > } > 2. Increment cLocks on construction of every heap object: > static HRESULT Example_Construct(...) > { > ... > LockModule(); > return S_OK; > } > 3. Decrement cLocks on destruction of every heap object: > static ULONG Example_Release(...) > { > ... > res = InterlockedDecrement(&This->cRefs); > if (!res) > { > /* Free object's resources, including memory, etc. */ > UnlockModule(); > } > } > 4. For non-heap based objects (commonly objects with no state, like > IClassFactory): > static ULONG Example_AddRef(...) > { > LockModule(); > return 2; /* non-heap object */ > } > > static ULONG Example_Release(...) > { > UnlockModule(); > return 1; > } > 5. Implement IClassFactory_LockServer's as follows: > HRESULT WINAPI Example_LockServer(...) > { > if (bLock) > LockModule(); > else > UnlockModule(); > return S_OK; > } > 6. Then implement DllCanUnloadNow: > HRESULT WINAPI DllCanUnloadNow() > { > return cLocks > 0 : S_FALSE : S_OK; > } > > Rob > Attached is my beginning attempts at adding DllCanUnloadNow to msi. There are a couple questions I have though. > static HRESULT Example_Construct(...) > { > ... > LockModule(); > return S_OK; > } Is _Construct the same as _AddRef()? I'm thinking it's not. If it isn't, I need to add a MSI_Construct to msi. What are the parameters to the Construct function and what would usually go in the place of the "..."? > static ULONG Example_Release(...) > { > ... > res = InterlockedDecrement(&This->cRefs); > if (!res) > { > /* Free object's resources, including memory, etc. */ > UnlockModule(); > } > } > static ULONG Example_Release(...) > { > UnlockModule(); > return 1; > } Are these _Release's referring to the same function? If not, what is the difference? If so, which one should be implemented and what usually goes in the place of the "..."? -- James Hawkins

Nov. 30, 2004

Re: implementing DllCanUnloadNow questions

by Robert Shearman

James Hawkins wrote: >I would like to work on the DllCanUnloadNow janitorial task, but I was >wondering if there are any patches or examples of dll's that correctly >implement this so that I can do it right. > > I don't know of any examples so far, but Mike Hearn and I will be tackling OLE soon, so that will involve cleaning up ole32. However, that probably won't happen until we've done some groundwork on COM first, so feel free to beat us to it and make a shining example of a DLL that correctly implements DllCanUnloadNow. >Is LockServer(TRUE/FALSE) the same as this example? > >static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { > IClassFactoryImpl *This = (IClassFactoryImpl *)iface; > FIXME("(%p)->(%d),stub!\n",This,dolock); > return S_OK; >} > >If they are the same, what is needed to complete this stub? I would >think that there would be a refCount variable that is incremented if >dolock is true and decremented if dolock is false. Also, should the >LockServer functions be listed in the spec files of the dlls? > > No, the LockServer functions are part of IClassFactory vtables. Only DllCanUnloadNow needs to be exported. >After implementing LockServer, it should be an easy matter to do a >check for refCount == 0 to see if the dll can be unloaded or not. Am >I heading in the right direction? > > To implement DllCanUnloadNow properly you need to do the following: 1. Add a variable "LONG cLocks" and two function for manipulating it: void LockModule() { InterlockedIncrement(&cLocks); } void UnlockModule() { InterlockedDecrement(&cLocks); } 2. Increment cLocks on construction of every heap object: static HRESULT Example_Construct(...) { ... LockModule(); return S_OK; } 3. Decrement cLocks on destruction of every heap object: static ULONG Example_Release(...) { ... res = InterlockedDecrement(&This->cRefs); if (!res) { /* Free object's resources, including memory, etc. */ UnlockModule(); } } 4. For non-heap based objects (commonly objects with no state, like IClassFactory): static ULONG Example_AddRef(...) { LockModule(); return 2; /* non-heap object */ } static ULONG Example_Release(...) { UnlockModule(); return 1; } 5. Implement IClassFactory_LockServer's as follows: HRESULT WINAPI Example_LockServer(...) { if (bLock) LockModule(); else UnlockModule(); return S_OK; } 6. Then implement DllCanUnloadNow: HRESULT WINAPI DllCanUnloadNow() { return cLocks > 0 : S_FALSE : S_OK; } Rob

Nov. 30, 2004

Re: Debugging of Windows App

by Eric Pouech

Bernard Gallet a écrit : > I am trying to debug a Windows app on Wine. I have the source code, it is > compiled with Visual Studio 2002. I have not yet been able to get Line/File > info. It is my understanding that winedbg does not recognize pdb, however, I > am unable to link without one! Can somebody help? T IA, did you try latest CVS, there should be some support for it. A+

Nov. 30, 2004

Re: Winecfg -> browse for folder

by Robert van Herk

Steven Edwards wrote: >Hi, > >--- Francois Gouget <fgouget(a)free.fr> wrote: > > >>If there's something preventing it, wouln't a Shell Namespace >>extension >>be the right solution? >> >> > >This would be ideal. You there is lots of example code for extending >the namespace for CVS and SVN so adding support for a Unix filesystem >should not be too hard. > > Oops, I guess this suggestion was a bit too late, since I commited my patch this afternoon... thanks, Robert

Nov. 30, 2004

Re: wine/dlls/shell32 tests/shellpath.c version.h - IE6 breakage

by Juan Lang

--- Mike McCormack <mike(a)codeweavers.com> wrote: > The following seemingly simple and harmless change caused a regression > in IE6. The toolbar icons are no longer displayed and the error message > below appears in the log. Interesting. My preference would have been to use Win2K's shell32 version, but I didn't have Win2K handy. If you happen to know its version, that'd be cool. --Juan __________________________________ Do you Yahoo!? Yahoo! Mail - Helps protect you from nasty viruses. http://promotions.yahoo.com/new_mail

Nov. 30, 2004

implementing DllCanUnloadNow questions

by James Hawkins

I sent this message a couple months ago, but I got no response so I'll try again. I would like to work on the DllCanUnloadNow janitorial task, but I was wondering if there are any patches or examples of dll's that correctly implement this so that I can do it right. Is LockServer(TRUE/FALSE) the same as this example? static HRESULT WINAPI SFCF_LockServer(LPCLASSFACTORY iface,BOOL dolock) { IClassFactoryImpl *This = (IClassFactoryImpl *)iface; FIXME("(%p)->(%d),stub!\n",This,dolock); return S_OK; } If they are the same, what is needed to complete this stub? I would think that there would be a refCount variable that is incremented if dolock is true and decremented if dolock is false. Also, should the LockServer functions be listed in the spec files of the dlls? After implementing LockServer, it should be an easy matter to do a check for refCount == 0 to see if the dll can be unloaded or not. Am I heading in the right direction? -- James Hawkins

Nov. 30, 2004

Re: acmstream mem leak fix

by MichaelGuennewig＠gmx.de

James Hawkins <truiken(a)gmail.com> writes: > Unless I'm mistaken, we don't want to free allocated memory only when > the call fails. Sorry, but you are wrong. When you always free the memory you will run into a segmentation fault when the application uses the returned stream. The problem is the same as with the icmstream patch you made. The current implementation will work correctly in all cases although it doesn't look very COM-like as Mike already pointed out for the icmstream patch. The methods you analyzed are only called internally from IClassFactory_fnCreateInstance in the factory.c file. The memory block which is allocated by LocalAlloc in the AVIFILE_CreateICMStream and AVIFILE_CreateACMStream is only returned to the application if the IAVIStream_QueryInterface call doesn't return an error. So when you always free the memory block you will most probably run into a segmentation fault. The proposed patch from Mike for the icmstream.c file should be adapted to this file when you don't like the LocalFree call there, but I'm sure that then people will ask why we don't call LocalFree in this method. So it would be perhaps fine when also some comments would be added to prevent another discussion about what's wrong or correct. When you don't understand the code feel free to write me as I'm the one who has produced it. Regards Michael Günnewig

Nov. 30, 2004

Re: Winecfg -> browse for folder

by Steven Edwards

Hi, --- Francois Gouget <fgouget(a)free.fr> wrote: > If there's something preventing it, wouln't a Shell Namespace > extension > be the right solution? This would be ideal. You there is lots of example code for extending the namespace for CVS and SVN so adding support for a Unix filesystem should not be too hard. Thanks Steven __________________________________ Do you Yahoo!? The all-new My Yahoo! - What will yours do? http://my.yahoo.com

Nov. 30, 2004

Re: systray rewrite part 2

by Grant Williamson

Mike, ok the rewrite, applies & compiles cleanly on 20041019, however, running SIP Phone-lite, it does not show on the systray, the older patch did. I am running gnome-2.8 on rhel4, what program do you want us to test with it. Mike Hearn wrote: >Clearly, I need to figure out a system for generating patches. This time >with (hopefully) all the files in the patch. > >- Add a new wineshell process, and put system tray handling in there >- Rewrite the shell32 systray handling to be out of process >- Support the freedesktop.org XEMBED protocol > > >------------------------------------------------------------------------ > > > >

Nov. 30, 2004