May 2013 - Wine-Devel - list.winehq.org

Re: [1/2] DWrite: Implemented functions regarding text alignment. (try 3)

by Nikolay Sivov

On Fri, May 31, 2013 at 9:07 PM, Fabian Müntefering <Cookiezzz97(a)gmx.de>wrote: > Implemented functions of text format and text layout regarding text > alignment. > > Try 3: Used proper enum value to set the enum variables. > > > > > + if(alignment!=DWRITE_TEXT_ALIGNMENT_CENTER && alignment!=DWRITE_TEXT_ALIGNMENT_LEADING && + alignment!=DWRITE_TEXT_ALIGNMENT_JUSTIFIED && alignment!=DWRITE_TEXT_ALIGNMENT_TRAILING) + return E_INVALIDARG; + This->format.text_align = alignment; This doesn't look great, you'll need a test that shows it really rejects meaningless values, and if it does it would be simpler to compare with greatest enum value.

May 31, 2013

Re: ole32: Add a basic OLE client/server test suite. Take 2.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > >> With minor clean ups and with increased timeout to wait for server termination >> to please some really slow VMs (that allowed to remove broken() statements). > > It would be helpful to provide some feedback and explain the 'pending' state > of the patch which adds a test. It seems to be awfully complicated. In particular I don't think you need a shared mapping plus a pipe plus a mutex just to log tracing output. Redefining standard macros is also not a good idea. -- Alexandre Julliard julliard(a)winehq.org

May 31, 2013

Re: ole32: Add a basic OLE client/server test suite. Take 2.

by Dmitry Timoshkov

Dmitry Timoshkov <dmitry(a)baikal.ru> wrote: > With minor clean ups and with increased timeout to wait for server termination > to please some really slow VMs (that allowed to remove broken() statements). It would be helpful to provide some feedback and explain the 'pending' state of the patch which adds a test. -- Dmitry.

May 31, 2013

Re: [PATCH] slc: Fix return type

by Christian Costa

2013/5/31 Detlef Riekenberg <wine.dev(a)web.de> > Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr > > > > + */ > > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD > *pvalue) > > > +{ > > > > > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR > lpszValueName, LPDWORD pdwValue); > > > +SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *); > > > > > I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :) > > I disagree for "const WCHAR *", which is really rare used in Wine > (Please grep the headers yourself) > > There was a discussion about the LPxxx stuff removal (I guess Pxxx as well) some time ago. There was also something about const that doesn't behave as expected in that case but I don't remember the details. > pvalue is a matter of taste. > It's not particularily my taste. It's something preferred. It was just a guess since the patch was pending. Christian

May 31, 2013

Re: [PATCH] winmm/tests: Fix test that fails on NT4

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25788 Your paranoid android. === WINEBUILD (build) === Make failed

May 31, 2013

Re: [1/2] explorer: Initial implementation of desktop launchers.

by Hans Leidekker

On Fri, 2013-05-31 at 03:30 +0800, Qian Hong wrote: > On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker <hans(a)codeweavers.com> wrote: > > + hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder ); > > + if (FAILED( hr )) > > + { > > + WINE_ERR("Could not get user desktop folder\n"); > > + return; > > + } > > + hr = SHGetKnownFolderPath( &FOLDERID_PublicDesktop, 0, NULL, &desktop_folder_public ); > > + if (FAILED( hr )) > > + { > > + WINE_ERR("Could not get public desktop folder\n"); > > + CoTaskMemFree( desktop_folder ); > > + return; > > + } > > Does KF_FLAG_CREATE look better here? Other wise every time a new Yes, that makes sense.

May 31, 2013

Re: [PATCH] slc: Fix return type

by Detlef Riekenberg

Christian wrote at Wednesday, 29. Mai 2013 at 23:12 Uhr > > + */ > > +HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR name, DWORD *pvalue) > > +{ > > > > -SLCAPI DWORD WINAPI SLGetWindowsInformationDWORD(LPCWSTR lpszValueName, LPDWORD pdwValue); > > +SLCAPI HRESULT WINAPI SLGetWindowsInformationDWORD(PCWSTR, DWORD *); > > > I think s/PCWSTR/const WCHAR */ and s/pvalue/value/ would be better. :) I disagree for "const WCHAR *", which is really rare used in Wine (Please grep the headers yourself) pvalue is a matter of taste. I will send an updated version -- By by ... Detlef

May 30, 2013

Re: [1/2] explorer: Initial implementation of desktop launchers.

by Qian Hong

Hello Hans, On Tue, May 28, 2013 at 6:42 PM, Hans Leidekker <hans(a)codeweavers.com> wrote: > + hr = SHGetKnownFolderPath( &FOLDERID_Desktop, 0, NULL, &desktop_folder ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get user desktop folder\n"); > + return; > + } > + hr = SHGetKnownFolderPath( &FOLDERID_PublicDesktop, 0, NULL, &desktop_folder_public ); > + if (FAILED( hr )) > + { > + WINE_ERR("Could not get public desktop folder\n"); > + CoTaskMemFree( desktop_folder ); > + return; > + } Does KF_FLAG_CREATE look better here? Other wise every time a new wineprefix created there is an err output. Maybe I'm missing something here, thanks for your work. -- Regards, Qian Hong - http://www.winehq.org

May 30, 2013

Re: [PATCH 2/4] d3dxof: Move list type and list nb elements into the parse context.

by Alexandre Julliard

Christian Costa <titan.costa(a)gmail.com> writes: > --- > dlls/d3dxof/d3dxof_private.h | 2 ++ > dlls/d3dxof/parsing.c | 23 ++++++++++------------- > 2 files changed, 12 insertions(+), 13 deletions(-) It doesn't work: ../../../tools/runtest -q -P wine -M d3dx9_36.dll -T ../../.. -p d3dx9_36_test.exe.so mesh.c && touch mesh.ok mesh.c:2291: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2299: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2323: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2347: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2399: Test failed: Expected E_FAIL, got 0x88760390 mesh.c:2403: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2407: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2408: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2409: Test failed: Expected D3D_OK, got 0x88760390 mesh.c:2495: Tests skipped: D3DXCreateBox failed make: *** [mesh.ok] Error 9 -- Alexandre Julliard julliard(a)winehq.org

May 30, 2013

Re: [2/2] advpack: Handle quoted arguments to rundll exports.

by Alexandre Julliard

Vincent Povirk <madewokherd(a)gmail.com> writes: > @@ -205,13 +205,24 @@ static HRESULT run_setup_commands_callback(HINF hinf, PCWSTR field, const void * > > /* sequentially returns pointers to parameters in a parameter list > * returns NULL if the parameter is empty, e.g. one,,three */ > -LPWSTR get_parameter(LPWSTR *params, WCHAR separator) > +LPWSTR get_parameter(LPWSTR *params, WCHAR separator, int quoted) Using proper boolean type and constants would be preferable. -- Alexandre Julliard julliard(a)winehq.org

May 30, 2013