November 2016 - Wine-Devel - list.winehq.org

Re: [PATCH v3] winemapi: Directly use xdg-email if available, enabling file attachments.

by André Hentschel

Hi, comments inline Am 22.11.2016 um 20:46 schrieb Jeremy White: > -ULONG WINAPI MAPISendMail(LHANDLE session, ULONG_PTR uiparam, > +static ULONG BrowserSendMail(LHANDLE session, ULONG_PTR uiparam, > lpMapiMessage message, FLAGS flags, ULONG reserved) > { > ULONG ret = MAPI_E_FAILURE; > @@ -291,6 +370,129 @@ exit: > return ret; > } Do you need all those parameters? > +/************************************************************************** > + * XDGSendMail > + * > + * Send a message using xdg-email mail client. > + * > + */ > +ULONG XDGSendMail(LHANDLE session, ULONG_PTR uiparam, > + lpMapiMessage message, FLAGS flags, ULONG reserved) Same here Also should be a static function > + > + TRACE("(0x%08lx 0x%08lx %p 0x%08x 0x%08x)\n", session, uiparam, message, flags, reserved); I'd keep the TRACE in the WINAPI function > + > + if (!message) > + return MAPI_E_FAILURE; maybe this check, too > + max_args = 1 + (2 + message->nRecipCount + message->nFileCount) * 2; > + argv = HeapAlloc(GetProcessHeap(), 0, (max_args + 1) * sizeof(*argv)); > + if (!argv) > + return MAPI_E_INSUFFICIENT_MEMORY; > + > + ret = add_argument(argv, &argc, "xdg-email", NULL); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + > + if (message->lpOriginator) > + TRACE("From: %s (unused)\n", debugstr_a(message->lpOriginator->lpszAddress)); Why is the TRACE message different from the original function? > + > + for (i = 0; i < message->nRecipCount; i++) > + { > + if (!message->lpRecips) > + { > + WARN("Recipient %d missing\n", i); > + ret = MAPI_E_FAILURE; > + goto exit; > + } > + > + if (message->lpRecips[i].lpszAddress) > + { > + ret = add_target(argv, &argc, message->lpRecips[i].ulRecipClass, add_target is only used in one place, no need for a helper function IMO > + message->lpRecips[i].lpszAddress); > + if (ret != SUCCESS_SUCCESS) > + goto exit; > + } > + else > + FIXME("Name resolution and entry identifiers not supported\n"); > + } > + > + for (i = 0; i < message->nFileCount; i++) > + { > + TRACE("File Path: %s, name %s\n", debugstr_a(message->lpFiles[i].lpszPathName), > + debugstr_a(message->lpFiles[i].lpszFileName)); > + ret = add_file(argv, &argc, message->lpFiles[i].lpszPathName, message->lpFiles[i].lpszFileName); Same for add_file Hope that helps

Nov. 30, 2016

Call for tests - GNU/Linux & specially OSX - iphlpapi

by Bruno Jesus

Hello all, in order to exercise an IP ordering problem from bug 40247 (OSX) [1] I would like to request help for testing the crosstest at [2]. Valid testers must have at least 1 network interface with a valid IP and a the loopback interface up. A good test should result in 1 error, if not send me the results anyway, only the traces from lines 262 and 266 are needed (first in the log, 10 lines should be enough). If you find the lines I'm expecting just paste them, if you don't have patience just attach the whole results, pĺease. Sample output: bruno(a)Note:~/programs/wine32/dlls/iphlpapi/tests$ wine iphlpapi_crosstest.exe iphlpapi.c:262: Entry[0]: addr 127.0.0.1, dwIndex 1, wType 0x1 iphlpapi.c:266: Test failed: Loopback interface wrongly at position 0/3 iphlpapi.c:262: Entry[1]: addr 192.168.1.34, dwIndex 3, wType 0x1 iphlpapi.c:262: Entry[2]: addr 192.168.112.1, dwIndex 4, wType 0x1 iphlpapi.c:262: Entry[3]: addr 192.168.27.1, dwIndex 5, wType 0x1 [1] https://bugs.winehq.org/show_bug.cgi?id=40247 [2] https://testbot.winehq.org/JobDetails.pl?Key=27012 Thanks in advance, Bruno

Nov. 30, 2016

wine-1.8.6-rc1 Available

by Michael Stefaniuc

Hello guys, I have pushed wine-1.8.6-rc1 (with tag) to https://github.com/mstefani/wine-stable https://static-winehq.rhcloud.com/stable/ After introducing a regression into 1.8.5 I got a little bit risk averse so just 51 cherry-picks this time. For the release I would follow the same process: one week for feedback followed by another rc if needed with the final release 3-4 days later. But that might change as I'm travelling at the moment. And now the interesting parts from the ANNOUNCE file: What's new in this release (see below for details): - Fix a regression introduced in 1.8.5 (#41627) - Various bug fixes. - A few more cards added to the GPU description table. ---------------------------------------------------------------- Bugs fixed in 1.8.6 (total 35): 27671 ComboFix fails to install 29661 wineboot unable to create win32 prefix if the directory already exists 29916 ElsterFormular cannot make use of default PDF viewer (e. g. Okular) 30368 AMD Radeon 6480g detected as ATI Radeon 3200 30673 Smart Cutter 1.9.4 crashes when the button OPEN is pressed 32694 NVIDIA GTX 690 not in the list of recognized cards. 33636 wine cmd: invalid behaviour of '&' operator 35025 Max Payne 2 Demo: checkboxes in options dialog have missing window styles 35658 Anthem Room Correction 2 v1.0.1 reports 'Unknown COM error 0x80004001' (needs IAudioEndpointVolume::GetVolumeRange method implementation) 36101 Wow Hangs at login screen when coming from battle.net launcher (only with gxapi Opengl) 39447 Unimplemented function hid.dll.HidP_TranslateUsagesToI8042ScanCodes 39734 ProtectDisc Driver 11: acedrv11.sys crashes 40448 Final Fantasy XI: Missing character models, potential black screen and crashes 40540 ReadIntervalTimeout is ignored if there is data in the buffer when ReadFile is called and no data arrives after that 40746 Microsoft Expression Web 4 crashes when opening site, needs rpcrt4.dll.NdrAsyncServerCall 40861 Kingsoft Office 2012 needs ntoskrnl.exe.IoAttachDevice 40999 Epic Games Launcher needs ws2_32.InetNtopW 41021 Zombie Army trilogy needs msvcr100.dll._fpieee_flt 41050 Age of Mythology: Extended Edition needs api-ms-win-crt-stdio-l1-1-0.dll.__stdio_common_vswscanf 41090 Multiple games (Starcraft 2, UE4 games) require vcruntime140.dll.__intrinsic_setjmp 41142 gcc6: server build warnings 41224 WineD3D8 crashes on Windows with GTAVC and i915-class video 41284 dbghelp_dwarf: parse_cie_details unknown CIE version 4 (clang/mesa/valgrind) 41308 iconfig.exe needs msvcr120.??0_Condition_variable(a)details@Concurrency@@QAE(a)XZ 41343 Ellisys Visual USB needs unimplemented function newdev.dll.DiInstallDriverA 41389 ComboFix fails to install: complains about missing HKLM\System\CurrentControlSet\Control\hivelist 41405 Hornbill Supportworks Client 7.6.0: crashes with ExtFloodFill when open 'Incident Details' pane 41428 The Forest: Terminal gets spammed with errors if Steam is running 41570 Xenia emulator needs unimplemented function api-ms-win-core-rtlsupport-l1-1.RtlLookupFunctionEntry called in 64-bit code 41602 Videos do not play in Age of Empires 41627 MS Word 2010 crash when exiting on Wine stable 1.8.5. 41640 add rx 480 into directx.c 41642 S3CC921 programmer app needs ntoskrnl.exe.KeSetTimerEx 41651 WScript object name on wine is case sensitive which should not be the case (vbscript) 41705 Build fails in dpnet: redefinition of typedef 'SOCKADDR' ---------------------------------------------------------------- Changes since 1.8.5: Alex Henrie (1): ntdll: Skip synchronous read if a serial read interval timeout is set. Alexandre Julliard (2): server: Avoid some compiler warnings when EWOULDBLOCK == EAGAIN. ntdll: Add a helper function for registering a file read async I/O. Alistair Leslie-Hughes (2): comdlg32/tests: Test when a directory is passed to OpenFileName Dialog. dpnet: Header files cleanup. Andrew Eikum (1): mmdevapi: Implement IAudioEndpointVolume::GetVolumeRange. Andrew Kanaber (1): wined3d: Add id for Broadwell Xeon E3 GPU. Andrey Gusev (1): user32: Add support for WS_EX_RIGHT style. André Hentschel (1): loader/wine.inf: Open pdf files using winebrowser. Aric Stewart (1): hid: Stub HidP_TranslateUsagesToI8042ScanCodes. Austin English (5): wine.inf: Add HKLM\System\CurrentControlSet\Control\hivelist key. newdev: Add DiInstallDriverA/W stubs. api-ms-win-core-rtlsupport-l1-1-0: Add missing forwards. ntoskrnl.exe: Add IoAttachDevice stub. ntoskrnl.exe: Add KeSetTimerEx stub. Bernhard Übelacker (1): ntoskrnl.exe: Make IoAllocateIrp not crash on negative values. Bruno Jesus (3): xinput1_3: Prefer builtin DLL. comdlg32: Avoid crash when a path is passed into Open File Dialog. msvfw32/tests: Add tests for ICInfo(). Carlos Rafael Ramirez (1): cmd: When 'if' condition is not met, ignore the next commands in the list. Daniel Lehman (2): ucrtbase: Add __stdio_common_vfwprintf. ucrtbase: Add __stdio_common_vfwscanf. Filip Frąckiewicz (5): wined3d: Add NVIDIA GTX 690 (GK104) to the GPU list. wined3d: Add AMD Radeon HD 6480G IGP. wined3d: Add NVIDIA GTX 980 Ti. wined3d: Add NVIDIA GTX 675MX to the GPU list. wined3d: Add NVIDIA GTX 760 Ti to the GPU list. Grazvydas Ignotas (1): wined3d: Add Polaris GPUs and their driver. Huw D. M. Davies (3): ucrtbase: Add __stdio_common_vswscanf(). gdi32: Check that ExtFloodFill()'s initial co-ordinates lie within the dib. fonts: Fix typo in glyph name. Jacek Caban (4): msctf: Don't call ITextStoreACP::UnadviseSink in context destructor. msctf: Added Push/Pop context tests. vbscript: Call GetItemInfo() with original item name. secur32: Use %LATEST_RECORD_VERSION gnutls priority. Józef Kucia (1): wined3d: Improve advertized driver version for Windows 10. Matteo Bruni (2): wined3d: Recognize a couple of Haswell / Broadwell GPUs on macOS. wined3d: Add a bunch of Broadwell and Skylake PCI ids and descriptions. Michael Müller (2): ntdll: Open current working directory with FILE_TRAVERSE access. msvfw32: Use case insensitive compare in ICInfo for fourcc codes. Nikolay Sivov (3): dbghelp: Support CIE version 4 in parse_cie_details(). rpcrt4: Added NdrAsyncServerCall stub. ucrtbase: Fix some spec file entries. Philipp Hoppermann (1): ws2_32: Implement InetNtopW. Piotr Caban (5): ucrtbase: Add __intrinsic_setjmp implementation. msvcrt: Add _fpieee_flt stub. msvcrt: Support fdiv m64fp in i386 _fpieee_flt. msvcr110: Add Concurrency::details::_Condition_variable class stub. msvcr120: Add _Condition_variable implementation. Ruslan Kabatsayev (1): wined3d: Initialise p_wglGetPixelFormat when USE_WIN32_OPENGL is defined. Sebastian Lackner (1): server: Allow to create win32 prefix when directory already exists. -- Michael Stefaniuc mstefani(a)winehq.org

Nov. 30, 2016

Windows 2008 does not support MP3 correctly in msacm32.dll?

by Bruno Jesus

Hi, in an attempt to add MP3 tests from Michael Müller it looks like the only machine that has trouble is Windows 2008 [1]. Around half of the tests are rejected while in all other versions it worked fine. Could there be a simple explanation to this? [1] https://testbot.winehq.org/JobDetails.pl?Key=27009 Best wishes, Bruno

Nov. 30, 2016

Re: [PATCH 1/2] server: Store async list in process object and use that to find async in cansel_async request.

by Alexandre Julliard

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -614,6 +615,7 @@ static void process_destroy( struct object *obj ) > > /* we can't have a thread remaining */ > assert( list_empty( &process->thread_list )); > + assert( list_empty( &process->asyncs )); I don't think that this is guaranteed, I believe that there can still be asyncs in the queues of shared files. We'd probably need to clear them explicitly at process exit. -- Alexandre Julliard julliard(a)winehq.org

Nov. 30, 2016

Re: [PATCH 8/9] d3d10core/tests: Add test for two sided stencil.

by Henri Verbeet

On 30 November 2016 at 12:47, Józef Kucia <jkucia(a)codeweavers.com> wrote: > + ds_desc.FrontFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.FrontFace.StencilFunc = D3D10_COMPARISON_NEVER; > + ds_desc.BackFace.StencilFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilDepthFailOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilPassOp = D3D10_STENCIL_OP_ZERO; > + ds_desc.BackFace.StencilFunc = D3D10_COMPARISON_ALWAYS; It's fine for a start, but note that this test doesn't do much for front/back stencil ops. Also, fwiw, in d3d9:visual there's stencil_cull_test() that's similar.

Nov. 30, 2016

Re: [PATCH 03/10] server: Use async object to transfer IRP result to client.

by Jacek Caban

On 28.11.2016 16:54, Alexandre Julliard wrote: > Jacek Caban <jacek(a)codeweavers.com> writes: > >> diff --git a/server/file.h b/server/file.h >> index c0a53a2..75a2e03 100644 >> --- a/server/file.h >> +++ b/server/file.h >> @@ -53,6 +53,8 @@ struct fd_ops >> void (*reselect_async)( struct fd *, struct async_queue *queue ); >> /* cancel an async operation */ >> int (*cancel_async)(struct fd *, struct process *process, struct thread *thread, client_ptr_t iosb); >> + /* find an async operation in queues */ >> + struct async *(*find_async)( struct fd *fd, struct process *process, client_ptr_t client_async ); >> }; > I think a per-process list of async/iosb would make more sense. There > should be nothing file type specific about finding an async. It could > probably be used to get rid of cancel_async() too. Indeed, it's much cleaner. I sent a patch implementing that. Thanks, Jacek

Nov. 30, 2016

Re: Github mirror seems to be out-of-sync

by Akihiro Sagawa

On Thu, 24 Nov 2016 19:39:05 +0300, Nikolay Sivov wrote: > On 24.11.2016 19:19, Akihiro Sagawa wrote: > > Official Github mirror, https://github.com/wine-mirror/wine, seems to be > > not updated for a few days. Could you take a look? > > Thanks in advance. > > I think github automatically maintains this mirror on its own, it wasn't > Wine project initiative to have it. It has been fixed. Wine mirror repository on Github and other Github mirrors are up to date. I contacted Github support last night. Then, they found out the problem and fixed it. Nikolay, thank you giving me nice hint. Akihiro Sagawa

Nov. 30, 2016

Re: [resend] fusion: Avoid buffer overflow in enum_gac_assemblies.

by Alexandre Julliard

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > [ Marvin indicated testing went fine, and I did not see any feedback > for two weeks. Only the description below has changed a little. ] > > In enum_gac_assemblies we have the following > > sprintf(buf, ", Version=%s, Culture=%s, PublicKeyToken=%s", > ffd.cFileName, culture, ptr); > > culture is declared as char[MAX_PATH], and WIN32_FIND_DATAA.cFileName > is CHAR[260], so a mere size of MAX_PATH for the output buffer buf is > not sufficient. > > (We need to double sizeof(ffd.cFileName) since ptr also points > into it.) They all point into the same path, so the total size is not going to exceed MAX_PATH (modulo the additionally printed chars). And it doesn't make sense to fix this buffer but not the other ones, you are just moving the bug. -- Alexandre Julliard julliard(a)winehq.org

Nov. 29, 2016

Re: Serial port sniffing problem

by Christopher Harrington

(copying list again, below edited for brevity) On Tue, Nov 29, 2016 at 12:39 PM Bill Lionheart <billlionheart(a)gmail.com> wrote: > $ ls -Fl > lrwxrwxrwx 1 bill bill 10 May 11 2014 c: -> ../drive_c/ > lrwxrwxrwx 1 bill bill 12 Jan 6 2016 com1 -> /dev/ttyUSB0 > > $ id -a > uid=1001(bill) gid=1001(bill) > groups=1001(bill),20(dialout) > $ ls -l /dev/ttyUSB0 > crw-rw---- 1 root dialout 188, 0 Nov 29 18:27 /dev/ttyUSB0 > > > All of this definitely looks correct. Here are a couple more suggestions: 1. Try creating a brand new wine prefix. Yours certainly has a beard on it and there may be artifacts of older copies of Wine that could be impacting your testing. Anyway, this essentially would look like moving ~/.wine to somewhere else, installing your test application again, and re-creating your com1 file in dosdevices/. You can always move your .wine directory back if it has important stuff in it. 2. See if using a more current version of Wine improves anything. You say you're on Wine 1.8; if you could be more specific (try running wine --version) that might give someone a lightbulb. 3. Crossover from Codeweavers is appallingly affordable if you haven't looked into that yet, and it comes with professional support. Anyway, wine-devel is more for discussion of development of Wine itself, not a support forum. What you're probably looking for is wine-users. I'm not subscribed to wine-users, so I can't copy your email there, but you can subscribe here: https://www.winehq.org/mailman/listinfo/wine-users Good luck. > > On 29 November 2016 at 17:57, Christopher Harrington > <ironiridis+winehq(a)gmail.com> wrote: > > On Tue, Nov 29, 2016 at 1:22 AM Bill Lionheart <billlionheart(a)gmail.com> > > wrote: > >> > >> Using Wine version 1.8 on Ubuntu 14.04.5 > >> I'm trying to use a AVRT5 APRS amateur radio GPRS tracker which has a > >> serial interface. The device is supplied with a Prolific USB serial > >> converter which comes up as /dev/ttyUSB0 which > >> I have sym linked to COM1 > > > > > > Can you please cd into your dosdevices folder and run this command? > > > > ls -Fl > > > > (that's an uppercase F and a lowercase L) > > > > Then we will also need to see permissions of the serial device, so run > this: > > > > ls -l /dev/ttyUSB0 > > > > That's a lowercase L again... and run this too: > > > > id -a > > > > With all this info we can rule out a couple problems, chief among them: > > 1. Is the symlink named correctly and actually pointing to something that > > exists > > 2. Do you actually have permissions to access the serial port > > > > If you provide the output of all three of these commands, we should be > able > > to help. > > > > -Chris > > > >> > >> > > > > > > -- > Professor of Applied Mathematics > University of Manchester > http://www.maths.manchester.ac.uk/bl >

Nov. 29, 2016