June 2004 - Wine-Devel - list.winehq.org

Pango for BiDi

by Mike Hearn

Hi Shachar, I am reading your interview and a few words jumped out at me, mostly "BiDi", "shaping" and "unicode" - very vague I know, but if I understand correctly Pango is a library with advanced support for shaping and laying out all kinds of different scripts. Only stopper I can think of would be that it uses UTF-8 not UTF-16. Have you looked at this, or am I talking smack? thanks -mike

June 30, 2004

Re: dlls/shell32 W->A cleanup of systray.c

by Marcelo Duarte

Danny Hawkins wrote: >Hi, > >Converted all wide-char->ansi calls to ansi->wide-char in systray.c > > > The TTM_UPDATETIPTEXTA should be converted to TTM_UPDATETIPTEXTW and TTM_ADDTOOLA -> TTM_ADDTOOLW >@@ -272,13 +272,13 @@ > ti.rect.bottom = ICON_SIZE+2*ICON_BORDER; > > if(modify) >- SendMessageA(ptrayItem->hWndToolTip, TTM_UPDATETIPTEXTA, 0, (LPARAM)&ti); >+ SendMessageW(ptrayItem->hWndToolTip, TTM_UPDATETIPTEXTA, 0, (LPARAM)&ti); > else >- SendMessageA(ptrayItem->hWndToolTip, TTM_ADDTOOLA, 0, (LPARAM)&ti); >+ SendMessageW(ptrayItem->hWndToolTip, TTM_ADDTOOLA, 0, (LPARAM)&ti); > } > > Here, you should'nt cast (WCHAR *)"". Please define: static const WCHAR emptyW[] = {0}; Or modify the function to accept NULL. >@@ -297,15 +297,15 @@ > (*ptrayItem)->notifyIcon.hWnd = pnid->hWnd; /* only needed for callback message */ > SYSTRAY_ItemSetIcon (*ptrayItem, (pnid->uFlags&NIF_ICON) ?pnid->hIcon :0); > SYSTRAY_ItemSetMessage(*ptrayItem, (pnid->uFlags&NIF_MESSAGE)?pnid->uCallbackMessage:0); >- SYSTRAY_ItemSetTip (*ptrayItem, (pnid->uFlags&NIF_TIP) ?pnid->szTip :"", FALSE); >+ SYSTRAY_ItemSetTip (*ptrayItem, (pnid->uFlags&NIF_TIP) ?pnid->szTip :(WCHAR *)"", FALSE); > > The old code should be eliminated, not commented: >+/*{ > BOOL flag=FALSE; > TRACE("enter %p %d %ld\n", pnid->hWnd, pnid->uID, dwMessage); > switch(dwMessage) { >@@ -377,13 +390,30 @@ > } > TRACE("leave %p %d %ld=%d\n", pnid->hWnd, pnid->uID, dwMessage, flag); > return flag; >-} >+}*/ > > > >+/*{ > BOOL ret; > > PNOTIFYICONDATAA p = HeapAlloc(GetProcessHeap(),0,sizeof(NOTIFYICONDATAA)); >@@ -395,4 +425,4 @@ > > HeapFree(GetProcessHeap(),0,p); > return ret; >-} >+}*/ > >

June 30, 2004

taskmgs hangs on edit debug channels

by Andrei Barbu

The taskmanager dies when trying to edit the debug channels of any programs with the newest CVS (checked out 2 days ago) It just sits there with this: 002e:Ret x11drv.MsgWaitForMultipleObjectsEx() retval=00000102 ret=409cd43c 002e:Call kernel32._ConfirmSysLevel(40a08ac0) ret=409a3f15 002e:Ret kernel32._ConfirmSysLevel() retval=00000000 ret=409a3f15 002e:Call kernel32.GlobalLock16(0000116f) ret=40999b70 002e:Ret kernel32.GlobalLock16() retval=404326d0 ret=40999b70 002e:Call kernel32.ReleaseThunkLock(41625f7c) ret=409cd30f 002e:Ret kernel32.ReleaseThunkLock() retval=00000000 ret=409cd30f 002e:trace:msg:GetMessageW (116f) mask=0000007f, bits=00000000, changed=00000000, waiting 002e:Call kernel32.ReleaseThunkLock(41625fe4) ret=409cd684 002e:Ret kernel32.ReleaseThunkLock() retval=00000000 ret=409cd684 002e:Call x11drv.MsgWaitForMultipleObjectsEx(00000001,404326d4,ffffffff,00000000,00000000) ret=409cd6c6 002e:Call ntdll.RtlEnterCriticalSection(40d76680) ret=40d54902 002e:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=40d54902 002e:Call ntdll.RtlLeaveCriticalSection(40d76680) ret=40d54932 002e:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=40d54932 002e:Call ntdll.RtlEnterCriticalSection(40d76680) ret=40d54902 002e:Ret ntdll.RtlEnterCriticalSection() retval=00000000 ret=40d54902 002e:Call ntdll.RtlLeaveCriticalSection(40d76680) ret=40d54932 002e:Ret ntdll.RtlLeaveCriticalSection() retval=00000000 ret=40d54932 002e:Call kernel32.WaitForMultipleObjectsEx(00000002,41625dac,00000000,ffffffff,00000000) ret=40d383db 002e:Call ntdll.NtWaitForMultipleObjects(00000002,41625ba0,00000000,00000000,00000000) ret=40591c85 If I move the mouse it spits out the correct mouse messages which indicate that wine itself is running just fine. The taskmanager window doesn't get redrawn (the black backround around it does). The backtrace from that point is: =>1 0x400636a9 (0x41b2be48) 2 0x402335c2 NTDLL_wait_for_multiple_objects+0x122(count=0x1, handles=0x41b2bf38, flags=0x4, timeout=0x0) [sync.c:587] in ntdll (0x41b2beec) 3 0x40233636 NtWaitForMultipleObjects+0x66(count=0x1, handles=0x41b2bf38, wait_all=0x0, alertable=0x0, timeout=0x0) [sync.c:605] in ntdll (0x41b2bf14) 4 0x40591c85 WaitForMultipleObjectsEx+0xb5(count=0x1, handles=0x41b2c06c, wait_all=0x0, timeout=0xffffffff, alertable=0x0) [sync.c:171] in kernel32 (0x41b2c044) 5 0x40591b1a WaitForSingleObject+0x3a(handle=0x6c, timeout=0xffffffff) [sync.c:99] in kernel32 (0x41b2c064) 6 0x40656867 ProcessPageRefreshThread+0x87(lpParameter=0x0) [procpage.c:511] in taskmgr (0x41b2c1a4) 7 0x40598fba THREAD_Start+0x11a(ptr=0x40450220) [thread.c:107] in kernel32 (0x41b2c27c) 8 0x40234fe9 start_thread+0x199(info=0x40450240) [thread.c:198] in ntdll (0x41b2cacc) 9 0x4005df70 (0x41b2cbcc) 10 0x4017e40a (0x00000000) Any ideas? I'm not quite versed enough in wine to know what's happening too well. I realise it's a thread waiting for another that apparently never finishes.. or I think it is, and I'm kind of lost from there. Thanks, Andrei

June 30, 2004

Re: Scrollbars, an application bug or a wine regression ? (#2314)

by George Marshall

Dmitry Timoshkov wrote: > Do you have a small application I could test with? Unfortunatly not :-( , the application you see in the screenshots (bug #2314) is run by a cobol runtime which is not freely distributable, it needs a license key. But I could test things for you if you want. Regards. PS: You could try with the application submitted in bug #2302

June 30, 2004

Re: Scrollbars, an application bug or a wine regression ? (#2314)

by Dmitry Timoshkov

"George Marshall" <g.marshall(a)nospam.com> wrote: > > Does reverting of the following patch help? > > Yes it does make the application work as it did before > the June Release :-) Do you have a small application I could test with? -- Dmitry.

June 30, 2004

Re: Cleaning up W->A calls

by Steven Edwards

Hi James, --- James Hawkins <truiken(a)comcast.net> wrote: > If I'm totally off the mark, let me know, and if there are other > jobs I > could be doing, let me know as well because I would like to > contribute, > but I'm not exactly sure what to do yet. Thankyou for your time. Welcome! I dont think it matters from a performance point of view. From my reading of documentation regarding Windows NT it seems they have abut a 20% performance hit on the ASCII calls vs the Unicode calls. I think that they implement both ASCII and Unicode rather than have ASCII call the unicode functions. (This is due to the fact that they had a semi-share source base with Win9x). Most of Wine just has the A function call the W function so I would follow this standard. It will reduce code duplication and prob'l lessen bugs. Thanks Steven __________________________________ Do you Yahoo!? New and Improved Yahoo! Mail - Send 10MB messages! http://promotions.yahoo.com/new_mail

June 30, 2004

Re: Scrollbars, an application bug or a wine regression ? (#2314)

by George Marshall

Dmitry Timoshkov wrote: > Does reverting of the following patch help? Yes it does make the application work as it did before the June Release. Great !

June 30, 2004

Re: Scrollbars, an application bug or a wine regression ? (#2314)

by George Marshall

Dimitrie O. Paun wrote: > On Wed, Jun 30, 2004 at 10:04:49AM +0200, George Marshall wrote: > >>Well no, with the Wine release of May the application had no >>scrollbars (correctly) while with June release the scrollbars >>are shown and are not working properly. > > > Figuring out the exact patch that introduced the problem would > be most helpful: > > http://winehq.org/site/docs/wine-devel/cvs-regression > The patch that Dimitry Timoshkov posted in this topic fixes the (regression?) issue .

June 30, 2004

Re: Scrollbars, an application bug or a wine regression ? (#2314)

by Dimitrie O. Paun

On Wed, Jun 30, 2004 at 10:04:49AM +0200, George Marshall wrote: > Well no, with the Wine release of May the application had no > scrollbars (correctly) while with June release the scrollbars > are shown and are not working properly. Figuring out the exact patch that introduced the problem would be most helpful: http://winehq.org/site/docs/wine-devel/cvs-regression -- Dimi.

June 30, 2004

err:opengl:X11DRV_ChoosePixelFormat Flag not supported

by Tobias Burnus

Hello, I have the following problems with WINE, CVS version as of yesterday and Crystal Impact's Diamond http://www.crystalimpact.com/diamond/ http://www.crystalimpact.com/download/diamond/demo/dm2demo.exe, which installs flawlessly. a) I get a err:opengl:X11DRV_ChoosePixelFormat Flag not supported when I open e.g. ./Samples/Minerals/Copper.dsf and a dialogbox with the following text is shown: ChoosePixelFormat() returns 0 (last error = 0) SetPixelFormat() returns 1 (last error = 0) wglCreateContext() returns 0 (last error 2000) wglMakeCurrent() returns 1 (last error = 0) (Workaround: disable rendering) b) Some data is displayed as list, e.g. like http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list.png under WINE this is completely mangled: http://www.physik.fu-berlin.de/~tburnus/wine/diamond_list_wine.png Sometimes some spread numbers appear, but in this case one can only mark cells. Any ideas how to fix/debug this? (I have unfortunally no experience at all in programming in Wine/Windows.) Anyone volunteering to look at this? I'm willing to spend some $$ (but not $$$) on that (I know that this is not much, but some rewarding of volunteer work doesn't hurd either). Regards, Tobias

June 30, 2004