July 2013 - Wine-Devel - list.winehq.org

Re: [PATCH 11/11] appelp: Add tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=26546 Your paranoid android. === WINEBUILD (build) === Patch failed to apply

July 31, 2013

Re: [PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)

by Alexandre Julliard

Caibin Chen <tigersoldi(a)gmail.com> writes: > There are at least 3 more interfaces to be implemented, should I put > them in richole.c as well? For now, yes. -- Alexandre Julliard julliard(a)winehq.org

July 31, 2013

Re: [PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)

by Caibin Chen

There are at least 3 more interfaces to be implemented, should I put them in richole.c as well? 2013/7/31 Alexandre Julliard <julliard(a)winehq.org>: > Caibin Chen <tigersoldi(a)gmail.com> writes: > >> Hi Alexandre, >> >> I think it make sense to have a separate file for ITextDocument. It >> will be used in txtsrv.c and richole.c (See patch 4). If it's WINE's >> convention to not have separate files for separate implementations, I >> can merge the txtrng.[ch] and txtsel.[ch] that introduced in patch 2 >> and 3 into txtdoc.[ch] > > It's already defined and used in richole.c. If at some point it becomes > too large it can be moved to a different file, but introducing a new > file and then removing that stuff from richole.c makes a mess of the > history. > > -- > Alexandre Julliard > julliard(a)winehq.org

July 31, 2013

Re: [PATCH] d3dx9_36: Filter out D3DCompile warning messages that are not present with D3DCompileShader.

by Stefan Dösinger

Am 2013-07-31 16:01, schrieb Christian Costa: > AFAIK no. My localization is french and I get english messages. Any > idea how I can check that? Should be ok then. > The parsing code handles missing null byte as well as both > unix/dos text formats but maybe I can just simplify it by using > strtok_r and assume dos format with null byte. Is there any reason why the format would change? > I'm afraid this is the only solution. AFAIK there is no option > that disable this warning. As far as my reserch goes, D3DCompileShader() is d3dx9's function and d3dcompiler.dll only has D3DCompile(), is that correct? If so, parsing the warnings is probably the least bad option. The obvious alternative is to ignore the mix of builtin d3dx9 and native d3dcompiler - but at some point we may want to write the same warnings from our d3dcompiler and the problem returns. In either case, please write some tests that demonstrate that d3dx9 does not generate those warnings.

July 31, 2013

Re: [PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)

by Alexandre Julliard

Caibin Chen <tigersoldi(a)gmail.com> writes: > Hi Alexandre, > > I think it make sense to have a separate file for ITextDocument. It > will be used in txtsrv.c and richole.c (See patch 4). If it's WINE's > convention to not have separate files for separate implementations, I > can merge the txtrng.[ch] and txtsel.[ch] that introduced in patch 2 > and 3 into txtdoc.[ch] It's already defined and used in richole.c. If at some point it becomes too large it can be moved to a different file, but introducing a new file and then removing that stuff from richole.c makes a mess of the history. -- Alexandre Julliard julliard(a)winehq.org

July 31, 2013

Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()

by Bruno Jesus

On Wed, Jul 31, 2013 at 10:21 AM, Thomas Faber <thfabba(a)gmx.de> wrote: > On 2013-07-31 02:48, Bruno Jesus wrote: >> + ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size), "getsockopt failed with %d\n", >> + WSAGetLastError()); > > It's not guaranteed that getsockopt is called before WSAGetLastError > here. (in fact the latter will be evaluated first with most practically > used calling conventions) > So this needs a variable. I see, thanks. Unfortunately previous patches already introduced that in 5 other places. If the patch is not commited today I'll change all older issues and send a new version fixing this. If the patch is commited today I'll send another patch fixing the 6 places. > Best, > Thomas Best wishes, Bruno

July 31, 2013

Re: [PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)

by Caibin Chen

Hi Alexandre, I think it make sense to have a separate file for ITextDocument. It will be used in txtsrv.c and richole.c (See patch 4). If it's WINE's convention to not have separate files for separate implementations, I can merge the txtrng.[ch] and txtsel.[ch] that introduced in patch 2 and 3 into txtdoc.[ch] 2013/7/31 Alexandre Julliard <julliard(a)winehq.org>: > Caibin Chen <tigersoldi(a)gmail.com> writes: > >> Thanks Jacek for reviewing. This time I send all the changes I have in >> 4 patches to make it clear that ReTxtDoc is reused between txtsrv.c >> and richole.c >> - Suppressed Patch 97331 >> - Change log from try 2: >> - follow COM naming convention >> - move ReTxtDoc definition to header, removed >> ReTxtDoc_get_ITextDocument() function >> - remove COM aggregation test for ITextDocument, only test >> ITextService supports querying for the interface. >> >> --- >> dlls/riched20/Makefile.in | 1 + >> dlls/riched20/tests/txtsrv.c | 10 ++ >> dlls/riched20/txtdoc.c | 270 +++++++++++++++++++++++++++++++++++++++++++ >> dlls/riched20/txtdoc.h | 51 ++++++++ >> dlls/riched20/txtsrv.c | 6 + > > Please avoid adding too many source files. In particular, if you have to > add new headers and define objects there, it's a sign that things should > be grouped in the same file. That's even more true for ITextDocument > that already exists. > > -- > Alexandre Julliard > julliard(a)winehq.org

July 31, 2013

Re: d3dx9: Replace M_PI by its D3DX equivalent

by Alexandre Julliard

Nozomi Kodama <nozomi.kodama(a)yahoo.com> writes: > What is the problem with patch: > http://source.winehq.org/patches/data/97500 > > M_PI is never used in D3DX (moreover it is deprecated in C99) It's used all over the place, and we have portability macros for it. There's no reason to avoid it. -- Alexandre Julliard julliard(a)winehq.org

July 31, 2013

Re: kernel32: Fix parameters checking for GetVolumePathName()

by Alexandre Julliard

Bruno Jesus <00cpxxx(a)gmail.com> writes: > @@ -1813,6 +1821,8 @@ BOOL WINAPI GetVolumePathNameW(LPCWSTR filename, LPWSTR volumepathname, DWORD bu > volumepathname[3] = 0; > return TRUE; > } > + > + SetLastError(ERROR_FILENAME_EXCED_RANGE); > return FALSE; This doesn't really make sense as a general error. -- Alexandre Julliard julliard(a)winehq.org

July 31, 2013

Re: [PATCH 1/4] riched20: Basic ITextDocument implementation for ITextServices (try 3)

by Alexandre Julliard

Caibin Chen <tigersoldi(a)gmail.com> writes: > Thanks Jacek for reviewing. This time I send all the changes I have in > 4 patches to make it clear that ReTxtDoc is reused between txtsrv.c > and richole.c > - Suppressed Patch 97331 > - Change log from try 2: > - follow COM naming convention > - move ReTxtDoc definition to header, removed > ReTxtDoc_get_ITextDocument() function > - remove COM aggregation test for ITextDocument, only test > ITextService supports querying for the interface. > > --- > dlls/riched20/Makefile.in | 1 + > dlls/riched20/tests/txtsrv.c | 10 ++ > dlls/riched20/txtdoc.c | 270 +++++++++++++++++++++++++++++++++++++++++++ > dlls/riched20/txtdoc.h | 51 ++++++++ > dlls/riched20/txtsrv.c | 6 + Please avoid adding too many source files. In particular, if you have to add new headers and define objects there, it's a sign that things should be grouped in the same file. That's even more true for ITextDocument that already exists. -- Alexandre Julliard julliard(a)winehq.org

July 31, 2013