December 2011 - Wine-Devel - list.winehq.org

new d3d9/device.ok test always fails here, but not a regression?

by Dan Kegel

Happy New Year's Eve, everyone! 002447357c2b1feca5ef2649429fc55f70238901 added a IDirect3DDevice9::SetCursorPosition() test to d3d9. That test never worked here, I think. I filed http://bugs.winehq.org/show_bug.cgi?id=29094 for it, and marked it as a regression (since tests/device.c used to pass, but fails here after that commit). Henri removed the regression keyword and sha1sum without comment. What's the reasoning there? Is Henri saying there's something wrong with my test setup (stock ubuntu), or are new tests that cause 'make test' to fail not considered regressions? Or something else?

Dec. 31, 2011

Re: Status on SetPixelFormat patch from May 2010

by Henri Verbeet

On 31 December 2011 12:51, Jeff Cook <jeff(a)deserettechnology.com> wrote: > Do you mind going into more detail on the motive for waiting for 1.4? > I was under the impression that WINE didn't usually postpone big > changes until an rc series was ongoing or at least anticipated. Is > there discussion of starting the 1.4 RC phase soon, and that's the > motive for holding off? I am just curious to know why you're waiting. Yes, I'd expect a freeze fairly soon. This change would be part of a larger set of changes to make wined3d work properly without a window to render to, and would probably be fairly invasive.

Dec. 31, 2011

Re: Status on SetPixelFormat patch from May 2010

by Jeff Cook

On Fri, Dec 30, 2011 at 11:43 PM, Henri Verbeet <hverbeet(a)gmail.com> wrote: > On 30 December 2011 22:15, Chris Robinson <chris.kcat(a)gmail.com> wrote: >> years ago. I think a better fix would be for wined3d to use a dummy surface, >> or a renderless context (available with OpenGL 3.0), if it's asked to use the >> desktop window. >> > Yes, we do something along those lines in ddraw, and we'll likely move > it to wined3d after 1.4. > Do you mind going into more detail on the motive for waiting for 1.4? I was under the impression that WINE didn't usually postpone big changes until an rc series was ongoing or at least anticipated. Is there discussion of starting the 1.4 RC phase soon, and that's the motive for holding off? I am just curious to know why you're waiting.

Dec. 31, 2011

Re: Status on SetPixelFormat patch from May 2010

by Henri Verbeet

On 30 December 2011 22:15, Chris Robinson <chris.kcat(a)gmail.com> wrote: > years ago. I think a better fix would be for wined3d to use a dummy surface, > or a renderless context (available with OpenGL 3.0), if it's asked to use the > desktop window. > Yes, we do something along those lines in ddraw, and we'll likely move it to wined3d after 1.4.

Dec. 31, 2011

Re: Status on SetPixelFormat patch from May 2010

by Chris Robinson

On Friday, December 30, 2011 1:41:12 PM Jeff Cook wrote: > Hello all > > I am curious about the patch on > http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in > vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a > pretty cogent explanation of the issue and the patch appears > reasonable enough. Because it's not correct. OpenGL's SetPixelFormat on the desktop window (GetDC(0)) is supposed to fail, or at least did when I made tests for it a few years ago. I think a better fix would be for wined3d to use a dummy surface, or a renderless context (available with OpenGL 3.0), if it's asked to use the desktop window.

Dec. 30, 2011

Status on SetPixelFormat patch from May 2010

by Jeff Cook

Hello all I am curious about the patch on http://bugs.winehq.org/show_bug.cgi?id=18490 and why it's not in vanilla. http://bugs.winehq.org/show_bug.cgi?id=18490#c9 seems to be a pretty cogent explanation of the issue and the patch appears reasonable enough. It prevents a major crasher in Empire: Total War, which otherwise works really well. Maybe it was just never submitted to wine-patches? Thanks Jeff

Dec. 30, 2011

Re: [PATCH 3/3] vbscript: Added InStr tests

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=16214 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Dec. 30, 2011

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

by Dmitry Timoshkov

Alexandre Julliard <julliard(a)winehq.org> wrote: > > - if (!set_active_window( hwnd, &prev, FALSE, TRUE )) return 0; > > + set_active_window( hwnd, &prev, FALSE, TRUE ); > > return prev; > > } > > It doesn't seem right to ignore all errors. This would need some more > tests. What kind of tests do you have in mind? Invalid window? Something else? -- Dmitry.

Dec. 30, 2011

Re: [7/8]usp10: implement ScriptGetFontLanguageTags

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > --- > dlls/usp10/shape.c | 121 > ++++++++++++++++++++++++++++++++++++++++++- > dlls/usp10/tests/usp10.c | 37 ++++++++++++- > dlls/usp10/usp10.c | 11 ++++ > dlls/usp10/usp10.spec | 2 +- > dlls/usp10/usp10_internal.h | 9 +++ > 5 files changed, 176 insertions(+), 4 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:2949: Test failed: wrong return code make: *** [usp10.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

Dec. 30, 2011

Re: [2/2] user32: Make a SetFocus message test for a top level child window pass. Resend.

by Alexandre Julliard

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > What kind of tests do you have in mind? Invalid window? Something else? Yes, invalid or belonging to a different thread input. -- Alexandre Julliard julliard(a)winehq.org

Dec. 30, 2011