September 2010 - Wine-Devel

Wineconf 2010: You're running out of procrastination time...act now! Supplies are limited!

by Jeremy White

Alright, we're now down to about six weeks out. Soon, flights and the rooms will go up in price. So book your travel now! One new favor - if you are coming, please RSVP here: http://www.winehq.org/wineconf/rsvp/ so we can have counts for meals and such. Again, if money is an issue, please write to me; the Wine Party Fund may be able to help. And, as always, the Wiki page has the latest scoop: http://wiki.winehq.org/WineConf2010 and most chatter is happening on the wineconf(a)winehq.org mailing list (except for pushy loud mouthed types like myself :-/). Cheers, Jeremy

Sept. 30, 2010

Re: [PATCH 1/4] gameux: initial implementation of loading game statistics

by Mariusz Pluciński

W dniu 28.09.2010 17:11, Alexandre Julliard pisze: > Mariusz Pluciński<vshader(a)gmail.com> writes: > >> +static BOOL GAMEUX_isFileExists(LPCWSTR sFile) >> +{ >> + HANDLE hFile; >> + >> + hFile = CreateFileW(sFile, GENERIC_READ, 0, >> + NULL, OPEN_EXISTING, 0, NULL); >> + >> + if(hFile == INVALID_HANDLE_VALUE) >> + return FALSE; >> + >> + CloseHandle(hFile); >> + return TRUE; >> +} > > This sort of thing is not a good idea in general, even if it had a more > grammatically correct function name ;-) If you need to load a file you > have to open it anyway, so you can check for errors at that point. > Checking for existence beforehand is only doing duplicate work. OK, I'll redesign process of loading these data. Thanks for advice. -- Best regards Mariusz Pluciński

Sept. 30, 2010

Re: Error path issues with "gameux: Add implementation of IGameStatisticsMgr::RemoveGameStatistics."

by Mariusz Pluciński

W dniu 29.09.2010 17:15, Joris Huizer pisze: > Hello, > > I noticed the committed patch "gameux: Add implementation of > IGameStatisticsMgr::RemoveGameStatistics." > (5cac9d2cb2c020802a56a5b1b28348316f1087ba) > > The GAMEUX_getAppIdFromGDFPath() function now ends with: > > + HeapFree(GetProcessHeap(), 0, lpRegistryPath); + + > TRACE("found app id: %s, return: %#x\n", debugstr_w(lpApplicationId), > hr); + return hr; > > In most of the error paths, lpRegistryPath is not initialized, so > it's pointing to garbage; I think just initializing to NULL should be > sufficient; > > Similarly, in that case, lpApplicationId is not initialized, so it > contains garbage; Tracing will probably print some random stack bytes > before hitting a zero byte. I'm not completely sure what should be > done about this issue; I think it should probably only be traced on > success, perhaps tracing the error otherwise; Any ideas? > > HTH, Joris Hi I'm author of this patch. You're definitely right, I moved code of this function from other place, and forgot to initialize these variables properly. I'll fix that by initializing these variables (I do not want to make TRACE conditional, as it prints HRESULT value too). Anyway, thanks for your notification. -- Best regards Mariusz Pluciński

Sept. 30, 2010

Re: [PATCH 2/2] msxml3: implement preserveWhiteSpace property

by Adam Martinson

On 09/30/2010 09:12 AM, Alexandre Julliard wrote: > Adam Martinson<amartinson(a)codeweavers.com> writes: > > >> +#define WS_CHECK_IGNORED(doc) \ >> + ole_check(IXMLDOMDocument2_selectNodes(doc, _bstr_("//*[local-name()='html']"),&list));\ >> + ole_check(IXMLDOMNodeList_get_item(list, 0,&node1));\ >> + ole_check(IXMLDOMNodeList_get_item(list, 1,&node2));\ >> + ole_check(IXMLDOMNodeList_reset(list));\ >> + expect_list_and_release(list, "E1.E4.E1.E2.D1 E2.E4.E1.E2.D1");\ >> + \ >> + ole_check(IXMLDOMNode_get_childNodes(node1,&list));\ >> + expect_list_and_release(list, "T1.E1.E4.E1.E2.D1 E2.E1.E4.E1.E2.D1 E3.E1.E4.E1.E2.D1 T4.E1.E4.E1.E2.D1 E5.E1.E4.E1.E2.D1");\ >> + IXMLDOMNode_Release(node1);\ >> + ole_check(IXMLDOMNode_get_childNodes(node2,&list));\ >> + expect_list_and_release(list, "T1.E2.E4.E1.E2.D1 E2.E2.E4.E1.E2.D1 T3.E2.E4.E1.E2.D1 E4.E2.E4.E1.E2.D1 T5.E2.E4.E1.E2.D1 E6.E2.E4.E1.E2.D1 T7.E2.E4.E1.E2.D1");\ >> + IXMLDOMNode_Release(node2) >> > Please don't write such large macros. Put this in a helper function > instead. > > OK, fixed & resubmitted.

Sept. 30, 2010

Re: [PATCH 2/2] msxml3: implement preserveWhiteSpace property

by Alexandre Julliard

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define WS_CHECK_IGNORED(doc) \ > + ole_check(IXMLDOMDocument2_selectNodes(doc, _bstr_("//*[local-name()='html']"), &list));\ > + ole_check(IXMLDOMNodeList_get_item(list, 0, &node1));\ > + ole_check(IXMLDOMNodeList_get_item(list, 1, &node2));\ > + ole_check(IXMLDOMNodeList_reset(list));\ > + expect_list_and_release(list, "E1.E4.E1.E2.D1 E2.E4.E1.E2.D1");\ > + \ > + ole_check(IXMLDOMNode_get_childNodes(node1, &list));\ > + expect_list_and_release(list, "T1.E1.E4.E1.E2.D1 E2.E1.E4.E1.E2.D1 E3.E1.E4.E1.E2.D1 T4.E1.E4.E1.E2.D1 E5.E1.E4.E1.E2.D1");\ > + IXMLDOMNode_Release(node1);\ > + ole_check(IXMLDOMNode_get_childNodes(node2, &list));\ > + expect_list_and_release(list, "T1.E2.E4.E1.E2.D1 E2.E2.E4.E1.E2.D1 T3.E2.E4.E1.E2.D1 E4.E2.E4.E1.E2.D1 T5.E2.E4.E1.E2.D1 E6.E2.E4.E1.E2.D1 T7.E2.E4.E1.E2.D1");\ > + IXMLDOMNode_Release(node2) Please don't write such large macros. Put this in a helper function instead. -- Alexandre Julliard julliard(a)winehq.org

Sept. 30, 2010

Re: msxml3/httprequest: Add basic bind callback for moniker binding (try2)

by Alexandre Julliard

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > +#define DEFINE_THIS2(cls,ifc,iface) ((cls*)((BYTE*)(iface)-offsetof(cls,ifc))) > +#define DEFINE_THIS(cls,ifc,iface) DEFINE_THIS2(cls,lp ## ifc ## Vtbl,iface) Don't do that, follow the standard impl_from_xxx inline function pattern. -- Alexandre Julliard julliard(a)winehq.org

Sept. 30, 2010

Re: winex11: Add support for animated cursors in X11 driver (try 4).

by Alexandre Julliard

Erich Hoover <ehoover(a)mines.edu> writes: > + /* Build an X cursor out of all of the frames */ > + if (!(images = pXcursorImagesCreate( nFrames ))) goto cleanup; > + for (images->nimage = 0; images->nimage < nFrames; images->nimage++) > + images->images[images->nimage] = imgs[images->nimage]; > wine_tsx11_lock(); > - cursor = pXcursorImageLoadCursor( gdi_display, image ); > - pXcursorImageDestroy( image ); > + cursor = pXcursorImagesLoadCursor( gdi_display, images ); > wine_tsx11_unlock(); > + pXcursorImagesDestroy( images ); /* Note: XcursorImagesDestroy is called on each frame */ The note isn't clear, does it destroy the individual images or not? Either way your cleanup code needs more work. > +cleanup: > + /* Cleanup all of the resources used to obtain the frame data */ > + if (imgs && !cursor) > + { > + int i; > + > + for (i = 0; i < nFrames; i++) > + pXcursorImageDestroy( image ); And this can't possibly work. -- Alexandre Julliard julliard(a)winehq.org

Sept. 30, 2010

Re: Backtraces in crash window

by Dmitry Timoshkov

Jerome Leclanche <adys.wh(a)gmail.com> wrote: > Adding copypastable backtraces to the crash window might go a long way > to prevent this sort of attachments: > http://bugs2.winehq.org/attachment.cgi?id=31033 > Maybe under a "Crash information" link or something similar. It > wouldn't always do the trick (seeing as most of the time the error > only shows in the fixmes, if not the traces), but at least it would > get rid of some completely useless attachments, imho. > > Has this been discussed before? http://bugs.winehq.org/show_bug.cgi?id=23682 -- Dmitry.

Sept. 30, 2010

Backtraces in crash window

by Jerome Leclanche

Adding copypastable backtraces to the crash window might go a long way to prevent this sort of attachments: http://bugs2.winehq.org/attachment.cgi?id=31033 Maybe under a "Crash information" link or something similar. It wouldn't always do the trick (seeing as most of the time the error only shows in the fixmes, if not the traces), but at least it would get rid of some completely useless attachments, imho. Has this been discussed before? J. Leclanche

Sept. 30, 2010

Re: Need to retrieve VS_VERSION_INFO for 16, 32, 64 bit windows binaries

by Damjan Jovanovic

On Thu, Sep 30, 2010 at 11:03 AM, Kapil Arora <karora23(a)gmail.com> wrote: > Hi, > I've created a small executable on windows which calls > GetFileVersionInfo() and VerQueryValue() to extract VS_VERSION_INFO > from various windows binary files. I want to use this utility under > wine on linux system. Everything works fine for most of the files but > for some older dlls I'm not getting correct version information. > In the wine sources I found some of the functions for previous (16- > bit) version info extraction to be stubs. > I tried replacing version.dll in $HOME/.wine/drive_c/windows/system32 > with the one on my windows XP box but nothing happens. I still don't > get complete information. > Is there a way to achieve this. > Thanks, > Kapil. > > > > After you copy the Windows XP version.dll, set a DLL override for it in winecfg as well. Where are these stubs in Wine? Regards Damjan Jovanovic

Sept. 30, 2010