November 2012 - Wine-Devel - list.winehq.org

Re: [PATCH] cabarc: Display message when extracting cab like in native.

by Alexandre Julliard

Christian Costa <titan.costa(a)gmail.com> writes: > Ok. I will use WINE_TRACE instead. So that would be better to remove > -v > option and turn all printf > dependant of this option to WINE_TRACE, right ? Of course not. Debug options are for debugging the app, -v is for normal users who want to see the details of what it's doing. -- Alexandre Julliard julliard(a)winehq.org

Nov. 30, 2012

Re: [PATCH] cabarc: Display message when extracting cab like in native.

by Christian Costa

Le 30/11/2012 23:12, Alexandre Julliard a écrit : > Christian Costa <titan.costa(a)gmail.com> writes: > >> Le 30/11/2012 11:58, Alexandre Julliard a écrit : >>> Christian Costa <titan.costa(a)gmail.com> writes: >>> >>>> @@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] ) >>>> argv[--argc] = NULL; >>>> } >>>> } >>>> - return extract_cabinet( buffer ); >>>> + WINE_MESSAGE("Extracting file(s) from cabinet %s\n", wine_dbgstr_a(cab_file)); >>>> + ret = extract_cabinet( buffer ); >>>> + break; >>>> default: >>>> usage(); >>>> - return 1; >>>> + ret = 1; >>>> + break; >>>> } >>>> + >>>> + cab_free(cab_file); >>>> + >>>> + return ret; >>> I don't think that's very useful. And freeing memory on process exit is >>> even less useful. >>> >> I have problems this cabarc and cabinet with multi-cab I'm trying to fix. >> Our cabarc implementation does not display anything that make impossible >> to figure out what is happening. This message and some others that are only >> displayed when -v option is enabled (btw I don't know why we have to >> enable them >> explicitly). I don't understand why we shouldn't display standard >> operation messages >> for a command line exe as we can have native one. > It's standard behavior on Unix, so that tools can be used from scripts > without being drowned in a lot of irrelevant output. If the goal is to > debug things you can enable debug output. > Ok. I will use WINE_TRACE instead. So that would be better to remove -v option and turn all printf dependant of this option to WINE_TRACE, right ?

Nov. 30, 2012

Re: [PATCH] cabarc: Display message when extracting cab like in native.

by Alexandre Julliard

Christian Costa <titan.costa(a)gmail.com> writes: > Le 30/11/2012 11:58, Alexandre Julliard a écrit : >> Christian Costa <titan.costa(a)gmail.com> writes: >> >>> @@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] ) >>> argv[--argc] = NULL; >>> } >>> } >>> - return extract_cabinet( buffer ); >>> + WINE_MESSAGE("Extracting file(s) from cabinet %s\n", wine_dbgstr_a(cab_file)); >>> + ret = extract_cabinet( buffer ); >>> + break; >>> default: >>> usage(); >>> - return 1; >>> + ret = 1; >>> + break; >>> } >>> + >>> + cab_free(cab_file); >>> + >>> + return ret; >> I don't think that's very useful. And freeing memory on process exit is >> even less useful. >> > I have problems this cabarc and cabinet with multi-cab I'm trying to fix. > Our cabarc implementation does not display anything that make impossible > to figure out what is happening. This message and some others that are only > displayed when -v option is enabled (btw I don't know why we have to > enable them > explicitly). I don't understand why we shouldn't display standard > operation messages > for a command line exe as we can have native one. It's standard behavior on Unix, so that tools can be used from scripts without being drowned in a lot of irrelevant output. If the goal is to debug things you can enable debug output. -- Alexandre Julliard julliard(a)winehq.org

Nov. 30, 2012

Re: [PATCH] cabarc: Display message when extracting cab like in native.

by Christian Costa

Le 30/11/2012 11:58, Alexandre Julliard a écrit : > Christian Costa <titan.costa(a)gmail.com> writes: > >> @@ -713,9 +716,16 @@ int wmain( int argc, WCHAR *argv[] ) >> argv[--argc] = NULL; >> } >> } >> - return extract_cabinet( buffer ); >> + WINE_MESSAGE("Extracting file(s) from cabinet %s\n", wine_dbgstr_a(cab_file)); >> + ret = extract_cabinet( buffer ); >> + break; >> default: >> usage(); >> - return 1; >> + ret = 1; >> + break; >> } >> + >> + cab_free(cab_file); >> + >> + return ret; > I don't think that's very useful. And freeing memory on process exit is > even less useful. > I have problems this cabarc and cabinet with multi-cab I'm trying to fix. Our cabarc implementation does not display anything that make impossible to figure out what is happening. This message and some others that are only displayed when -v option is enabled (btw I don't know why we have to enable them explicitly). I don't understand why we shouldn't display standard operation messages for a command line exe as we can have native one.

Nov. 30, 2012

Re: kernel32: Implement SetFileValidData.

by Alexandre Julliard

Hans Leidekker <hans(a)codeweavers.com> writes: > --- > configure.ac | 1 + > dlls/kernel32/file.c | 12 +++- > dlls/kernel32/tests/file.c | 136 ++++++++++++++++++++++++++++++++++++++++++++ > dlls/ntdll/file.c | 27 +++++++++ > include/ddk/ntddk.h | 5 ++ > include/winbase.h | 1 + > 6 files changed, 180 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M kernel32.dll -T ../../.. -p kernel32_test.exe.so file.c && touch file.ok file.c:940: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\ err=5 should be 3 file.c:940: Tests skipped: Either no authority to volume, or is todo_wine for C:\users\julliard\Temp\removeme\ err=5 should be 3 file.c:940: Tests skipped: Either no authority to volume, or is todo_wine for C:\ err=5 should be 3 file.c:940: Tests skipped: Either no authority to volume, or is todo_wine for \\?\C:\ err=5 should be 3 file.c:3528: Test succeeded inside todo block: SetFileValidData succeeded file.c:3532: Test failed: SetFileValidData failed 50 file.c:3548: Test succeeded inside todo block: SetFileValidData succeeded file.c:3552: Test failed: SetFileValidData failed 50 file.c:3555: Test failed: SetFileValidData failed 50 file.c:3559: Test succeeded inside todo block: SetFileValidData succeeded file.c:3563: Test failed: SetFileValidData failed 50 make: *** [file.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

Nov. 30, 2012

Re: [PATCH] dsound: Use event based threads

by Andrew Eikum

On Thu, Nov 29, 2012 at 12:50:20PM +0100, Maarten Lankhorst wrote: > Op 21-11-12 19:16, Maarten Lankhorst schreef: > > Signed-off-by: Maarten Lankhorst <maarten.lankhorst(a)ubuntu.com> > > > Bump, anything wrong with this patch? > Been spending my "Wine time" on Bug 32297 this week. I'll take a look at this shortly. Andrew

Nov. 30, 2012

Re: [PATCH 6/6] jscript: Added support for indexed string access

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23169 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Nov. 30, 2012

Re: [PATCH 4/6] jscript: Added support for DontDelete attribute and use it for arguments object

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23168 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Nov. 30, 2012

Re: [PATCH 1/6 try2] jscript: Alias arguments properties to real values

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=23167 Your paranoid android. === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === TEST64_W7SP1 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found === TEST64_W7SP1 (64 bit) === No test summary line found

Nov. 30, 2012

Re: [PATCH 0/3] Add O_DENY* flags to fcntl and cifs

by Pavel Shilovsky

2012/11/30 Pavel Shilovsky <piastry(a)etersoft.ru>: > Network filesystems CIFS, SMB2.0, SMB3.0 and NFSv4 have such flags - this change can benefit cifs and nfs modules. While this change is ok for network filesystems, itsn't not targeted for local filesystems due security problems (e.g. when a user process can deny root to delete a file). > > Share flags are used by Windows applications and WINE have to deal with them too. While WINE can process open share flags itself on local filesystems, it can't do it if a file stored on a network share and is used by several clients. This patchset makes it possible for CIFS/SMB2.0/SMB3.0. > > Pavel Shilovsky (3): > fcntl: Introduce new O_DENY* open flags for network filesystems > CIFS: Add O_DENY* open flags support > CIFS: Use NT_CREATE_ANDX command for forcemand mounts > > fs/cifs/cifsacl.c | 10 ++++---- > fs/cifs/cifsglob.h | 11 ++++++++- > fs/cifs/cifsproto.h | 9 ++++---- > fs/cifs/cifssmb.c | 47 ++++++++++++++++++++------------------ > fs/cifs/dir.c | 14 ++++++++---- > fs/cifs/file.c | 18 ++++++++++----- > fs/cifs/inode.c | 11 +++++---- > fs/cifs/link.c | 10 ++++---- > fs/cifs/readdir.c | 2 +- > fs/cifs/smb1ops.c | 15 ++++++------ > fs/cifs/smb2file.c | 10 ++++---- > fs/cifs/smb2inode.c | 4 ++-- > fs/cifs/smb2ops.c | 10 ++++---- > fs/cifs/smb2pdu.c | 6 ++--- > fs/cifs/smb2proto.h | 14 +++++++----- > fs/fcntl.c | 5 ++-- > include/uapi/asm-generic/fcntl.h | 11 +++++++++ > 17 files changed, 125 insertions(+), 82 deletions(-) > > -- > 1.7.10.4 > CC'ing wine-devel(a). -- Best regards, Pavel Shilovsky.

Nov. 30, 2012