May 2008 - Wine-Devel - list.winehq.org

Re: [2/2] ddraw: Rename IDirectDraw functions (try 2)

by Stefan Dösinger

Am Sonntag, 1. Juni 2008 00:13:22 schrieb Christian Costa: > Hi Michael, > > I think it would be better to fix function names in IDirectDraw7. The IDirectDraw7 functions are without a version number because they're the common implementation for all ddraw versions. If there's a specific function for IDirectDraw7 that is not called by older versions via thunk due to behavior differences, it is already called IDirectDraw7Impl_XYZ

May 31, 2008

Re: ddraw: Don't release ddraw if a surface is still using it.

by Stefan Dösinger

Am Samstag, 31. Mai 2008 17:03:13 schrieb Michael Karcher: > > Anyway it makes wine stop crashing when programs tries to do something > > crazy like this. Stefan Dösinger asked me to put a HeapAlloc all memory > > between the two Release's to check if the memory of ddraw object would be > > corrupt in Windows. It really doesn't matter if programs live by chance > > in windows, if we can implement it so it's not by chance anymore. > > I agree on that point. Actually, that is dangerous. There may be situations in which this make-something-work has an unintended side effect, e.g. failure to restore the display mode because the ddraw object isn't destroyed(although it maybe should be - it's the test's job to find that out). Another possibility are apps that intend to cause an exception, like copy protection systems.

May 31, 2008

Re: [2/2] ddraw: Rename IDirectDraw functions (try 2)

by Christian Costa

Hi Michael, I think it would be better to fix function names in IDirectDraw7. Christian Michael Karcher a écrit : > The functions implementing IDirectDraw are called IDirectDrawImpl_Foo, > the ones implementing IDirectDraw7 are called alike. As they are > static functions in different files, the compiler has no problems > distinguishing them, but it confuses the reader of TRACE messages. > --- > dlls/ddraw/ddraw_thunks.c | 92 ++++++++++++++++++++++---------------------- > 1 files changed, 46 insertions(+), 46 deletions(-) > > ------------------------------------------------------------------------ > >

May 31, 2008

Re: MinGW RPM packages - discontinued

by Hin-Tak Leung

Hans Leidekker wrote: > On Saturday 31 May 2008 22:50:38 Vitaliy Margolen wrote: > >> Thank you very much for all the hard work you did maintaining those RPMs! >> Your hard work is greatly appreciated. <snipped> I would like to say a thank-you as well. I only wrote to Mingw-devel and R-devel (an R package I regularly cross-compile for), but I have started distributing my cross-compiler rpm's a few days ago, and I learned from yours. http://sourceforge.net/project/showfiles.php?group_id=217165 Mine is just one giant package put under /opt/mingw - there are two other sourceforge projects (besides mingw itself, which does not) which distribute cross-compiler rpms - one doing 4.3 and one doing 4.0. As my primary purpose is compiling and build the windows build of something I wrote, I chose to keep it simple - it is just one rpm (unlike the other projects), and it is just a simple wrapper around the cross-build script rather than trying to scavenge it. Hope it is useful to the people. Hin-Tak

May 31, 2008

Re: #1 wininet: Make resolving hostnames thread-safe. try2

by Rob Shearman

2008/5/31 Hans Leidekker <hans(a)it.vu.nl>: > Make resolving hostnames thread-safe. > > +/* critical section to protect non-reentrant gethostbyname() */ > +CRITICAL_SECTION cs_gethostbyname; > +static CRITICAL_SECTION_DEBUG critsect_debug = > +{ > + 0, 0, &cs_gethostbyname, > + { &critsect_debug.ProcessLocksList, &critsect_debug.ProcessLocksList }, > + 0, 0, { (DWORD_PTR)(__FILE__ ": cs_gethostbyname") } > +}; > +CRITICAL_SECTION cs_gethostbyname = { &critsect_debug, -1, 0, 0, 0, 0 }; cs_gethostbyname should be static. -- Rob Shearman

May 31, 2008

Re: MinGW RPM packages - discontinued

by Hans Leidekker

On Saturday 31 May 2008 22:50:38 Vitaliy Margolen wrote: > Thank you very much for all the hard work you did maintaining those RPMs! > Your hard work is greatly appreciated. Thank you. I'd like to extend this thank you to the people who contributed patches. > One use that will be missed is cross-compiling PE binaries that are not Wine > tests. I know, several people told me they were using the compiler for other purposes. One guy told me he was working on 64bit Fedora packages based on mine and intended get them upstream. Don't know what became of it but who knows, someone may fill the void some day. -Hans

May 31, 2008

Re: MinGW RPM packages - discontinued

by Vitaliy Margolen

Hans Leidekker wrote: > Hi all, > > This is a message for those who used or contributed to the cross compiler > packages available from this URL: > > http://mirzam.it.vu.nl/mingw/ > > Quoting myself from that page: > > I have decided to stop maintaining these packages. The original incentive > to create these packages was to be able to build Wine's test suite as PE > executables on Fedora. Wine recently changed its build system to use Wine's > own headers and import libraries when cross compiling the test suite, which > means that the mingw-w32api package (where most of the action was) is no > longer needed. > > Another reason is that I'm moving towards Ubuntu as my main development > platform. > Thank you very much for all the hard work you did maintaining those RPMs! Your hard work is greatly appreciated. One use that will be missed is cross-compiling PE binaries that are not Wine tests. Regards, Vitaliy.

May 31, 2008

Re: Fix debug log incosistencies and function naming

by Vitaliy Margolen

Michael Karcher wrote: > Debugging DirectDraw reference counting is confusing, > as the IDirectDraw{,2,3,4}_AddRef methods dump to ddraw_thunk, > whereas the matching Release methods dump to ddraw. This > patch changes to consistently use the ddraw channel. > > Furthermore, as the methods from IDirectDraw7 are named > like "IDirectDrawImpl_Foo", the functions from IDirectDraw > (Direct Draw 1) get renamed to "IDirectDraw1Impl_Foo" to > avoid non-unique function names in trace logs. > --- Please make it two patches. One to change debug channel. Second to rename IDirectDrawImpl into IDirectDraw1Impl. Vitaliy.

May 31, 2008

MinGW RPM packages - discontinued

by Hans Leidekker

Hi all, This is a message for those who used or contributed to the cross compiler packages available from this URL: http://mirzam.it.vu.nl/mingw/ Quoting myself from that page: I have decided to stop maintaining these packages. The original incentive to create these packages was to be able to build Wine's test suite as PE executables on Fedora. Wine recently changed its build system to use Wine's own headers and import libraries when cross compiling the test suite, which means that the mingw-w32api package (where most of the action was) is no longer needed. Another reason is that I'm moving towards Ubuntu as my main development platform. -Hans

May 31, 2008

Re: Fixing crashes in Tests (OS version check)

by Juan Lang

> An example of one that fails is > ret = SnmpUtilOidToA(NULL); > Under win98, this function is valid to call, but will crash if you call > it will a NULL parameter. I don't think removing this test a good idea, > since we are setting XP as a base, at this passes. I disagree that the test shouldn't be removed. The tests are meant to show Windows behavior that apps are likely to expect. Since the apps will crash if they pass NULL to SnmpUtilOidToA, it's reasonable to expect that they will not. Unless there's an app that depends on being able to do so, removing the test seems more sensible as it means we'll get better test coverage on Win98. --Juan

May 31, 2008