March 2005 - Wine-Devel - list.winehq.org

Re: KERNEL: improve stubs for DnsHostnameToComputerName{A,W}

by Peter Berg Larsen

On Thu, 31 Mar 2005, Peter Berg Larsen wrote: > + memcpy( computername, hostname, len ); > + computername[len + 1] = 0; > or you risk the computername[len+1] is invalid. Hmm, why didnt I see that at once; usually mistake here. Dont you mean computername[len] = 0; Peter

March 31, 2005

Re: Implementation of EnumMoniker and Partial impl on MkParseDisplayName

by Mike McCormack

Jeff Latimer wrote: > Rob, I did not grasp what you meant by this. The examples I looked at > to set this up seem to do the way I coded it. If you put the vtable at the end of the file after all the functions are declared, there should be no need to declare any functions as prototypes. Mike

March 31, 2005

Re: Implementation of EnumMoniker and Partial impl on MkParseDisplayName

by Jeff Latimer

Rob, I did not grasp what you meant by this. The examples I looked at to set this up seem to do the way I coded it. Jeff Robert Shearman wrote: > Jeff Latimer wrote: > > >> + DWORD runObjTabRegister; /* registration key of the next >> registered object */ >> + DWORD currentPos; /* enum position in the >> list */ >> + >> +} EnumMonikerImpl; >> + >> + >> +/* IEnumMoniker prototype functions : */ >> +/* IUnknown functions*/ >> +static HRESULT WINAPI EnumMonikerImpl_QueryInterface(IEnumMoniker* >> iface,REFIID riid,void** ppvObject); >> +static ULONG WINAPI EnumMonikerImpl_AddRef(IEnumMoniker* iface); >> +static ULONG WINAPI EnumMonikerImpl_Release(IEnumMoniker* iface); >> +/* IEnumMoniker functions */ >> +static HRESULT WINAPI EnumMonikerImpl_Next(IEnumMoniker* iface, >> ULONG celt, IMoniker** rgelt, ULONG* pceltFetched); >> +static HRESULT WINAPI EnumMonikerImpl_Skip(IEnumMoniker* iface, >> ULONG celt); >> +static HRESULT WINAPI EnumMonikerImpl_Reset(IEnumMoniker* iface); >> +static HRESULT WINAPI EnumMonikerImpl_Clone(IEnumMoniker* iface, >> IEnumMoniker** ppenum); >> >> > > If you put the vtable after the implementations of the functions then > you don't need to declare the prototypes here. > + >> +/* Virtual function table for the IEnumMoniker class. */ >> +static IEnumMonikerVtbl VT_EnumMonikerImpl = >> +{ >> + EnumMonikerImpl_QueryInterface, >> + EnumMonikerImpl_AddRef, >> + EnumMonikerImpl_Release, >> + EnumMonikerImpl_Next, >> + EnumMonikerImpl_Skip, >> + EnumMonikerImpl_Reset, >> + EnumMonikerImpl_Clone >> +}; >> + >> /*********************************************************************** >

March 31, 2005

installing Win32 Compilers

by Wesley Parish

Installing MinGW32 together with msys-1.* and msysDTK was a breeze. I started installing lccwin32, only to find problems with the library compilation in the latter part of installation, with it hanging once it got to commandline.txt fdlibm.lib lcccrt0.obj libcrt0s.obj stdlib.idx complex.lib gdbmdll.lib lcccrt0s.obj libml.lib tcconio.lib daguid.lib gdbm.lib lcc.lib regexp.lib UUID.LIB dx8math.lib glaux.lib libc.lib scrnsave.lib weditres.lib dxguid.lib iostream.lib libcrt0.obj shell32.lib wizard/ until I stopped it. Consequently it hung on installing Sleepycat's db. I'll erase the installation and try again, this time saving the error messages. Wesley Parish PS But wow, it felt good, watching MinGW32 install _without_ a hitch! Well done! -- Clinersterton beademung, with all of love - RIP James Blish ----- Mau e ki, he aha te mea nui? You ask, what is the most important thing? Maku e ki, he tangata, he tangata, he tangata. I reply, it is people, it is people, it is people.

March 31, 2005

Re: KERNEL: improve stubs for DnsHostnameToComputerName{A,W}

by Peter Berg Larsen

+BOOL WINAPI DnsHostnameToComputerNameA(LPCSTR hostname, + LPSTR computername, LPDWORD size) ... + DWORD len; + ... + if (!hostname || !size) return FALSE; + len = lstrlenW(hostname); + + if (len > MAX_COMPUTERNAME_LENGTH) + len = MAX_COMPUTERNAME_LENGTH; + + if (*size < len) + { + *size = len; + return FALSE; + } + if (!computername) return FALSE; + + memcpy( computername, hostname, len ); + computername[len + 1] = 0; + return TRUE; + } I have seen at lot of these where the \0 termination is unspecified for the size parameter, but in this case msdn mentions it. >From msdn: -------- BOOL DnsHostnameToComputerName( LPCTSTR Hostname, LPTSTR ComputerName, LPDWORD nSize ); Parameters Hostname [in] Pointer to a string that specifies the DNS name. If the DNS name is not a valid, translatable name, the function fails. ComputerName [out] Pointer to a string buffer that receives the computer name. The buffer size should be large enough to contain MAX_COMPUTERNAME_LENGTH + 1 characters. nSize [in, out] On input, specifies the size of the buffer, in TCHARs. On output, receives the number of TCHARs copied to the destination buffer, not including the terminating null character. If the buffer is too small, the function fails, GetLastError returns ERROR_MORE_DATA, and nSize receives the required buffer size, not including the terminating null character. ----------- So at least the check should be: if (*size < len + 1) { ... } or you risk the computername[len+1] is invalid. Now the second question is, which might be a convention, where does is say that I cant set computerName size to 3*MAX_COMPUTERNAME_LENGTH and expect it to return the computername not truncated to MAX_COMPUTERNAME_LENGTH? Peter

March 31, 2005

Re: Wine Debugger

by Francois Gouget

On Thu, 31 Mar 2005, Pouech Eric DMI AEI CAEN wrote: > use regedit at the beginning of your script to set the AeDebug key to > a "" string (and you should have saved the key value before), and > restore it at the end of your script Alternately you could add the '--auto' option and winedbg should then run in non-interactive mode. This will also cause it to dump a stack trace which is nice for later debugging if you save the output somewhere. [Software\\Microsoft\\Windows NT\\CurrentVersion\\AeDebug] "Auto"="1" "Debugger"="winedbg.exe --auto %ld %ld" -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

March 31, 2005

GetExitCodeProcess always returns 1

by Igor Sysoev

2 years ago I reported that on FreeBSD Wine-20030508's GetExitCodeProcess() always returns 1: http://www.winehq.org/hypermail/wine-devel/2003/06/0100.html It was fixed by patch: http://www.winehq.org/hypermail/wine-devel/2003/06/0381.html and I used the patched Wine-20030508 all the time to run MSVC, OpenWatcom C, and Borland C in a command line. However, when I try to run dmc.exe, sc.exe, or make.exe from Digital Mars C/C++ Compiler, I always see the message: wine: Unhandled exception (thread 0009), starting debugger... I build Wine-20050310, but it has the same two problems: 1) GetExitCodeProcess() always returns 1 on FreeBSD 5.3, 2) and wine could not run Digital Mars C/C++ Compiler. Digital Mars C/C++ Compiler is could be downloaded here: http://www.digitalmars.com/download/freecompiler.html Igor Sysoev http://sysoev.ru/en/

March 31, 2005

Re: winetest: ask for a tag (take 2)

by Alexandre Julliard

Ferenc Wagner <wferi(a)tba.elte.hu> writes: > ChangeLog: Ask for a tag if one was not given on the command line. > > This patch incorporates the suggestions of Rob and Mike. > Some casts are still necessary to suppress the warnings, but > this code is hopefully 64-bit safe. Simply storing the string in a global variable would make things a lot easier and more readable... -- Alexandre Julliard julliard(a)winehq.org

March 31, 2005

Re: Wine Debugger

by Paul Millar

Hi Cal, If you change the AeDebugger setting to include the --auto option: HKLM,Software\Microsoft\WindowsNT\CurrentVersion\AeDebug,"Debugger",,"winedbg --auto %ld %ld" This is the default if you delete the key completely and is now also the default if you have no registry and wine creating a fresh ~/.wine directory. Cheers, Paul. On Thursday 31 March 2005 07:36, you wrote: > So, is there any way to disable the debugger so that the script can > just continue on errors and not sit at a "Wine-dbg>" prompt?

March 31, 2005

Re: Wine Debugger

by Pouech Eric DMI AEI CAEN

use regedit at the beginning of your script to set the AeDebug key to a "" string (and you should have saved the key value before), and restore it at the end of your script > Message du 31/03/05 08:47 > De : "Cal Pierog" > A : wine-devel(a)winehq.org > Copie à : > Objet : Wine Debugger > > I am trying to write a script which, at one point, needs to run the wine > test suite, accomplished with: > > make -k test > > Even though this skips over bad tests, it does not prevent the debugger > from kicking in every once in a while and asking for user input. I would > like this script to be robust enough to run the test suite without user > input, even when one of the tests fails badly enough to call the debugger. > > So, is there any way to disable the debugger so that the script can just > continue on errors and not sit at a "Wine-dbg>" prompt? > > Thanks, > Cal Pierog > > > > >

March 31, 2005