March 2001 - Wine-Devel - list.winehq.org

RegSetValueEx problem?

by davep

I've been trying to track down why WineMine does not save my best scores ;-( On exit, WineMine saves the current user settings to the registry with code like this: char data[16]; wsprintf( data, "%d", p_board->pos.x ); RegSetValueEx( hkey, "Xpos", 0, REG_SZ, (LPBYTE) data, sizeof( data )); The problem here is that the 'count' parameter passed to RegSetValueEx is not the string length but the size of the entire buffer. Wine dutifully writes into the registry the entire buffer including the trailing garbage, and also adds a null to the end if there isn't one there. When WineMine tries to read the value back it is now 17 characters long and too big to fit in the 16-byte buffer. Compiling and running Winemine under Windows 95 this problem doesn't occur. Win95 truncates the value at the first null. So RegSetValueEx needs fixing. However there are already comments in there about the differences between 95 and NT in the handling of REG_SZ values, and I don't have an NT system to carry out checks. Can someone with experience propose a solution? -- Dave Pickles

March 31, 2001

Sendmessage fix..

by crazney

Hey, im writing cause i presently use Andreas Mohr's sendmessage fix (titled TEB fix, because it stop the TEB errors).. basically, what the patch does, is clean up after a killed SendMessage if it didnt clean itsself up.. (well something like that, iirc).. anyway, i run the LHL howto page, and this patch is very useful to running Half-Life and several other games/programs.. so itd be nice to have it in CVS.. which it isnt presently.. when Andreas Mohr first wrote the patch, he told me that alexandre denied it, and neither him, ove or myself can work out why.. so yer, i'd just like to know a) why was it refused.. and b) can you put it in now, or write something which does just this now.. thanks in advance ps, can you please email me about this, because im not subscribed to this list. cheers David -- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ David Hammerton aka crazney Victoria, Australia http://crazney.net/ HOWTO maintainer and Linux Half-Life http://lhl.linuxgames.com/ email: http://crazney.net/contact.html -> Note: this email address expires after one week.

March 31, 2001

Re: [PATCH] HOOK_CallHook

by Michael Stefaniuc

On Fri, Mar 30, 2001 at 12:54:06AM -0500, James Juran wrote: > James Juran wrote: > > > > Ulrich Weigand wrote: > > [...] > > > I've managed to reduce the problem to a simple testcase, which is > > > appended below. It fails on RedHat gcc-2.96-69 (as of 12/2000) ... > > > > Running this program with Red Hat's gcc-2.96-74 still produces the > > error. I'm downloading -79 now and will test that. Has this been > > reported to Red Hat's Bugzilla? I'll submit it if you don't want to. > > Same results with -79. It fails with -O2, but passes with -O2 > -fno-gcse. Tested also the very last version -80, same problem. I've forwarded yesterday Francois email to Jakub Jelinek and I'm making now the bugzilla entry. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.de Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

March 30, 2001

Re: OpenGL Visual Management ... continued.

by lawson_whitney＠juno.com

On Fri, 30 Mar 2001, Gavriel State wrote: > > Ok - this is what I'll explore further then. It may be a few more days > before I can get to it though, since it looks like I'm going to be a daddy > in a few hours. 8-) > > -Gav > Don't let me stop you. :-) I lived with local patches for about 3 months while file handles were getting sorted out, I guess I can give you a few days - hell, take a week if you need it. I just hope the wine-users don't catch us. Lawson ---cut here ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

March 30, 2001

Re: [PATCH] HOOK_CallHook

by James Juran

James Juran wrote: > > Ulrich Weigand wrote: > [...] > > I've managed to reduce the problem to a simple testcase, which is > > appended below. It fails on RedHat gcc-2.96-69 (as of 12/2000) ... > > Running this program with Red Hat's gcc-2.96-74 still produces the > error. I'm downloading -79 now and will test that. Has this been > reported to Red Hat's Bugzilla? I'll submit it if you don't want to. Same results with -79. It fails with -O2, but passes with -O2 -fno-gcse. -- James Juran jamesjuran(a)alumni.psu.edu

March 30, 2001

Re: [PATCH] HOOK_CallHook

by Michael Veksler

I tested this with 2 newer gcc versions: gcc version 3.0 20010305 (prerelease) gcc version 2.97 20010122 (experimental) Both print PASS, when compiling with -O2. Michael

March 30, 2001

Re: OpenGL Visual Management ... continued.

by Gavriel State

lawson_whitney(a)juno.com wrote: > > At a guess - the privately created ColorMaps need to take their initial colors > > from the Default Color Map? > > That sounds about right. Oh, at one point I reverted only wnd.c - no > difference - then palette.c. Colors seemed better with the pointer off > the window IIRC, but it still went to black and white withe the pointer > on the desktop. Ok - this is what I'll explore further then. It may be a few more days before I can get to it though, since it looks like I'm going to be a daddy in a few hours. 8-) -Gav -- Gavriel State, CEO TransGaming Technologies Inc. http://www.transgaming.com gav(a)transgaming.com

March 30, 2001

Re: [PATCH] HOOK_CallHook

by James Juran

Ulrich Weigand wrote: [...] > I've managed to reduce the problem to a simple testcase, which is > appended below. It fails on RedHat gcc-2.96-69 (as of 12/2000) ... Running this program with Red Hat's gcc-2.96-74 still produces the error. I'm downloading -79 now and will test that. Has this been reported to Red Hat's Bugzilla? I'll submit it if you don't want to. james[1]%gcc -v Reading specs from /usr/lib/gcc-lib/i386-redhat-linux/2.96/specs gcc version 2.96 20000731 (Red Hat Linux 7.0) james[2]%rpm -qi gcc Name : gcc Relocations: (not relocateable) Version : 2.96 Vendor: Red Hat, Inc. Release : 74 Build Date: Sat 03 Feb 2001 06:49:13 PM EST Install date: Mon 12 Feb 2001 12:02:51 AM EST Build Host: porky.devel.redhat.com Group : Development/Languages Source RPM: gcc-2.96-74.src.rpm Size : 8444185 License: GPL Packager : Red Hat, Inc. <http://bugzilla.redhat.com/bugzilla> URL : http://gcc.gnu.org Summary : Various compilers (C, C++, Objective-C, Chill, ...) Description : The gcc package contains the GNU Compiler Collection: cc and gcc. You'll need this package in order to compile C/C++ code. james[3]%gcc -O2 test.c james[4]%./a.out FAIL james[6]%gcc -O2 -fno-gcse test.c james[7]%./a.out PASS james[8]%exit Script done on Fri Mar 30 00:09:36 2001 -- James Juran jamesjuran(a)alumni.psu.edu

March 30, 2001

Re: [PATCH] HOOK_CallHook

by François Jacques

>OK, I must have misunderstood you then. Sorry ... It's ok :) >I've managed to reduce the problem to a simple testcase, which is >appended below. It fails on RedHat gcc-2.96-69 (as of 12/2000) ... > >Culprit *appears* to be the global common subexpression elimination, >although this is not quite definite. I haven't tracked the problem >down yet. Are you thinking of doing more investigation on that? >However, when switching off GCSE (-fno-gcse), correct code is produced. >I'm not sure I'd like to do a complete Wine build without GCSE though; >this might significantly reduce code quality ... Oh the runtime behavior should not change that much but it's still non-negligeable. I like the "disable-gcse-if-you-probe-that-gcc-version" approach. >I'll write a configure check to switch off gcse, using the testcase >below. We should probably contact RedHat (I think Jacub Jelinek >handles 2.96 bugs ...) to confirm that GCSE is really at fault. If you want to post it with the test program, go ahead :) I never posted to gcc bug list so I'm not sure how much attention would be given to the bug. I think the mailing list should be cc'ed on the postings so everybody can follow up how it turns out. Ciao! Francois

March 30, 2001

Re: [PATCH] HOOK_CallHook

by François Jacques

>To be honest, I didn't read the patch and simply assumed this was a simple case >of forgetting to add volatile and getting bitten by a compiler that optimizes >more agressively. > >Either way it still is a valid point to be concerned about not only compiler >bugs but also new compiler features. 100% agree on this point. The community needs some ways to keep up to date with those new compiler versions. I know it's hard since we work on different projects which usually needs some kind of stability (in the product and in the development process) so we tend to stick with a reference compiler that we know works. However, if we don't keep up to date with those new compiler version, well fall in some intensive bug chasing session... and debugging at the assembly level is not that fun. And it's a cycle, we test the new compiler version, we find bugs, we get an improved compiler which, with a nice side-effect, may solve other bugs. >That would be a good idea. Of course I don't think the volatile keyword in >this case is hurting anything except maybe speed (negligble). Hopefully this >can get fixed soon in gcc. Looking at the gcc project page, it seems that 3.0 >is very close to be done. 3.0 ? That's good news in terms of technology advance... however I fear some late nites chasing bugs generated from that new version :) Cheers! Francois

March 30, 2001