January 2002 - Wine-Devel - list.winehq.org

Bug in MoveFileEx

by Gerhard W. Gruber

I just played around with Thandor trying to install it and see what the differences are between Win98 and Wine because I noticed a slightly different behaviour. Now I discovered that MoveFileEx is not even available in Windows 98 but wine supplies it nevertheless. I suspect that the Setup doesn't check the windows version, but rather calls MoveFileEx and if that fails with not implemented returncode continues with other code to supply the functionality. I wrote a small test app to confirm this and this returns an error code when calling MoveFileEx on a native win98 whiel wine executes it. How shall I fix this? Shall I simply call GetVersion() to determine if MoveFileEx should be allowed or is there a different way with wine to determine which functions are available for which version (a global variable or such)? I looked through the sources but I couldn't find anywhere something where a versioncheck has been used to switch code but then again I don't know much functions where I know for sure that they are available in one version and not in the other. -- Bye, Gerhard If you think education is expensive, try ignorance.

Jan. 31, 2002

Re: Bug in WritePrivateProfileSection

by Gerhard W. Gruber

On Thu, 31 Jan 2002 23:38:05 +0100, Andreas Mohr <andi(a)rhlx01.fht-esslingen.de> wrote: >On Thu, Jan 31, 2002 at 11:23:58PM +0100, Gerhard W. Gruber wrote: >> I just wrote a small up to test the behaviour of WritePrivateProfileSection. >> This confirmed my suspicion that the wine implementation is wrong because on >> Win98 I can create multiple keys with the same name when using this function, >> while wine always substitutes the new value if the key already exists. If >> nobody is working on that, then I'll fix this first before continuing with the >> boot process. >Yep, go ahead. >In case of questions with that boot stuff, just ask me. ok. -- Bye, Gerhard If you think education is expensive, try ignorance.

Jan. 31, 2002

Re: DESTDIR support for make install

by Joerg Mayer

On Thu, Jan 31, 2002 at 02:33:53PM -0800, Alexandre Julliard wrote: > But "make install prefix=/home/myaccount/rpms/tmp" should do exactly > the same thing, unless I missed something. You can run make with one > prefix and make install with another one, that's a feature. I didn't know about this feature, but it works fine :) Thanks! Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

Jan. 31, 2002

Re: ROTD (Rant Of The Day): patches

by Joerg Mayer

Hmm, looks like after the failed attempt for a flame war on version numbering, you are trying to start one on mail clients 8-=) On Thu, Jan 31, 2002 at 03:52:19PM -0500, Dimitrie O. Paun wrote: > I've come to _hate_ diffs attached as Application/OCTET-STREAM. Can you > please, Please, PLEASE, attach them as Text/PLAIN? I'd like to see properly labeled attachment types too, be they text/plain, mime, gzip or whatever. > I use Pine over a ssh connection to read wine-{devel,patches}, and I can > simply view the Text/PLAIN attachments, whereas I have to: Hmm, the problem you mentioned is one of the two major reasons that drove me away from pine towards mutt. I'm now running a (n almost) properly configured mutt and don't have these problems any more because app/o-s are just viewed with the text viewer after pressing v and selecting the attachment (which takes maybe 2 seconds). I don't like your idea of 1 patch per mail, as this would probably take me 2-3 additional seconds per mail (poor me). ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

Jan. 31, 2002

Re: Bug in WritePrivateProfileSection

by Andreas Mohr

On Thu, Jan 31, 2002 at 11:23:58PM +0100, Gerhard W. Gruber wrote: > I just wrote a small up to test the behaviour of WritePrivateProfileSection. > This confirmed my suspicion that the wine implementation is wrong because on > Win98 I can create multiple keys with the same name when using this function, > while wine always substitutes the new value if the key already exists. If > nobody is working on that, then I'll fix this first before continuing with the > boot process. Yep, go ahead. In case of questions with that boot stuff, just ask me. -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

Jan. 31, 2002

Re: DESTDIR support for make install

by Alexandre Julliard

Joerg Mayer <jmayer(a)loplof.de> writes: > So changing prefix is not the way to go. DESTDIR allows to do the > install via "DESTDIR=/home/myaccount/rpms/tmp make install" instead > of doing all the steps from "make install" manually. But "make install prefix=/home/myaccount/rpms/tmp" should do exactly the same thing, unless I missed something. You can run make with one prefix and make install with another one, that's a feature. -- Alexandre Julliard julliard(a)winehq.com

Jan. 31, 2002

Re: DESTDIR support for make install

by Joerg Mayer

On Thu, Jan 31, 2002 at 01:09:28PM -0800, Alexandre Julliard wrote: > > wine currently doesn't support the DESTDIR flag commonly used by > > packagers. The patch I've attached fixes this. > > Could you explain this a bit more? Why can't you use the existing > $prefix to do the same thing? When creating a spec file for rpms, you basically prepare the source (unpack, apply patches), then run configure, make and --->make install Because the result is intended not to be run but to be packaged, you don't install into e.g. /usr/local directly, but into something like /home/myaccount/rpms/tmp/usr/local. Later, when you *install* the package, you want the binaries to be installed into /usr/local and all paths compiled into the binaries to point to /usr/local/... too. So changing prefix is not the way to go. DESTDIR allows to do the install via "DESTDIR=/home/myaccount/rpms/tmp make install" instead of doing all the steps from "make install" manually. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

Jan. 31, 2002

Bug in WritePrivateProfileSection

by Gerhard W. Gruber

I just wrote a small up to test the behaviour of WritePrivateProfileSection. This confirmed my suspicion that the wine implementation is wrong because on Win98 I can create multiple keys with the same name when using this function, while wine always substitutes the new value if the key already exists. If nobody is working on that, then I'll fix this first before continuing with the boot process. -- Bye, Gerhard If you think education is expensive, try ignorance.

Jan. 31, 2002

Re: DESTDIR support for make install

by Daniel Sabo

On Thu, 31 Jan 2002 13:09:28 -0800, Alexandre Julliard wrote: > Bernhard Rosenkraenzer <bero(a)redhat.de> writes: > >> wine currently doesn't support the DESTDIR flag commonly used by >> packagers. The patch I've attached fixes this. > > Could you explain this a bit more? Why can't you use the existing > $prefix to do the same thing? > > $prefix changes the code, e.g. winelauncher sets it's directories based on $prefix. DESTDIR puts the files somewhere esle but writes the code like it was going in $prefix. So you could have $prefix=/usr and DESTDIR=/tmp/winepackage

Jan. 31, 2002

Re: ROTD (Rant Of The Day): patches

by Francois Gouget

On Thu, 31 Jan 2002, Dimitrie O. Paun wrote: [...] > BTW, how do you fork the external pager? I just do '>', select the attachement and 'V'. I don't think I have any specific option. [...] > Me too! :) That is, I would like to know as well. > > I guess you can insert the patch in the body of the message using: > ^R - from Pico to "Read File" Maybe I'll try that. it should tae care of botht the MIME and base64 issues. Putting a patch directly inline worries me though. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux, WinNT, MS-DOS - also known as the Good, the Bad and the Ugly.

Jan. 31, 2002