November 2002 - Wine-Devel - list.winehq.org

Re: strcat+strcat+strcat == baaad

by Joerg Mayer

On Sat, Nov 30, 2002 at 10:49:34AM -0800, Alexandre Julliard wrote: > > It's more efficient to do: > > > > sprintf(foo, "%s%s%s%s%s%s", bar1,bar2,bar3,bar4,bar5,bar6); In case you cannot be 100% sure of the lengths, it might still be worth it with snprintf, but otherwise, it's a matter of taste. Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

Nov. 30, 2002

Reopened a bug

by Dustin Navea

I have reopened bug #15 due to the fact that the bug still exists to a certain extent and in a different form. When sending an IM in AIM with any recent version of wine (including a couple of days before the latest cvs snapshot), I can resize the window and when the buttons go to reposition themselves, they move much slower than the border of the window, and you can see them updating their position. Would there be any debug traces I could post to the bug to help resolve this? -Dustin

Nov. 30, 2002

Re: Janitorial Projects

by Dustin Navea

Sorry if this hits the list twice im not sure if i typed wine-devel into the to line or not ;) That is a good question, either that or i will need borrow a copy of msvc from a friend.. -Dustin ----- Original Message ----- From: "Tony Lambregts" <tony_lambregts(a)telusplanet.net> To: <dpaun(a)rogers.com> Cc: "Wine devel" <wine-devel(a)winehq.com> Sent: Saturday, November 30, 2002 1:09 PM Subject: Re: Janitorial Projects > Dimitrie O. Paun wrote: > > >On November 29, 2002 03:06 pm, Francois Gouget wrote: > > > > > >>Here's a proposed addition to the Janitorial projects: > >> > >> > > > >Added: > > http://www.dssd.ca/wine/Wine-Fun.html#tests > > > >Let me know if you want anything changed. > > > > > > > Well since I have Windows 98 on my computer I would like to volunteer to > run the tests. I however do not have Visual C++ (or any other windows > compiler). That leads me to the following question. Would someone place > the compiled tests somewhere on the web so that I can download them. > > I suppose that another solution would be to use MinGW (right?) If this > is a Good Idea (tm) then some tips on how to do this (or a pointer to > some relevant documentation) would be appreciated. > > -- > > Tony Lambregts > > > >

Nov. 30, 2002

Re: Adding support for xxx_test.exe all

by Alexandre Julliard

Francois Gouget <fgouget(a)free.fr> writes: > So I propose the following patch which makes it possible to run > 'xxx_test.exe all' which runs all the tests implemented by that > executable. > > Do others find this patch acceptable? Useful? The drawback I see is that with this change the tests do not start with a clean process state, which could cause problem for some of them. Or we need to require that all tests cleanup properly after them, which may be a bit painful. -- Alexandre Julliard julliard(a)winehq.com

Nov. 30, 2002

Re: Janitorial Projects

by Tony Lambregts

Dimitrie O. Paun wrote: >On November 29, 2002 03:06 pm, Francois Gouget wrote: > > >>Here's a proposed addition to the Janitorial projects: >> >> > >Added: > http://www.dssd.ca/wine/Wine-Fun.html#tests > >Let me know if you want anything changed. > > > Well since I have Windows 98 on my computer I would like to volunteer to run the tests. I however do not have Visual C++ (or any other windows compiler). That leads me to the following question. Would someone place the compiled tests somewhere on the web so that I can download them. I suppose that another solution would be to use MinGW (right?) If this is a Good Idea (tm) then some tips on how to do this (or a pointer to some relevant documentation) would be appreciated. -- Tony Lambregts

Nov. 30, 2002

RE: strcat+strcat+strcat == baaad

by Medland, Bill

> -----Original Message----- > From: wine-patches-admin(a)winehq.com > [mailto:wine-patches-admin(a)winehq.com]On Behalf Of Francois Gouget > Sent: Friday, November 29, 2002 10:11 PM > To: wine-patches(a)winehq.com > Subject: strcat+strcat+strcat == baaad > > > > I don't like pieces of code that go: > > strcpy(foo, bar1); > strcat(foo, bar2); > strcat(foo, bar3); > strcat(foo, bar4); > strcat(foo, bar5); > strcat(foo, bar6); > > It's really inefficient: the cost increases quadratically > with the size > of the resulting string. It's more efficient to do: > > sprintf(foo, "%s%s%s%s%s%s", bar1,bar2,bar3,bar4,bar5,bar6); > > Here the cost is proportional to the size of the resulting string. And surely when the opportunity arises it would be better to use snprintf (i.e. when you know the size of the buffer). (I doubt that the code has already checked the size of the strings being pasted together) > > For for various reasons I came accross a couple of instances of > strcat+strcat badness and replaced them with a sprintf. So here's the > patch. > > Changelog: > > * memory/environ.c, > tools/makedep.c > > Use sprintf rather than calling strcat over and over > > > Index: memory/environ.c > =================================================================== > RCS file: /home/wine/wine/memory/environ.c,v > retrieving revision 1.38 > diff -u -r1.38 environ.c > --- memory/environ.c 9 Oct 2002 18:35:02 -0000 1.38 > +++ memory/environ.c 30 Nov 2002 05:20:12 -0000 > @@ -641,12 +641,7 @@ > > /* Set the new string */ > > - if (value) > - { > - strcpy( p, name ); > - strcat( p, "=" ); > - strcat( p, value ); > - } > + if (value) sprintf( p, "%s=%s", name, value ); > current_envdb.env = new_env; > ret = TRUE; > > Index: tools/makedep.c > =================================================================== > RCS file: /home/wine/wine/tools/makedep.c,v > retrieving revision 1.13 > diff -u -r1.13 makedep.c > --- tools/makedep.c 17 Aug 2002 18:28:43 -0000 1.13 > +++ tools/makedep.c 30 Nov 2002 06:10:17 -0000 > @@ -192,9 +192,7 @@ > if (SrcDir) > { > pFile->filename = xmalloc( strlen(SrcDir) + > strlen(pFile->name) + 2 ); > - strcpy( pFile->filename, SrcDir ); > - strcat( pFile->filename, "/" ); > - strcat( pFile->filename, pFile->name ); > + sprintf( pFile->filename, "%s/%s", SrcDir, pFile->name ); > } > else pFile->filename = xstrdup( pFile->name ); > > @@ -218,9 +216,7 @@ > for (path = firstPath; path; path = path->next) > { > char *filename = xmalloc(strlen(path->name) + > strlen(pFile->name) + 2); > - strcpy( filename, path->name ); > - strcat( filename, "/" ); > - strcat( filename, pFile->name ); > + sprintf( filename, "%s/%s", path->name, pFile->name ); > if ((file = fopen( filename, "r" ))) > { > pFile->filename = filename; > > > -- > Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ > Linux: It is now safe to turn on your computer. > > >

Nov. 30, 2002

Re: strcat+strcat+strcat == baaad

by Alexandre Julliard

Francois Gouget <fgouget(a)free.fr> writes: > I don't like pieces of code that go: > > strcpy(foo, bar1); > strcat(foo, bar2); > strcat(foo, bar3); > strcat(foo, bar4); > strcat(foo, bar5); > strcat(foo, bar6); > > It's really inefficient: the cost increases quadratically with the size > of the resulting string. Well, no, the cost is linear. It would only be quadratic if the number of strcat calls depended on the length of the string. > It's more efficient to do: > > sprintf(foo, "%s%s%s%s%s%s", bar1,bar2,bar3,bar4,bar5,bar6); I seriously doubt that sprintf would be faster that a couple of strcats. And I don't think we need to worry about this kind of micro-optimizations right now... -- Alexandre Julliard julliard(a)winehq.com

Nov. 30, 2002

Re: somebody help me identify this bug please

by ezra daniel

that I have tried and needed yes, only valves with "acute accent" like you call it, excuse my english.. :) And I dont understand what you mean by dead key... but anyway... in every linux app I can type that right, only the new wine version breaks that, but I know it was fixed on 20021031 cause it worked great. To make an example of what I can't type : canción = in the wine version appears as cancion without the ó In my language this is very important or they will think I dont know how to write my language, hehehe Thanks :) -daniel http://www.debian-gnu.com >From: "Jeff Smith" <whydoubt(a)hotmail.com> >To: ezra_daniel(a)hotmail.com, wine-devel(a)winehq.com >Subject: Re: somebody help me identify this bug please >Date: Fri, 29 Nov 2002 13:31:46 -0600 > >Is it only characters with the acute accent? Is it that your are >attempting this using 'dead key' entry on a Spanish keyboard? > >If this is the case, the problem may be in a recent correction to >the Spanish keyboard layout. > >I will work on this some more when I get a chance, but hopefully >someone else will find something sooner. > > -- Jeff S > > >>From: "ezra daniel" <ezra_daniel(a)hotmail.com> >> >>Hello, >> >>At work I use Lotus Notes under Wine. >> >>I downloaded compiled and installed the new wine version 20021125 and I am >>no longer able to type accecented valves, like á é í ó ú. >> >>Ñ can be typed though correctly. >> >>With the other version 20021031 I could type accented valves.In fact I >>went back to using the older version and worked again so it is obvious it >>is a problem in the new wine version. >> >>Though I am a newbie and know nothing of developing, but I would like to >>submit the bug to the proper person so it fixes it back again but I dont >>know which section of wine or person deals with this character typing >>problem. >> >>Can anyone point me in the right direction? Thanks in advance. >> >>-daniel >>http://www.debian-gnu.com > _________________________________________________________________ MSN Fotos: la forma más fácil de compartir e imprimir fotos. http://photos.msn.es/support/worldwide.aspx

Nov. 30, 2002

Re: Yet another D3D patch....

by Christian Costa

Lionel Ulmer wrote: >>This patch breaks the TWIST demo that was working fine. >>I think the changes in d3ddevice_create are responsible of that. >> > >Strange, it works fine here.. A bit slow when statistics are displayed (due >to the locking of the D3DEVICE surface and thus needing a slow GL call like >glReadPixels / glDrawPixels) but as fast as before when disabling them. > > >But well, my tree has patches up to number 13 so maybe I broke something >that was fixed later on (although I wonder what). > I applied your next patches (until 13) and it has been fixed. Cool... :-) Statistics are not displayed for me and the 565 texture format looks strange. But appart from that it's fine. Thanks.

Nov. 30, 2002

Re: Janitorial Projects

by Dimitrie O. Paun

On November 29, 2002 03:06 pm, Francois Gouget wrote: > Here's a proposed addition to the Janitorial projects: Added: http://www.dssd.ca/wine/Wine-Fun.html#tests Let me know if you want anything changed. -- Dimi.

Nov. 30, 2002