August 2014 - Wine-Devel - list.winehq.org

Re: [PATCH 2/5] comdlg32: Implement calling IFileDialogEvents::OnTypeChange().

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8725 Your paranoid android. === wvistau64 (64 bit itemdlg) === itemdlg.c:1210: Test failed: Got 5

Aug. 31, 2014

Re: [PATCH 1/5] comdlg32/tests: Add some IFileDialogEvents tests.

by Marvin

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=8724 Your paranoid android. === wvistau64 (32 bit itemdlg) === itemdlg.c:1210: Test failed: Got 3 === wvistau64 (64 bit itemdlg) === itemdlg.c:1210: Test failed: Got 5

Aug. 31, 2014

Re: Wine test analysis August 28th

by Maarten Lankhorst

Hey, On 28-08-14 17:57, Jeremy White wrote: > Hi Folks, > > Good news - we've made progress! We're down to only 25 issues. > > I have now annotated every single failure: > https://www.winehq.org/~jwhite/5aeb834dd4e7.html > (although some of my annotations are out of date). > > It looks like the biggest win will come if Francois and Hans can figure out the msi timing stuff. > > I think there are a number of ones that might be 'easy': > http://test.winehq.org/data/tests/gdi32:font.html > Bug 35573, 35760, fails in certain locales > > http://test.winehq.org/data/tests/mmdevapi:capture.html > I asked Jorg, but he may have a hard time getting to it. It's nice and consistent... Seems to be a winealsa specific bug. It works fine if I enable winepulse. But if I set WINETEST_PLATFORM to wine I get 3 failures because of tests succeeding inside todo blocks. ;-) Otherwise 6 failures, of which 3 todo. ~Maarten

Aug. 29, 2014

RE: Wine test analysis August 28th

by Indrek Altpere

Hello Perhaps the issue is related to the png url redirecting from http to https? At line 2883 in events.c there is run_test(readystate_doc_str, test_onreadystatechange); run_test(img_doc_str, test_imgload); Meaning that imgload test runs right after readystatechange test which very likely has finished correctly. On line 1847 in test_imgload function there is img url http://www.winehq.org/images/winehq_logo_text.png When opening it, it actually seems to redirect to https://www.winehq.org/images/winehq_logo_text.png Most likely some winehq.org server setting was changed to force connections to https and IE started complaining? Does it help if the url is also fixed to be https from the start? Or does the IE expect it to be from HTTP when loading non-remote html? Regards, Indrek From: wine-devel [mailto:wine-devel-bounces(a)winehq.org] On Behalf Of Austin English Sent: Friday, August 29, 2014 8:32 PM To: Francois Gouget Cc: Jeremy White; Wine Develop Subject: Re: Wine test analysis August 28th On Fri, Aug 29, 2014 at 12:25 PM, Francois Gouget <fgouget(a)free.fr <mailto:fgouget(a)free.fr> > wrote: One of the failures is mshtml:events which has started ahppening on the 11th of August. What is mighty strange is that: * There was no change to dlls/mshtml/tests/events.c around that time and testing with a pre-11th build still shows the failure. * I did not change the VMs around that time (or any time past the 3rd of August). Also the failures started happening not only on some of my VMware VMs, but also on the Windows 2008 VMs of the TestBot. * It does not seem that test actually accesses the network though I may be wrong there. Could it be a change on the Wine web server (I found no matching commit in the tools repository). * The test started failing on Linux (64 bit only) and FreeBSD (32 bit) on the 15th which corresponds to the next commit round. Testing this Windows 2000 and XP shows that the issue is that the iframe_onreadystatechange_complete test triggers a 'You are about to view pages over a secure connection' popup dialog which blocks the process until it is answered, thus leading to the timeout. So given that nothing changed in the VM (still starting from the same snapshot), why did it start displaying this dialog on the 11th? Here's a screenshot: http://fgouget.free.fr/tmp/mshtml_events.png -- Francois Gouget <fgouget(a)free.fr <mailto:fgouget(a)free.fr> > http://fgouget.free.fr/ question = ( to ) ? be : ! be; -- Wm. Shakespeare FWIW, I've noticed a hang with mshtml:events under valgrind (and when I attempted to bisect it, previously working commits failed). I filed a bug, didn't investigate further: https://bugs.winehq.org/show_bug.cgi?id=37157 -- -Austin

Aug. 29, 2014

Re: Wine test analysis August 28th

by Austin English

On Fri, Aug 29, 2014 at 12:25 PM, Francois Gouget <fgouget(a)free.fr> wrote: > > One of the failures is mshtml:events which has started ahppening on the > 11th of August. > > What is mighty strange is that: > * There was no change to dlls/mshtml/tests/events.c around that time and > testing with a pre-11th build still shows the failure. > * I did not change the VMs around that time (or any time past the 3rd of > August). Also the failures started happening not only on some of my > VMware VMs, but also on the Windows 2008 VMs of the TestBot. > * It does not seem that test actually accesses the network though I > may be wrong there. Could it be a change on the Wine web server (I > found no matching commit in the tools repository). > * The test started failing on Linux (64 bit only) and FreeBSD (32 bit) > on the 15th which corresponds to the next commit round. > > Testing this Windows 2000 and XP shows that the issue is that the > iframe_onreadystatechange_complete test triggers a 'You are about to > view pages over a secure connection' popup dialog which blocks the > process until it is answered, thus leading to the timeout. > > So given that nothing changed in the VM (still starting from the same > snapshot), why did it start displaying this dialog on the 11th? > > Here's a screenshot: > http://fgouget.free.fr/tmp/mshtml_events.png > > -- > Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ > question = ( to ) ? be : ! be; > -- Wm. Shakespeare > > > FWIW, I've noticed a hang with mshtml:events under valgrind (and when I attempted to bisect it, previously working commits failed). I filed a bug, didn't investigate further: https://bugs.winehq.org/show_bug.cgi?id=37157 -- -Austin

Aug. 29, 2014

Re: Wine test analysis August 28th

by Francois Gouget

One of the failures is mshtml:events which has started ahppening on the 11th of August. What is mighty strange is that: * There was no change to dlls/mshtml/tests/events.c around that time and testing with a pre-11th build still shows the failure. * I did not change the VMs around that time (or any time past the 3rd of August). Also the failures started happening not only on some of my VMware VMs, but also on the Windows 2008 VMs of the TestBot. * It does not seem that test actually accesses the network though I may be wrong there. Could it be a change on the Wine web server (I found no matching commit in the tools repository). * The test started failing on Linux (64 bit only) and FreeBSD (32 bit) on the 15th which corresponds to the next commit round. Testing this Windows 2000 and XP shows that the issue is that the iframe_onreadystatechange_complete test triggers a 'You are about to view pages over a secure connection' popup dialog which blocks the process until it is answered, thus leading to the timeout. So given that nothing changed in the VM (still starting from the same snapshot), why did it start displaying this dialog on the 11th? Here's a screenshot: http://fgouget.free.fr/tmp/mshtml_events.png -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ question = ( to ) ? be : ! be; -- Wm. Shakespeare

Aug. 29, 2014

Re: [PATCH] mshtml: Add IHTMLTableCell::bgColor property implementation.

by Jactry Zeng

Hi Jacek, 2014-08-29 23:24 GMT+08:00 Jacek Caban <jacek(a)codeweavers.com>: > > > Please handle variant_to_nscolor errors here. A newer version was sent. Thanks for your review! -- Regards, Jactry Zeng

Aug. 29, 2014

Re: [PATCH] mshtml: Add IHTMLTableCell::bgColor property implementation.

by Jacek Caban

Hi Jactry, On 08/29/14 17:17, Jactry Zeng wrote: > --- a/dlls/mshtml/htmltablecell.c > +++ b/dlls/mshtml/htmltablecell.c > @@ -174,15 +174,47 @@ static HRESULT WINAPI HTMLTableCell_get_vAlign(IHTMLTableCell *iface, BSTR *p) > static HRESULT WINAPI HTMLTableCell_put_bgColor(IHTMLTableCell *iface, VARIANT v) > { > HTMLTableCell *This = impl_from_IHTMLTableCell(iface); > - FIXME("(%p)->(%s)\n", This, debugstr_variant(&v)); > - return E_NOTIMPL; > + nsAString strColor; > + nsresult nsres; > + > + TRACE("(%p)->(%s)\n", This, debugstr_variant(&v)); > + > + nsAString_InitDepend(&strColor, V_BSTR(&v)); > + variant_to_nscolor(&v, &strColor); Please handle variant_to_nscolor errors here. Jacek

Aug. 29, 2014

Implementation of IDwriteFactory::CreateCustomFontCollection

by Guillaume Charifi

Hello, I heard you are working on IDwriteFactory::CreateCustomFontCollection implementation, so I attached my current work, if it can help. It's almost done, just this part, retrieving the font family name to effectively save it, is to be implemented (even if Adobe Creative Cloud works with this changes): + if(!This->families) { + This->count = 1; + This->alloc = 1; + This->families = heap_alloc(This->alloc * sizeof(WCHAR *)); + This->families[0] = heap_strdupW((const WCHAR[]){'d','u','m','m','y',0}); + } else { + add_family_syscollection(This, (const WCHAR[]){'d','u','m','m','y',0}); + } In the hope it could be useful, Regards

Aug. 29, 2014

Re: [2/2] winemenubuilder: ignore icons in unsupported PNG format

by Indrek Altpere

Ah, indeed, my bad for not digging deep enough to the windowscodecs code and jumping to assumptions based on BITMAPINFO. Thanks for catching that, and as I can see on patches page the invalid patch is already marked as rejected. Regards, Indrek

Aug. 29, 2014