October 2007 - Wine-Devel - list.winehq.org

Valgrind and structs with holes

by Dan Kegel

Valgrind is a great tool, but if there's a struct with a hole in it, and we write that struct to a socket (say, to send it to the server), valgrind will likely complain that the hole is uninitialized. For instance, the warning ==3415== Syscall param writev(vector[1]) points to uninitialised byte(s) ==3415== at 0x40007F2: (within /lib/ld-2.6.1.so) ==3415== by 0x4412E24: wine_server_call (server.c:244) ==3415== by 0x43EBA73: server_ioctl_file (file.c:1010) ==3415== by 0x43EC570: NtFsControlFile (file.c:1223) ==3415== by 0x45394C1: WaitNamedPipeW (sync.c:1298) ==3415== by 0x453963B: WaitNamedPipeA (sync.c:1225) ==3415== by 0x46490B5: test_CreateNamedPipe (pipe.c:97) in kernel32/tests/sync.c can be silenced either by appeasing Valgrind with a patch like --- a/dlls/kernel32/sync.c +++ b/dlls/kernel32/sync.c @@ -1285,6 +1285,12 @@ BOOL WINAPI WaitNamedPipeW (LPCWSTR name, DWORD nTimeOut) return FALSE; } + /* FILE_PIPE_WAIT_FOR_BUFFER has a hole after boolean TimeoutSpecified. + * Clear the hole so valgrind doesn't get upset about uninitialized bytes. + * No need to zero Name[1...], which is initialized ok later. + */ + memset(pipe_wait, 0, sizeof(FILE_PIPE_WAIT_FOR_BUFFER)); or by using a suppression like { wine_struct_hole_FILE_PIPE_WAIT_FOR_BUFFER Memcheck:Param writev(vector[1]) obj:* fun:wine_server_call fun:server_ioctl_file fun:NtFsControlFile fun:WaitNamedPipeW } Alexandre, which approach would you prefer? If you say #1, I'll eat my hat. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

Oct. 31, 2007

Re: wined3d: Enable clip planes with GLSL shader backend

by Stefan Dösinger

Am Mittwoch, 31. Oktober 2007 18:50:32 schrieb Fabian Bieler: > - glMatrixMode(GL_MODELVIEW); > - glPushMatrix(); > - glLoadMatrixf((float *) > &stateblock->transforms[WINED3DTS_VIEW].u.m[0][0]); + > if(!use_vs(stateblock->wineD3DDevice)) { > + /* Clip Plane settings are affected by the model view in OpenGL, > the View transform in direct3d */ + glMatrixMode(GL_MODELVIEW); > + glPushMatrix(); > + glLoadMatrixf((float *) > &stateblock->transforms[WINED3DTS_VIEW].u.m[0][0]); + } Isn't this going to cause problems with the glPopMatrix afterwards?

Oct. 31, 2007

Re: Wine Gecko packaging

by Jacek Caban

Hi Dmitry, Dmitry Timoshkov wrote: > http://source.winehq.org/winegecko.php still points to an old Gecko > package > (0.0.1). Please update it. > We can't change it due to compatibility with older Wine versions. We encode Gecko version in URL instead, so http://source.winehq.org/winegecko.php?v=0.1.0 will do what you want. Jacek

Oct. 31, 2007

Generic text printer driver

by Juan Luis Ramos

Hi all, is there anybody working in the generic text printer driver o raw printer driver? I've a problem with a compatible Epson POS printer so, I've modified the text.c code inside wineps.drv to send the text to the printer without postscript processing. The function that send the data is PSDRV_ExtTextOut, but the LPCWSTR parameter passed (str) doesn't contain the ESCAPE codes sent to the printer. I don't find when does the program call the PSDRV_ExtTextOut function. Can anybody help me? Thanks.

Oct. 31, 2007

Re: Tips needed for debugging Skype on Wine (Access violation)

by Paul Vriens

Dmitry Timoshkov wrote: > "Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > >>> Paul, what values IsWow64Process() returns on your box? Is that 32-bit, >>> or 64-bit machine? >>> >> (It wasn't meant as patch that's why I put it between quotes.) >> >> What do you mean with "what values IsWow64Process() returns" ? This is >> hardcoded in process.c > > Sorry, meant to ask "on your XP box". > So as said, that's the same as on Wine. I guess it's just because Skype takes a different path on error. Skype also continues when *Wow64Process is set to TRUE instead of FALSE. So maybe it has nothing to do with it. Running the app on Wine as W2K also fails with the same error but IsWow.. is not called there. -- Cheers, Paul.

Oct. 31, 2007

Re: Tips needed for debugging Skype on Wine (Access violation)

by Dmitry Timoshkov

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: >> Paul, what values IsWow64Process() returns on your box? Is that 32-bit, >> or 64-bit machine? >> > (It wasn't meant as patch that's why I put it between quotes.) > > What do you mean with "what values IsWow64Process() returns" ? This is hardcoded > in process.c Sorry, meant to ask "on your XP box". -- Dmitry.

Oct. 31, 2007

Re: Tips needed for debugging Skype on Wine (Access violation)

by Paul Vriens

Dmitry Timoshkov wrote: > "Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > >> Paul Vriens schreef: >>> Hi, >>> >>> I'm trying to get Skype 3.5.0.39 running on Wine (latest Git). The >>> app however throws an 'Access violation at address 00593AD1 in module >>> "Skype.exe". Read of address FFFFFFFF'. >>> >>> I've set set the version to XP. I do find that when I apply this >>> "patch": >>> >> If I read msdn correctly, the return value you have in that little patch >> is correct. >> >> Return Value >> If the function succeeds, the return value is a nonzero value. >> If the function fails, the return value is zero. To get extended error >> information, call GetLastError. >> >> If you do 'return 1;' it should work correctly, and it should be >> accepted into wine. > > Returning FALSE from IsWow64Process() indicates that there was some error, > so the patch is no correct. Probably what should be changed is setting of > *Wow64Process to TRUE instead of FALSE. > >> From MSDN: > If the application is a 64-bit application running under 64-bit Windows, > the Wow64Process parameter is set to FALSE. > > Paul, what values IsWow64Process() returns on your box? Is that 32-bit, > or 64-bit machine? > (It wasn't meant as patch that's why I put it between quotes.) What do you mean with "what values IsWow64Process() returns" ? This is hardcoded in process.c I've checked with a quick test that the return value and the PBOOL give the same results on my Linux box (64-bit OS) as on my WinXP box (32-bit). So I agree that the "patch" is not correct but it solves this issue (Skype probably takes a different path on error). -- Cheers, Paul.

Oct. 31, 2007

Re: Tips needed for debugging Skype on Wine (Access violation)

by Dmitry Timoshkov

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Paul Vriens schreef: >> Hi, >> >> I'm trying to get Skype 3.5.0.39 running on Wine (latest Git). The app however >> throws an 'Access violation at address 00593AD1 in module "Skype.exe". Read of >> address FFFFFFFF'. >> >> I've set set the version to XP. I do find that when I apply this "patch": >> > If I read msdn correctly, the return value you have in that little patch > is correct. > > Return Value > If the function succeeds, the return value is a nonzero value. > If the function fails, the return value is zero. To get extended error > information, call GetLastError. > > If you do 'return 1;' it should work correctly, and it should be > accepted into wine. Returning FALSE from IsWow64Process() indicates that there was some error, so the patch is no correct. Probably what should be changed is setting of *Wow64Process to TRUE instead of FALSE. >From MSDN: If the application is a 64-bit application running under 64-bit Windows, the Wow64Process parameter is set to FALSE. Paul, what values IsWow64Process() returns on your box? Is that 32-bit, or 64-bit machine? -- Dmitry.

Oct. 31, 2007

Re: alsa->pulseaudio->alsa directsound hang

by Maarten Lankhorst

Hi Al, Al Tobey schreef: > I spent some time this evening playing around with trying to get wine > sound output to go through pulseaudio on my fc8/rawhide (x86_64) box. > I tried wine 0.9.43 (built), 0.9.47 (fc8 rpm), and Crossover 6.2.0. > I was testing with Steam/TF2, but found that the same issue comes up > with a install of Winamp Lite using its default DirectSound output > plugin. If I configure nothing and let wine grab the soundcard (I > have an Audigy, so it allows multiple streams), it works fine. If I > configure it to use pulseaudio through the alsa plugin, it hangs. > Why would you do 'alsa -> pulseaudio -> alsa'? I'm not surprised it wouldn't work. It is more likely a problem with the audio system then with wine, however if you do WINEDEBUG=+wave,+tid,+dsalsa you have a chance of tracking it down yourself. Cheers, Maarten.

Oct. 31, 2007

Re: Tips needed for debugging Skype on Wine (Access violation)

by Maarten Lankhorst

Hi Paul, Paul Vriens schreef: > Hi, > > I'm trying to get Skype 3.5.0.39 running on Wine (latest Git). The app however > throws an 'Access violation at address 00593AD1 in module "Skype.exe". Read of > address FFFFFFFF'. > > I've set set the version to XP. I do find that when I apply this "patch": > If I read msdn correctly, the return value you have in that little patch is correct. Return Value If the function succeeds, the return value is a nonzero value. If the function fails, the return value is zero. To get extended error information, call GetLastError. If you do 'return 1;' it should work correctly, and it should be accepted into wine. Cheers, Maarten.

Oct. 31, 2007