March 2022 - Wine-Devel - list.winehq.org

Re: [PATCH vkd3d 7/8] vkd3d-shader/preproc: Don't add additional spaces after whitespace tokens.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

March 31, 2022

Re: [PATCH v4] programs/winetest: don't create console when non connected to a console

by Alexandre Julliard

Francois Gouget <fgouget(a)codeweavers.com> writes: > Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> > > That's great. I can now reproduce these failures. > The easiest way to do so from a terminal is something like this: > > nohup ./wine ... 2>&1 | cat > > With this winetest patch user32:input succeeds... sometimes. > I don't think this means the patch is wrong. > > Rather the issue is that user32:input itself 'forks' without passing > DETACHED_PROCESS to CreateProcess(), causing consoles to appear in the > middle of the test which randomly leads to failures. Do these consoles also appear on Windows then? -- Alexandre Julliard julliard(a)winehq.org

March 31, 2022

[PATCH] Replace / with : in ConnectionString

by Florian Manschwetus

From: manschwetusCS <30724946+manschwetusCS(a)users.noreply.github.com> In Windows ODBC it seems to be legal to use "host/port", which is not legal with Linux ODBC. This patch aims to find and replace such in the ConnectionString Signed-off-by: Florian Manschwetus <manschwetus(a)cs-software-gmbh.de> --- dlls/odbc32/proxyodbc.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/dlls/odbc32/proxyodbc.c b/dlls/odbc32/proxyodbc.c index c1cb44c29fc..3c78d94b69a 100644 --- a/dlls/odbc32/proxyodbc.c +++ b/dlls/odbc32/proxyodbc.c @@ -1779,10 +1779,21 @@ SQLRETURN WINAPI SQLDriverConnect(SQLHDBC hdbc, SQLHWND hwnd, SQLCHAR *Connectio SQLCHAR *conn_str_out, SQLSMALLINT conn_str_out_max, SQLSMALLINT *ptr_conn_str_out, SQLUSMALLINT driver_completion) { + static const char *serverStr="SERVER="; struct SQLDriverConnect_params params = { hdbc, hwnd, ConnectionString, Length, conn_str_out, conn_str_out_max, ptr_conn_str_out, driver_completion }; SQLRETURN ret; + SQLCHAR *serverPos; + for (serverPos = strstr(ConnectionString,serverStr);(*serverPos != ';') && (*serverPos != '\0'); ++serverPos) + { + if (*serverPos == '/') + { + *serverPos = ':'; + break; + } + } + TRACE("(hdbc %p, hwnd %p, ConnectionString %s, Length %d, conn_str_out %p, conn_str_out_max %d," " ptr_conn_str_out %p, driver_completion %d)\n", hdbc, hwnd, debugstr_an((const char *)ConnectionString, Length), Length, conn_str_out, conn_str_out_max, -- 2.33.0.windows.2 If you received this email in error, please advise the sender (by return email or otherwise) immediately.

March 31, 2022

Re: [PATCH vkd3d 7/8] vkd3d-shader/preproc: Don't add additional spaces after whitespace tokens.

by Matteo Bruni

On Thu, Mar 31, 2022 at 7:13 PM Zebediah Figura <zfigura(a)codeweavers.com> wrote: > > Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> > > --- > > FWIW, the native preprocessor doesn't emit spaces after newlines, but > also, the native HLSL compiler is fine with spaces before "preprocessor" > directives. I have patches in my tree for the latter issue as well. Good to know, makes sense given that the preprocessor allows those. I think I mostly jumped at the opportunity to get rid of those ugly extra whitespaces :D

March 31, 2022

Re: [PATCH v4] programs/winetest: don't create console when non connected to a console

by Francois Gouget

Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> That's great. I can now reproduce these failures. The easiest way to do so from a terminal is something like this: nohup ./wine ... 2>&1 | cat With this winetest patch user32:input succeeds... sometimes. I don't think this means the patch is wrong. Rather the issue is that user32:input itself 'forks' without passing DETACHED_PROCESS to CreateProcess(), causing consoles to appear in the middle of the test which randomly leads to failures. So it looks like we now will have to patch a bunch of tests for similar issues. -- Francois Gouget <fgouget(a)codeweavers.com>

March 31, 2022

Re: [PATCH vkd3d 7/8] vkd3d-shader/preproc: Don't add additional spaces after whitespace tokens.

by Zebediah Figura

Signed-off-by: Zebediah Figura <zfigura(a)codeweavers.com> --- FWIW, the native preprocessor doesn't emit spaces after newlines, but also, the native HLSL compiler is fine with spaces before "preprocessor" directives. I have patches in my tree for the latter issue as well.

March 31, 2022

Re: [PATCH vkd3d v7 2/8] vkd3d-shader/hlsl: Concatenate nested initializers.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

March 31, 2022

Re: [PATCH vkd3d v7 3/8] vkd3d-shader/hlsl: Add 'braces' flag to parse initializers.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

March 31, 2022

Re: [PATCH vkd3d v7 4/8] vkd3d-shader/hlsl: Properly free parse_variable_def memory.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

March 31, 2022

Re: [PATCH vkd3d v7 6/8] vkd3d-shader/hlsl: Treat all braceless initializers as assignments.

by Henri Verbeet

Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com>

March 31, 2022