November 2001 - Wine-Devel - list.winehq.org

Re: Crashing menus, event handling broken?

by Jukka Heinonen

Alexandre Julliard wrote: > Raw messages are not supposed to get processed while there is a cooked > message in the queue. Is the app filtering messages in GetMessage? > Could you please do a +server trace showing the problem? Well, raw messages can be processed even though there is a cooked message in the queue if the application calls GetMessage and the requested message range does not include mouse messages. This seems to be the case here. It looks like the correct fix is much more simple than I thought it would be: wineserver get_message handler just needs to check that there are no pending cooked messages before returning raw messages and some signaling magic must be added to prevent wakeups for raw messages if a cooked message has been queued. Here is (hopefully) the relevant part of +server trace: 080703b8: get_message( flags=1, get_win=00000000, get_first=00000100, get_last=00000108 ) 080703b8: get_message() = 0 { type=6, win=00000000, msg=00000200, wparam=00000001, lparam=00000000, x=142, y=26, time=0000b7b8, info=00020022, data={} } 080703b8: send_message( id=0x80703b8, type=7, win=00020022, msg=000000a0, wparam=00000005, lparam=001a008e, x=142, y=26, time=0000b7b8, info=00020022, timeout=0, data={} ) 080703b8: send_message() = 0 080703b8: get_message( flags=1, get_win=00000000, get_first=00000100, get_last=00000108 ) 080703b8: get_message() = 0 { type=6, win=00000000, msg=00000202, wparam=00000000, lparam=00000000, x=142, y=26, time=0000b7b8, info=00020022, data={} } 080703b8: send_message( id=0x80703b8, type=7, win=00020022, msg=000000a2, wparam=00000005, lparam=001a008e, x=142, y=26, time=0000b7b8, info=00020022, timeout=0, data={} ) 080703b8: send_message() = 0 -- Jukka Heinonen <http://www.iki.fi/jhei/>

Nov. 24, 2001

Re: mmsystem should be loaded at startup

by Alexandre Julliard

Joshua Thielen <thielen(a)netprince.net> writes: > Finale expects mmsystem to be present without having to call LoadLibrary > on it. It does a GetModuleHandle on mmsystem.dll to find out if the mm > extensions are available. I checked out windows 95, and it has mmsystem > and winmm loaded when no apps are runing besides the desktop / > explorer. This patch links wine with winmm andmakes winmm load mmsystem > on init. Finale gets by this ok now. I don't know if this the correct > approach, though. Could someone (Eric or Alexandre?) please take a look > at it before I send it to wine-patches? It would be better to do the LoadLibrary16("mmsystem") in wine_initial_task, this way it only impacts 16-bit applications. -- Alexandre Julliard julliard(a)winehq.com

Nov. 24, 2001

Re: Where are we going on multiuser?

by Alexandre Julliard

"Bill Medland" <medbi01_1(a)accpac.com> writes: > What is our vision on support for multiple users on a single computer? > > I know that WINEPREFIX allows us to use something other than $HOME/.wine for > the base of everything but as far as I can see the whole design still > requires a different WINEPREFIX for each user. (e.g. the socket is in > wine-server-<hostname> and there is no apparent support for the system.reg, > user.reg and userdef.reg being in different places). You need one WINEPREFIX per user yes. You can use global registry files by creating symlinks to global files in the user WINEPREFIX. The usual way is to wrap your app in a shell script that will populate the user's WINEPREFIX if it doesn't exist yet. There are plans for splitting registry files into separate sections with some kind of include mechanism, but nothing implemented yet. -- Alexandre Julliard julliard(a)winehq.com

Nov. 24, 2001

Re: Crashing menus, event handling broken?

by Alexandre Julliard

Jukka Heinonen <jhei(a)iki.fi> writes: > The reason for this is that raw hardware messages get processed > before menu event loop starts. Raw event processing turns raw events > into cooked events and because menu event loop has not started yet, > game window is not capturing events and thus clicks on menu bar > are turned into nonclient messages. These cooked messages are > put back into message queue. Raw messages are not supposed to get processed while there is a cooked message in the queue. Is the app filtering messages in GetMessage? Could you please do a +server trace showing the problem? -- Alexandre Julliard julliard(a)winehq.com

Nov. 24, 2001

Re: mmsystem should be loaded at startup

by Andreas Mohr

On Fri, Nov 23, 2001 at 03:59:16PM -0500, Joshua Thielen wrote: > Hello everybody, > > Finale expects mmsystem to be present without having to call LoadLibrary > on it. It does a GetModuleHandle on mmsystem.dll to find out if the mm > extensions are available. I checked out windows 95, and it has mmsystem > and winmm loaded when no apps are runing besides the desktop / > explorer. This patch links wine with winmm andmakes winmm load mmsystem > on init. Finale gets by this ok now. I don't know if this the correct > approach, though. Could someone (Eric or Alexandre?) please take a look > at it before I send it to wine-patches? OK, I guess that's at least #2, then: King's Quest V installer does the very same thing. I've already been discussing this with Alexandre, BTW. -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

Nov. 23, 2001

mmsystem should be loaded at startup

by Joshua Thielen

Hello everybody, Finale expects mmsystem to be present without having to call LoadLibrary on it. It does a GetModuleHandle on mmsystem.dll to find out if the mm extensions are available. I checked out windows 95, and it has mmsystem and winmm loaded when no apps are runing besides the desktop / explorer. This patch links wine with winmm andmakes winmm load mmsystem on init. Finale gets by this ok now. I don't know if this the correct approach, though. Could someone (Eric or Alexandre?) please take a look at it before I send it to wine-patches? TIA, Josh Thielen Index: wine/miscemu/wine.spec =================================================================== RCS file: /home/wine/wine/miscemu/wine.spec,v retrieving revision 1.3 diff -u -r1.3 wine.spec --- wine/miscemu/wine.spec 2000/12/15 03:38:11 1.3 +++ wine/miscemu/wine.spec 2001/11/23 19:11:47 @@ -4,3 +4,4 @@ init wine_initial_task import ntdll.dll +import winmm.dll Index: wine/dlls/winmm/mmsystem.c =================================================================== RCS file: /home/wine/wine/dlls/winmm/mmsystem.c,v retrieving revision 1.46 diff -u -r1.46 mmsystem.c --- wine/dlls/winmm/mmsystem.c 2001/11/13 21:58:32 1.46 +++ wine/dlls/winmm/mmsystem.c 2001/11/23 19:11:59 @@ -114,6 +114,7 @@ */ BOOL WINAPI WINMM_LibMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID fImpLoad) { + HINSTANCE16 mmsys16; TRACE("0x%x 0x%lx %p\n", hInstDLL, fdwReason, fImpLoad); switch (fdwReason) { @@ -124,9 +125,15 @@ MULTIMEDIA_DeleteIData(); return FALSE; } + mmsys16 = LoadLibrary16("mmsystem.dll"); + if (!mmsys16) { + ERR("Could not load sibling mmsystem.dll\n"); + return FALSE; + } break; case DLL_PROCESS_DETACH: MULTIMEDIA_DeleteIData(); + if(mmsys16) FreeLibrary16(mmsys16); break; case DLL_THREAD_ATTACH: case DLL_THREAD_DETACH: @@ -2549,7 +2556,7 @@ TRACE("(%d, %p, %d);\n", uDeviceID, lpCaps, uSize); if ((wmld = MMDRV_Get(uDeviceID, MMDRV_MIDIIN, TRUE)) == NULL) - return MMSYSERR_INVALHANDLE; + return MMSYSERR_BADDEVICEID; return MMDRV_Message(wmld, MIDM_GETDEVCAPS, (DWORD)lpCaps, uSize, TRUE); }

Nov. 23, 2001

Where are we going on multiuser?

by Bill Medland

What is our vision on support for multiple users on a single computer? I know that WINEPREFIX allows us to use something other than $HOME/.wine for the base of everything but as far as I can see the whole design still requires a different WINEPREFIX for each user. (e.g. the socket is in wine-server-<hostname> and there is no apparent support for the system.reg, user.reg and userdef.reg being in different places). Bill

Nov. 23, 2001

Re: fix documentation compilation error

by Andreas Mohr

On Fri, Nov 23, 2001 at 01:35:14AM +0100, Michael Stefaniuc wrote: > Changelog: > Michael Stefaniuc <mstefani(a)redhat.com> > Add missing </para> in documentation/packaging.sgml Ouch ! Hmm, better make an actual compile next time :-\ Sorry !! -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.nexgo.de/andi.mohr/

Nov. 23, 2001

Re: Another pack4 issue (fwd)

by Dmitry Timoshkov

"Ulrich Weigand" <weigand(a)immd1.informatik.uni-erlangen.de> wrote: > > Without pshpack4.h sizeof(LUID_AND_ATTRIBUTES)=16 instead of 12. Don't ask > > me why. > > Because the size of a structure is always padded to the next multiple of > its alignment (so that in an array of structures, every element is properly > aligned iff the array is). By changing the alignment, you therefore also > sometimes change the size of a structure ... Ulrich, thanks for explanations. I believe that's the case for the FILETIME vs. LARGE_INTEGER issue too. -- Dmitry.

Nov. 23, 2001

Re: Another pack4 issue (fwd)

by Ulrich Weigand

> Without pshpack4.h sizeof(LUID_AND_ATTRIBUTES)=16 instead of 12. Don't ask > me why. Because the size of a structure is always padded to the next multiple of its alignment (so that in an array of structures, every element is properly aligned iff the array is). By changing the alignment, you therefore also sometimes change the size of a structure ... Bye, Ulrich -- Dr. Ulrich Weigand weigand(a)informatik.uni-erlangen.de

Nov. 23, 2001