May 2001 - Wine-Devel - list.winehq.org

Finding (or not) the exact number of args

by Gaël de Chalendar

Hi, I'm trying to implement stubs for some missing ordinal functions in shlwapi. Reading the NOTES comment in dlls/shlwapi/ordinal.c I don't know if it is a good idea, but it allows explorer.exe (Win 98) to show its desktop and it is what I'm testing (just for fun. I do not hope to be able to use it right now). Anyway, it uses at a moment or another unimplemented ordinal functions. To implement their stubs, I begins with a lot of args, reducing this number until the function is passed. It seems to work but I wonder if I do not add only problems with this strategy. If I left the stack in a corrupted state, maybe the problem will become visible a lot later... I was not able to find in docs, mails archives or google groups any useful tip to find (simply) the right number of args. Particularly, the URL http://www.ece.cmu.edu/afs/ece/usr/dacut/www/src is dead. So, do I continue ? If yes, in this way or differently ? Thanks for your advices. Gael. PS: I will not read my mail until monday 28.

May 23, 2001

Re: Finding (or not) the exact number of args

by 520053692817-0001＠t-online.de

On Wed, May 23, 2001 at 06:01:51PM +0000, Gaël de Chalendar wrote: [...] > Anyway, it uses at a moment or another unimplemented ordinal functions. To > implement their stubs, I begins with a lot of args, reducing this number > until the function is passed. It seems to work but I wonder if I do not add > only problems with this strategy. If I left the stack in a corrupted state, > maybe the problem will become visible a lot later... > I was not able to find in docs, mails archives or google groups any useful > tip to find (simply) the right number of args. Particularly, the URL > http://www.ece.cmu.edu/afs/ece/usr/dacut/www/src is dead. > > So, do I continue ? If yes, in this way or differently ? Differently. You get a nice "crash" when the program hits an unimplemented function. Do a backtrace, then do a disas of the code that led to the unimplemented function. Count the number of pushes before that call. That's usually the number of arguments you need to use. -- Andreas Mohr Stauferstr. 6, D-71272 Renningen, Germany Tel. +49 7159 800604 http://home.germany.net/100-30936/

May 23, 2001

Re: Configuration/Announce

by Ian Pilcher

Mike Bond wrote: > > I believe it should have been HKEY_CURRENT_USER instead of HKEY_LOCAL_USER. > That did it. Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

May 23, 2001

More wine beginner questions

by Mike Bond

I was just perusing through msvcrt and noticed that in wcs.c there is an implementation of _vsnwprintf, which also exists, verbatim, in it's entirety, in ntdll/wcstring.c. Unless I am misunderstanding the .spec files there appears to be a method of "forward"ing a symbol to an external implementation, such as: @ forward -noimport wcslen ntdll.wcslen Is there any particular reason this was not done for _vsnwprintf as well? There is even a comment in the wcs.c copy saying to mirror any fixes in the ntdll copy. Also, on perhaps a style note, I've noticed some implementations are prefixed by the dll name in all caps, such as MSVCRT_vfprintf, and some are not, such as _wmkdir. Is this just personal style or is there more to these differences? -- TTFN MikeB

May 23, 2001

Re: Configuration/Announce

by Mike Bond

I believe it should have been HKEY_CURRENT_USER instead of HKEY_LOCAL_USER. On Tue, May 22, 2001 at 05:21:44PM -0500, Ian Pilcher wrote: > eric pouech wrote: > > > > regapi setValue < foo > > Anyone know why I would get the following? > > regapi: doSetValue failed to open key > [HKEY_LOCAL_USER\Software\Microsoft\Windows\CurrentVersion\Multimedia\MIDIMap] -- TTFN MikeB

May 23, 2001

Re: Configuration/Announce

by Ian Pilcher

eric pouech wrote: > > regapi setValue < foo Anyone know why I would get the following? regapi: doSetValue failed to open key [HKEY_LOCAL_USER\Software\Microsoft\Windows\CurrentVersion\Multimedia\MIDIMap] -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

May 22, 2001

Re: Small fixes in controls/menu.c

by gerard patel

At 03:42 AM 22/05/2001 +0200, you wrote: >In attachement WIN.3_11 you can see listing generated under windows 3.11. >( Borland WinSight ) (If you want get a listing generated under win98/95 - no >problem , but I'll have to format&reinstall ,because this copy of windows >stopped functioning about 6 months ago ) >WINE_SETWINPOS ,WINE_NCALC- under wine with first and second version of >patch. >I think WINE_NCALC is more similar to WIN.3_11 . There is nothing looking like a SetWindowPos call between WM_INITMENU and WM_INITPOPUPMENU, yes. But as Alexandre Julliard was pointing, it does not mean that something like calling NC_HandleNCCalcSize is done. >I'm wondering why menu->Height == 0. I'll investigate it. height = 0 because at some point the menu has been changed; this is a Wine flag to signal that the menu dimensions have to be calculated again. The problem with my test app without my original patch is that the menu sizes are not calculated at this point so the mouse clicks are ignored Btw, I have downloaded several of the availables app on your web site and I don't see anything wrong with menus; IIRC I have tried 7.5 for Win3.11, and trial versions 8 and 9 (32 bits). Is it with the main menu that you see this problem ? Gerard

May 22, 2001

Re: Configuration/Announce

by Alexandre Julliard

eric pouech <eric.pouech(a)wanadoo.fr> writes: > First of all, your Wine configuration file now needs a WinMM section > containing the following: > [WinMM] > "Drivers" = "wineoss.drv" > "WaveMapper" = "msacm.drv" > "MidiMapper" = "midimap.drv" > > Not adding this will print the following message > > You didn't setup properly the config file for the Wine multimedia modules. > > Will use the hard-coded setup, but this will disapear soon. > > Please add a WinMM section to your Wine config file. > Note that the above configuration will be shortly required, so don't > wait before setting your configuration up Please keep the defaults. There is no reason to force people to update their configuration file when there are workable defaults that we can use. Ideally Wine should behave reasonably even with an empty configuration file; this is not entirely possible because things like paths don't have reasonable defaults, but forcing people to specify things that we could guess is not user-friendly. -- Alexandre Julliard julliard(a)winehq.com

May 22, 2001

Configuration/Announce

by eric pouech

with today's CVS commit (for those who stay up to date with the latest developments), you'll have to modify your Wine configuration to reflect the changes. First of all, your Wine configuration file now needs a WinMM section containing the following: [WinMM] "Drivers" = "wineoss.drv" "WaveMapper" = "msacm.drv" "MidiMapper" = "midimap.drv" Not adding this will print the following message > You didn't setup properly the config file for the Wine multimedia modules. > Will use the hard-coded setup, but this will disapear soon. > Please add a WinMM section to your Wine config file. Note that the above configuration will be shortly required, so don't wait before setting your configuration up Next, you have also to add a key to your registry. To do so, create a sample file (let's call it foo) containing the following text: [HKEY_LOCAL_USER\Software\Microsoft\Windows\CurrentVersion\Multimedia\MIDIMap] 989041554 "AutoScheme"=dword:00000000 "CurrentInstrument"="#0" "UseScheme"=dword:00000000 then goto the <wine>/programs/regapi and compile the program the run: regapi setValue < foo that's it Not applying the key in the registry will result in various errors in MIDIMAP_ functions (mainly if Wine is set up to use a native Windows system) Maintainers are welcome to update theirs packages accordingly (default values are in documentation/samples/config & winedefault.reg) Detailed information is available in documentation/multimedia.sgml. A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

May 22, 2001

Re: Small clean up

by eric pouech

> Is it because I made changes to these files (probably traces) that CVS > did not dare delete them? yes > But shouldn't it say 'was removed, no comparison available'? well, it's hard to tell between a deleted file and a not yet submitted file (knowing that you can also recreate a file with the same name as one you've already deleted) so, an error message telling that a file with the same name exists in Attic would make more sense anyway, it's a always a good point to inspect closely the output of a cvs update A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

May 22, 2001