July 2001 - Wine-Devel - list.winehq.org

Re: Make built-in font data read-only

by Ian Pilcher

Alexandre Julliard wrote: > > Well, if it's not feasible so be it. But if it's at all possible I > think it's worth some reasonable amount of trouble. > AFAICT, just about every part of the driver that deals with fonts would have to be rewritten to deal with two different data models. In addition to the up-front work, just imagine the maintenance nightmare! I'll keep chewing on this. Suggestions are welcome! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

July 25, 2001

Re: Make built-in font data read-only

by Alexandre Julliard

Ian Pilcher <ian.pilcher(a)home.com> writes: > If all pointers have to be eliminated, I can't see any way to do it. > In order for the code to have any kind of sanity, built-in font metrics > and dynamically loaded font metrics have to use the same data model, and > I don't think it's even remotely practical to get rid of the pointers in > the case of the dynamically loaded metrics. Well, if it's not feasible so be it. But if it's at all possible I think it's worth some reasonable amount of trouble. > I'm open to suggestions, but I think that the effort involved in doing > this (assuming a sane way could be found) probably far outweighs the > benefit (less swap usage if the data is paged out; is there any other > benefit?). The main benefit is sharing between processes; so if you have 10 processes that want to print you only have one copy of the font data in memory. Plus it gets loaded on-demand so data that isn't used doesn't need to be loaded from disk at all. > Just in case I get inspired, though, what tool/command are you using to > determine read-only vs. read/write data sizes? Can I just go by what > objdump says about .data and .rodata? objdump is fine yes. size works too, though I seem to remember some versions not counting .rodata correctly. -- Alexandre Julliard julliard(a)winehq.com

July 25, 2001

Re: Make built-in font data read-only

by Ian Pilcher

Alexandre Julliard wrote: > Ian Pilcher <ian.pilcher(a)home.com> writes: > > > Unfortunately the data still isn't stored in read-only memory even > though it is declared const, because the structures contain pointers > that require relocation. Would it be possible to store offsets instead > of pointers? > > If all pointers have to be eliminated, I can't see any way to do it. In order for the code to have any kind of sanity, built-in font metrics and dynamically loaded font metrics have to use the same data model, and I don't think it's even remotely practical to get rid of the pointers in the case of the dynamically loaded metrics. I'm open to suggestions, but I think that the effort involved in doing this (assuming a sane way could be found) probably far outweighs the benefit (less swap usage if the data is paged out; is there any other benefit?). Better to focus to eliminating unused data, which is probably more than 50% of what's there right now. Just in case I get inspired, though, what tool/command are you using to determine read-only vs. read/write data sizes? Can I just go by what objdump says about .data and .rodata? -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

July 25, 2001

Re: move 16bit COMM code to USER

by lawson_whitney＠juno.com

On Tue, 24 Jul 2001 11:11:05 +1000 Mike McCormack <mike_mccormack(a)start.com.au> writes: > This is a multi-part message in MIME format > > ------=_NextPart_000_83577347 > Content-Type: text/plain; charset="us-ascii" > Content-Transfer-Encoding: 7bit > > > This patch completes the seperation of the 16bit COMM code from > KERNEL > and moves it to USER. Seems to work with Terminal from WFW 3.11. > > Mike If you get this, it seems to work for juno 1.49 too. Lawson ---oof--- > ChangeLog: > move 16-bit COMM code to USER dll > > ________________________________________________________________ GET INTERNET ACCESS FROM JUNO! Juno offers FREE or PREMIUM Internet access for less! Join Juno today! For your FREE software, visit: http://dl.www.juno.com/get/tagj.

July 25, 2001

Re: Microsoft source code releases - a danger to Wine?

by kenon＠go2.pl

On Mon, Jul 23, 2001 at 02:39:02PM +0000, Bill Medland wrote: > > I must admit that as a newcomer to the Wine project I would appreciate a > little guidance on what are and are not valid methods for investigating > Windows sufficiently to work on the Wine project. This cuts two ways: > 1. What methods are accepted as legal for obtaining information and what > methods must not be used (in order to protect Wine) > 2. What methods are especially effective and what methods are a waste of > time (in order to improve the learning curve for contributors) > > Should there be a section in the Wine Development HQ > > (Or is it already there and I missed it). > > Bill > > I want to know too. Maciek

July 24, 2001

Re: Make built-in font data read-only

by Alexandre Julliard

Ian Pilcher <ian.pilcher(a)home.com> writes: > Log message: > Ian Pilcher <ian.pilcher(a)home.com> > WINEPS: make built-in font data read-only Unfortunately the data still isn't stored in read-only memory even though it is declared const, because the structures contain pointers that require relocation. Would it be possible to store offsets instead of pointers? -- Alexandre Julliard julliard(a)winehq.com

July 24, 2001

Re: oleaut32 patch

by Alexandre Julliard

Andreas Mohr <a.mohr(a)mailto.de> writes: > - changes OaBuildVersion() to always return a very high version value > (2.xx.0xffff), which can be overridden in the config file to deliver > an exact value instead Do we really need such an obscure parameter in the main config file? Are there actual cases where setting the version based on -winver is not enough? -- Alexandre Julliard julliard(a)winehq.com

July 24, 2001

Compile error, Please help!!!!!Thanks

by EriK W

Hi gurus, Please help me out with the fatal compiling problem. I am using soalris8 x86 with wine-20010629, Any suggestion would be highly appreciated! /usr/openwin/include/X11/Xutil.h:56: warning: ignoring pragma: "@(#)Xutil.h 1.2 00/07/05 SMI gcc -Wl,-G -Wl,-h,/usr/local/lib/libwine_tsx11.so locking.o ts_xf86dga.o ts_xf86dga2.o ts_xf86vmode.o ts_xshm.o ts_xlib.o ts_xresource.o ts_xvideo.o ts_xutil.o ts_shape.o ts_xpm.o -o libwine_tsx11.so.1.0 rm -f libwine_tsx11.so && ln -s libwine_tsx11.so.1.0 libwine_tsx11.so LD_LIBRARY_PATH="../../unicode:$LD_LIBRARY_PATH" ../../tools/winebuild/winebuild -fPIC -L../../dlls -o ntdll.spec.c -spec ./ntdll.spec ld.so.1: ../../tools/winebuild/winebuild: fatal: /usr/local/lib/libwine_unicode.so: open failed: No such file or directory *** Error code 137 make: Fatal error: Command failed for target `ntdll.spec.c' Current working directory /export/home/ericw/system/wine-20010629/dlls/ntdll *** Error code 1 make: Fatal error: Command failed for target `ntdll/libntdll.so' Current working directory /export/home/ericw/system/wine-20010629/dlls *** Error code 1 make: Fatal error: Command failed for target `dlls'

July 24, 2001

Re: Function declaration fixes

by Francois Gouget

On Mon, 23 Jul 2001, Patrik Stridvall wrote: [...] > *** declarations > > * dlls/msvcrt/cpp.c, > dlls/msvcrt/exit.c, > dlls/msvcrt/mbcs.c, > dlls/msvcrt/msvcrt.h, > dlls/ntdll/signal_i386.c, > dlls/shell32/shlmenu.c, > include/wine/undocshell.h: > - Made sure that the files that contains the declarations > of the implementated functions are included. > - Corrected mismatching prototypes. > - Cleaned up the include section. You should not add a prototype for MSVCRT_isleadbyte and MSVCRT_realloc in wine/dlls/msvcrt/msvcrt.h. These are declared in include/msvcrt/wctype.h and include/msvcrt/malloc.h respectively. The correct fix is to include these headers where needed. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Broadcast message : fin du monde dans cinq minutes, repentez vous !

July 23, 2001

[PROBLEM REPORT] Edit control line scrolling

by Gerard Patel

With programs using a multiline edit control, such as Notepad (I'm using Win3.11 version) or Eudora Light 1.5 with mails from the 'In' mailbox (this is a 32 bits application), scrolling down the edit buffer line by line mostly does not work. In fact, it works only if the edit buffer size is an exact multiple of the line height. In all other cases, the format rectangle is smaller than the client size, and when the edit control tries to redraw the last line, the update rectangle is wrong : only the lower part of the line is drawn. I think that this problem can be traced to the replacement of code in ScrollWindowEx by the call to ScrollDC. What is happening is that the client rectangle is scrolled, but the client rectangle is bigger than the formatting rectangle by a few pixels; these pixels are missing in the update region. In Wine previous version, the client rectangle was first ANDed with the so-called 'visible region' (hvisRgn), so the result was not bigger than the format rectangle before being scrolled, then diff-ed with it. The following patch works around this problem. I don't have time to investigate further as I am taking one week of holidays :-) but if someone is interested in the edit control.... Gerard Index: dlls/x11drv/scroll.c =================================================================== RCS file: /home/wine/wine/dlls/x11drv/scroll.c,v retrieving revision 1.2 diff -u -r1.2 scroll.c --- dlls/x11drv/scroll.c 2001/06/20 00:18:48 1.2 +++ dlls/x11drv/scroll.c 2001/07/22 22:12:06 @@ -114,7 +114,7 @@ hrgn2 = CreateRectRgnIndirect( &rect ); if (hrgn) SetRectRgn( hrgn, rClip.left, rClip.top, rClip.right, rClip.bottom ); else hrgn = CreateRectRgn( rClip.left, rClip.top, rClip.right, rClip.bottom ); - CombineRgn( hrgn, hrgn, hrgn2, RGN_AND ); + CombineRgn( hrgn2, hrgn, hrgn2, RGN_AND ); OffsetRgn( hrgn2, dx, dy ); CombineRgn( hrgn, hrgn, hrgn2, RGN_DIFF );

July 23, 2001