August 2001 - Wine-Devel - list.winehq.org

Re: Toolbar background error

by Guy L. Albertelli

-----Original Message----- From: Bill Medland <medbi01(a)accpac.com> To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> Date: Wednesday, August 15, 2001 1:58 PM Subject: Re: Toolbar background error > >BTW since you are working on controls I thought I'd better let you know >this. > >I intend at some point working on the ListView control's handling of the >text in the large icon view unless someone gets there first. However it >will require corrections to DrawText/DrawTextEx's handling of the >EDIT_CONTROL style flag first (which affects the word wrapping/cutting of >long words in multiline stuff). In addition from a quick experiment I >think that quite a lot of work will be required within listview.c because >it appears to be unstably dependent on the fact that the size of the text >portion is currently constant; the clipping and repainting falls to pieces >when the size of the text depends on whether the icon is selected or not >etc. > >I thought I'd better let people know in case they get there before me. > Sounds great!! Have at it!! Guy

Aug. 16, 2001

Re: toolbar

by Guy L. Albertelli

-----Original Message----- From: Mike McCormack <mike_mccormack(a)start.com.au> To: galberte(a)neo.lrun.com <galberte(a)neo.lrun.com> Date: Wednesday, August 15, 2001 8:11 PM Subject: Re: toolbar >Hey Guy, > >i updated from CVS thismorning, and saw some messages in wine-devel >about the toolbar, so did a quick test with WinZip 8. > >Everything seems to be fine! There are still some minor drawing >problems, but they were there before. They are: > >* button sometimes remains in the clicked state after i click it... >for example after clicking on the Open button in WinZip, the Open File >dialog appears, but the Open button is still in the clicked state. It >remains that way until i move the mouse over it again. Yes , I have seen this also. I am not sure what the problem is or even where. Possibilities: - WM_MOUSELEAVE not always getting generated. - Toolbar processing of WM_MOUSELEAVE is not 100% correct. - Something totally else. > >* sometimes after the tooltips disappear, the rectangle around the >edge of the button is not redrawn, so there is a "mark" where the >tooltip was. > I have not seen this, but I haven't looked for it. Thanks, Guy

Aug. 16, 2001

Re: Toolbar background error

by Bill Medland

Guy L. Albertelli <galberte(a)neo.lrun.com> wrote in article <000401c125ab$e2978260$d1ae5d18(a)oemcomputer.neo.rr.com>... > Bill, > > Can you try the current CVS and let me know how that works. I have been > doing some work with Toolbar, Rebar, etc. and the background drawing was one > of the problems. > > If it still has problems, let me know the application and I will work on it. > > Thanks, > > Guy > -----Original Message----- > From: Bill Medland <medbi01(a)accpac.com> > To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> > Date: Wednesday, August 15, 2001 11:12 AM > Subject: Toolbar background error > > > >Has anyone else noticed this? Is anyone already looking into this? > > > >Sometime during July something was changed that resulted on my setup > >failing to draw the toolbar background properly (it leaves the bottom third > >transparent). > > > >Since I have had previous problems with this setup (due to some sort of gcc > >bug) I thought I'd check. > > > >Bill > > > > > > > > > > > > > > > In case you haven't found it yet it is in windows/defwnd.c; the change made between 1.57 and 1.58. Are you going to handle it? Bill

Aug. 15, 2001

RE: Toolbar background error

by Medland, Bill

I am just compiling up today's Wine; it was certainly there yesterday. As far as I can tell it crept in between 20010726 and 20010731 (dates in the WINE cvs itself). I will send you a test executable that shows the problem. Let me know how it appears on yours. Bill > -----Original Message----- > From: Guy L. Albertelli [SMTP:galberte(a)neo.lrun.com] > Sent: Wednesday, August 15, 2001 10:01 AM > To: Bill Medland > Cc: Wine Devel > Subject: Re: Toolbar background error > > Bill, > > Can you try the current CVS and let me know how that works. I have been > doing some work with Toolbar, Rebar, etc. and the background drawing was > one > of the problems. > > If it still has problems, let me know the application and I will work on > it. > > Thanks, > > Guy > -----Original Message----- > From: Bill Medland <medbi01(a)accpac.com> > To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> > Date: Wednesday, August 15, 2001 11:12 AM > Subject: Toolbar background error > > > >Has anyone else noticed this? Is anyone already looking into this? > > > >Sometime during July something was changed that resulted on my setup > >failing to draw the toolbar background properly (it leaves the bottom > third > >transparent). > > > >Since I have had previous problems with this setup (due to some sort of > gcc > >bug) I thought I'd check. > > > >Bill > > > > > > > > > >

Aug. 15, 2001

COM/DCOM standard, conformance test suite (was: Wine call graph; wineserver; the "big picture")

by Dan Kegel

Phillip Schmitz wrote: > I've been lurking for a while now with a view to starting work on wine > - specifically COM and DCOM. I know some people have started some work > and there might be some patent issues with COM at least - so maybe > DCOM is a better bet (I had the possibly naive idea of implementing > COM via DCOM - it would be almost transparent, slower but less > "dangerous"). I doubt that DCOM has fewer patent issues than COM. By the way, here's a good 'executive summary' of com/dcom: http://www.sei.cmu.edu/str/descriptions/com_body.html And here's the official spec (yes, there is one!): http://www.opengroup.org/onlinepubs/009899899/ The above document is actually the "ActiveX" spec, so it covers more than just COM, but that's probably good. I don't know how good it is as an implementor's guide, but it looks promising. > Also, what do people use in terms of test-suites? custom win32 apps? > free/shareware? While I have quite a few larger apps like Office etc I > imagine it's better to try smaller, more specific apps at first. I > want to do comparisons and communication with Win95/8 in VMWare and > don't really want to _purchase more Win32 apps_ for testing! Good question. There *is* a COM conformance test suite; see http://www.microsoft.com/msj/1298/ntUnix/ntUnixtop.htm I doubt that Microsoft would let Wine developers use it, though. On the other hand, the Open Group sells COM/DCOM implementations packaged with the interoperability test suite at a "nominal fee"; see http://www.opengroup.org/comsource/datasheet.htm They have released things like Motif as open source in the past... I wonder if they'd be willing to contribute their DCOM or the test suite? That would rock. Anyone know anyone who works at the Open Group? :-) - Dan -- "I have seen the future, and it licks itself clean." -- Bucky Katt

Aug. 15, 2001

Re: Toolbar background error

by Guy L. Albertelli

Bill, Can you try the current CVS and let me know how that works. I have been doing some work with Toolbar, Rebar, etc. and the background drawing was one of the problems. If it still has problems, let me know the application and I will work on it. Thanks, Guy -----Original Message----- From: Bill Medland <medbi01(a)accpac.com> To: wine-devel(a)winehq.com <wine-devel(a)winehq.com> Date: Wednesday, August 15, 2001 11:12 AM Subject: Toolbar background error >Has anyone else noticed this? Is anyone already looking into this? > >Sometime during July something was changed that resulted on my setup >failing to draw the toolbar background properly (it leaves the bottom third >transparent). > >Since I have had previous problems with this setup (due to some sort of gcc >bug) I thought I'd check. > >Bill > > > > >

Aug. 15, 2001

Re: Toolbar background error

by Bill Medland

Guy L. Albertelli <galberte(a)neo.lrun.com> wrote in article <000401c125ab$e2978260$d1ae5d18(a)oemcomputer.neo.rr.com>... > Bill, > > Can you try the current CVS and let me know how that works. I have been > doing some work with Toolbar, Rebar, etc. and the background drawing was one > of the problems. > > If it still has problems, let me know the application and I will work on it. > > Thanks, > > Guy BTW since you are working on controls I thought I'd better let you know this. I intend at some point working on the ListView control's handling of the text in the large icon view unless someone gets there first. However it will require corrections to DrawText/DrawTextEx's handling of the EDIT_CONTROL style flag first (which affects the word wrapping/cutting of long words in multiline stuff). In addition from a quick experiment I think that quite a lot of work will be required within listview.c because it appears to be unstably dependent on the fact that the size of the text portion is currently constant; the clipping and repainting falls to pieces when the size of the text depends on whether the icon is selected or not etc. I thought I'd better let people know in case they get there before me. Bill

Aug. 15, 2001

Transparent child windows

by Timo Kujala

Hi, Some time ago I posted a problem with M$ 32-bit terminal server client, as it did not paint it's window. Finally I got some time to look into this a bit more and found out following: The terminal server client creates (among other windows) two child windows, "Input Capture Window" and "Output Painter Window" (in that order). Input capture window is specified as transparent and it is laid over the output painter window so that the actual image is painted in the output painter window and input capture window just receives mouse clicks and keyboard input. The problem is that the input capture window is not really transparent. Output painter window is behind it and therefore output is never seen. (I was able to find this out by moving input capure window away from the view by modifying code in createwindow-call in win.c, but then mouse won't work in terminal server client) Any fixes for this?

Aug. 15, 2001

Toolbar background error

by Bill Medland

Has anyone else noticed this? Is anyone already looking into this? Sometime during July something was changed that resulted on my setup failing to draw the toolbar background properly (it leaves the bottom third transparent). Since I have had previous problems with this setup (due to some sort of gcc bug) I thought I'd check. Bill

Aug. 15, 2001

Re: printing AND memory

by Richard Canada

> Richard Canada wrote: > >>trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' >>err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for >>printer 'Wine PostScript Driver' >>trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) >>trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' >>err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for >>printer 'Wine PostScript Driver' >>trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) >>fixme:pthread_kill_other_threads_np >> >> > > It looks like you haven't specified a PPD file for your printer. The > right method for configuring this varies, depending on how you've > configured your printer, so I need to know how you set up your printer. > -- > ======================================================================== > Ian Pilcher ian.pilcher(a)home.com > ======================================================================== This is how I have my printer set up: (snip from my wine config file) [afmfiles] "file<n>" = "/usr/share/fonts/afms/adobe/pagd8a.afm" [psdrv] "ppdfile" = "/windows/wine/TEMP/ADOBE/HP/HP4PLUS6.PPD" [serialports] "Com1" = "/dev/ttyS0" "Com2" = "/dev/ttyS1" "Com3" = "/dev/ttyS2" "Com4" = "/dev/modem" [parallelports] "Lpt1" = "/dev/lp0" [ppdev] ;; key: io-base of the emulated port ;; value : parport-device{,timeout} ;; timeout for auto closing an open device ( not yet implemented) ;"378" = "/dev/parport0" ;"278" = "/dev/parport1" ;"3bc" = "/dev/parport2" [spooler] "FILE:" = "tmp.ps" "LPT1:" = "|lp -ddevelp -tRICHARD" "LPT2:" = "|gs -sDEVICE=bj200 -sOutputFile=/tmp/fred -q -" "LPT3:" = "/dev/lp3" I have set up the win.ini file correctly, here is the file: [devices] Wine PostScript Driver=WINEPS,LPT1: [windows] device=Wine PostScript Driver,WINEPS,LPT1: [PrinterPorts] Wine PostScript Driver=WINEPS,LPT1: BTW, I am using LPRng on my RedHat 7.1 box. I have no local printers, only network printers that I print to through a print server. Any more suggestions, I would appreciate it. Regards, Richard

Aug. 15, 2001

wine server

by Mike McCormack

Hi Phillip, The wineserver does the job of the Windows NT kernel in wine. Here's a summary of what i've worked out about the wineserver: * the wineserver is responsible for all system level synchronization of wine processes, and maintaining integrity of handles * the wineserver is the sole repository for all HANDLE data in the wine process group. * wineserver communicates with each wine process thru a socket and shared memory. There is one socket and one shared memory area per wine process. * the main task of wineserver is a loop which polls on all the wine process sockets, and handles timeouts. * the wineserver processes requests one by one (it is a single thread). * each request is triggered by the wine process writing to its socket, and ended when the wineserver writes back to the socket. During the request, the wine process is effectively stopped. * request data may be read to or written from the shared memory, but the shared memory is not used for synchronization. Synchronization is maintained solely by socket reads and writes. * the wineserver should end each request before processing the next * the wineserver must never wait for or depend upon any wine processes. All wine processes must be assumed to be unstable and unreliable. (even if they're not) * the wineserver design is reliable, but rather slow due to all the context switching required by each request. David Howells made an effort to turn it into a Linux kernel module... he hasn't finished yet. hope that's accurate and helpful... Mike ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

Aug. 15, 2001

Wine call graph; wineserver; the "big picture"

by Phillip Schmitz

[I mistakenly posted this to comp.emulators.ms-windows.wine / wine-users rather than here. Thanks to eric pouech for his reply there. Sorry if you've already seen this there] Hi, I've been lurking for a while now with a view to starting work on wine - specifically COM and DCOM. I know some people have started some work and there might be some patent issues with COM at least - so maybe DCOM is a better bet (I had the possibly naive idea of implementing COM via DCOM - it would be almost transparent, slower but less "dangerous"). I've read most of the developer docs and some relevant source but I'm still having problems grokking the interrelationships between different parts of wine and the role(s) of wineserver. I have a general understanding of Win32 from a programatic point of view rather than wine's implementation details. While I'm quite willing to "read the source" there's rather a lot of it :) and rather deep dependencies (even with tags one jumps around for a while trying to understand what does what). Does anyone have a call graph for wine or a (decent, open-source) program for making one. I've considered Source-Navigator but it seems like the required database would be twice the size of the wine source! Since (D)COM affects many parts of function and message handling and process address space tampering I considered the less ambitious project of fixing up (Net)DDE first - at least then the all-important Hearts will run networked. Is anyone actively working on that (the source has sporadic updates)? I don't want to start hacking off on a tangent. The different behaviours of win9x and NT will also be a problem since I don't have a real NT installation Also, what do people use in terms of test-suites? custom win32 apps? free/shareware? While I have quite a few larger apps like Office etc I imagine it's better to try smaller, more specific apps at first. I want to do comparisons and communication with Win95/8 in VMWare and don't really want to _purchase more Win32 apps_ for testing! Thanks for any experience or insight you might share. Phillip

Aug. 15, 2001

RE: Unable to use RegisterClass(&WndClass);

by Craig Chandler

> Hello all. > > According to MSDN all classes in Win32 are local. > > My experiments under Win2000 show that user32 always turns off > CS_GLOBALCLASS (actually even "system" classes doesn't have it set) > and does fix hInstance to the module handle. > > The attached patch tries to do the same in Wine. > > Comments, suggestions? > -- > Dmitry. > > ok, played around with both patches, both refuse to start the application with errors in invalid class names. Changed my own source to rename the "button" class to my own custom name ("ifbutton") and it starts fine. (so the original class.c works). Had a whole lot of other errors but i'll get to them later. I'm reading up on how to debug wine at the moment (i'm a new user) so hopefully i'll get some more usefull info to you later.

Aug. 14, 2001

Re: printing AND memory

by Ian Pilcher

Richard Canada wrote: > > trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' > err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for > printer 'Wine PostScript Driver' > trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) > trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' > err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for > printer 'Wine PostScript Driver' > trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) > fixme:pthread_kill_other_threads_np > It looks like you haven't specified a PPD file for your printer. The right method for configuring this varies, depending on how you've configured your printer, so I need to know how you set up your printer. -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

Aug. 14, 2001

Re: Solaris X86 mmap...

by Alexandre Julliard

Robert Lunnon <bob(a)yarrabee.net.au> writes: > After that point I can't find any reference to this patch, it certainly > hasn't made it into the CVS yet ? > > Does anyone know the outcome of this work, or am I the only Solaris X86 > user out there :-) Last I heard it needed someone to test it on Solaris x86, but nobody ever did. So yes it seems you may be the only user out there... If you tested it and it works for you, please submit it to wine-patches. -- Alexandre Julliard julliard(a)winehq.com

Aug. 14, 2001

Re: Advice please. adding a MODULE_LoadLibraryExA argument

by Alexandre Julliard

"Bill Medland" <medbi01(a)accpac.com> writes: > The way I would prefer would be to add an argument to all the functions in > the recursion and use that to carry the name around. > MODULE_LoadLibraryExA > PE_LoadLibraryExA > ELF_LoadLibraryExA > PE_CreateModule > fixup_imports > > Any objections? This won't work for builtin dlls, you cannot pass an argument into dlopen(). This is not a problem for builtins themselves since they are not searched the same way, but it may break if a builtin imports a native dll. -- Alexandre Julliard julliard(a)winehq.com

Aug. 14, 2001

Re: SNOOP: How to find out if an DLL entry is a DATA reference?

by Alexandre Julliard

Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: > However I like to ask if there are other methods of distinguishing DATA and > function references? Could the PE loader perhaps know? Or can we perhaps > protect our snoop entries from being read as data and catch those exceptions? > Any other idea? I don't think there's any way to make snoop 100% reliable, the PE file simply doesn't contain enough information. This is the reason we have to build special tables in the builtin dlls for relay debugging. -- Alexandre Julliard julliard(a)winehq.com

Aug. 14, 2001

Advice please. adding a MODULE_LoadLibraryExA argument

by Bill Medland

I'd appreciate advice on this. I am looking at adding the handling of LoadLibraryExA (..LOAD_WITH_ALTERED_SEARCH_PATH) (which we use) and I am wondering about how to carry around the library directory during the recursion on MODULE_LoadLibraryExA. The easiest way is to put it in a static variable (ok, some allocated memory pointed to by a static variable) and depend upon the existing critical sections (which I don't understand particularly) to ensure it is only used by the currently loading tree of DLLS (i.e. set it up after the RtlAcquirePebLock in MODULE_LoadLibraryExA). However I dislike using static variables as a matter of principle. The way I would prefer would be to add an argument to all the functions in the recursion and use that to carry the name around. MODULE_LoadLibraryExA PE_LoadLibraryExA ELF_LoadLibraryExA PE_CreateModule fixup_imports Any objections? Bill

Aug. 14, 2001

Re: printing AND memory

by Richard Canada

Ian Pilcher wrote: > Richard Canada wrote: > >>Does anyone know why I am getting an error message about "Insufficient >>memory" when I try to print from wine? I can see the printer is there, >>but I cannot print. I am running Lotus Notes 5.0.6. Thanks >> >> > > Lotus Notes will display this message whenever the printer driver fails > to initialize -- for any reason. (OT, there's a user interface "Hall of > Shame" somewhere on the 'net with a whole section devoted to Notes!) > > Run it with '--debugmsg +psdrv', and see if you can spot why the driver > is failing. This can produce a lot of output, so you may want to > redirect stderr to a file: > > wine --debugmsg -all,+psdrv nlnotes 2> ~/wine.log > > or something like that. > > If you can't figure out what's going on, send me the file. > > BTW, what version of Wine are you running, and did this work for you > before? > > I did this and here is what it told me: trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for printer 'Wine PostScript Driver' trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) trace:psdrv:PSDRV_FindPrinterInfo 'Wine PostScript Driver' err:psdrv:PSDRV_FindPrinterInfo Error 2 getting PPD file name for printer 'Wine PostScript Driver' trace:psdrv:PSDRV_CreateDC (WINEPS Wine PostScript Driver LPT1: (nil)) fixme:pthread_kill_other_threads_np Any suggestions? Regards, Richard

Aug. 14, 2001

Solaris X86 mmap...

by Robert Lunnon

On Jan 10 2001 Ulrich Weigand submitted a patch to library/port.c to attempt to fix the linux mmap behaviour dependency for solaris systems. After that point I can't find any reference to this patch, it certainly hasn't made it into the CVS yet ? Does anyone know the outcome of this work, or am I the only Solaris X86 user out there :-)

Aug. 14, 2001

Re: SNOOP: How to find out if an DLL entry is a DATA reference?

by Dan Kegel

Uwe Bonnes wrote: > e.g. with the MFC libraries the snoop option crashes quite often, while > without snoop the programm proceeds some more. Digging deeper for the crash in > msdev.exe, I saw that a library has exported DATA entries mixed into the > codesegment. Our snoop loader only checks for DATA entries in the PE DATA > section and so happyly overwrites data. It seems that most exported DATA > entries have a decorated name ending in @A or @B and by handling entries with > that ending as DATA, the crash with msdev.exe happens at the same place with > or without snoop. > > Appended patch does this hacky search for DATA entries. > > However I like to ask if there are other methods of distinguishing DATA and > function references? Could the PE loader perhaps know? Or can we perhaps > protect our snoop entries from being read as data and catch those exceptions? > Any other idea? For what it's worth, I reverse-engineered and documented the name decoration scheme used by Microsoft in 1999. My doc is at http://www.kegel.com/mangle.html You should probably not check for the @, as that's not always there. (I think a global variable int g; might have a decorated name ?g(a)3HA but don't quote me on that.) The trailing A or B should be reliable. A trailing C indicates a const; maybe you should check for that, too (you'd know better than me). You may want to use presence of a '?' to detect a mangled name, tho. e.g. if ((name[0] == '?') && ((name[len-1] == 'A') || (name[len-1] == 'B'))) (I have no idea if that's right, it's been two years since I touched this.) - Dan -- "I have seen the future, and it licks itself clean." -- Bucky Katt

Aug. 14, 2001

SNOOP: How to find out if an DLL entry is a DATA reference?

by Uwe Bonnes

Hallo, e.g. with the MFC libraries the snoop option crashes quite often, while without snoop the programm proceeds some more. Digging deeper for the crash in msdev.exe, I saw that a library has exported DATA entries mixed into the codesegment. Our snoop loader only checks for DATA entries in the PE DATA section and so happyly overwrites data. It seems that most exported DATA entries have a decorated name ending in @A or @B and by handling entries with that ending as DATA, the crash with msdev.exe happens at the same place with or without snoop. Appended patch does this hacky search for DATA entries. However I like to ask if there are other methods of distinguishing DATA and function references? Could the PE loader perhaps know? Or can we perhaps protect our snoop entries from being read as data and catch those exceptions? Any other idea? Bye Changelog: relay32/snoop.c: SNOOP_GetProcAddress Don't snoop on names ending in "@A" and "@B", they seem to be DATA entries. Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Free Software: If you contribute nothing, expect nothing -- Index: wine/relay32/snoop.c =================================================================== RCS file: /home/wine/wine/relay32/snoop.c,v retrieving revision 1.45 diff -u -r1.45 snoop.c --- wine/relay32/snoop.c 24 Jul 2001 21:45:24 -0000 1.45 +++ wine/relay32/snoop.c 13 Aug 2001 19:51:42 -0000 @@ -158,7 +158,7 @@ SNOOP_GetProcAddress(HMODULE hmod,LPCSTR name,DWORD ordinal,FARPROC origfun) { SNOOP_DLL *dll = firstdll; SNOOP_FUN *fun; - int j; + int j,len; IMAGE_SECTION_HEADER *pe_seg = PE_SECTIONS(hmod); if (!TRACE_ON(snoop)) return origfun; @@ -182,7 +182,14 @@ !(pe_seg[j].Characteristics & IMAGE_SCN_CNT_CODE) ) return origfun; - + /* some heuristic to filter out DATA objects + decorated names end like "@A" and "@B" and some more */ + len=strlen(name); + if ((name [len-2] == '@') && ((name[len-1] == 'A') || (name[len-1] == 'B'))) + { + return origfun; + } + while (dll) { if (hmod == dll->hmod) break;

Aug. 13, 2001

IShellLinkA_fnSetIconLocation problem with Kid Pix 3?

by Dan Kegel

Kid Pix 3 doesn't install with Wine from cvs (with either August 6th's or today's cvs). The problem appears to be related to shortcut or icon creation, as the installer bombs with alert "Cannot create shortcuts." right after checking for the existence of "Picker.ico". Here is what seems to be the interesting 250-line section of the log, starting with the fnSetIconLocation and ending with the "Cannot create shortcuts". There is an iffy looking line near the bottom I've marked with !!!!!!!!!!!!!. I'd be grateful for any suggestions. Thanks, Dan trace:shell:IShellLinkA_fnSetIconLocation (0x418884bc)->(path=C:\Program Files\Broderbund\Kid Pix Deluxe 3\Picker.ico iicon=0) trace:shell:IShellLinkA_fnQueryInterface (0x418884bc)->( IID: {0000010b-0000-0000-c000-000000000046}) trace:shell:IPersistFile_fnAddRef (0x418884bc)->(count=1) trace:shell:IShellLinkA_fnAddRef (0x418884bc)->(count=1) trace:shell:IShellLinkA_fnQueryInterface -- Interface: (0x405d53fc)->(0x418884c8) 08077c28:Call kernel32.MultiByteToWideChar(00000000,00000000,405d51dc "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk",ffffffff,405d4dc0,00000104) ret=100394e7 08077c28:Ret kernel32.MultiByteToWideChar() retval=00000034 ret=100394e7 trace:shell:IPersistFile_fnSave (0x418884bc)->(L"C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk") 08077c28:Call advapi32.RegOpenKeyExA(80000002,40879140 "Software\\Wine\\Wine\\Config\\Wine",00000000,000f003f,405d490c) ret=408563c4 08077c28:Call ntdll.RtlInitAnsiString(405d47dc,40879140 "Software\\Wine\\Wine\\Config\\Wine") ret=407afaa4 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407afaa4 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d47dc,00000000) ret=407afaad 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407afaad 08077c28:Call ntdll.NtOpenKey(405d490c,000f003f,405d47e4) ret=407afac0 trace:reg:NtOpenKey (0x80000002,L"Software\\Wine\\Wine\\Config\\Wine",f003f,0x405d490c) trace:reg:NtOpenKey <- 0x0034 08077c28:Ret ntdll.NtOpenKey() retval=00000000 ret=407afac0 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407afac6 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407afac6 08077c28:Ret advapi32.RegOpenKeyExA() retval=00000000 ret=408563c4 08077c28:Call advapi32.RegQueryValueExA(00000034,4087915f "ShellLinker",00000000,405d4904,405d4c90,405d4908) ret=408563fb trace:reg:RegQueryValueExA (0x34,"ShellLinker",(nil),0x405d4904,0x405d4c90,0x405d4908=260) 08077c28:Call ntdll.RtlInitAnsiString(405d46f4,4087915f "ShellLinker") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d46f4,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d46fc,00000100,405d46f0) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"ShellLinker",2,0x405d46fc,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=00000000 ret=407b0cc4 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4708 L"wineshelllink",0000000e,00000000,00000000,00000000,00000000) ret=407b0ddc 08077c28:Ret kernel32.WideCharToMultiByte() retval=0000000e ret=407b0ddc 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4708 L"wineshelllink",0000000e,405d4c90,0000000e,00000000,00000000) ret=407b0e1b 08077c28:Ret kernel32.WideCharToMultiByte() retval=0000000e ret=407b0e1b 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000000 ret=408563fb 08077c28:Call advapi32.RegCloseKey(00000034) ret=40856411 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=40856411 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4dc0 L"C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk",ffffffff,405d4c90,00000104,00000000,00000000) ret=40856482 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000034 ret=40856482 08077c28:Call kernel32.GetFullPathNameA(405d4c90 "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk",00000104,405d4b80,00000000) ret=408564b0 trace:string:lstrcpynA (0x405d43dc, "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk", 1024) trace:string:lstrcpynA (0x405d4b80, "C:\\Windows\\Desktop\\Shortcut to Kid Pix Deluxe 3.lnk", 260) 08077c28:Ret kernel32.GetFullPathNameA() retval=00000033 ret=408564b0 trace:shell:SHGetSpecialFolderPathA 0x0000,0x405d4c90,csidl=7,0x0000 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d37e 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d37e 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "StartUp",00000000,405d4560,405d4c90,405d4564) ret=4085d3aa trace:reg:RegQueryValueExA (0x34,"StartUp",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "StartUp") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"StartUp",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=c0000034 ret=407b0cc4 08077c28:Call ntdll.RtlNtStatusToDosError(c0000034) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000002 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000002 ret=4085d3aa 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d3bd 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d3bd 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d3e8 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d3e8 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "StartUp",00000000,405d4560,405d4c90,405d4564) ret=4085d408 trace:reg:RegQueryValueExA (0x34,"StartUp",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "StartUp") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"StartUp",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=00000000 ret=407b0cc4 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Start Menu\\Programs\\Startup",00000027,00000000,00000000,00000000,00000000) ret=407b0ddc 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000027 ret=407b0ddc 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Start Menu\\Programs\\Startup",00000027,405d4c90,00000027,00000000,00000000) ret=407b0e1b 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000027 ret=407b0e1b 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000000 ret=4085d408 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d579 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d579 08077c28:Call shlwapi.PathFileExistsA(405d4c90 "C:\\WINDOWS\\Start Menu\\Programs\\Startup") ret=4085d7d6 trace:shell:PathFileExistsA C:\WINDOWS\Start Menu\Programs\Startup 08077c28:Call kernel32.GetFileAttributesA(405d4c90 "C:\\WINDOWS\\Start Menu\\Programs\\Startup") ret=408fd447 trace:string:lstrcpynA (0x405d3bfc, "/home/dank/.wine/fake_windows", 1024) 08077c28:Ret kernel32.GetFileAttributesA() retval=00000010 ret=408fd447 08077c28:Ret shlwapi.PathFileExistsA() retval=00000001 ret=4085d7d6 trace:shell:SHGetSpecialFolderPathA 0x0000,0x405d4c90,csidl=16,0x0000 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d37e 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bb20 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\User Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d37e 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "Desktop",00000000,405d4560,405d4c90,405d4564) ret=4085d3aa trace:reg:RegQueryValueExA (0x34,"Desktop",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "Desktop") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"Desktop",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=c0000034 ret=407b0cc4 08077c28:Call ntdll.RtlNtStatusToDosError(c0000034) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000002 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000002 ret=4085d3aa 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d3bd 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d3bd 08077c28:Call advapi32.RegCreateKeyExA(80000001,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",00000000,00000000,00000000,000f003f,00000000,405d4568,405d456c) ret=4085d3e8 08077c28:Call ntdll.RtlInitAnsiString(405d443c,4087bac0 "Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders") ret=407af91e 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407af91e 08077c28:Call ntdll.RtlInitAnsiString(405d4434,00000000) ret=407af92d 08077c28:Ret ntdll.RtlInitAnsiString() retval=400bf8ac ret=407af92d 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d443c,00000000) ret=407af936 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af936 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(405d442c,405d4434,00000001) ret=407af94a 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407af94a 08077c28:Call ntdll.NtCreateKey(405d4568,000f003f,405d4444,00000000,405d442c,00000000,405d456c) ret=407af968 trace:reg:NtCreateKey (0x80000001,L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Shell Folders",L"",0,f003f,0x405d4568) trace:reg:NtCreateKey <- 0x0034 08077c28:Ret ntdll.NtCreateKey() retval=00000000 ret=407af968 08077c28:Call ntdll.RtlFreeUnicodeString(405d442c) ret=407af970 08077c28:Ret ntdll.RtlFreeUnicodeString() retval=00000001 ret=407af970 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407af976 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407af976 08077c28:Ret advapi32.RegCreateKeyExA() retval=00000000 ret=4085d3e8 08077c28:Call advapi32.RegQueryValueExA(00000034,405d4790 "Desktop",00000000,405d4560,405d4c90,405d4564) ret=4085d408 trace:reg:RegQueryValueExA (0x34,"Desktop",(nil),0x405d4560,0x405d4c90,0x405d4564=260) 08077c28:Call ntdll.RtlInitAnsiString(405d4374,405d4790 "Desktop") ret=407b0c79 08077c28:Ret ntdll.RtlInitAnsiString() retval=00000000 ret=407b0c79 08077c28:Call ntdll.RtlAnsiStringToUnicodeString(4010bbf8,405d4374,00000000) ret=407b0c8e 08077c28:Ret ntdll.RtlAnsiStringToUnicodeString() retval=00000000 ret=407b0c8e 08077c28:Call ntdll.NtQueryValueKey(00000034,4010bbf8,00000002,405d437c,00000100,405d4370) ret=407b0cc4 trace:reg:NtQueryValueKey (0x34,L"Desktop",2,0x405d437c,256) 08077c28:Ret ntdll.NtQueryValueKey() retval=00000000 ret=407b0cc4 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Desktop",00000013,00000000,00000000,00000000,00000000) ret=407b0ddc 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000013 ret=407b0ddc 08077c28:Call kernel32.WideCharToMultiByte(00000000,00000000,405d4388 L"C:\\WINDOWS\\Desktop",00000013,405d4c90,00000013,00000000,00000000) ret=407b0e1b 08077c28:Ret kernel32.WideCharToMultiByte() retval=00000013 ret=407b0e1b 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b0ed2 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b0ed2 08077c28:Ret advapi32.RegQueryValueExA() retval=00000000 ret=4085d408 08077c28:Call advapi32.RegCloseKey(00000034) ret=4085d579 08077c28:Call ntdll.NtClose(00000034) ret=407b04e2 08077c28:Ret ntdll.NtClose() retval=00000000 ret=407b04e2 08077c28:Call ntdll.RtlNtStatusToDosError(00000000) ret=407b04e8 08077c28:Ret ntdll.RtlNtStatusToDosError() retval=00000000 ret=407b04e8 08077c28:Ret advapi32.RegCloseKey() retval=00000000 ret=4085d579 08077c28:Call shlwapi.PathFileExistsA(405d4c90 "C:\\WINDOWS\\Desktop") ret=4085d7d6 trace:shell:PathFileExistsA C:\WINDOWS\Desktop 08077c28:Call kernel32.GetFileAttributesA(405d4c90 "C:\\WINDOWS\\Desktop") ret=408fd447 trace:string:lstrcpynA (0x405d3bfc, "/home/dank/.wine/fake_windows", 1024) 08077c28:Ret kernel32.GetFileAttributesA() retval=00000010 ret=408fd447 08077c28:Ret shlwapi.PathFileExistsA() retval=00000001 ret=4085d7d6 08077c28:Call kernel32.wine_get_unix_file_name(4187b708 "C:\\Program Files\\Broderbund\\Kid Pix Deluxe 3\\KPRUN.EXE",405d4a70,00000104) ret=4085669d trace:string:lstrcpynA (0x405d4004, "/home/dank/.wine/fake_windows", 1024) trace:string:lstrcpynA (0x405d4a70, "/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3/KPRUN.EXE", 260) 08077c28:Ret kernel32.wine_get_unix_file_name() retval=00000001 ret=4085669d 08077c28:Call kernel32.wine_get_unix_file_name(41888530 "C:\\Program Files\\Broderbund\\Kid Pix Deluxe 3",405d4960,00000104) ret=4085671c trace:string:lstrcpynA (0x405d4004, "/home/dank/.wine/fake_windows", 1024) trace:string:lstrcpynA (0x405d4960, "/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3", 260) 08077c28:Ret kernel32.wine_get_unix_file_name() retval=00000001 ret=4085671c 08077c28:Call kernel32.LoadLibraryExA(4188856c "C:\\Program Files\\Broderbund\\Kid Pix Deluxe 3\\Picker.ico",00000000,00000002) ret=40855d46 trace:string:lstrcpynA (0x405d3e70, "/home/dank/.wine/fake_windows", 1024) warn:dosfs:DOSFS_FindUnixName 'Picker.ico' not found in '/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3' trace:string:lstrcpynA (0x405d3e2c, "/home/dank/.wine/fake_windows", 1024) warn:dosfs:DOSFS_FindUnixName 'Picker.ico' not found in '/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3' trace:string:lstrcpynA (0x418886ec, "C:\\WINDOWS\\SYSTEM", 260) !!!!!!!!!!!!!!!!!!!! why is it trying to load C:\WINDOWS\SYSTEM?! !!!!!!!!!!!!!!!!! warn:module:MODULE_LoadLibraryExA Failed to load module 'C:\WINDOWS\SYSTEM'; error=0x00000002, 08077c28:Ret kernel32.LoadLibraryExA() retval=00000000 ret=40855d46 trace:shell:ExtractFromEXEDLL LoadLibraryExA (C:\Program Files\Broderbund\Kid Pix Deluxe 3\Picker.ico) failed, error 2 trace:shell:IPersistFile_fnSave linker app='wineshelllink' link='Shortcut to Kid Pix Deluxe 3' mode=desktop path='/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3/KPRUN.EXE' args=' Main' icon='/tmp/fileUlFDEJ' workdir='/home/dank/.wine/fake_windows/Program Files/Broderbund/Kid Pix Deluxe 3' descr='' fixme:pthread_kill_other_threads_np trace:shell:IPersistFile_fnRelease (0x418884bc)->(count=2) trace:shell:IShellLinkA_fnRelease (0x418884bc)->(count=2) trace:shell:IShellLinkA_fnRelease (0x418884bc)->(count=1) trace:shell:IShellLinkA_fnRelease -- destroying IShellLink(0x418884bc) 08077c28:Call ole32.CoUninitialize() ret=10039541 08077c28:Call kernel32.FreeLibrary(40845000) ret=408b00fc 08077c28:Ret kernel32.FreeLibrary() retval=00000001 ret=408b00fc 08077c28:Ret ole32.CoUninitialize() retval=00000000 ret=10039541 08077c28:Call window proc 0x416979 (hwnd=000001c0,msg=WM_USER+000c,wp=00000000,lp=00000000) 08077c28:Ret window proc 0x416979 (hwnd=000001c0,msg=WM_USER+000c,wp=00000000,lp=00000000) retval=00000000 08077c28:Call kernel32.lstrlenA(0048636c "") ret=00417ef4 08077c28:Ret kernel32.lstrlenA() retval=00000000 ret=00417ef4 08077c28:Call kernel32.lstrcpyA(4185a0e7,0048636c "") ret=0041801e 08077c28:Ret kernel32.lstrcpyA() retval=4185a0e7 ret=0041801e 08077c28:Call kernel32.lstrcpyA(405d6144,40491e32 "MESSAGE_CANNOT_CREATE_ICONS") ret=0041832a 08077c28:Ret kernel32.lstrcpyA() retval=405d6144 ret=0041832a 08077c28:Call kernel32.lstrlenA(4043bcec "Cannot create shortcuts.") ret=0045714a -- "I have seen the future, and it licks itself clean." -- Bucky Katt

Aug. 13, 2001

Re: Unable to use RegisterClass(&WndClass);

by Dmitry Timoshkov

Hello all. According to MSDN all classes in Win32 are local. My experiments under Win2000 show that user32 always turns off CS_GLOBALCLASS (actually even "system" classes doesn't have it set) and does fix hInstance to the module handle. The attached patch tries to do the same in Wine. Comments, suggestions? -- Dmitry.

Aug. 12, 2001

Re: Question about network stuff

by Bobby Bingham

I'm not sure of the answer to your problem (could you be a little more specific than "it basically told me it couldn't access the network.) This isn't the right list for this question. This list is for patches that have been submitted to WINE. You might try the wine-users mailing list, or, if you're really daring, the wine-devel list if no one on wine-users knows Bobby Bingham Microsoft Windows: Made for the internet The Internet: Made for UNIX On Sunday 12 August 2001 02:02 am, you wrote: > Hi there > > (am I even on the right list??) > > I've been trying to get some Internet playable games to work with Wine, > namely everquest. > > I started out by making the mistake of running wine from my home dir (like > wine /win/d/everquest/everquest.exe) and having it download the whole game > from the 'net to my home dir.. I stopped that in a hurry :-) > > When I moved to /win/d/everquest, and tried to do wine ./everquest, it > basically told me it couldn't access the network. > > Why? How do I fix this? > > Thanks a ton, > > Tim

Aug. 12, 2001

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Alexandre Julliard

Patrik Stridvall <ps(a)leissner.se> writes: > So to the details of the marshalling API (the unmarshalling API can wait). > 1. Where should we put them? Suggestion: include/wine/messsage.h No, it should be private to the dlls that really need it. We shouldn't add a global Wine-specific interface, we already have too many of that. And please don't go around converting all SendMessage calls to some marshalling API; this should be reserved to the cases where there is really a need. This is why I suggested to add the inline function in the C file directly: if there is a file where there are a lot of WM_COMMANDs with ugly casts, you can add an inline function there. But if there is only one or two, or calls that don't need ugly typecasts (most of them don't), then you definitely don't want to use the inline, just do a normal SendMessage. -- Alexandre Julliard julliard(a)winehq.com

Aug. 11, 2001

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Patrik Stridvall

> Patrik Stridvall <ps(a)leissner.se> writes: > > > We can just do it like: > > #ifdef __GNUC__ > > extern inline void FORWARD_WM_COMMAND(HWND hwnd, int id, > HWND hwndCtl, UINT > > codeNotify, WNDPROC fn) > > { > > fn(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM) hwnd); > > } > > #else > > #define FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, fn) \ > > (void)(fn)((hwnd), WM_COMMAND, > > MAKEWPARAM((UINT)(id),(UINT)(codeNotify)), (LPARAM)(HWND)(hwndCtl)) > > #endif > > > > if you wish. And if you are worried about preprocessor abusing > > Winelib application we could do #if defined(__GNUC__) && > defined(__WINE__) > > instead or use some kind of macro wrap around protection of the > > kind that I proposed that you didn't like. > > If you want to wrap WM_COMMAND, do something like: > > inline void send_wm_command(HWND hwnd, int id, HWND hwndCtl, > UINT codeNotify) > { > SendMessageW(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), > (LPARAM)hwndCtl); > } > > This is a normal function, doing a normal SendMessage call, and it's > perfectly all right with me. And if you want to do a PostMessage then > write a separate post_wm_command() function. Of course this is not a > standard Windows API so you cannot put it in the standard header > files; but you can have it in some dll private headers, or even > directly in the C files that need it. Ironically that was approximately my original idea. But I didn't think you would accept it so I didn't bother investigating further. Then I realized that the windowsx.h macros did what I wanted so choosed that solution instead. But sure we have a marshalling/unmarshalling API of our own, if that is what you want. Unless of course you prefer the hack below for PostMessage (not likely :-). So to the details of the marshalling API (the unmarshalling API can wait). 1. Where should we put them? Suggestion: include/wine/messsage.h 2. What should we call them? Suggestion: {POST,SEND}_WM_COMMAND etc. We really should capitalize the message name because of people doing "grep WM_COMMAND". And not capitalizing the POST/SEND would look silly if the suffix is capitalized. Sure they look like macros but then they could easily be made to be as an alterative implemention like #define SEND_WM_COMMAND(hwnd, id, hwndCtl, codeNotify) \ FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, SendMessage) 3. Do you want the macro wrapper (against the FORWARD API) above for the non GNU C case? 4. Should have have {POST,SEND}_WM_COMMAND{A,W} for calling {Post,Send}Message{A,W} or should we always the W variant like in your example above. > > To sum it up: > > 1. The FORWARD_* API and the HANDLE_* API really are normal > functions not > > macros (preprocessor abuses). The fact Micrsoft > implemented them as macros > > because of lack of compiler support for inline functions > or because of > > incompetence is irrelevant, we can do it right in a 100% > compatible way. > > No we can't; SendMessage and PostMessage don't have the same > prototype, so the preprocessor abuse is necessary to avoid > warnings. It seems you are right. PostMessage returns BOOL. Anyway there are not so many PostMessage calls that can be converted. $ find . -name \*.c | xargs grep PostMessage | grep WM_ | wc -l 35 The type compatible ones on the other hand are $ find . -name \*.c | xargs egrep 'Def.*Proc' | grep WM_ | wc -l 33 $ find . -name \*.c | xargs grep SendMessage | grep WM_ | wc -l 420 The Def.*Proc ones doesn't seem of closer examination to require marshalling of parameters so let skip them. Total 420 compared to 35. So we either decide not to use the the FORWARD_ API for such cases or we do: BOOL bResult = (BOOL) FORWARD_WM_COMMAND(/* ... */, (WNDPROC) PostMessageW); The use above is type correct regardless of whether FORWARD_WM_COMMAND is a macro or a inline function. A little ugly yes, but then it isn't nessary to convert the few PostMessage that exists to the FORWARD_* API at all.

Aug. 11, 2001

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Alexandre Julliard

Patrik Stridvall <ps(a)leissner.se> writes: > We can just do it like: > #ifdef __GNUC__ > extern inline void FORWARD_WM_COMMAND(HWND hwnd, int id, HWND hwndCtl, UINT > codeNotify, WNDPROC fn) > { > fn(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM) hwnd); > } > #else > #define FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, fn) \ > (void)(fn)((hwnd), WM_COMMAND, > MAKEWPARAM((UINT)(id),(UINT)(codeNotify)), (LPARAM)(HWND)(hwndCtl)) > #endif > > if you wish. And if you are worried about preprocessor abusing > Winelib application we could do #if defined(__GNUC__) && defined(__WINE__) > instead or use some kind of macro wrap around protection of the > kind that I proposed that you didn't like. If you want to wrap WM_COMMAND, do something like: inline void send_wm_command(HWND hwnd, int id, HWND hwndCtl, UINT codeNotify) { SendMessageW(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM)hwndCtl); } This is a normal function, doing a normal SendMessage call, and it's perfectly all right with me. And if you want to do a PostMessage then write a separate post_wm_command() function. Of course this is not a standard Windows API so you cannot put it in the standard header files; but you can have it in some dll private headers, or even directly in the C files that need it. > To sum it up: > 1. The FORWARD_* API and the HANDLE_* API really are normal functions not > macros (preprocessor abuses). The fact Micrsoft implemented them as macros > because of lack of compiler support for inline functions or because of > incompetence is irrelevant, we can do it right in a 100% compatible way. No we can't; SendMessage and PostMessage don't have the same prototype, so the preprocessor abuse is necessary to avoid warnings. -- Alexandre Julliard julliard(a)winehq.com

Aug. 11, 2001

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Patrik Stridvall

> Patrik Stridvall <ps(a)leissner.se> writes: > > > Microsoft introduced the windowsx.h macros for a reason and > > while without inline functions the current implementation > > of the FORWARD_* macros was the best they could do, it > > was at least better than nothing since it at least handled > > the parameter marshalling even if it wasn't 100% type safe. > > I wouldn't rely on Microsoft choices to judge an API design ;-) Point taken. :-) However not everything Microsoft does is bad, eventhough I admit that being sceptical is a good start. > > Another things to think about: > > What is the difference between calling {Set,Get}WindowText > > functions and calling the FORWARD_WM_{GET,SET}TEXT macros? > > It's a matter of taste. Calling a normal function is perfectly all > right; But they are normal functions. It is just not that apparent that they really are. Whether this is by design or by accident I leave unsaid. :-) Anyway, see below. > but I find that using a macro (or worse an inline function > masquerading as a macro) and having to pass it the name of the > function you want to call is ugly and offensive. If you want to call > SendMessage, then call SendMessage, don't hide it inside a macro. It is not hidden in the macro. Which function to call is provided as the last parameter of the macro. > Just because you can do all kinds of abuses of the preprocessor in C > doesn't mean you should. Well actually, the so called abuses of the preprocesor was for 100% compabillity with Winelib applications, if they abuse the fact that FORWARD_* might not always be macros (like doing undef on them). It is possible do it cleaner that the crude example I provide as well. Anyway, with the exception of preprocessor abusing application, which Wine easily can be made not to be. We can just do it like: #ifdef __GNUC__ extern inline void FORWARD_WM_COMMAND(HWND hwnd, int id, HWND hwndCtl, UINT codeNotify, WNDPROC fn) { fn(hwnd, WM_COMMAND, MAKEWPARAM(id, codeNotify), (LPARAM) hwnd); } #else #define FORWARD_WM_COMMAND(hwnd, id, hwndCtl, codeNotify, fn) \ (void)(fn)((hwnd), WM_COMMAND, MAKEWPARAM((UINT)(id),(UINT)(codeNotify)), (LPARAM)(HWND)(hwndCtl)) #endif if you wish. And if you are worried about preprocessor abusing Winelib application we could do #if defined(__GNUC__) && defined(__WINE__) instead or use some kind of macro wrap around protection of the kind that I proposed that you didn't like. Note that the above inline function "abuses" that fact that C autocasts between functions and pointer to functions, but then it standard well documented and often used "abuse", so calling it an abuse isn't really fair (not that you did since my example contained an unnessary &)). To sum it up: 1. The FORWARD_* API and the HANDLE_* API really are normal functions not macros (preprocessor abuses). The fact Micrsoft implemented them as macros because of lack of compiler support for inline functions or because of incompetence is irrelevant, we can do it right in a 100% compatible way. 2. The FORWARD_* API provides marshalling of parameters and the HANDLE_* API provides unmarshalling of parameters. 3. The FORWARD_* API provides type safe sending of parameters and the HANDLE_* API provides type safe recieving of parameters. Note that the fact that marshalling and unmarshalling of parameters are hidden makes that code much more readable and yes, I say it again, the FORWARD_* API and HANDLE_* API really are normal functions, there is no hidden traps for the unwary user. Just a nice wrapper for type safe marshalling and unmarshalling of parameters. PS. We could easily rewrite the HANDLE_* API as inline functions as well, I don't think it gives us anything though. They are good as they are AFAICS. But if you don't like macros, sure I can rewrite them as inline functions well. It just a lot of work to no gain AFAICS. It wouldn't hurt either though.

Aug. 11, 2001

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Alexandre Julliard

Patrik Stridvall <ps(a)leissner.se> writes: > Microsoft introduced the windowsx.h macros for a reason and > while without inline functions the current implementation > of the FORWARD_* macros was the best they could do, it > was at least better than nothing since it at least handled > the parameter marshalling even if it wasn't 100% type safe. I wouldn't rely on Microsoft choices to judge an API design ;-) > Another things to think about: > What is the difference between calling {Set,Get}WindowText > functions and calling the FORWARD_WM_{GET,SET}TEXT macros? It's a matter of taste. Calling a normal function is perfectly all right; but I find that using a macro (or worse an inline function masquerading as a macro) and having to pass it the name of the function you want to call is ugly and offensive. If you want to call SendMessage, then call SendMessage, don't hide it inside a macro. Just because you can do all kinds of abuses of the preprocessor in C doesn't mean you should. -- Alexandre Julliard julliard(a)winehq.com

Aug. 10, 2001

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Patrik Stridvall

> Patrik Stridvall <ps(a)leissner.se> writes: > > > This will give us all the advantages of the "macros" > without any typecasts > > that could > > possibly hide a type error. > > > > What do you say? > > I don't like it. I think windowsx.h should not be used at all in Wine; > it only obfuscates things by making it harder to see what's really > going on. Obfuscates what? The only thing the "macros" do is that it hides the way the parameters are marshalled. That is totally unintresting for almost all Wine developers. Like the Win16/Win32 thunking code you don't have to know how it works, you just call the appropriate functions. The same with the stdcall calling convention most API functions use. You add WINAPI before the function and you don't care how it works. It is the somebody else problem and you trust that they know what they are doing. So please explain what the use of FORWARD_* macros obfuscates for I really can't see it. AFAICS it is much better to use the FORWARD_ macros (especially with my hack to make them truely type safe). They are just a function like any other. Why look up how the parameters are marshalled when you can call a function FORWARD_* that not only does it, but does it in a type safe way. If you call the function with the wrong parameters you are very likely to get type errors. If you marshall the parameters in the wrong way it is almost 100% certain that the compiler will say nothing. Microsoft introduced the windowsx.h macros for a reason and while without inline functions the current implementation of the FORWARD_* macros was the best they could do, it was at least better than nothing since it at least handled the parameter marshalling even if it wasn't 100% type safe. Another things to think about: What is the difference between calling {Set,Get}WindowText functions and calling the FORWARD_WM_{GET,SET}TEXT macros? Answer: No difference at all except that you can easily do a PostMessage instead of a SendMessage if you wish. Of course I'm not suggesting that we should call the FORWARD_WM_{GET,SET}TEXT instead of {Set,Get}WindowText, but in most cases no appropriate functions exists and FORWARD_* macros will at least do the marshalling of parameters and if we implement my version of them also type safe. > Besides, the FORWARD_* macros are not really meant to be > used to send messages, they are meant to help receiving messages, so I > don't think we should abuse them that way. No, that is what the HANDLE_* macros are for. The FORWARD_* macros are for sending (or forwarding) messages. Speaking of which the HANDLE_* macros could find uses in COMCTL32 and other similar DLL:s to provide a type safe receiving of messages. I don't even think we will have to do as a proposed for the FORWARD_* to make them truely type safe.

Aug. 10, 2001

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Alexandre Julliard

Patrik Stridvall <ps(a)leissner.se> writes: > This will give us all the advantages of the "macros" without any typecasts > that could > possibly hide a type error. > > What do you say? I don't like it. I think windowsx.h should not be used at all in Wine; it only obfuscates things by making it harder to see what's really going on. Besides, the FORWARD_* macros are not really meant to be used to send messages, they are meant to help receiving messages, so I don't think we should abuse them that way. -- Alexandre Julliard julliard(a)winehq.com

Aug. 10, 2001

RE: RFC: Should we use the macros in windowsx.h to fix -DSTRICT w arni ngs?

by Patrik Stridvall

> Patrik Stridvall <ps(a)leissner.se> writes: > > > So the question is: > > Should we use the FORWARD_WM_* macros to avoid typecasts > > (or rather avoid visable typecast) or should we not? > > If not how should we fix the problems? > > I think it's better to avoid that. Hiding the typecasts in the macros > doesn't really make things cleaner IMO. This is a case where the API > design forces us to use a typecast, so we might as well make it > explicit. True, but be aware of the macros often use a double type cast like (LPARAM)(HWND). I'm not sure this is really helpful, since I guess it will reveal but a few type error if any at all. Also note that the macros also takes care of MAKEWPARAM and MAKELPARAM stuff so it makes the code a little more readable. Anyway, never mind. We could be a little more clever than the macros permit that if we like. See below. > Note that for the specific case of WM_GET/SETTEXT, it would be much > better to use Get/SetWindowText which will do correct type checks. True. They was just an example. They are a few more with similar problems but they are few (less than 10 IIRC). I guess we can worry about them later. > But > for messages that don't have a corresponding function we have to do > the typecast. As the macros work now, yes. But we could extend the "macros" to be a little more clever than that. Take for example one of the more advanced macros #define FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ (void)(fn)((hwnd), (fDoubleClick) ? WM_LBUTTONDBLCLK : WM_LBUTTONDOWN, (WPARAM)(UINT)(keyFlags), MAKELPARAM((x), (y))) We could quite easily write it like: #define _FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ (void)(fn)((hwnd), (fDoubleClick) ? WM_LBUTTONDBLCLK : WM_LBUTTONDOWN, (WPARAM)(UINT)(keyFlags), MAKELPARAM((x), (y))) #if defined(__WINE__) && defined(__GNUC__) extern inline void _WINE_FORWARD_WM_LBUTTONDOWN(HWND hwnd, BOOL fDoubleClick, int x, int y, UINT keyFlags, WNDPROC *fn) { /* return */ _FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, *fn); } #define FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ _WINE_FORWARD_WM_LBUTTONDOWN((hwnd), (fDoubleClick), (x), (y), (keyFlags), &(fn)) #else #define FORWARD_WM_LBUTTONDOWN(hwnd, fDoubleClick, x, y, keyFlags, fn) \ _FORWARD_WM_LBUTTONDOWN((hwnd), (fDoubleClick), (x), (y), (keyFlags), (fn)) #endif Or something like that. I'm not even sure the __WINE__ is needed. I not sure that any Winelib application could possibly misuse the macros in such a way that the result is not semantically the same (type warnings/errors excluded of course). Note that it is quite easy to write script that automatically does this to avoid subtle bugs especially since the correct (almost) prototype is already before each macro. Like in the case above: /* void Cls_OnLButtonDown(HWND hwnd, BOOL fDoubleClick, int x, int y, UINT keyFlags) */ This will give us all the advantages of the "macros" without any typecasts that could possibly hide a type error. What do you say? Note that we don't have to implement the solution above right now either. Using the macros as they are will not gain us very much (except possible a cleaner looking code), true. However when we implement the type safe "macros" as described above we will immediately find any and all type errors concerning such code. Anway fixing windowsx.h to look like above will not be very difficult either so there is no real reason to wait is it? PS. As hinted above this will also work with most (all?) Winelib applications that happends to use the windowsx.h macros and enable the finding of subtle type errors in such applications.

Aug. 10, 2001

Re: RFC: Should we use the macros in windowsx.h to fix -DSTRICT warni ngs?

by Alexandre Julliard

Patrik Stridvall <ps(a)leissner.se> writes: > So the question is: > Should we use the FORWARD_WM_* macros to avoid typecasts > (or rather avoid visable typecast) or should we not? > If not how should we fix the problems? I think it's better to avoid that. Hiding the typecasts in the macros doesn't really make things cleaner IMO. This is a case where the API design forces us to use a typecast, so we might as well make it explicit. Note that for the specific case of WM_GET/SETTEXT, it would be much better to use Get/SetWindowText which will do correct type checks. But for messages that don't have a corresponding function we have to do the typecast. -- Alexandre Julliard julliard(a)winehq.com

Aug. 10, 2001

RFC: Should we use the macros in windowsx.h to fix -DSTRICT warni ngs?

by Patrik Stridvall

This is not primarily a patch it is a RFC. I have experimented a bit with fixing the strict warnings. I have a few patch that I haven't submitted yet partly because I'm not 100% sure how all warnings should be fixed. Anyway, one large class of warnings is the ones cause by the window messaging functions. Like the one below: SendMessageW(lphc->hWndEdit, WM_SETTEXT, 0, (LPARAM)empty_stringW); This one unlike others this one does cause any warning with -DSTRICT because of the ugly cast, but the principle is the same. The only good way to fix this kind of problems that I can see is to use the FORWARD_WM_* macros in include/windowsx.h to write it like: FORWARD_WM_SETTEXT(lphc->hWndEdit, empty_stringW, SendMessageW); This works fine because the FORWARD_WM_SETTEXT macro look like this: #define FORWARD_WM_SETTEXT(hwnd, lpszText, fn) \ (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCTSTR)(lpszText)) Actually I lied this special case will not work fine since FORWARD_WM_SETTEXT uses TCHAR and friends. But that is not so important for the general principle. See below. Anyway, in some meaning the macros only hides the casts, but can casts really be avoided? We must cast to {W,L}PARAM at some time mustn't we? And the macros in windowsx.h is not that bad they cast to the correct type before the cast to {W,L}PARAM. This might help to find some bugs. Perhaps rewriting to macros as inline functions might help to? So the question is: Should we use the FORWARD_WM_* macros to avoid typecasts (or rather avoid visable typecast) or should we not? If not how should we fix the problems? And if we decide to use them, is patches like the one below to include/windowsx.h that fixes the TCHAR and friend problem acceptable or should we solve such problems in another way? PS. Alexandre: Feel free to apply the patch below if you agree. ---8<--- * include/windowsx.h: Include files used internally by Wine can't use the types TCHAR and friends. ---8<--- Index: wine/include/windowsx.h =================================================================== RCS file: /home/wine/wine/include/windowsx.h,v retrieving revision 1.7 diff -u -u -r1.7 windowsx.h --- wine/include/windowsx.h 2001/01/10 22:42:35 1.7 +++ wine/include/windowsx.h 2001/08/10 12:43:18 @@ -714,17 +714,37 @@ #define FORWARD_WM_ENABLE(hwnd, fEnable, fn) \ (void)(fn)((hwnd), WM_ENABLE, (WPARAM)(BOOL)(fEnable), 0L) +/* void Cls_OnSetTextA(HWND hwnd, LPCSTR lpszText) */ +#define HANDLE_WM_SETTEXTA(hwnd, wParam, lParam, fn) \ + ((fn)((hwnd), (LPCSTR)(lParam)), 0L) +#define FORWARD_WM_SETTEXTA(hwnd, lpszText, fn) \ + (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCSTR)(lpszText)) + +/* void Cls_OnSetTextW(HWND hwnd, LPCWSTR lpszText) */ +#define HANDLE_WM_SETTEXTW(hwnd, wParam, lParam, fn) \ + ((fn)((hwnd), (LPCWSTR)(lParam)), 0L) +#define FORWARD_WM_SETTEXTW(hwnd, lpszText, fn) \ + (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCWSTR)(lpszText)) + /* void Cls_OnSetText(HWND hwnd, LPCTSTR lpszText) */ -#define HANDLE_WM_SETTEXT(hwnd, wParam, lParam, fn) \ - ((fn)((hwnd), (LPCTSTR)(lParam)), 0L) -#define FORWARD_WM_SETTEXT(hwnd, lpszText, fn) \ - (void)(fn)((hwnd), WM_SETTEXT, 0L, (LPARAM)(LPCTSTR)(lpszText)) +#define HANDLE_WM_SETTEXT WINELIB_NAME_AW(HANDLE_WM_SETTEXT) +#define FORWARD_WM_SETTEXT WINELIB_NAME_AW(FORWARD_WM_SETTEXT) + +/* INT Cls_OnGetTextA(HWND hwnd, int cchTextMax, LPSTR lpszText) */ +#define HANDLE_WM_GETTEXTA(hwnd, wParam, lParam, fn) \ + (LRESULT)(DWORD)(int)(fn)((hwnd), (int)(wParam), (LPSTR)(lParam)) +#define FORWARD_WM_GETTEXTA(hwnd, cchTextMax, lpszText, fn) \ + (int)(DWORD)(fn)((hwnd), WM_GETTEXT, (WPARAM)(int)(cchTextMax), (LPARAM)(LPSTR)(lpszText)) + +/* INT Cls_OnGetTextW(HWND hwnd, int cchTextMax, LPWSTR lpszText) */ +#define HANDLE_WM_GETTEXTW(hwnd, wParam, lParam, fn) \ + (LRESULT)(DWORD)(int)(fn)((hwnd), (int)(wParam), (LPWSTR)(lParam)) +#define FORWARD_WM_GETTEXTW(hwnd, cchTextMax, lpszText, fn) \ + (int)(DWORD)(fn)((hwnd), WM_GETTEXT, (WPARAM)(int)(cchTextMax), (LPARAM)(LPWSTR)(lpszText)) /* INT Cls_OnGetText(HWND hwnd, int cchTextMax, LPTSTR lpszText) */ -#define HANDLE_WM_GETTEXT(hwnd, wParam, lParam, fn) \ - (LRESULT)(DWORD)(int)(fn)((hwnd), (int)(wParam), (LPTSTR)(lParam)) -#define FORWARD_WM_GETTEXT(hwnd, cchTextMax, lpszText, fn) \ - (int)(DWORD)(fn)((hwnd), WM_GETTEXT, (WPARAM)(int)(cchTextMax), (LPARAM)(LPTSTR)(lpszText)) +#define HANDLE_WM_GETTEXT WINELIB_NAME_AW(HANDLE_WM_GETTEXT) +#define FORWARD_WM_GETTEXT WINELIB_NAME_AW(FORWARD_WM_GETTEXT) /* INT Cls_OnGetTextLength(HWND hwnd) */ #define HANDLE_WM_GETTEXTLENGTH(hwnd, wParam, lParam, fn) \

Aug. 10, 2001

wine+mirc /rename confusiion bug

by mdew

make a empty file..place it the mirc dir... /rename y:\fake_windows\mirc\text.txt c:\mirc\text2.txt *** /rename: unable to rename 'y:\fake_windows\mirc\text.txt' to 'c:\mirc\text2.txt' $ ls text* -al -rw-r--r-- 1 mdew mdew 6 Aug 10 22:33 text.txt -rw-r--r-- 1 mdew mdew 6 Aug 10 22:36 text2.txt complains about it...yet it actually does it. -- id: 9DF3262C key fingerprint: B556 04DA CFD9 78DD 9215 A970 8196 FB6D 9DF3 262C

Aug. 10, 2001

Re: Unable to use RegisterClass(&WndClass);

by Dmitry Timoshkov

"Craig Chandler" <craig.chandler(a)interdynamics.com> wrote: > positive on the code working under all forms of windows (95, 98, me, nt, > 2k), has been since 1997 Please try whether the attached patch fixes your problem. -- Dmitry.

Aug. 10, 2001

Re: Unable to use RegisterClass(&WndClass);

by Dmitry Timoshkov

"Craig Chandler" <craig.chandler(a)interdynamics.com> wrote: > positive on the code working under all forms of windows (95, 98, me, nt, > 2k), has been since 1997 That probably means that global/local atom management in Wine is broken. As a temporary workaround you could use unique class names for local classes. -- Dmitry.

Aug. 10, 2001

Re: Unable to use RegisterClass(&WndClass);

by Dmitry Timoshkov

"Craig Chandler" <craig.chandler(a)interdynamics.com> wrote: > WNDCLASS WndClass; > > GetClassInfo(NULL, IF_BUTTON_NAME, &WndClass); > > WndClass.lpszClassName = IF_BUTTON_NAME; Use here different name for your own class. For instance "my_button" > WndClass.hInstance = hInstance; > WndClass.hbrBackground = (HBRUSH)GetStockObject( LTGRAY_BRUSH ); > > WndClass.cbWndExtra = kIFWNDEXTRA; > > IF_BUTTON_PROC = WndClass.lpfnWndProc; > WndClass.lpfnWndProc = ButtonWndProcBridge; > > return RegisterClass(&WndClass); > > > where IF_BUTTON_NAME = "button" Are you sure that the code above works under Windows? -- Dmitry.

Aug. 10, 2001

Re: Unable to use RegisterClass(&WndClass);

by Dmitry Timoshkov

"Craig Chandler" <craig.chandler(a)interdynamics.com> wrote: > when i use the RegisterClass(&WndClass); under wine the call fails. I'm > using it to sub class the button class. Does wine not support this? As I already wrote in the newsgroup: please provide the source of your code. -- Dmitry.

Aug. 10, 2001

RE: Unable to use RegisterClass(&WndClass);

by Craig Chandler

positive on the code working under all forms of windows (95, 98, me, nt, 2k), has been since 1997 -----Original Message----- From: Dmitry Timoshkov [mailto:dmitry(a)baikal.ru] Sent: Friday, 10 August 2001 13:02 To: Craig Chandler Cc: wine-devel(a)winehq.com Subject: Re: Unable to use RegisterClass(&WndClass); "Craig Chandler" <craig.chandler(a)interdynamics.com> wrote: > WNDCLASS WndClass; > > GetClassInfo(NULL, IF_BUTTON_NAME, &WndClass); > > WndClass.lpszClassName = IF_BUTTON_NAME; Use here different name for your own class. For instance "my_button" > WndClass.hInstance = hInstance; > WndClass.hbrBackground = (HBRUSH)GetStockObject( LTGRAY_BRUSH ); > > WndClass.cbWndExtra = kIFWNDEXTRA; > > IF_BUTTON_PROC = WndClass.lpfnWndProc; > WndClass.lpfnWndProc = ButtonWndProcBridge; > > return RegisterClass(&WndClass); > > > where IF_BUTTON_NAME = "button" Are you sure that the code above works under Windows? -- Dmitry.

Aug. 10, 2001

RE: Unable to use RegisterClass(&WndClass);

by Craig Chandler

WNDCLASS WndClass; GetClassInfo(NULL, IF_BUTTON_NAME, &WndClass); WndClass.lpszClassName = IF_BUTTON_NAME; WndClass.hInstance = hInstance; WndClass.hbrBackground = (HBRUSH)GetStockObject( LTGRAY_BRUSH ); WndClass.cbWndExtra = kIFWNDEXTRA; IF_BUTTON_PROC = WndClass.lpfnWndProc; WndClass.lpfnWndProc = ButtonWndProcBridge; return RegisterClass(&WndClass); where IF_BUTTON_NAME = "button" "Craig Chandler" <craig.chandler(a)interdynamics.com> wrote: > when i use the RegisterClass(&WndClass); under wine the call fails. I'm > using it to sub class the button class. Does wine not support this? As I already wrote in the newsgroup: please provide the source of your code. -- Dmitry.

Aug. 10, 2001

trouble with fonts (old, old problem)

by Mike McCormack

Hi All, i've got a problem with fonts in Netscape that's been around for a long time, while i've tried several times, unsuccessfully, to fix. When netscape 4.77 first loads, then loads an arbitary page, everything (text, buttons, comboboxes) is rendered incorrectly. If i go to another page, then hit the Back button, the page that was originally rendered incorrectly is now correct. All further renderings are correct for all pages. In my investigations (some time ago), i found that : * font enumeration functions returned different things on the first and second load of the same page. * i could correct the problem by changing the default ansi fixed font to helvetica i suspect that the wine loads extra X11 fonts between the first and second page viewings... but i don't know much about font handling in wine. i'll make some screen shots if anybody is interested. Any ideas? Mike ------------------------------------------ mailto:Mike_McCormack(a)start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au

Aug. 10, 2001

Font scaling in PSDRV_EnumDeviceFonts

by Ian Pilcher

Can anyone point me to the Win32 API that ultimately calls the subject function? I'm trying to understand why it scales fonts to a 200 logical unit (I think) character cell. Is this completely arbitrary? Thanks! -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

Aug. 10, 2001

Unable to use RegisterClass(&WndClass);

by Craig Chandler

when i use the RegisterClass(&WndClass); under wine the call fails. I'm using it to sub class the button class. Does wine not support this? Interdynamics Web Page : http://www.interdynamics.com

Aug. 10, 2001

Re: wineserver.pid

by Alexandre Julliard

Andreas Mohr <a.mohr(a)mailto.de> writes: > Hi all, > > some guy was running several different versions of wineservers for one > account via wrapper scripts. > And of course he had a hell of a hard time figuring out which wineserver to > kill for which application ;-) Why would you want to do that? Just kill the app and it will die on its own (and save everything too). I don't think encouraging people to kill the wineserver is a good idea. -- Alexandre Julliard julliard(a)winehq.com

Aug. 9, 2001

Re: winelib application debugging

by eric pouech

Vitaly Kuznetsov wrote: > > Is there currently any way to debug winelib application? I read winedbg > doc, but there are only samples for windows executables. you can also debug winelib applications with winedbg and you should get access to both the executable information and the different loaded DLL (counting the Wine builtin ones) A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

Aug. 9, 2001

Today's CVS hangs on startup

by Ian Pilcher

The good news is that --debugmsg +all actually stops producing anything. Hopefully someone can look at the output below and figure out what's going on. Anyone else seen this? ... 080689c0:trace:dosfs:DOSFS_FindUnixName (/home/pilcher/wine,Eudora\EUDORA.EXE) -> Eudora (EUDORA) 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:heap:HeapFree (403a0000,00000002,403c36c8): returning TRUE 080689c0:trace:dosfs:DOSFS_FindUnixName /home/pilcher/wine/Eudora,EUDORA.EXE 080689c0:trace:heap:HeapAlloc (403a0000,00000002,0000022c): returning 403c36c8 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:dosfs:DOSFS_FindUnixName (/home/pilcher/wine/Eudora,EUDORA.EXE) -> EUDORA.EXE (EUDORA.EXE) 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:heap:HeapFree (403a0000,00000002,403c36c8): returning TRUE 080689c0:trace:dosfs:DOSFS_GetFullName returning /home/pilcher/wine/Eudora/EUDORA.EXE = C:\EUDORA\EUDORA.EXE 080689c0:trace:string:lstrcpynA (0x405f68e8, "C:\\EUDORA\\EUDORA.EXE", 260) 080689c0:trace:string:lstrcpynA (0x405f68ea, "/Eudora/EUDORA.EXE", 258) 080689c0:trace:module:GetModuleFileName16 01cf -> 'C:\Eudora\EUDORA.EXE' 080689c0:trace:heap:HeapAlloc (403a0000,00000002,0000004c): returning 403c3480 080689c0:trace:reg:NtOpenKey (0x80000002,L"Software\\Wine\\Wine\\Config\\AppDefaults",f003f,0x405f6820) 080689c0: open_key( parent=-2147483646, access=000f003f, name=L"Software\\Wine\\Wine\\Config\\AppDefaults" ) Open key ERROR 080689c0: open_key() = OBJECT_NAME_NOT_FOUND { hkey=0 } 080689c0:trace:reg:NtOpenKey <- 0x0000 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"display",(nil),(nil),0x405f68f0,0x405f6818=268) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"display",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"display" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"Managed",(nil),(nil),0x405f68e8,0x405f6814=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"Managed",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"Managed" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"Desktop",(nil),(nil),0x405f68e8,0x405f6810=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"Desktop",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"Desktop" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"DXGrab",(nil),(nil),0x405f68e8,0x405f680c=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"DXGrab",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"DXGrab" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"UseDGA",(nil),(nil),0x405f68e8,0x405f6808=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"UseDGA",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"UseDGA" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"ScreenDepth",(nil),(nil),0x405f68e8,0x405f6804=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"ScreenDepth",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"ScreenDepth" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0:trace:reg:RegQueryValueExA (0x20,"Synchronous",(nil),(nil),0x405f68e8,0x405f6800=276) 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 080689c0:trace:reg:NtQueryValueKey (0x20,L"Synchronous",2,0x405f6688,256) 080689c0: get_key_value( hkey=32, offset=00000000, name=L"Synchronous" ) 080689c0: get_key_value() = OBJECT_NAME_NOT_FOUND { type=-1, len=0, data={} } 080689c0:trace:heap:HeapFree (403a0000,00000002,403c3480): returning TRUE 080689c0: close_handle( handle=32 ) 080689c0: close_handle() = 0 { fd=-1 } 080689c0:trace:heap:HeapAlloc (403a0000,00000002,00000018): returning 403c3480 -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

Aug. 9, 2001

winelib application debugging

by Vitaly Kuznetsov

Is there currently any way to debug winelib application? I read winedbg doc, but there are only samples for windows executables. -- Vitaly AKA Vitty mailto: vitty(a)dts.ru NetMail:2:5015/133.41

Aug. 9, 2001

Re: printing AND memory

by Ian Pilcher

Richard Canada wrote: > Does anyone know why I am getting an error message about "Insufficient > memory" when I try to print from wine? I can see the printer is there, > but I cannot print. I am running Lotus Notes 5.0.6. Thanks > Lotus Notes will display this message whenever the printer driver fails to initialize -- for any reason. (OT, there's a user interface "Hall of Shame" somewhere on the 'net with a whole section devoted to Notes!) Run it with '--debugmsg +psdrv', and see if you can spot why the driver is failing. This can produce a lot of output, so you may want to redirect stderr to a file: wine --debugmsg -all,+psdrv nlnotes 2> ~/wine.log or something like that. If you can't figure out what's going on, send me the file. BTW, what version of Wine are you running, and did this work for you before? -- ======================================================================== Ian Pilcher ian.pilcher(a)home.com ========================================================================

Aug. 9, 2001