August 2001 - Wine-Devel - list.winehq.org

Re: Just out of interest whats this?

by Robert Laverick

Robert Laverick wrote: > FIXME:pthread_rwlock_rdlock > FIXME:pthread_rwlock_unlock > what's this, what's causing it and what needs fixing (I'll give it a > look if it's needed) or is it just an old error that dosn't really need > fixing (I can run almost everything I want to and the all show this > error) just intersted > Rob > ok so I've found where these all some from, I see that it's mostly stubs, is there a deff of what all these should be or is that for me to work out? anyone got any hints? my threads stuff is a bit rusty, but I'll give it a try and see where it gets me. anyone else looking at this? if so just drop me a line and let me know what's going on. ahh come on, it'd be good to drop all those fixme's!!! or is there a reason not to do this? just wondering if it's better that the locks arn't in yet while other stuff is messed with? let me know what you all think. Rob

Aug. 5, 2001

Just out of interest whats this?

by Robert Laverick

FIXME:pthread_rwlock_rdlock FIXME:pthread_rwlock_unlock what's this, what's causing it and what needs fixing (I'll give it a look if it's needed) or is it just an old error that dosn't really need fixing (I can run almost everything I want to and the all show this error) just intersted Rob

Aug. 5, 2001

Window-position bug?

by davep

Here's one I haven't seen before. Build the 'winemine' application in the programs directory and start it running. Click on the smiley-face button (which redraws the window). Every time I press the button the entire window moves down the screen one pixel. Dave

Aug. 4, 2001

Re: wine/dlls/oleaut32 typelib.c

by Dmitry Timoshkov

"Alexandre Julliard" <julliard(a)winehq.com> wrote: > Log message: > Malte Starostik <malte(a)kde.org> > Implemented RegisterTypeLib. > > Patch: http://cvs.winehq.com/patch.py?id=99686240431774649117142 + if (res == S_OK && RegCreateKeyExA(key, "FLAGS", 0, NULL, 0, + KEY_WRITE, NULL, &subKey, NULL) == ERROR_SUCCESS) + { + CHAR buf[20]; + /* FIXME: is %u correct? */ + snprintf(buf, strlen(buf), "%u", attr->wLibFlags); ^^^^^^^^^^^ + if (RegSetValueExA(subKey, NULL, 0, REG_SZ, + buf, lstrlenA(buf) + 1) != ERROR_SUCCESS) + res = E_FAIL; + } I'm sorry, it's late a bit. But anyway, instead of strlen() above should be sizeof(). -- Dmitry.

Aug. 4, 2001

Re: PATCH: ITypeInfo::Invoke

by Dmitry Timoshkov

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > +static void dump_VarType(VARTYPE vt,char *szVarType) { > + /* FIXME : we could have better trace here, depending on the VARTYPE > + * of the variant > + */ > + switch(vt) { > + case VT_UI1: MESSAGE(szVarType, "VT_UI"); break; ^^^^^^^ > + case VT_I2: sprintf(szVarType, "VT_I2"); break; > + case VT_I4: sprintf(szVarType, "VT_I4"); break; Seems to be a typo. Shouldn't it be sprintf instead of MESSAGE? -- Dmitry.

Aug. 4, 2001

RE: What is the @ in the function headers

by Patrik Stridvall

> Quick question. What is the @ in a function header supposed > to contain? > Presumably it is the ordinal in the Dll. Well, functions either has an ordinal or a @. If it has a @ it is means that it doesn't matter what the ordinal is, that winebuild can assign any ordinal it likes for the function. > But what if the > same function has > different ordinals in different copies of the Dll? You mean different versions? Anyway, Wine has no support for it, because none is really needed, because any application that tries to access functions by ordinal that doesn't have a fixed ordinal across DLL version is broken even on Windows.

Aug. 3, 2001

What is the @ in the function headers

by Bill Medland

Quick question. What is the @ in a function header supposed to contain? Presumably it is the ordinal in the Dll. But what if the same function has different ordinals in different copies of the Dll? Bill

Aug. 3, 2001

Re: Dont allow SetSelectorBase to change into an kernel region

by Uwe Bonnes

>>>>> "Alexandre" == Alexandre Julliard <julliard(a)winehq.com> writes: Alexandre> Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> writes: >> If I only allow to set the selector base when (selector base + >> selector limit) is smaller than 0x8000000, the application goes on >> and lets me read an eprom plugged into the Galep3 Programmer. Is the >> appended fix a right acceptable? Alexandre> No, it's legal to have selectors covering the entire address Alexandre> space. I'm afraid there is no good solution to this kind of Alexandre> problem. What does the app do under NT or with -winver nt40? Hallo Alexandre, I didn't get the NT version of Galep to install under wine. There is some deadlock with the Win16Mutex. It would be nice if someone could have a look at that problem. The installation file is found at http://conitec.net/hardware/down/119NTUK.EXE Copying the galep directory from a NT machine, I can successfully run the executable with winver "win31/win95/win95", without hitting the SetSelectorBase problem. Running with --winver nt40 however gives: hertz:> wine --winver nt40 galep3.exe fixme:event:EnableHardwareInput16 (0) - stub fixme:event:EnableHardwareInput16 (1) - stub fixme:win32:DEVICE_Open Unknown VxD glpntdrv. Try --winver nt40 or win31 ! and the device is not accesible. PS: Sould I submitt a patch to emitting a warning when SetSelectorBase wants an illegal region? I think all memory about 0x80000000 is not allowed on normal ix86 linux, while with the bigmen option it is 0xc0000000? Can I determine this number during runtime? Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

Aug. 3, 2001

Re: CS_PARENTDC with WS_CLIPSIBLINGS

by Andreas Mohr

On Thu, Aug 02, 2001 at 11:50:42PM +0200, Ladislav Sladecek wrote: > Alexandre Julliard wrote: > > > > Yes, there were a number of problems with the flags handling in > > GetDCEx. I think the behavior with the current CVS should now be > > correct in all cases; please give it a try. > > Thank you for the fix. The example works fine but the original app ( 16 bit > _prowin.exe from Progress RDBMS] ceased to work at all. After the menu > is drawn, the application stops responding and complains about some > illegal string operations and then about unknown driver ,, in GetDCA. > > > err:string:lstrcpyA (0x40a2e75e, (nil)): page fault occurred ! Caused by bug ? > err:dc:CreateDCA no driver found for ,, device:,, > err:dc:CreateDCA no driver found for ,, device:,, > err:dc:CreateDCA no driver found for ,, device:,, > err:dc:CreateDCA no driver found for ,, device:,, > > > I tried also --debugmsg +all; several houndreds lines of the trace are > attached. I do not know if the problem is somewhat connected with your fix or is > created by some other patch. No, it's not. Wine is not guilty at all, AFAICS. It's a totally dainbread application, that's why. It checks win.ini [windows] device=XXX and as this entry doesn't exist (it's "HP LaserJet 5M,PCL5EMS,LPT1:" here), the app does all sorts of very strange things: 0806c1f0:Call KERNEL.89: LSTRCAT(0667:e736 "",0x121f0190 ".DRV") ret=0ff7:0c29 ds=121f 0806c1f0:trace:global:GlobalHandle16 015f 0806c1f0:Ret KERNEL.89: LSTRCAT() retval=0x0667e736 ret=0ff7:0c29 ds=121f 0806c1f0:trace:global:GlobalHandle16 015f 0806c1f0:Call KERNEL.95: LOADLIBRARY(0x0667e736 ".DRV") ret=0ff7:0c34 ds=121f 0806c1f0:Ret KERNEL.95: LOADLIBRARY() retval=0x0002 ret=0ff7:0c34 ds=121f ^^^^^^ not too surprising 0806c1f0:trace:global:GlobalHandle16 015f 0806c1f0:Call KERNEL.107: SETERRORMODE(0x0000) ret=0ff7:0c42 ds=121f 0806c1f0:trace:global:GlobalHandle16 015f 0806c1f0:Ret KERNEL.107: SETERRORMODE() retval=0x8000 ret=0ff7:0c42 ds=121f 0806c1f0:trace:global:GlobalHandle16 015f 0806c1f0:Call KERNEL.50: GETPROCADDRESS(0x0002,0x121f0195 "EXTDEVICEMODE") ret=0ff7:0c57 ds=121f ^^^^^^ eh ?? 0806c1f0:trace:module:GetProcAddress16 0000 'EXTDEVICEMODE' 0806c1f0:trace:global:GlobalHandle16 015f 0806c1f0:Ret KERNEL.50: GETPROCADDRESS() retval=0x00000000 ret=0ff7:0c57 ds=121 could have told you before... ^^^^^^^^^^ f My guess is that this application exhibits so braindead, non-checking behaviour since this win.ini entry is absolutely expected to exist. Unfortunately I can't see from this short log why it checks the printer at all. We might want to make sure that in case we get asked for a printer, we also have a device= line in place, and if this isn't the case, then issue a fat warning to the end user. So OTOH Wine is probably guilty by not making sure that there is a device= line in case of psdrv or something. What happens if you run this program on a windoze box without any printer installed ? (and thus the device= line should not exist, there, too...) Does it fail the same way or does it seem to recognize somehow that there is no printer installed ? -- Andreas Mohr

Aug. 3, 2001

Some questions about TB_REPLACEBITMAP

by Marco Bizzarri

Hi all. I'm trying to implement the TB_REPLACEBITMAP message in the comctrl32, and I would like to have some advice about the ImageList structure. The TB_REPLACEBITMAP provides (via the hInst, nID pair) the handle to the old bitmap and the handle to the new bitmap, as well as the number of button in the new bitmap. I think I could use the ImageList_Replace to actually replace the bitmaps. However, the ImageList_Replace function requires a number, which is the first bitmap to be replaced. How can I retrieve this information? For what I can see, once a bitmap has been added to the imagelist, no information about is is stored. I'm doing some tests, using a value (like 0) as the bitmap index, but this is of little help, of course. Any help will be appreciated. Bye Marco

Aug. 3, 2001