September 2001 - Wine-Devel

Re: Callwave doesn't run

by eric pouech

Steven Walter wrote: > > On Sat, Sep 22, 2001 at 09:26:22AM +0200, eric pouech wrote: > > the first fixme is harmless > > the second part means that an exception occured in the program (likely a > > seg fault) > > and the debugger couldn't be launched to display the context of the > > error > > read the doc and properly set up the debugger for this information, > > and/or > > look at the various ways to submit a full bug report (running with > > -debugmsg +relay > > and quoting the 500 lines before the point the exception is triggered is > > quite always a good starting point) > > Attached is the /entire/ relay log. Its pretty obvious that it doesn't > get far. Additionally, the debugger seems to get killed for some > reason; it pops up, stays for a fraction of a second, and is then > killed. I get the message "Terminated" in the shell where I was running > wine. what's strange is that the relay posted only targets the debugger process, not the process creating the exception... (the one creating the exception is 080671f0 and never shows up in the trace) how did you run your program ? which wine version are you using ? (from your previous post, the debugger now starts) A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

Sept. 22, 2001

Re: Callwave doesn't run

by Steven Walter

On Sat, Sep 22, 2001 at 09:26:22AM +0200, eric pouech wrote: > the first fixme is harmless > the second part means that an exception occured in the program (likely a > seg fault) > and the debugger couldn't be launched to display the context of the > error > read the doc and properly set up the debugger for this information, > and/or > look at the various ways to submit a full bug report (running with > -debugmsg +relay > and quoting the 500 lines before the point the exception is triggered is > quite always a good starting point) Attached is the /entire/ relay log. Its pretty obvious that it doesn't get far. Additionally, the debugger seems to get killed for some reason; it pops up, stays for a fraction of a second, and is then killed. I get the message "Terminated" in the shell where I was running wine. -- -Steven In a time of universal deceit, telling the truth is a revolutionary act. -- George Orwell Freedom is slavery. Ignorance is strength. War is peace. -- George Orwell fixme:win32:PE_CreateModule Security directory ignored fixme:pthread_kill_other_threads_np 084a9b88:Call PE DLL (proc=0x40907958,module=408f9000,type=1,res=0x1) 084a9b88:Ret PE DLL (proc=0x40907958,module=408f9000,type=1,res=0x1) retval=1 084a9b88:Call PE DLL (proc=0xbfed135c,module=bfed0000,type=1,res=0x1) 084a9b88:Call kernel32.DisableThreadLibraryCalls(bfed0000) ret=bfed136f 084a9b88:Ret kernel32.DisableThreadLibraryCalls() retval=00000001 ret=bfed136f 084a9b88:Ret PE DLL (proc=0xbfed135c,module=bfed0000,type=1,res=0x1) retval=1 084a9b88:Starting process /home/srwalter/cvs/wine/debugger/winedbg (entryproc=0x40749148) 084a9b88:Call ntdll.__wine_get_main_args(407867fc) ret=40749164 084a9b88:Ret ntdll.__wine_get_main_args() retval=00000003 ret=40749164 084a9b88:Call kernel32.IsBadWritePtr(408a6e8c,00000004) ret=bfed1795 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed1795 084a9b88:Call kernel32.VxDCall3(00010012) ret=bfed17be fs=008f eax=80000001 ebx=4076fe94 ecx=00000001 edx=408a6e8c esi=407868ac edi=40786b40 ebp=408a6e4c esp=408a6e40 ds=002b es=002b gs=0000 flags=00200282 084a9b88:Ret kernel32.VxDCall3() retval=00000000 ret=bfed17be fs=008f eax=00000000 ebx=4076fe94 ecx=00000001 edx=408a6e8c esi=407868ac edi=40786b40 ebp=408a6e4c esp=408a6e4c ds=002b es=002b gs=0000 flags=00200282 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.IsBadWritePtr(408a6e88,00000004) ret=bfed15d1 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15d1 084a9b88:Call kernel32.IsBadWritePtr(408a6e84,00000004) ret=bfed15e8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15e8 084a9b88:Call kernel32.IsBadWritePtr(408a6e80,00000004) ret=bfed15f8 084a9b88:Ret kernel32.IsBadWritePtr() retval=00000000 ret=bfed15f8 084a9b88:Call kernel32.VxDCall6(0001001a) ret=bfed1626 fs=008f eax=00000001 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e1c ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall6() retval=00000002 ret=bfed1626 fs=008f eax=00000002 ebx=408a6e80 ecx=00000000 edx=408a6e80 esi=40938960 edi=408a6e88 ebp=408a6e40 esp=408a6e34 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.VxDCall1(00010013) ret=bfed16ca fs=008f eax=00000001 ebx=4076fe94 ecx=00000000 edx=40786908 esi=0000001c edi=00000250 ebp=408a6e90 esp=408a6e50 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Ret kernel32.VxDCall1() retval=00000000 ret=bfed16ca fs=008f eax=00000000 ebx=4076fe94 ecx=00000000 edx=40786908 esi=0000001c edi=00000250 ebp=408a6e90 esp=408a6e54 ds=002b es=002b gs=0000 flags=00200202 084a9b88:Call kernel32.GetStdHandle(fffffff5) ret=4075db3b 084a9b88:Ret kernel32.GetStdHandle() retval=00000008 ret=4075db3b 084a9b88:Call kernel32.SetConsoleCursorPosition(00000008,00010000) ret=4075db41 Console: Making console complex (creating an xterm)... fixme:pthread_kill_other_threads_np fixme:pthread_kill_other_threads_np fixme:pthread_kill_other_threads_np fixme:pthread_kill_other_threads_np 084a9b88:Ret kernel32.SetConsoleCursorPosition() retval=00000001 ret=4075db41 084a9b88:Call kernel32.GetStdHandle(fffffff5) ret=4075bf58 084a9b88:Ret kernel32.GetStdHandle() retval=00000008 ret=4075bf58 084a9b88:Call kernel32.WriteFile(00000008,40785760,00000014,00000000,00000000) ret=4075bf5e 084a9b88:Ret kernel32.WriteFile() retval=00000001 ret=4075bf5e 084a9b88:Call kernel32.DebugActiveProcess(080671f0) ret=4075cac7 084a9b88:Ret kernel32.DebugActiveProcess() retval=00000001 ret=4075cac7 084a9b88:Call kernel32.SetEvent(00000018) ret=4075dbae 084a9b88:Ret kernel32.SetEvent() retval=00000001 ret=4075dbae 084a9b88:Call kernel32.CloseHandle(00000018) ret=4075dbcc 084a9b88:Ret kernel32.CloseHandle() retval=00000001 ret=4075dbcc 084a9b88:Call kernel32.GetStdHandle(fffffff5) ret=4075bf58 084a9b88:Ret kernel32.GetStdHandle() retval=00000008 ret=4075bf58 084a9b88:Call kernel32.WriteFile(00000008,40785760,00000010,00000000,00000000) ret=4075bf5e 084a9b88:Ret kernel32.WriteFile() retval=00000001 ret=4075bf5e 084a9b88:Call kernel32.WaitForDebugEvent(408a6e34,ffffffff) ret=4075d998 084a9b88:Ret kernel32.WaitForDebugEvent() retval=00000001 ret=4075d998 084a9b88:Call kernel32.ReadProcessMemory(0000001c,4011033c,408a6b28,00000004,408a6b2c) ret=4075c8af 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075c8af 084a9b88:Call kernel32.ReadProcessMemory(0000001c,40126340,408a6d10,00000100,408a6b2c) ret=4075c8d0 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075c8d0 084a9b88:Call kernel32.ReadProcessMemory(0000001c,0040003c,408a6a10,00000004,00000000) ret=40753367 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=40753367 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400108,408a6a3c,000000f8,00000000) ret=40753398 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=40753398 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400200,408a6a14,00000028,00000000) ret=40753411 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=40753411 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400228,408a6a14,00000028,00000000) ret=40753411 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=40753411 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400250,408a6a14,00000028,00000000) ret=40753411 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=40753411 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400200,408a69b0,00000028,00000000) ret=4075698d 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075698d 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400228,408a69b0,00000028,00000000) ret=4075698d 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075698d 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400250,408a69b0,00000028,00000000) ret=4075698d 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075698d 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400200,0804ef90,00000078,00000000) ret=4075679f 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075679f 084a9b88:Call kernel32.CloseHandle(00000000) ret=40754235 084a9b88:Ret kernel32.CloseHandle() retval=00000000 ret=40754235 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400200,408a66a0,00000028,00000000) ret=4075365e 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075365e 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400228,408a66a0,00000028,00000000) ret=4075365e 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075365e 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400250,408a66a0,00000028,00000000) ret=4075365e 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=4075365e 084a9b88:Call kernel32.ReadProcessMemory(0000001c,00400180,408a6670,00000008,00000000) ret=407536fb 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=407536fb 084a9b88:Call kernel32.ReadProcessMemory(0000001c,0044bc20,408a6678,00000028,00000000) ret=40753760 084a9b88:Ret kernel32.ReadProcessMemory() retval=00000001 ret=40753760 084a9b88:Call kernel32.GetStdHandle(fffffff5) ret=4075bf58 084a9b88:Ret kernel32.GetStdHandle() retval=00000008 ret=4075bf58 084a9b88:Call kernel32.WriteFile(00000008,40785760,00000012,00000000,00000000) ret=4075bf5e 084a9b88:Ret kernel32.WriteFile() retval=00000001 ret=4075bf5e

Sept. 22, 2001

Re: Callwave doesn't run

by eric pouech

Steven Walter wrote: > > Is this a known problem? When I try to run the callwave install > program, or the callwave program itself, I merely get: > > fixme:win32:PE_CreateModule Security directory ignored > err:seh:start_debugger Couldn't start debugger (debugger/winedbg 134640112 24) (2) > Read the Wine Developers Guide on how to set up winedbg or another debugger the first fixme is harmless the second part means that an exception occured in the program (likely a seg fault) and the debugger couldn't be launched to display the context of the error read the doc and properly set up the debugger for this information, and/or look at the various ways to submit a full bug report (running with -debugmsg +relay and quoting the 500 lines before the point the exception is triggered is quite always a good starting point) A+ -- --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) "The future will be better tomorrow", Vice President Dan Quayle

Sept. 22, 2001

Callwave doesn't run

by Steven Walter

Is this a known problem? When I try to run the callwave install program, or the callwave program itself, I merely get: fixme:win32:PE_CreateModule Security directory ignored err:seh:start_debugger Couldn't start debugger (debugger/winedbg 134640112 24) (2) Read the Wine Developers Guide on how to set up winedbg or another debugger Is this a configuration error on my part? Either way, is there some information I need to give to get this fixed? I appreciate it. Thanks -- -Steven In a time of universal deceit, telling the truth is a revolutionary act. -- George Orwell Freedom is slavery. Ignorance is strength. War is peace. -- George Orwell

Sept. 21, 2001

Re: wsprintf

by Jeremy White

> Well, because *you* don't look at it doesn't mean it's not the right > place, does it? <g> I look at the CVS history quite often, and I find > that in many cases it's the best way to find out why things are done a > certain way. Ah, but I suspect that I am more representative of the typical hacker than you are, in this regard. Further, attempting to comprehend the changelog without the context of the relevant source code is generally unrewarding for me. However, I think I realize that my post and thread is largely useless. As much as I think you err on the side of brevity, I suspect that, except for my patches, you rarely go around deleting comments from code... Jer

Sept. 21, 2001

Re: wsprintf

by Bill Medland

Jeremy White <jwhite(a)codeweavers.com> wrote in message news:3BAB95E0.2020608(a)codeweavers.com... > > > > I added a comment in wsprintf16 to make Andreas happy. But I agree > > that the change log (and cvs diff) is the best way to store this kind > > of information. > > > > Okay, so it's a slow news day, and I feel like stirring up trouble. Seems like a reasonable idea for a Friday afternoon > > I would argue that it is, in fact, counterintuitive, to have this > sort of comment solely in the change log. The only time I ever think > to look at a diff (or even the change log) is when something has broken > recently. I agree in general, but I believe that such information is required (in two different forms) in both places. (In this particular case what is in the cvs seems fine to me, but to a large extent we have Alexandre to thank for keeping that tidy). > > IMO, it is appropriate to comment in the code, > whenever something useful about Wine/Windows behavior is learned, > especially when the knowledge is something non intuitive > like the fact that the 16 bit version and 32 bit version > behave differently. Here's my views The change log and cvs diff should explain why a change was made (and in an ideal world should refer to the supporting documentation e.g. bug numbers etc.). In this particular case it should mention, as it does, that the difference has been detected. The code should not contain change information. (I have worked on large code without the benefit of version control; it's revolting!). Comments in the code ought to reflect its current state, not how it got there. They should highlight important information that is not obvious (and what may be obvious to you may not be obvious to someone else or, more worryingly, may be obviously something else to them). Thus when two pieces of code look extremely similar but not identical it is worth a quick comment that the difference is deliberate, not the result of poor maintenance. (And I am a firm believer in doubly linked comments; e.g. one place contains the comment and the other refers to it). So what does anyone else think? Bill

Sept. 21, 2001

Re: wsprintf

by Alexandre Julliard

Jeremy White <jwhite(a)codeweavers.com> writes: > Okay, so it's a slow news day, and I feel like stirring up trouble. Bad boy... > I would argue that it is, in fact, counterintuitive, to have this > sort of comment solely in the change log. The only time I ever think > to look at a diff (or even the change log) is when something has broken > recently. Well, because *you* don't look at it doesn't mean it's not the right place, does it? <g> I look at the CVS history quite often, and I find that in many cases it's the best way to find out why things are done a certain way. I don't see any reason to duplicate this info inside the code itself; since we are using a source control system we might as well take advantage of it. Plus it guarantees the info is stored permanently, unlike a comment that may get moved or lost next time the code is changed. -- Alexandre Julliard julliard(a)winehq.com

Sept. 21, 2001

Re: wsprintf

by Jeremy White

> > I added a comment in wsprintf16 to make Andreas happy. But I agree > that the change log (and cvs diff) is the best way to store this kind > of information. Okay, so it's a slow news day, and I feel like stirring up trouble. I would argue that it is, in fact, counterintuitive, to have this sort of comment solely in the change log. The only time I ever think to look at a diff (or even the change log) is when something has broken recently. IMO, it is appropriate to comment in the code, whenever something useful about Wine/Windows behavior is learned, especially when the knowledge is something non intuitive like the fact that the 16 bit version and 32 bit version behave differently. Jer

Sept. 21, 2001

Re: re-implementing real mode interrupts

by Alexandre Julliard

Mike McCormack <mike_mccormack(a)start.com.au> writes: > For example, currently calling DeviceIoControl VWIN32_DIOC_DOS_INT_13 > on the VWIN32 device calls to the real mode interrupt INT 13. It could > be re-implemented so that INT_Int13Handler does a DeviceIoControl and > the low level disk access code moved into the VWIN32 device > implemetation. VWIN32_DIOC_DOS_INT_13 is not really different from int 13, so it wouldn't make much difference either way. Much better would be to implement the higher level calls that are needed to reimplement the DOS interrupts; for instance int 13 should use the IOCTL_DISK calls of DeviceIoControl, int 25/26 should be replaced by Win32 device access (CreateFile("\\.\PHYSICALDRIVEx")+Read/WriteFile), etc. -- Alexandre Julliard julliard(a)winehq.com

Sept. 21, 2001

Re: wsprintf

by Alexandre Julliard

Aric Stewart <aric(a)codeweavers.com> writes: > I think this is part of what the change log is for. > > Alexandre has committed the patch, i will ask him if he wants me to > document something further and submit another patch. I added a comment in wsprintf16 to make Andreas happy. But I agree that the change log (and cvs diff) is the best way to store this kind of information. -- Alexandre Julliard julliard(a)winehq.com

Sept. 21, 2001