October 2002 - Wine-Devel - list.winehq.org

Re: Re: So lets say we do it

by chrismorgan＠rcn.com

> > 2. People will look for the typical left-side menu: > > Home > > About > > Status > > Development > > Download > > Screenshots > > > > *BZZT* We don't have any. 5% will drop off here. > > Sorry to say that, but in this mail, *you* were talking *some* crap IMHO > ;-) > > We *do* have screenshots. The About page has some pretty nice screenshot. > OK, it's a minimalist approach, granted, but it does show IE etc. > I'd also like to second the opinion that we should have a dedicated "Screenshot" entry right off of the main page. I do the same stuff that Dimitrie does, go to a project, look at some text briefly and then immediately want to see what the app looks like when it is working. So maybe leave the screenshot link off of the "About" page but also put a link on the main page. Chris

Oct. 31, 2002

Re: So lets say we do it

by Dimitrie O. Paun

On October 31, 2002 10:29 am, Andreas Mohr wrote: > Sorry to say that, but in this mail, *you* were talking *some* crap IMHO > ;-) It's OK, you just missed the point. :P Honestly, you did: it's not ranting, it's a way to highlight where, and what we need to do. I said that in the P.S. by the way. Reread it. > We *do* have screenshots. The About page has some pretty nice screenshot. > OK, it's a minimalist approach, granted, but it does show IE etc. All projects that have something to show, have a link to the screenshots on the front page. Period. *Except* us. What's the point in arguing that the entire world is stupid, but us?!? People expect that, the same way they expect a "File, Edit, View, ... Help" menu. Many just stop there, if they don't find it. I know *I* do that, for chrissake! Just remember: if we are pissing against the wind, we'll get wet. :) -- Dimi.

Oct. 31, 2002

Re: RPC test code?

by Paul Millar

Yes, there's a race condition, although it looks like you've got a different bit of NTDLL failing. See: http://bugs.winehq.com/show_bug.cgi?id=970 Cheers, Paul. On Thu, 31 Oct 2002, Greg Turner wrote: > On Wednesday 30 October 2002 12:22 pm, Greg Turner wrote: > > BTW, this is somewhat off-topic, but sometimes the winsock test hangs > > for me after "make testclean"; ctrl-c and re-running "make test" > > always works, so I wonder if perhaps there is a race condition > > tickled by the make processing? Next time (if there is one) that I > > encounter this, I'll attach a debugger and tell you what I see. > > this happened to turn up last night. first, i was wrong that this was > your winsock test, Martin; it's the http test in dlls/wininet/tests > (not sure who owns that code?) > > nevertheless, i attached a debugger, here's a trace: > > #0 0x4033a0a4 in read () from /lib/libc.so.6 > #1 0x40110654 in __JCR_LIST__ () from > /var/src/wine/dlls/libntdll.dll.so > #2 0x400ccc33 in WaitForMultipleObjectsEx (count=0, handles=0x0, > wait_all=0, timeout=100, alertable=0) at ../../scheduler/synchro.c:265 > #3 0x400cc989 in Sleep (timeout=100) at ../../scheduler/synchro.c:186 > #4 0x40234a43 in winapi_test (flags=268435456) at http.c:139 > #5 0x40234f8c in func_http () at http.c:211 > #6 0x402354ee in run_test (name=0xbffff7c5 "http.c") at > ../../../include/wine/test.h:283 > #7 0x402356f4 in main (argc=2, argv=0xbffff638) at > ../../../include/wine/test.h:322 > #8 0x40234040 in __wine_exe_main () at wininet_test.exe.spec.c:133 > #9 0x400c80aa in start_process () at ../../scheduler/process.c:564 > #10 0x400ccfa5 in call_on_thread_stack (func=0x400c7dde) at > ../../scheduler/sysdeps.c:112 > (gdb) > > after this, as predicted above, "killall wine; killall wineserver; make > test" succeeded. "rm dlls/wininet/tests/http.ok; make test" also > succeeds. As soon as I do "make testclean && make test," it hangs > again. To whomever wants to tackle this, let me know if there's more > info I should give; the behvior is more-or-less repeatable on my box. > > -- > gmt > > "The purpose of government is to rein in the rights of the people" > --President Bill Clinton, MTV interview, 1993 > > > > -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- Particle Physics (Theory & Experimental) Groups Paul Millar Department of Physics and Astronomy paulm(a)astro.gla.ac.uk University of Glasgow paulm(a)physics.gla.ac.uk Glasgow, G12 8QQ, Scotland http://www.astro.gla.ac.uk/users/paulm +44 (0)141 330 4717 A54C A9FC 6A77 1664 2E4E 90E3 FFD2 704B BF0F 03E9 -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --

Oct. 31, 2002

Re: SetWindowHookEx

by steve.lustbader＠philips.com

This patch fixed it. Could you change the fixme message in user/hook.c to something more explicit than "won't work right," or at least include a comment in the code explaining why it won't work right? -Steve steve.lustbader(a)philips.com writes: > It's returning NULL for me, which implies it isn't working. Is there some > sort of trace that I can send you to help you out? Oops you are right, this should fix it: Index: server/hook.c =================================================================== RCS file: /opt/cvs-commit/wine/server/hook.c,v retrieving revision 1.1 diff -u -r1.1 hook.c --- server/hook.c 29 Oct 2002 00:41:42 -0000 1.1 +++ server/hook.c 30 Oct 2002 19:51:20 -0000 @@ -227,7 +227,8 @@ set_error( STATUS_INVALID_PARAMETER ); return; } - if (!(thread = get_thread_from_id( req->tid ))) return; + if (!req->tid) thread = (struct thread *)grab_object( current ); + else if (!(thread = get_thread_from_id( req->tid ))) return; if ((hook = add_hook( thread, req->id - WH_MINHOOK ))) { -- Alexandre Julliard julliard(a)winehq.com

Oct. 31, 2002

Re: Wine securityflaw.

by Vincent Béron

Marcus Meissner wrote: > On Thu, Oct 31, 2002 at 11:10:33AM -0300, Raul Dias wrote: > >>My $0.02, >> >>I always though of a wine as way to run windows apps >>better than windows. >> >>Better also means "more secure" for me. >> >>A way to make it more secure is to catch key API calls and decide if >>the application is allowed to run it or not. >> >>This would be easy to detect if an application is trying to delete >>a file, to open a network connection, or anything that could be >>possible unsafe if not used correct. > > > ... > > The whole issue can probably addressed by very simple sandboxing: > > Just use a WINE pseudo user. > > Then WINE and the windows applications can do only damage within > the pseudo user context, which should be harmless. > > Automated cleanup (like cron based kills or similar) would be easy. > > > Drawback: Does not scale well to a multi user system. > > Ciao, Marcus > > And, as all sandbox designs, is not very practical to use, even for a single user. I'm talking access to documents, etc. And nothing prevents a rogue app to either access the network (and send stuff you feed it), or wipe your fake windows. OTOH, the potential damage is still somewhat contained. In the end, I'd say don't expect any more security than what the host OS can already provide to you. Vincent

Oct. 31, 2002

Re: So lets say we do it

by Dirk

> > If you want more screenshots, then you just need to go to the AppDB. > (although we don't mention it yet, so I'll add a subtitle > "for more screenshots, see AppDB" to the screenshot now) > hmm.. IMHO the screenshots should be shown BEFORE the rest of the site shows up.. screenshots are the most important thing.. when i go to a side to download something that's not a cmdline tool i want screenshots.. and i want A LOT of them... in wine's case that would be screenshots of wine running all M$ products to give people a good laugh and motivate them to go on.. and after that IMPORTANT screenshots of wine running games... and after that some screenshots of wine running crap.. and atfer that the download screen with a 5 or 10 step installation instruction.. and after that the rest... 1) screenshots/flash animation with M$ products 2) screenshots/flash animation with games 3) download and a richly pictured 5 or 10 step installation guide (for dummies.. i mean REAL dummies.. hmm.. or let's say people who just installed Linux/Unix and miss their windows crap) 4) example config files to enable dummies to run the top 10 most-best-favourite-games in 2 or 3 steps (i think this is the MOST important point.. firms who want to run M$ products will have their consulting ppl who do things like installing wine for them.. but ppl who have to do things themselves are almost ppl who want to run games..) .... 5) all BLABLABLA and sciences nobody is interested in when he JUST wants to run M$ stuff on his linux/unix.. maybe you should select someone who takes care only of such stuff.. like "Big mouthing", PR , ranting, tutorial writing, picture drawing, flash animations... etc.. that's meant to be a constructive critic.. for more inspirations have a look here.. http://www.microsoft.com Dirk

Oct. 31, 2002

Re: Wine securityflaw.

by Marcus Meissner

On Thu, Oct 31, 2002 at 11:10:33AM -0300, Raul Dias wrote: > My $0.02, > > I always though of a wine as way to run windows apps > better than windows. > > Better also means "more secure" for me. > > A way to make it more secure is to catch key API calls and decide if > the application is allowed to run it or not. > > This would be easy to detect if an application is trying to delete > a file, to open a network connection, or anything that could be > possible unsafe if not used correct. ... The whole issue can probably addressed by very simple sandboxing: Just use a WINE pseudo user. Then WINE and the windows applications can do only damage within the pseudo user context, which should be harmless. Automated cleanup (like cron based kills or similar) would be easy. Drawback: Does not scale well to a multi user system. Ciao, Marcus

Oct. 31, 2002

Re: So lets say we do it

by Andreas Mohr

On Thu, Oct 31, 2002 at 02:11:31AM -0500, Dimitrie O. Paun wrote: > That is, > > Lets assume for the sake of argument that Alexandre likes my > 0.8 idea so much, that he releases Wine 0.8 with much fanfare > next Monday (so we have a good audience), and the news reaches > Slashdot where a message with a link to http://www.winehq.org > is posted, in good CmdrTaco fashion... > > And so, let's see what's going to happen: > > 1. 90% of /.ers will click on the link, and WineHQ gets Slashdotted! :) > > 2. People will look for the typical left-side menu: > Home > About > Status > Development > Download > Screenshots > > *BZZT* We don't have any. 5% will drop off here. Sorry to say that, but in this mail, *you* were talking *some* crap IMHO ;-) We *do* have screenshots. The About page has some pretty nice screenshot. OK, it's a minimalist approach, granted, but it does show IE etc. If you want more screenshots, then you just need to go to the AppDB. (although we don't mention it yet, so I'll add a subtitle "for more screenshots, see AppDB" to the screenshot now) > 3. Then they'll visually search for the word "Screenshot" > > *BZZT* We don't have any on front page. 30% will drop off. > *I* drop off here when I visit other projects, for crying out loud! The "About Wine" item *definitely* tells *everyone* that a screenshot should be found within the "About Wine" section... If we honoured every stupid link request, then the main page would look like some huge pile of... err... crap. We've been asked directly or indirectly countless times to include certain things on the main page (and we often thought "hmm, this needs quite a bit of attention, so: put it on the main page ??"). But including everything would be a HUGE mistake. Instead WineHQ needs a *clean* and obvious organisation (some improvements might well be possible here, I guess). And the idea of finding screenshot(s) on "About Wine" is definitely as good as it can ever get. > So let's assume that by a miracle they'll discover the screenshots: > do they make them drool? No, we loose another 15%. Hmm, k, it could be a bit more spectacular, correct. > Damn, that's tough! Let's see what happens to the rest: > > 4. Let's download, and try it out > > Do we have officially sanctioned binaries (at the very least > .rpms for RH, and .deb for Debian)? No. *BZZT* We loose another 30%. > Again, *I* don't care about stuff that doesn't come as a binary > .rpm for my RH system. I used to, not anymore. Well... obviously we don't have enough people who are willing to enforce a properly maintained package for various architectures. Instead we've got some chaotic heap of wildly differing packages. One could argue that this situation helps CodeWeavers' bottom line, though ;-) > Fine, some will install what they download. What next? Hm, this > Wine thing just sits there, it's not that simple. We need to > read some docs. Back to the site. > > 5. Look at the docs > > Oh, we have some. We hate to read docs, but Wine is cool, so we > swallow the pill. Only to find out it's out of date!!! What a > piece of #@$%! *I* am definitely not the one to blame here :) (BTW, you got a point here) > *BZZT* Another 10% drop off. > > Thats 90% drop-off before they really tried it out! The rest 10%, > go on. So, what do we do with it? > > 6. Look for a list of Win-apps that we can run > > Is there something on the site? No. Blah, too much hassel... > > *BZZT* Another 5% go. Hmm, I guess it all boils down to having the About page get redesigned a bit. We should definitely include a prominent link to the AppDB, and maybe also a separate page with kickass knock-down screenshots... Does anyone want to give us some ideas about how the page should be redesigned ? > (Don't even mention app-db, it's *way* too complicated!) Huh ?? I really can't follow you on that one... (ok, it's not a dumbed-down page listing some screenshots and nothing else apart from that, but it was never meant to be made for dummies) Which all boils down to the essential question: which amount of morons does our project need/want ? :-) > So the 5% left, install wine, install a Win-app, and play around. > Great, it works! They start learning the utilities, etc., but > those are in flux, and we change them, and they get PO-ed. Another > percent, or two leave the fold... OK, those ~ 90% might be somewhat drastic (after all if you really *need* to run Windoze apps, you'll be willing to go through quite some hassle), but it might be rather high indeed. May I suggest that you'd probably have fixed about 50% of these issues if you hadn't done this ranting about it, but instead used that time to fix them ? ;-)) Take it easy, Andreas

Oct. 31, 2002

RE: winapi_check question...

by Patrik Stridvall

> winapi_check tells me: > > ndr_stubless.c:86: rpcrt4: LONG_PTR WINAPIV > NdrClientCall2(PMIDL_STUB_DESC,PFORMAT_STRING,...): argument 1 > documentation: \ > /* CLIENT_CALL_RETURN */ This is because winapi_check misparser the line: LONG_PTR /* CLIENT_CALL_RETURN */ RPCRT4_NdrClientCall2(PMIDL_STUB_DESC pStubDesc, PFORMAT_STRING pFormat, va_list args) Ignore it. > rpc_epmap.c:56: rpcrt4: RPC_STATUS WINAPI > RpcEpRegisterA(RPC_IF_HANDLE,PRPC_BINDING_VECTOR,PUUID_VECTOR,LPSTR): > no translation defined: PRPC_BINDING_VECTOR This is because winapi_check doesn't know the type of PRPC_BINDING_VECTOR. One day I will teach it to parse the header files properly. Until then tell it what type it is in the the file tools/winapi/win32.api: %%rpcrt4 ... %ptr ... PRPC_BINDING_VECTOR ... Since PRPC_BINDING_VECTOR is presumable a pointer it goes under the ptr section. > rpc_epmap.c:56: rpcrt4: RPC_STATUS WINAPI > RpcEpRegisterA(RPC_IF_HANDLE,PRPC_BINDING_VECTOR,PUUID_VECTOR,LPSTR): > no translation defined: PUUID_VECTOR Same as above. > rpc_epmap.c:102: rpcrt4: RPC_STATUS WINAPI > RpcEpUnregister(RPC_IF_HANDLE,PRPC_BINDING_VECTOR,PUUID_VECTOR): > argument 2 type is forbidden: PRPC_BINDING_VECTOR (unknown) Same as above. > how shall I deal with these? Fix them as above or do as everybody elses do wait for me to fix it. :-)

Oct. 31, 2002

Re: rpc_H_PL9

by Michael Stefaniuc

On Thu, Oct 31, 2002 at 08:49:18AM -0600, Greg Turner wrote: > LICENSE: X11 > > CHANGELOG: > * dlls/rpcrt4: rpc_server.c; > include: rpcdcep.h: > Greg Turner <gmturner007(a)ameritech.net> > - One more fixup for winapi_check > -UINT WINAPI I_RpcWindowProc( HANDLE hWnd, UINT Message, UINT wParam, ULONG lParam) +UINT WINAPI I_RpcWindowProc( void *hWnd, UINT Message, UINT wParam, ULONG lParam ) That's totaly broken. It's a problem in winapi_check and not in your code. Well, their is a problem in your code too, i would change HANDLE to HWND. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 System Administration Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

Oct. 31, 2002