December 2002 - Wine-Devel - list.winehq.org

Debugger / wineconsole problem

by Lionel Ulmer

Hi all, I have a little annoying problem with the wineconsole / winedbg : as soon as I switch to another window and come back to the debugger, I loose keyboard input. Mouse input still works fine. I have also often graphical glitches (ie I have only garbage when scrolling due to a newline being displayed). The scollbar seems also to be non-functionnal. Lionel -- Lionel Ulmer - http://www.bbrox.org/

Dec. 30, 2002

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

by Dimitrie O. Paun

On December 30, 2002 12:43 pm, Dan Kegel wrote: > OK, maybe that's another janitorial project I can take on. You asked for it! :) http://www.dssd.ca/wine/Wine-Janitorial.html#include-quotes -- Dimi.

Dec. 30, 2002

Re: Fixing include quotes (was: Re: conformance test for ShellExecute)

by Dimitrie O. Paun

On December 30, 2002 12:43 pm, Dan Kegel wrote: > OK, maybe that's another janitorial project I can take on. > Is it only the test programs and winelib programs that should be converted > from "" to <>, or is there more? Everything. That is, all files that include things from include/* should use <> instead of "". -- Dimi.

Dec. 30, 2002

Re: File locking ... need info

by Bill Medland

On December 28, 2002 05:08 pm, Mike Robinson wrote: > [Please reply e-mail; I don't yet subscribe.] > > I am interested in support for file-locking and locking of specified > regions of a file, in order to support databases such as MS-Access and > Paradox. > I expect Alexandre will get back to you on this. Anyway here's my input. > But as I ponder the various likely-looking segments of the source-code, I > really do not know where to begin ... nor what has been done in this area > before. Basically much of it has been done before but hasn't made it to the CVS. Way back, Alexandre Julliard implemented it in the Corel source tree. Back in November 2001 I tried reworking the code to fit into the current tree and submitted it (with a few bugs I am sure) but it was not accepted. Alexandre had it on his list of things to do but I don't know where it stands currently. > > It is clear that an implementation of locking must work on SMB-shares and > that it should "actually lock things" in that other Windows users should > see the locks as they are placed and removed. It's also clear that > implementing timeouts on these locks could be "problematic," since the Unix > impl. of file locking is not quite the same as Windows expects. > > Pointers? Comments? War-stories? Advice? "Someone already did that"s? If you do intend working on it then you are going to have to address some of the following issues: 1. Windows region locking has different behaviour with regard to merging regions etc. than Unix. 2. Remember that fcntl locks are on the actual file, not on the handle; and closing one handle drops all the locks on all other handles to the same file. (I am being almost criminally lax with my wording here but it will do for now). 3. The timeouts are going to be an interesting task. However the structure of the wine server should help immensely 4. To the best of my knowledge SMB file systems don't handle it. No one has yet told me differenly on the several occasions I have tried to ask. (I know that Samba serves out locks to Windows machines successfully but if you put an fcntl lock on a file on a SMB share to the best of my knowledge it doesn't translate to an SMB lock request). 5. The whole issue of advisory and mandatory locking. Our software depends quite significantly on region locking but we don't need the full semantics and we can make guarantees such as only one handle open on a file by a process so what we have done is to use winelib and create builtin dlls for our own ones but that use the native fcntl locking. Get back to me if you want further details. -- Bill Medland ACCPAC International, Inc. medbi01(a)accpac.com Corporate: www.accpac.com Hosted Services: www.accpaconline.com

Dec. 30, 2002

Fixing include quotes (was: Re: conformance test for ShellExecute)

by Dan Kegel

Dimitrie O. Paun wrote: > On December 29, 2002 07:45 pm, Dan Kegel wrote: >>+#include "wine/test.h" > > > Please use <> instead of "" even in Wine. The old code > uses "" for historical reasons that are no longer an issue. > It needs to be changed (and we're waiting for some Perl > wizard to help out <g>), but the new code should not perpetuate > this deprecated practice IMO. Yay! OK, maybe that's another janitorial project I can take on. Is it only the test programs and winelib programs that should be converted from "" to <>, or is there more? - Dan -- Dan Kegel Linux User #78045 http://www.kegel.com

Dec. 30, 2002

Re: Regression in msvideo patch

by Stephen Mollett

On Monday 30 Dec 2002 14:36, Eric Pouech wrote: > does the attached patch fix your issue ? That appears to work OK... Thanks. Stephen

Dec. 30, 2002

Alexandre?

by Jeff Smith

I've seen no activity on wine-cvs for a week (Dec 23). What's up? Holiday vacation? Either way, Happy (if belated) Holidays to everyone who celebrates a holiday. :-) -- Jeff S _________________________________________________________________ MSN 8 helps eliminate e-mail viruses. Get 3 months FREE*. http://join.msn.com/?page=features/virus&xAPID=42&PS=47575&PI=7324&DI=7474&… http://www.hotmail.msn.com/cgi-bin/getmsg&HL=1216hotmailtaglines_virusprote…

Dec. 30, 2002

Re: Regression in msvideo patch

by Eric Pouech

> Here are the basic -debugmsg +msvideo logs. The ones with +relay are at: > > http://www.cantoris.demon.co.uk/before-relay.log.bz2 (690,270 B) > http://www.cantoris.demon.co.uk/after-relay.log.bz2 (1,476,695 B) > > so as not to explode anyone's mailbox. :-) They will expand to about 300MB (!) > total. thanx does the attached patch fix your issue ? A+ -- Eric Pouech Index: dlls/msvideo/drawdib.c =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/dlls/msvideo/drawdib.c,v retrieving revision 1.19 diff -u -r1.19 drawdib.c --- dlls/msvideo/drawdib.c 15 Dec 2002 01:14:21 -0000 1.19 +++ dlls/msvideo/drawdib.c 30 Dec 2002 14:33:18 -0000 @@ -64,11 +64,11 @@ { WINE_HDD* hdd; - for (hdd = HDD_FirstHdd; hdd != NULL && hdd->hSelf != hdd; hdd = hdd->next); + for (hdd = HDD_FirstHdd; hdd != NULL && hdd->hSelf != hd; hdd = hdd->next); return hdd; } -static DWORD HDD_HandleRef = 1; +static DWORD HDD_HandleRef = 0x1000; /*********************************************************************** * DrawDibOpen [MSVFW32.@] @@ -80,7 +80,6 @@ TRACE("(void)\n"); whdd = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(WINE_HDD)); - TRACE("=> %p\n", whdd); while (MSVIDEO_GetHddPtr((HDRAWDIB)HDD_HandleRef) != NULL) HDD_HandleRef++; whdd->hSelf = (HDRAWDIB)HDD_HandleRef++; @@ -88,6 +87,8 @@ whdd->next = HDD_FirstHdd; HDD_FirstHdd = whdd; + TRACE("=> %p (%p)\n", whdd->hSelf, whdd); + return whdd->hSelf; } @@ -97,12 +98,22 @@ BOOL VFWAPI DrawDibClose(HDRAWDIB hdd) { WINE_HDD* whdd = MSVIDEO_GetHddPtr(hdd); + WINE_HDD** p; TRACE("(%p)\n", hdd); if (!whdd) return FALSE; if (whdd->begun) DrawDibEnd(hdd); + + for (p = &HDD_FirstHdd; *p != NULL; p = &((*p)->next)) + { + if (*p == whdd) + { + *p = whdd->next; + break; + } + } HeapFree(GetProcessHeap(), 0, whdd);

Dec. 30, 2002

Re: [D3D 67] Fix small compilation bug

by Lionel Ulmer

> This patch fix a compilation bug that was around for 10 patches or so. Hmmm, seems that gcc 3.2 that is in Mandrake is in C99 mode by default... Sorry for all the GCC 2.X users out there :-) Lionel -- Lionel Ulmer - http://www.bbrox.org/

Dec. 30, 2002

Re: Regression in msvideo patch

by Stephen Mollett

On Sunday 29 Dec 2002 16:40, Eric Pouech wrote: > could you send me the two traces (before and after the patch) with > -debugmsg +msvideo... > (if you have a large band connection - or you can put it on a server > somewhere - having another pair of traces with -debugmsg +relay,+msvideo > would be just fine) Hi, Here are the basic -debugmsg +msvideo logs. The ones with +relay are at: http://www.cantoris.demon.co.uk/before-relay.log.bz2 (690,270 B) http://www.cantoris.demon.co.uk/after-relay.log.bz2 (1,476,695 B) so as not to explode anyone's mailbox. :-) They will expand to about 300MB (!) total. Basically, they just record me opening VirtualDub, opening an AVI and pulling the position scroller along a bit. Using the version after the patch, Wine just hangs when the console output is redirected rather than trying to start the debugger. top shows wineserver using about 75% CPU and wine using the rest, until I interrupt the process. Regards, Stephen

Dec. 30, 2002