March 2002 - Wine-Devel - list.winehq.org

Re: cvs doesn't build .. my fault?

by Paul Millar

On 29 Mar 2002, Alexandre Julliard wrote: > Actually ttydrv usually builds just fine without curses, it's just > that my last patch broke it. It should be fixed now. Yep, seems to be fixed now. WRT should relect this after the next compile cycle. Cheers, Paul.

March 29, 2002

Re: cvs doesn't build .. my fault?

by Francois Gouget

On Fri, 29 Mar 2002, Paul Millar wrote: > Hi, > > A couple of things: > > First, I've noticed cvs didn't build for me anymore. The problem was > because I removed the header files for ncurses (ie removed the > ncurses-devel RPM). The file dlls/ttydrv/bitmap.c then failed to compile. > > Having had a look at the code in ttydrv, its fairly obvious it wont build > without either curses or ncurses installed. A simple patch (wine-diff-1) > provides a better error message. It shouldn't be needed (with the next > patch), but might help bug finding in the future. > > But, shouldn't wine simply abstain from building ttydrv if a (n?)curses > package isn't available? I've attached another patch (wine-diff-2) that > does that. AFAIK, there's no knock-on effects. Could this be that you did not re-run a clean configure? -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ Linux: It is now safe to turn on your computer.

March 29, 2002

Re: how to unsubscribe?

by Francois Gouget

On 29 Mar 2002, Ludootje wrote: [...] > So, where can I unsubscribe, and resubscribe (for when I'm back)? > Or even better, is there an option like with sourceforge lists where I > just edit my preferences and check the box which says I don't want to > receive any mails anymore temporarily? http://www.winehq.com/mailman/listinfo/wine-devel You can even temporarily disable receiving emails without unsubscribing. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ La terre est une bêta...

March 29, 2002

Re: Improving the regression testing infrastructure

by Eric Pouech

Francois Gouget a écrit : > > On Fri, 29 Mar 2002, Eric Pouech wrote: > > > > at least until I can find a good way to test > > > CreateProcess... > > a bit out of topic (from the question), but I have an > > embryonic CreateProcess test, so don't bother with that > > (and there is a lot to test here) > > This is interesting. How do you test it? > AFAICS, The problem with the current infrastructure is that you > cannot have a second executable to start. So you have to start yourself, > and then convince the test framework to let you do your thing rather > than just running another test. You cannot just write a perl/bash script > either as this would not work on Windows. > If you put submit a CreateProcess test I would be happy to add checks > for the quote / command line parsing. as of today, the test restarts itself, with a bit of a different command line it's written in C, but didn't test it on windows yet (I know a few issues already) the global test goes as : 1/ the parent creates the child 2/ the parent waits for the child to terminate 3/ the child process stores most information it can gather in a temporary file 4/ the child terminates 5/ the parent does the final checking I did choose the temporary file (instead of registry for example) to be as independant as possible of other APIs (even if the format of the file is a .INI one, and as of today, the parent reads it with private profile API) one of the checking that won't be possible is all the path lookup (except if we decide to copy the exec in different places :-( I'll put something out when I have the test working in Windows A+

March 29, 2002

Re: Improving the regression testing infrastructure

by Francois Gouget

On 29 Mar 2002, Geoffrey Hausheer wrote: [...] > In general, while Francois' presentation is a > good place to get started, I think it'd be a lot easier > if there was a document off of winehq with > recommendations on how to build, test, and document > tests. Lowering the difficulty threshold, is more likely > to draw more people to do so. I agree. Documenting and finishing the test framework is on the list for Wine 0.9.0. I added the corresponding tasks yesterday: * 526 [NEW] - Document the regression testing framework http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=526 * 530 [NEW] - Package the regression tests for Windows http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=530 * 527 [NEW] - Running C regression tests on Windows with MSVC http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=527 * 528 [NEW] - Running C regression tests on Windows with Cygwin/MinGW http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=528 * 529 [NEW] - Running Perl regression tests on Windows http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=529 -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

March 29, 2002

Re: cvs doesn't build .. my fault?

by Alexandre Julliard

Paul Millar <paulm(a)astro.gla.ac.uk> writes: > Having had a look at the code in ttydrv, its fairly obvious it wont build > without either curses or ncurses installed. A simple patch (wine-diff-1) > provides a better error message. It shouldn't be needed (with the next > patch), but might help bug finding in the future. Actually ttydrv usually builds just fine without curses, it's just that my last patch broke it. It should be fixed now. -- Alexandre Julliard julliard(a)winehq.com

March 29, 2002

Re: Improving the regression testing infrastructure

by Francois Gouget

On Fri, 29 Mar 2002, Eric Pouech wrote: > > at least until I can find a good way to test > > CreateProcess... > a bit out of topic (from the question), but I have an > embryonic CreateProcess test, so don't bother with that > (and there is a lot to test here) This is interesting. How do you test it? AFAICS, The problem with the current infrastructure is that you cannot have a second executable to start. So you have to start yourself, and then convince the test framework to let you do your thing rather than just running another test. You cannot just write a perl/bash script either as this would not work on Windows. If you put submit a CreateProcess test I would be happy to add checks for the quote / command line parsing. -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ The greatest programming project of all took six days; on the seventh day the programmer rested. We've been trying to debug the *&^%$#@ thing ever since. Moral: design before you implement.

March 29, 2002

cvs doesn't build .. my fault?

by Paul Millar

Hi, A couple of things: First, I've noticed cvs didn't build for me anymore. The problem was because I removed the header files for ncurses (ie removed the ncurses-devel RPM). The file dlls/ttydrv/bitmap.c then failed to compile. Having had a look at the code in ttydrv, its fairly obvious it wont build without either curses or ncurses installed. A simple patch (wine-diff-1) provides a better error message. It shouldn't be needed (with the next patch), but might help bug finding in the future. But, shouldn't wine simply abstain from building ttydrv if a (n?)curses package isn't available? I've attached another patch (wine-diff-2) that does that. AFAIK, there's no knock-on effects. Second problem, when attempting to verify the build-failure on a different machine (hathi), it failed, but in a different part of the build! It only succeeded on the third machine (romulus) On hathi, a RH-7.0 (w/ Linus-2.4.3 kernel) I got: > make[2]: Entering directory `/disk/hathi1/paulm/wine/dlls/ntdll' > LD_LIBRARY_PATH="../../unicode:$LD_LIBRARY_PATH" > ../../tools/winebuild/winebuild -fPIC -L../../dlls -o ntdll.spec.c > -spec ./ntdll.spec > make[2]: *** [ntdll.spec.c] Segmentation fault (core dumped) [...] After some investigation, it transpires that gcc on hathi (the RH-7.0 machine) builds broken winebuild programs (the unicode library was fine). The RH-7.1 (romulus) could "fix" the problem by recompiling just the winebuild directory. The problem turned out to be because I had old gcc-2.96 RPMs installed. After updating to the latest upgrade RPMs winebuild is built correctly, but wrc is now broken: it segfaults whenever its run. Can anyone with a 7.0 machine verify this? Cheers, Paul.

March 29, 2002

update in EDIT_WM_SetText

by Rizsanyi Zsolt

Hi! I have this next patch: --- controls/edit.c Fri Mar 29 19:03:25 2002 +++ controls/edit.c Fri Mar 29 19:03:09 2002 @@ -4727,7 +4727,10 @@ * if it is multiline, or it is part of combobox */ if( !((es->style & ES_MULTILINE) || es->hwndListBox)) + { EDIT_NOTIFY_PARENT(hwnd, es, EN_CHANGE, "EN_CHANGE"); + EDIT_NOTIFY_PARENT(hwnd, es, EN_UPDATE, "EN_UPDATE"); + } EDIT_EM_ScrollCaret(hwnd, es); } Which fixes an update problem in my program. As much as I understand the program reeds the state of the edit on every EN_UPDATE event. And because EN_UPDATE was not sent, so the program operated with undefined values and could not find the words (its a dictionary program). I see, that the above code is somewhat weird, because two events are sent. But of course if the programs rely on it, then it has to be so. I will let to somebody more acquinted with wine and windows to decide whether this solution is ok. Best regards Zsolt Rizsanyi

March 29, 2002

Re: how to unsubscribe?

by Eric Pouech

> First of all I'd like to say I'm sorry to both you people with this. > I tried some stuff to unsubscribe by going to the default urls of > sourceforge lists etc, but that didn't helped. I went to wine.sf.net, > but didn't found any public mailing list, and I can't remember where I > subscribed to this list. well the mail address is at wine-devel(a)winehq.com so, perhaps, www.winehq.com would be the answer A+

March 29, 2002