April 2002 - Wine-Devel - list.winehq.org

Re: comm.c:COMM_BuildOldCommDCB err...

by Joerg Mayer

On Tue, Apr 23, 2002 at 05:43:32PM -0700, Duane Clark wrote: > Forwarded for marcelo(a)sysmo.com.br > + if (!strncasecmp(device,"COM",3)) strcpy(temp,device+5); > + else strcpy(temp,device); What happens, if device is "COM\0" ? Ciao Jörg -- Joerg Mayer <jmayer(a)loplof.de> I found out that "pro" means "instead of" (as in proconsul). Now I know what proactive means.

April 24, 2002

Re: comm.c: TransmitCommChar

by Mike McCormack

Hi Marcelo, Does this help things? It's not perfect, but it should be better than nothing... Mike Marcelo Welter wrote: > Greatings > > I have some application qhen use the comm.c:TransmitCommChar function, but this function are not implemented. > > anybody have one ideia to me go around this problem...? > > > thaks and sorry per my litle english > > > Marcelo Welter > > Index: dlls/kernel/comm.c =================================================================== RCS file: /home/wine/wine/dlls/kernel/comm.c,v retrieving revision 1.57 diff -u -r1.57 comm.c --- dlls/kernel/comm.c 22 Apr 2002 22:32:13 -0000 1.57 +++ dlls/kernel/comm.c 23 Apr 2002 23:24:45 -0000 @@ -1435,9 +1435,23 @@ HANDLE hComm, /* [in] The communication device in need of a command character. */ CHAR chTransmit) /* [in] The character to transmit. */ { - FIXME("(%x,'%c'), stub ! Use win32 handle!\n",hComm,chTransmit); - return TRUE; + BOOL r = FALSE; + int fd; + + WARN("(%x,'%c') not perfect!\n",hComm,chTransmit); + + fd = FILE_GetUnixHandle( hComm, GENERIC_READ ); + if ( fd < 0 ) + SetLastError ( ERROR_INVALID_PARAMETER ); + else + { + r = (1 == write(fd, &chTransmit, 1)); + close(fd); + } + + return r; } + /***************************************************************************** * GetCommTimeouts (KERNEL32.@)

April 23, 2002

MoveFileExA bug and half-a-solution

by Jeremy Shaw

Hello, The Problem: There is a bug in MoveFileExA (files/file.c). MoveFileExA will (usually) call rename() in libc to move a file. Unfortunately, this causes problems because it does not update the sharing table. I will illustrate with an example. When the Office intaller tries to install Internet Explorer it sees that the file: C:\Windows\System\UrlMon.dll exists and moves it to: C:\Windows\System\IE4Setup\UrlMon.dll it then tries to create the file C:\Windows\System\UrlMon.dll but fails because of a "sharing violation". It believes that a file already exists at c:\window\systems\urlmon.dll, because, according to the shared table, one does. But on the disk, the file has been moved. The Half-a-fix: It seems odd to me that MoveFileExA is directly renaming the file. The other functions in the same file do their dirty work via wineserver. Does it seem reasonable that I should have to add a new wineserver request for "MoveFile" that will rename the file and update the share table? Or am I missing something obvious? Also of note: I do not think this has been a "problem" until some recent changes in MoveFileExA where these lines were removed: /* check, if we are allowed to delete the source */ hFile = CreateFileA(full_name1.long_name, 0, 0, NULL,OPEN_EXISTING,0,0); if(hFile == INVALID_HANDLE_VALUE) return FALSE; CloseHandle(hFile); If a file was being shared, this code would prevent it from being moved. So, perhaps that was the right fix? Maybe you can't move a file that is being "shared"? If that is the case, there does not seem to be code in place anymore to prevent you from moving a shared filed. Thanks for you help! I will send a patch in, as soon as I got one. Jeremy Shaw. Here is a trace of the bug in action: Its shows the file being moved, a log file being updated, and then the CreateFileA failing. ** 080baec8:Call kernel32.MoveFileA(403d1e94 "C:\\WINDOWS\\SYSTEM\\URLMON.DLL",40556734 "C:\\WINDOWS\\SYSTEM\\IE4Setup\\URLMON.DLL") ret=500f6a98 retval=00000001 ** trace:file:MoveFileA (C:\WINDOWS\SYSTEM\URLMON.DLL,C:\WINDOWS\SYSTEM\IE4Setup\URLMON.DLL) ** trace:file:MoveFileExA (C:\WINDOWS\SYSTEM\URLMON.DLL,C:\WINDOWS\SYSTEM\IE4Setup\URLMON.DLL,0002) ** 080baec8:Ret kernel32.MoveFileA() retval=00000001 ret=500f6a98 ** 080baec8:CALL mssetup.87: FLogOpen() ret=500f78ff retval=00000001 ** 080baec8:RET mssetup.87: FLogOpen() retval=00000001 ret=500f78ff ** 080baec8:Call kernel32.FormatMessageA(00000500,500f1be0,00000000,00000000,40556710,00000000,4055670c) ret=500f7927 retval=0000005a ** 080baec8:Ret kernel32.FormatMessageA() retval=0000005a ret=500f7927 ** 080baec8:CALL mssetup.100: FWriteToLogFile(403d20a8,00000000) ret=500f7938 retval=00000001 *** 080baec8:Call kernel32.SetErrorMode(00000001) ret=5009df3c retval=00000000 *** 080baec8:Ret kernel32.SetErrorMode() retval=00000000 ret=5009df3c *** 080baec8:Call kernel32.CreateFileA(4036a7e0 "C:\\WINDOWS\\IE Setup Log.Txt",c0000000,00000000,00000000,00000003,00000000,00000000) ret=5009df92 retval=0000008c *** trace:file:CreateFileA C:\WINDOWS\IE Setup Log.Txt GENERIC_READ GENERIC_WRITE OPEN_EXISTING *** 080baec8:Ret kernel32.CreateFileA() retval=0000008c ret=5009df92 *** 080baec8:Call kernel32.SetErrorMode(00000000) ret=5009dfdd retval=00000001 *** 080baec8:Ret kernel32.SetErrorMode() retval=00000001 ret=5009dfdd *** 080baec8:Call kernel32.SetFilePointer(0000008c,00000000,00000000,00000002) ret=5009e199 retval=0000356a *** trace:file:SetFilePointer handle 140 offset 0 high 0 origin 2 *** 080baec8:Ret kernel32.SetFilePointer() retval=0000356a ret=5009e199 *** 080baec8:Call kernel32.lstrlenA(403d20a8 "\tMoveFile succeeded: C:\\WINDOWS\\SYSTEM\\URLMON.DLL to C:\\WINDOWS\\SYSTEM\\IE4Setup\\"...) ret=5009e388 retval=0000005a *** 080baec8:Ret kernel32.lstrlenA() retval=0000005a ret=5009e388 *** 080baec8:Call kernel32.WriteFile(0000008c,403d20a8,0000005a,405566c8,00000000) ret=5009e161 retval=00000001 *** trace:file:WriteFile 140 0x403d20a8 90 0x405566c8 (nil) *** 080baec8:Ret kernel32.WriteFile() retval=00000001 ret=5009e161 *** 080baec8:Call kernel32.lstrlenA(500c68f4 "\r\n") ret=5009e388 retval=00000002 *** 080baec8:Ret kernel32.lstrlenA() retval=00000002 ret=5009e388 *** 080baec8:Call kernel32.WriteFile(0000008c,500c68f4,00000002,405566c8,00000000) ret=5009e161 retval=00000001 *** trace:file:WriteFile 140 0x500c68f4 2 0x405566c8 (nil) *** 080baec8:Ret kernel32.WriteFile() retval=00000001 ret=5009e161 *** 080baec8:Call kernel32.CloseHandle(0000008c) ret=5009e0ef retval=00000001 *** 080baec8:Ret kernel32.CloseHandle() retval=00000001 ret=5009e0ef ** 080baec8:RET mssetup.100: FWriteToLogFile() retval=00000001 ret=500f7938 ** 080baec8:Call kernel32.LocalFree(403d20a8) ret=500f7941 retval=00000000 ** 080baec8:Ret kernel32.LocalFree() retval=00000000 ret=500f7941 ** 080baec8:Call kernel32.CopyFileA(40556734 "C:\\WINDOWS\\SYSTEM\\IE4Setup\\URLMON.DLL",403d1e94 "C:\\WINDOWS\\SYSTEM\\URLMON.DLL",00000000) ret=500f6aca retval=00000000 ** trace:file:_lopen ('C:\WINDOWS\SYSTEM\IE4Setup\URLMON.DLL',0000) ** trace:file:CreateFileA C:\WINDOWS\SYSTEM\IE4Setup\URLMON.DLL GENERIC_READ FILE_SHARE_READ FILE_SHARE_WRITE OPEN_EXISTING ** trace:file:CreateFileA C:\WINDOWS\SYSTEM\URLMON.DLL GENERIC_WRITE FILE_SHARE_READ FILE_SHARE_WRITE CREATE_ALWAYS ** 080baec8:Ret kernel32.CopyFileA() retval=00000000 ret=500f6aca

April 23, 2002

Re: internet explorer regression

by Justin

----- Original Message ----- From: "Michael Cardenas" <michael.cardenas(a)lindows.com> To: <wine-devel(a)winehq.com> Cc: <jeremy.shaw(a)lindows.com> Sent: Tuesday, April 23, 2002 2:26 PM Subject: internet explorer regression > I just picked up the latest cvs and some time in the last 3 weeks someone put > in a patch that causes IE5 to crash when typing in an address in the address > bar. I used office 2k pro to test. With IE 5.5 and WinME I am able to enter the url into the address bar without crashing. This is with wine downloaded yesterday as wine-20020411.tag.gz Kevin > > Also, windows media player can't install downloaded codecs, and it can in > crossover office, but I'm not sure if that's a regression or an old bug. It > complains about security settings. > > -- > michael cardenas > lead windows compatibility engineer > lindows.com > > "Be the change you want to see in the world" > -Mahatma Gandhi > > >

April 23, 2002

Re: [PATCH] ./tools/wineinstall *correct (.diff) format*

by ccrayne＠crayne.org

In <20020423212458.52050.qmail(a)web13104.mail.yahoo.com>, on 04/23/02 at 02:24 PM, Speeddymon <speeddymon(a)yahoo.com> said: :I'm thinking maybe it added $libdir to ld.so.conf but :didnt run ldconfig... ? What actually happened is that $libdir was already in ld.so.conf, so the script did NOT add it, and therefore, it did NOT run ldconfig. This strategy works when one upgrades modules with identical names, but not when modules are renamed, as was the case with libntdll.dll.so replacing libntdll.so. The line in wineinstall which controls this behavior is: if [ -f /etc/ld.so.conf ] && ! grep -qs "$libdir" /etc/ld.so.conf -- Chuck Crayne ----------------------------------------------------------- ccrayne(a)crayne.org -----------------------------------------------------------

April 23, 2002

RE: tools/wineinstall problems

by Medland, Bill

> -----Original Message----- > From: Stig Vig [mailto:lancer_irc(a)hotmail.com] > Sent: Tuesday, April 23, 2002 1:36 PM > To: wine-devel(a)winehq.com > Subject: tools/wineinstall problems > > > Hi > I love your wine except one thing. I cant install it proper. > When I run > tools/wineinstall and it asks for the root password, it says > it's wrong > password but I have entered the right. In the message it says > that I shoudl > email on this adress if its a problem of this sort. So now I > be gratefull if > you could help me solw my problem. > //greets lancer > > > _________________________________________________________________ > MSN Photos is the easiest way to share and print your photos: > http://photos.msn.com/support/worldwide.aspx > > In the wineinstall script correct the following two lines: 1. Where it mentions "ldconfig" explicitly state "/sbin/ldconfig" 2. Where it says su -c"$sucommand" put su -c "$sucommand" Then run it again and that should solve it. Bill

April 23, 2002

Re: [PATCH] ./tools/wineinstall *correct (.diff) format*

by Speeddymon

well something isn't right with the current wineinstall, because I installed wine to the default directories, and it wasn't finding libntdll.dll.so until after I added $libdir/wine. I'm not sure why that happened, I will do some checking tonight and find out why it wasn't finding the file. I'm thinking maybe it added $libdir to ld.so.conf but didnt run ldconfig... ? I will check that out tonight and a couple other possibilities and let you know the outcome tomorrow... --- Alexandre Julliard <julliard(a)winehq.com> wrote: > $libdir/wine must not be added to ld.so.conf. Users > have to set the > WINEDLLPATH variable if Wine is not installed in the > directory that > was specified with --prefix (which shouldn't happen > with > wineinstall). > > -- > Alexandre Julliard > julliard(a)winehq.com __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 23, 2002

comm.c: TransmitCommChar

by Marcelo Welter

Greatings I have some application qhen use the comm.c:TransmitCommChar function, but this function are not implemented. anybody have one ideia to me go around this problem...? thaks and sorry per my litle english Marcelo Welter

April 23, 2002

Re: The Euro symbol

by Huw D M Davies

On Tue, Apr 23, 2002 at 01:37:23PM -0700, Medland, Bill wrote: > I am looking into getting the Euro symbol (Cp1252 0x80 ie U20ac) to display > (and print) from Wine programs. I am running RedHat 7.1. From my quick > literature search it looks to me like it isn't going to be easy. > Am I being too pessimistic? > Are there people out there who have been using it for ages? Hi Bill, If you're using client side TT fonts and the euro symbol glyph is in the fonts then displaying on the XServer should just work. As for printing, I'm working on downloading TT fonts to the printer at the moment which will mean we'll be able to print the thing as well. Huw.

April 23, 2002

The Euro symbol

by Medland, Bill

I am looking into getting the Euro symbol (Cp1252 0x80 ie U20ac) to display (and print) from Wine programs. I am running RedHat 7.1. From my quick literature search it looks to me like it isn't going to be easy. Am I being too pessimistic? Are there people out there who have been using it for ages? TIA Bill

April 23, 2002

tools/wineinstall problems

by Stig Vig

Hi I love your wine except one thing. I cant install it proper. When I run tools/wineinstall and it asks for the root password, it says it's wrong password but I have entered the right. In the message it says that I shoudl email on this adress if its a problem of this sort. So now I be gratefull if you could help me solw my problem. //greets lancer _________________________________________________________________ MSN Photos is the easiest way to share and print your photos: http://photos.msn.com/support/worldwide.aspx

April 23, 2002

Re: [PATCH] ./tools/wineinstall *correct (.diff) format*

by Alexandre Julliard

Speeddymon <speeddymon(a)yahoo.com> writes: > ModifiedFiles: tools/wineinstall > =================================================================== > RCS file: /home/wine/wine/tools/wineinstall,v > retrieving revision 1.26 > diff -u -r1.26 wineinstall > --- wineinstall 1 Apr 2002 20:56:51 -0000 1.26 > +++ wineinstall 17 Apr 2002 23:06:39 -0000 > @@ -291,6 +310,14 @@ > sucommand="echo $libdir>>/etc/ld.so.conf;ldconfig;$sucommand" > } > fi > + if [ -f /etc/ld.so.conf ] && ! grep -qs "$libdir/wine" /etc.ld.so.conf > + then { > + echo > + echo "$libdir/wine doesn't exist in your /etc/ld.so.conf, it will be" > + echo " added when we perform the install..." > + sucommand="echo $libdir/wine>>/etc/ld.so.conf;$sucommand" > + } > + fi $libdir/wine must not be added to ld.so.conf. Users have to set the WINEDLLPATH variable if Wine is not installed in the directory that was specified with --prefix (which shouldn't happen with wineinstall). -- Alexandre Julliard julliard(a)winehq.com

April 23, 2002

Re: internet explorer regression [correction]

by Michael Cardenas

Correction, there was not a regression. Apparently this bug only happens in the IE which comes bundled with pre-sr1 versions of office. On Tuesday 23 April 2002 06:19 pm, Justin wrote: > ----- Original Message ----- > From: "Michael Cardenas" <michael.cardenas(a)lindows.com> > To: <wine-devel(a)winehq.com> > Cc: <jeremy.shaw(a)lindows.com> > Sent: Tuesday, April 23, 2002 2:26 PM > Subject: internet explorer regression > > > I just picked up the latest cvs and some time in the last 3 weeks someone > > put > > > in a patch that causes IE5 to crash when typing in an address in the > > address > > > bar. I used office 2k pro to test. > > With IE 5.5 and WinME I am able to enter the url into the address bar > without crashing. This is with wine downloaded yesterday as > wine-20020411.tag.gz > > > Kevin > > > Also, windows media player can't install downloaded codecs, and it can in > > crossover office, but I'm not sure if that's a regression or an old bug. > > It > > > complains about security settings. > > > > -- > > michael cardenas > > lead windows compatibility engineer > > lindows.com > > > > "Be the change you want to see in the world" > > -Mahatma Gandhi -- michael cardenas lead windows compatibility engineer lindows.com "Be the change you want to see in the world" -Mahatma Gandhi

April 23, 2002

Re: minor regression testing patch

by Paul Millar

Hi Geoff, On Tue, 23 Apr 2002, Geoffrey Hausheer wrote: [...] > > #define WIN98_PLUS(version) \ > > ( (version.dwPlatformId == VER_PLATFORM_WIN32_WINDOWS) && \ > > ( (version.dwMajorVersion > 4) || \ > > (version.dwMajorVersion==4 && version.dwMinorVersion>0))) > > > > Is this more correct? > > I don't think so. If you look at my test, you'll see that I explicitly check > for WIN98+ OR Win2k+ (that is, for some functions, the only valid operating > systems are Win2k, Winxp, win98, and winme. The code above would allow nt4.0 > in there too. > The following link is how I defined the macros: > http://msdn.microsoft.com/library/en-us/sysinfo/sysinfo_3a0i.asp Ok, When I posted the fix I didn't know the major and minor versions of the various MS OSs. The above link has almost all the information (it doesn't have maj/min versions for Win3.x). If I've got this right, then the following table should summarise the data: dwMajorVersion dwMinorVersion dwPlatformID Win3x+Win32s ? ? VER_PLATFORM_WIN32s Win95 4 0 VER_PLATFORM_WIN32_WINDOWS Win98 4 10 VER_PLATFORM_WIN32_WINDOWS WinME 4 90 VER_PLATFORM_WIN32_WINDOWS NT3.51 3 51 VER_PLATFORM_WIN32_NT NT4.0 4 0 VER_PLATFORM_WIN32_NT Win2k 5 0 VER_PLATFORM_WIN32_NT WINXP 5 1 VER_PLATFORM_WIN32_NT WIN.NET 5 1 VER_PLATFORM_WIN32_NT So, NT3.51 and NT4.0 should both fail the above WIN98_PLUS test (as version.dwPlatformId != VER_PLATFORM_WIN32_WINDOWS). If the test is (Major == 4, Minor > 0) then this would include NT4.0, or am I missing something? > Is something in the test causing a failure? > I've tested them on win2k and win98 (the only real Microsoft OS that I have > access too) Nothing's going wrong. I'm not testing these against any real MS OS, but I came across the code and was curious :) Cheers, Paul. ---- Paul Millar

April 23, 2002

Re: small patch for ./tools/wineinstall

by Speeddymon

alright thanks, the reason i thought you needed internet/cvs was because of the way that the winehq patch-making page was worded...it says to use cvs diff (instead of regular diff). I thoguht that there may be a difference in the 2, so I didnt want to make the diffs with diff when they required cvs diff. But now that I know, i will submit in diff format... Maybe the winehq site maintainer (alexandre?) could make that a little more clear (for us patch-contributing newbies/relative newbies) --- Tony Lambregts <tony_lambregts(a)telusplanet.net> wrote: > Speeddymon wrote: > > >as I have said a couple times, i dont have any way > to > >make the proper diff's due to the fact that I have > no > >internet at home, thanks again for making them for > me, > >I will be submitting the 2 diff's tomorrow (can't > do > >it here due to the fact that this computer is at > >compusa and has downloading disabled) > > > >Would there be anyone willing to make diff's for me > >when I have a patch to post? if so, could you > please > >email me directly so I know who to talk to? > > > >Thanks in advance > > > Well I would be glad to make diffs for you but it > really is not required > that you have CVS or the Internet to make propper > diffs. > > diff -u wineinstall.old wineinstall > > wineinstall.dif > > Where wineinstall.old is the original file (that you > saved somewhere or > got from the tarball) and wineinstall is the file > with your changes. > "man diff" will give you more information but thats > about all that you > need to know. > > You can edit the wineinstall.dif to get rid of the > .old extention but > I'm not sure its required. I guess to be on the safe > side I would get > rid of it. > > Tony Lambregts > > > PS: dont feel too bad there are tons of stuff that I > don't know either. > > __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 23, 2002

Re: Installing MS Office gives error in installer

by Speeddymon

Well, I did use crossover office last night and everything turned out beautifully. Hell when I used that it also helped me (indirectly) to find the icon for loki's port of unreal tournament, so i now have that in my kde menu. what i was saying before though was that the windows link files (.lnk extension) weren't being put into the kde menu, i believe it is a bug/problem in 20020411 wine mainly due to that fact that that wine wouldn't install the icons but crossover office wine would...who knows, all is well now on my computer though. thanks for the help guys. --- Hetz Ben Hamo <hetz(a)kde.org> wrote: > On Monday 22 April 2002 23:48, Speeddymon wrote: > > no, in the installer its the .lnk files (windows > link > > files) that aren't being copied from the cd (or > being > > converted to .desktop files) or something at any > rate > > tho, they never showed up in my kde menu or on my > > desktop... so theres probably a problem in wine > > somewhere. I will try crossover office tonight to > see > > if it installs the files or not... and post back > > tomorrow > > Check it on your .kde directory - they should be > there. I'm running crossover > office and they're appearing quite well. > > Thanks, > Hetz __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 23, 2002

New Winsock2 patch series - now tested

by Martin Wilck

Hi, I will now start to submit a new series of patches for Winsock2-related issues. Most of it is for overlapped IO, but there are some other issues, too. I have done a fair bit of testing with 16 and 32 bit network-oriented Windows apps, and found no regressions (well some apps wouldn't install or run with either the CVS version or my patched version of wine). Among the tested apps are - Opera (v5.12, 32bit, and 3.62, 16bit) - FreeAgent (news reader, 16bit) - Solstice Internet Mail (16bit) - Hamster local news server (32bit, interesting because it's using ReadFile()/WriteFile() for overlapped socket IO) - My evil overlapped testing server/client app I spotted a number of bugs with the "big" patch I sent to wine-devel last Friday. These are fixed in the version I'll submit now. The patch is now split into parts again (one bug fix for an earlier patch of mine that is already in CVS, and 7 "real" parts). Most of the testing has of course been done with the full patch set applied. I have tried to separate logically independent units, but I cannot swear that all is fine if only part of them is applied, and the later patches do fix some important problems. The main reason for splitting the stuff up is to make it easier for people to review. I honestly think that these patches are now ready for being applied to CVS and tested in the field. Here is the overall patch summary (for detailed explanantions see the patches thenmselves): - Correct handling of deferred WSAAccept() operations, - Change register_async() and the queue_async() method to allow more flexibility, needed for sockets, - Server support for overlapped IO on sockets, - Fix problem with FD_CLOSE never being delivered in some situations, - Wait for POLLIN if FD_CLOSE event notification is requested to catch grateful close or shutdown by the peer (empty recv(), no POLLHUP), - Implement overlapped WSARecvFrom()/WSASendTo() and WSAGetOverlappedResult(), - Change shutdown() to account for pending overlapped requests, - Change ReadFile() semantics for overlapped reads on sockets (return even if buffer is not yet full), - Improve error reporting for asynchronous requests (files and sockets) - Account for the SO_OPENTYPE socket option on a per-thread basis. I plan to look into the regression-testing code and also supply a few tests for the new socket functionality. Cheers (and please test this stuff with your apps!), Martin -- Martin Wilck Phone: +49 5251 8 15113 Fujitsu Siemens Computers Fax: +49 5251 8 20409 Heinz-Nixdorf-Ring 1 mailto:Martin.Wilck(a)Fujitsu-Siemens.com D-33106 Paderborn http://www.fujitsu-siemens.com/primergy

April 23, 2002

Re: toolbar.c problem

by Duane Clark

Rick Romero wrote: > I hope it's not a coincidence, but unfortunately I don't know how you > got to the point you did to fix it :) Wasn't easy for someone with as little wine experience as me, that's for sure :-) Basically, fpga_editor actually had two different toolbars. The main one did not work, but some sub-windows had a toolbar that did work. So I traced the application in both cases, and compared what was different. The difference was as I mentioned in the posting you linked to, regarding the call of ReleaseCapture(). I could tell from the return addresses in the traces that ReleaseCapture() was being called directly by the application in the broken case, immediately before TOOLBAR_LButtonUp(), but by wine in the working case. From that point, it was a matter duplicating the procedure in a more controlled environment. I had just recently figured how to use ControlSpy (for some listview bugs), and that turned out to be an ideal testbed for this too.

April 23, 2002

internet explorer regression

by Michael Cardenas

I just picked up the latest cvs and some time in the last 3 weeks someone put in a patch that causes IE5 to crash when typing in an address in the address bar. I used office 2k pro to test. Also, windows media player can't install downloaded codecs, and it can in crossover office, but I'm not sure if that's a regression or an old bug. It complains about security settings. -- michael cardenas lead windows compatibility engineer lindows.com "Be the change you want to see in the world" -Mahatma Gandhi

April 23, 2002

Re: toolbar.c problem

by Rick Romero

On Tue, 2002-04-23 at 10:51, Duane Clark wrote: > Rick Romero wrote: > > > > Forgive the intrusion, but I've been watching your thread, because it > > sounds quite like bug # 434. > > http://bugs.codeweavers.com/long_list.cgi?buglist=434 > > My own feeling is that this probably is not related, because my patch > was pretty specific to mouse up events within the toolbar. The > WM_LBUTTONUP message that you refer to in this bug is sent from many > different routines, depending on where the mouse is in the app. > Also, this bug appears to be a problem of a missing mouse capture > release. In my case, the cursor was being released just fine. It was > just that the expected action was never invoked. >From what I understand some applications (MS VC++ apps) will make some of those calls directly. It appears that my app (MS Visual FoxPro) does this.. So I would assume that VFP itself is sending a LBUTTONUP call whether it's run from Wine or Win9x or Win2k. THEREFORE (caps to indicate massive assumption coming:) the problem is the action isn't invoked.. I support that assumption with my funky 'slowness' test (that nobody else can replicate - how appropriate). The action IS taken when the system is ungodly slow. <shrug> > > > > > I believe it was your toolbar.c patch that initially fixed the toolbar > > issues, but out of curiosity, before the patch, were you able to check > > if it was a regression? (Maybe back to 6/20/01?) I found your comments( > > http://www.winehq.com/hypermail/wine-devel/2002/03/0109.html ), but I > > didn't see any comments indicating a regression test. > > My memory of events that far back is vague, but my recollection is that > the toolbar problem with my two apps (fpga_editor and Designer) has been > there since I started using wine, about May 2000. There were indeed a > number of other regressions triggered by the June 2001 changes, so I do > remember that date fairly well ;) Yes, for that bug, it appears to be something with the wineserver. Maybe it's also releated to the server serialization issues another user posted. > > I think what you described is happening in other areas (see the bug), > > with other apps, but for your app, it only manifested in the toolbars. > > Possible, but I suspect just a coincidence. The TOOLBAR_LButtonUp() > routine should only be called very specifically when the mouse is in the > toolbar. It certainly is possible that there is a very similar problem > in another routine, though. I hope it's not a coincidence, but unfortunately I don't know how you got to the point you did to fix it :) Rick

April 23, 2002

Re:unit test (C) with WINAPIV function

by Eric Pouech

> ok ((wsprintfW (buf, fmt -1) == 10), "wsPrintfW length failure"); shouldn't it be wsprintfW (buf, fmt, -1) == 10 instead ? ^ | A+ --------------- Eric Pouech (http://perso.wanadoo.fr/eric.pouech/) The future will be better tomorrow, Vice President Dan Quayle ____________________________________________________________ Faites un voeu et puis Voila ! www.voila.fr Avec Voila Mail, consultez vos e-mails sur votre mobile Wap.

April 23, 2002

Re: unit test (C) with WINAPIV function

by Francois Gouget

On Tue, 23 Apr 2002, Medland, Bill wrote: > Any chance of some help with this? > > Yesterday i submitted a unit test for wsprintfA. I didn't include wsprintfW > because I couldn't get it to work right. I still can't. I think it's > something to do with the calling convention (since wsprintf uses cdecl, not > stdcall). Here's the test code itself; > > static BOOL wsprintfWTest (void) > { > WCHAR buf[25]; > static const WCHAR fmt[] = {'%','0','1','0','l','d','\0'}; > WCHAR target[] = {'-','0','0','0','0','0','0','0','0','1'}; > > printf ("%p %p\n", buf, fmt); > ok ((wsprintfW (buf, fmt, -1) == 10), "wsPrintfW length failure"); ^ Would adding the above comma fix the problem? > ok ((lstrcmpW (buf, target) == 0), > "wsprintfW zero padded negative value failure\n"); > > return TRUE; > } [...] > Am I missing something obvious? Yes and no :-) -- Francois Gouget fgouget(a)free.fr http://fgouget.free.fr/ It really galls me that most of the computer power in the world is wasted on screen savers. Chris Caldwell from the GIMPS project http://www.mersenne.org/prime.htm

April 23, 2002

Re: unit test (C) with WINAPIV function

by Huw D M Davies

On Tue, Apr 23, 2002 at 09:18:45AM -0700, Medland, Bill wrote: > Any chance of some help with this? > static BOOL wsprintfWTest (void) > { > WCHAR buf[25]; > static const WCHAR fmt[] = {'%','0','1','0','l','d','\0'}; > WCHAR target[] = {'-','0','0','0','0','0','0','0','0','1'}; target's not '\0' terminated. > printf ("%p %p\n", buf, fmt); > ok ((wsprintfW (buf, fmt -1) == 10), "wsPrintfW length failure"); missing a ',' between fmt and -1. > ok ((lstrcmpW (buf, target) == 0), > "wsprintfW zero padded negative value failure\n"); > > return TRUE; > } Huw.

April 23, 2002

RE: unit test (C) with WINAPIV function - sorry

by Medland, Bill

> -----Original Message----- > From: Medland, Bill [mailto:Bill.Medland(a)accpac.com] SNIP > ok ((wsprintfW (buf, fmt -1) == 10), "wsPrintfW length failure"); DUH! > Am I missing something obvious? Yes Bill

April 23, 2002

unit test (C) with WINAPIV function

by Medland, Bill

Any chance of some help with this? Yesterday i submitted a unit test for wsprintfA. I didn't include wsprintfW because I couldn't get it to work right. I still can't. I think it's something to do with the calling convention (since wsprintf uses cdecl, not stdcall). Here's the test code itself; static BOOL wsprintfWTest (void) { WCHAR buf[25]; static const WCHAR fmt[] = {'%','0','1','0','l','d','\0'}; WCHAR target[] = {'-','0','0','0','0','0','0','0','0','1'}; printf ("%p %p\n", buf, fmt); ok ((wsprintfW (buf, fmt -1) == 10), "wsPrintfW length failure"); ok ((lstrcmpW (buf, target) == 0), "wsprintfW zero padded negative value failure\n"); return TRUE; } but if I print the addresses of buf and fmt from within wsprintfW I get the same values for buf but for fmt I get a smaller pointer (0x401ecac instead of 0x401ecae) (and I can't figure out how to get at it in gdb to see exactly what is going on). Am I missing something obvious? Bill

April 23, 2002