April 2002 - Wine-Devel - list.winehq.org

Re: toolbar.c problem

by Duane Clark

Rick Romero wrote: > > Forgive the intrusion, but I've been watching your thread, because it > sounds quite like bug # 434. > http://bugs.codeweavers.com/long_list.cgi?buglist=434 My own feeling is that this probably is not related, because my patch was pretty specific to mouse up events within the toolbar. The WM_LBUTTONUP message that you refer to in this bug is sent from many different routines, depending on where the mouse is in the app. Also, this bug appears to be a problem of a missing mouse capture release. In my case, the cursor was being released just fine. It was just that the expected action was never invoked. > > I believe it was your toolbar.c patch that initially fixed the toolbar > issues, but out of curiosity, before the patch, were you able to check > if it was a regression? (Maybe back to 6/20/01?) I found your comments( > http://www.winehq.com/hypermail/wine-devel/2002/03/0109.html ), but I > didn't see any comments indicating a regression test. My memory of events that far back is vague, but my recollection is that the toolbar problem with my two apps (fpga_editor and Designer) has been there since I started using wine, about May 2000. There were indeed a number of other regressions triggered by the June 2001 changes, so I do remember that date fairly well ;) > I think what you described is happening in other areas (see the bug), > with other apps, but for your app, it only manifested in the toolbars. Possible, but I suspect just a coincidence. The TOOLBAR_LButtonUp() routine should only be called very specifically when the mouse is in the toolbar. It certainly is possible that there is a very similar problem in another routine, though.

April 23, 2002

Re: minor regression testing patch

by Geoffrey Hausheer

> but, MS's documentation: > http://msdn.microsoft.com/library/en-us/sysinfo/sysinfo_49iw.asp > suggests something more like: > > #define WIN98_PLUS(version) \ > ( (version.dwPlatformId == VER_PLATFORM_WIN32_WINDOWS) && \ > ( (version.dwMajorVersion > 4) || \ > (version.dwMajorVersion==4 && version.dwMinorVersion>0))) > > Is this more correct? I don't think so. If you look at my test, you'll see that I explicitly check for WIN98+ OR Win2k+ (that is, for some functions, the only valid operating systems are Win2k, Winxp, win98, and winme. The code above would allow nt4.0 in there too. The following link is how I defined the macros: http://msdn.microsoft.com/library/en-us/sysinfo/sysinfo_3a0i.asp For instance, GetLongPathName is only defined for Win2k and later an Win98 and later (thus no NT4.0): http://msdn.microsoft.com/library/en-us/fileio/filesio_2cv9.asp Is something in the test causing a failure? I've tested them on win2k and win98 (the only real Microsoft OS that I have access too) Thanks, .Geoff

April 23, 2002

Re: toolbar.c problem

by Rick Romero

On Fri, 2002-04-19 at 13:14, Dusan Vujosevic wrote: > > ----- Original Message ----- > From: "Duane Clark" <dclark(a)akamail.com> > To: <wine-devel(a)winehq.com> > Sent: Friday, April 19, 2002 11:41 AM > Subject: Re: toolbar.c problem (ATTN: Duane) > > > > I think you misunderstood my explanation. Once the menu is stuck and the > > button released, I slide the mouse into the flying menu and back out > > again, without pressing any mouse buttons. When the cursor leaves the > > flying menu, it disappears, but without calling TOOLBAR_LButtonUp(). > > This is the second behavior, which may not be related. > > I am working with the latest build of SL and this doesn't happen. I guess > you have the demo and that it does have that problem in which case it is > irrelevant since it has been fixed. > > > >>Unfortunately > > >>for me, my real work is once again interfering severely with the amount > > >>of time I have to spend on Wine :-( > > > > > > > > > I'd be all too happy to help. I will take off my own time to test & fix > > > this. I'll try give you something over the weekend (patch). > > > > > > > > >> But I will try to get in a couple > > >>of tests with ControlSpy with the TBSTYLE_DROPDOWN style, since it > > >>should not take much time, perhaps this weekend. > > > > A suggestion I made a couple weeks ago would make things easier, I would > > think. That would be to duplicate your flying menus within ControlSpy. I > > don't know how easy that would be to implement, but once implemented, it > > would likely make debugging much easier. > > OK, that's what I'll do. I will implement it (not a big deal) and forward it > to you. Expect it this weekend some time.. > > Thanks, > Dusan > Forgive the intrusion, but I've been watching your thread, because it sounds quite like bug # 434. http://bugs.codeweavers.com/long_list.cgi?buglist=434 I believe it was your toolbar.c patch that initially fixed the toolbar issues, but out of curiosity, before the patch, were you able to check if it was a regression? (Maybe back to 6/20/01?) I found your comments( http://www.winehq.com/hypermail/wine-devel/2002/03/0109.html ), but I didn't see any comments indicating a regression test. I think what you described is happening in other areas (see the bug), with other apps, but for your app, it only manifested in the toolbars. Rick

April 23, 2002

Re: fixme:dialog:MSGBOX_OnInit task modal msgbox ! Not modal yet.

by Laurent Pinchart

> > >Just wanted to say the winpos.c.diff patch of 12/25/2001 works like a charm >for me. > [...] > >Thanks Laurent! > You're welcome :-) BTW, why hasn't this patch been commited to CVS ? I submitted twice and never got any feedback before today. Laurent Pinchart

April 23, 2002

existing cooperation with mono?

by Freddy BL

Hi Wine-Team! Existing cooperations between the Wine-project and the Mono-project (http://www.go-mono.org)? At the moment it seams, that in the future there exists under MS-Windows three types of programs: programs which are in native-code (that can be run on Wine and can be portet to Linux by re-compiling with Wine), programs which are in MS-IL-code (that can in the future be run on Mono I hope) and mixed programs (IL-Code-programs, which integrate Native-Code DLLs and Native-Code-programs, which integrate IL-Code DLLs). And I think, that for the last type of programs a cooperation between the Wine-Devels and the Mono-Devels is very advantageous. So, existing this cooperations? (One of the results of an coopration could be an installer like that by CodeWeavers, which can be install both (Wine and Mono) for example) Greatings Freddy BL _________________________________________________________________ Senden und empfangen Sie Hotmail über Ihr Mobilgerät: http://mobile.msn.com

April 23, 2002

Re: Unit testing

by Francois Gouget

Hi Jakob, Jakob Eriksson wrote: > > Is there a tutorial or so for how to create > new unit tests in Wine? Well, not really. The closest thing is the presentation I gave at WineConf2002: http://www.codeweavers.com/about/news/talks/wineconf2002/regression/ Writing proper documentation for the regression framework is part of the Wine 0.9.0 tasklist: http://wine.codeweavers.com/bugzilla/show_bug.cgi?id=526 > If not, I'll just go ahead and use those there are for blueprints. Combined with a quick walk through my presentation, this should pretty much get you up to speed :-) -- Francois Gouget fgouget(a)codeweavers.com

April 23, 2002

Re: fixme:dialog:MSGBOX_OnInit task modal msgbox ! Not modal yet.

by David Yerger

Just wanted to say the winpos.c.diff patch of 12/25/2001 works like a charm for me. [Was my first experience actually building wine from source - took me about two days to figure out how to patch an SRPM and build the patched version. Apparently what you're supposed to do is put the patch in the SOURCES folder, modify the spec file, run rpm -bb <specfile> and let it rip. Had no success doing rpm -bp wine.spec, patching manually and then running configure manually, or using tools/wineconfig, and then running rpm -bi --short-circuit or make install - I could build the program but it complained when I tried to run it. Sorry, I thought I wrote down the complaint. . . Oh well, I'm pretty sure it's because of something I did wrong anyway.] Thanks Laurent! David Yerger

April 23, 2002

Re: Please educate me

by leanne

Medland, Bill wrote: >Can anyone explain what is going on here please; this is obviously an area >of bash etc I don't understand. > >This morning I was doing a fresh install on a totally clean machine from the >Wine-20020411 tarball under Redhat 7.1. > >All went reasonable well until I saw a "..<something not write> .." go >flashing past as I ran wineinstall and later on the regapi failed because it >couldn't find libntdll.dll.so. OK so I guess it was the ldconfig that >failed!! > sorry and do not know I could help. when I got "libntdll.dll.so no such file..." I add a line "/usr/local/lib" in /etc/ld.so.conf and then run "ldconfig" (I guess u install in the default path /usr/local/...) > > >So I thought "lets fix it". Yes; in the last fix to wineinstall where we >went with using "su root" instead the ldconfig was hard-coded (and wasn't on >the path for simply "su root"). So I followed up on the machine I normally >use and started messing about with $ac_cv_path_LDCONFIG. I got that >working, consistant on hand-editing the config.cache to change "true" to >"/sbin/ldconfig". > >So the remaining thing was to get the cache entry generated correctly. This >is where the problem is. (I still don't understand why it should get set >either to the name of an executable or to the value "true"; I dislike >variables holding dissimilar types). Anyway I was watching the loop so see >why it wasn't finding the /sbin/ldconfig and I noticed that > >for ac_dir in /sbin:/usr/sbin:$PATH > >was splitting as >1. /sbin:/usr/sbin:/usr/local/bin >2. /bin >3. /usr/bin >etc. > >Now, I know I can force it to work by changing the for loop to >for ac_dir in /sbin /usr/sbin $PATH > >However the original form used to work (I guess, since the cache is correct >on my other machine) so I'd rather know why it isn't working currently and >fix that > >Can anyone explain why it isn't splitting the for the way we want it to > >TIA > >Bill >

April 23, 2002

Re: Enhancements and fixes for the rich text edit control

by Alexandre Julliard

ccrayne(a)crayne.org writes: > Because of this concept, it was necessay to make two small changes to > edit.c -- to move the definition of the EDITSTATE structure into (new > file) edit.h, and to add support in function EDIT_BuildLineDefs_ML to > recognize "\n" as an alternative soft line break. I don't think richedit should know about edit.c internal structures (and it seems your patch didn't require that anyway) so I haven't applied that part of the patch. If we really need to access the internal edit structure it will have to be made Windows-compatible so that we can still mix builtin and native dlls. But it's better to avoid it if possible. -- Alexandre Julliard julliard(a)winehq.com

April 22, 2002

Re: dlls/kernel/comm.c build failure

by Gil Kloepfer Jr.

I think I probably need to get on the mailing list, but... On Mon, Apr 22, 2002 at 08:46:03AM +0200, Gerald Pfeifer wrote: > The following patch > > revision 1.56 > date: 2002/04/21 22:06:09; author: julliard; state: Exp; lines: +24 -0 > <wine(a)gc2.kloepfer.org> > Faster serial speed cases for non Linux systems. > > broke dlls/kernel/comm.c on FreeBSD 4.5 (and probably all non-Linux > systems) The 57600 and up case (even for Linux) didn't have the CBR_ prefix before them, which is why I didn't have them in the patch I sent to Bugzilla. I compiled the changes I submitted successfully on FreeBSD 4.5-RELEASE, so it should have worked OK. I'll admit to being a newbie at the entire innards of Wine, so I may have misunderstood something. But the code inside the "CBAUD" (I assume this is what Linux uses) #ifdef has all baud rates >38400 without the CBR_ prefix in the switch statement. I simply copied this same set of case statements to the non-CBAUD version (the #elif !defined(__EMX__) case) and changed the port.c_cflag to port.c_ospeed. Hope this helps explain my thought processes. It looks like that whole pair of switch/case/#ifdef statements is screaming for a bit of simplification. (PS: I'll try to cc the mailing lists, but if it doesn't make it, would someone please forward it along ... thanks) --- Gil Kloepfer wine(a)gc2.kloepfer.org

April 22, 2002

Re: Installing MS Office gives error in installer

by Hetz Ben Hamo

On Monday 22 April 2002 23:48, Speeddymon wrote: > no, in the installer its the .lnk files (windows link > files) that aren't being copied from the cd (or being > converted to .desktop files) or something at any rate > tho, they never showed up in my kde menu or on my > desktop... so theres probably a problem in wine > somewhere. I will try crossover office tonight to see > if it installs the files or not... and post back > tomorrow Check it on your .kde directory - they should be there. I'm running crossover office and they're appearing quite well. Thanks, Hetz

April 22, 2002

Unit testing

by Jakob Eriksson

Is there a tutorial or so for how to create new unit tests in Wine? If not, I'll just go ahead and use those there are for blueprints. -- regards, Jakob Eriksson The wages of sin is debugging. -- Ron Jeffries

April 22, 2002

Re: Installing MS Office gives error in installer

by Speeddymon

no, in the installer its the .lnk files (windows link files) that aren't being copied from the cd (or being converted to .desktop files) or something at any rate tho, they never showed up in my kde menu or on my desktop... so theres probably a problem in wine somewhere. I will try crossover office tonight to see if it installs the files or not... and post back tomorrow --- Hetz Ben Hamo <hetz(a)kde.org> wrote: > On Monday 22 April 2002 23:01, Speeddymon wrote: > > actually i did manage to get it work work from the > cd, > > you have to explicitly specify the -o unhide > command > > when you run mount or put the unhide command in > your > > /etc/fstab... > > > > as for the files not getting written, i had the > same > > problem, it is the .lnk files (that i assume go > in > > the start menu on windows)...i am thinking that > they > > aren't being properly converted to .desktop files > or > > something. I will try installing with crossover > > office tonight and post the results tomorrow > > > > -Dustin > > Those .lnk files (you probably mean .kdelnk files) > suppose to appear on your K > menu if you're using KDE. If you still don't see > them after a minute or two > then run manually: kbuildsycoca > > Thanks, > Hetz > __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 22, 2002

RE: bug?

by Speeddymon

actually its a typo in wineinstall, find the line that says: if ! su root -c"$sucommand" and put a space between -c and "$sucommand" i.e. make it: if ! su root -c "$sucommand" --- "Medland, Bill" <Bill.Medland(a)accpac.com> wrote: > > -----Original Message----- > > From: Rikard Bj�rklind [mailto:olof(a)linux.nu] > > Sent: Saturday, April 20, 2002 5:38 AM > > To: wine-devel(a)winehq.com > > Subject: bug? > > > > > > Hi, I tried to use ./tools/wineinstall: > > > > Performing 'make install' as root to install > binaries, enter > > root password > > Password: [here I wrote the password] > > /bin/bash: - : unrecognized option > > > > What's wrong? > > > > > Probably failed to run the ldconfig. > > Check the /etc/ld.so.conf to see that the location > of the wine lib directory > is included (probably /usr/local/lib) and su root > and run /sbin/ldconfig. > > Bill > __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 22, 2002

Re: Installing MS Office gives error in installer

by Hetz Ben Hamo

On Monday 22 April 2002 23:01, Speeddymon wrote: > actually i did manage to get it work work from the cd, > you have to explicitly specify the -o unhide command > when you run mount or put the unhide command in your > /etc/fstab... > > as for the files not getting written, i had the same > problem, it is the .lnk files (that i assume go in > the start menu on windows)...i am thinking that they > aren't being properly converted to .desktop files or > something. I will try installing with crossover > office tonight and post the results tomorrow > > -Dustin Those .lnk files (you probably mean .kdelnk files) suppose to appear on your K menu if you're using KDE. If you still don't see them after a minute or two then run manually: kbuildsycoca Thanks, Hetz

April 22, 2002

Re: Installing MS Office gives error in installer

by Speeddymon

actually i did manage to get it work work from the cd, you have to explicitly specify the -o unhide command when you run mount or put the unhide command in your /etc/fstab... as for the files not getting written, i had the same problem, it is the .lnk files (that i assume go in the start menu on windows)...i am thinking that they aren't being properly converted to .desktop files or something. I will try installing with crossover office tonight and post the results tomorrow -Dustin --- Rizsanyi Zsolt <rizsanyi(a)myrealbox.com> wrote: On Wednesday 17 April 2002 21:42, Speeddymon wrote: > > I just recently installed wine-20020411 (as you > > may > > have noticed from my patch) > > I haven't tried installing Office 2000 on previous > > versions, but heard that it worked, so I decided > to > > try it. First I tried it in Crossover Office > (since i > > just recently got that also) and the Office 2000 > > installer complained that it couldnt find a > package to > > install on the installation media. So I tried it > in > > wine and it did the same thing... There were no > debug > > messages or anything (in the console). > > > > If anyone knows of a way around this, please let > me > > know... If it has been mentioned before please > point > > me to the right wine-devel archive so I can find > it... > > I have also dared to try to install office2k, and > had the same problem. > But I have found a workaround... > When the installation fails, the MSI installer is > already copied to your > windows directory (I think its name is > installmsi.exe or something like that > - I dont have it at hand). So I have tried to invoke > it with the msi file in > the root of the CD (the data1.msi or something like > that - the other msi is > something else). > This way the installation started. The configuration > of what programs to > install worked perfectly, but when copying the files > the installer broke, and > said that it can't write a file. I dont know what > was the problem. I had > enough space, the persmissions were ok, and so on. > > I have tried again, and the installer broke again > but now with a different > file. So I give up, since I don't really need it to > install, just I wanted to > see what the people are talking about... But if you > find a solution (or > submit a patch :), then I will be interested... > > Best regards, > Zsolt Rizsanyi > __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 22, 2002

Re: Installing MS Office gives error in installer

by Speeddymon

I use mandrake 8.2, so the cdrom is mounted with supermount, but i will try that tonight and see what happens -Dustin > --- Gustavo Junior Alves <alves(a)coslinux.com.br> > wrote: > > The install is from a cdrom? You tried "mount > > /dev/cdrom /mnt/cdrom -o > > unhide" ???? > > > > Gustavo > > > > Speeddymon wrote: > > > > >I just recently installed wine-20020411 (as you > may > > >have noticed from my patch) > > >I haven't tried installing Office 2000 on > previous > > >versions, but heard that it worked, so I decided > to > > >try it. First I tried it in Crossover Office > > (since i > > >just recently got that also) and the Office 2000 > > >installer complained that it couldnt find a > package > > to > > >install on the installation media. So I tried it > > in > > >wine and it did the same thing... There were no > > debug > > >messages or anything (in the console). > > > > > >If anyone knows of a way around this, please let > me > > >know... If it has been mentioned before please > > point > > >me to the right wine-devel archive so I can find > > it... > > > > > >Thanks, > > > > > >Dustin > > > > > > >__________________________________________________ > > >Do You Yahoo!? > > >Yahoo! Tax Center - online filing with TurboTax > > >http://taxes.yahoo.com/ > > > > > > > > > > __________________________________________________ > Do You Yahoo!? > Yahoo! Tax Center - online filing with TurboTax > http://taxes.yahoo.com/ > __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 22, 2002

Re: Wine not releasing CDROM

by Duane Clark

Eric Pouech wrote: > > does the attached patch solves the issue ? Fixes it for me. And the behavior with CDROMs is now significantly improved over what it used to be. I used to have to click through a couple of dialogs to switch CDs. But now when I am asked to insert a new CD, I can unmount the old one, mount the new, click OK, and the program immediately finds it.

April 22, 2002

Re: Wine not releasing CDROM

by Eric Pouech

Oliver Sampson a écrit : > > Howdy, > I'm seeing a strange behavior and I thought I'd let the Devel > community know about it: > > While using Agent v1.8, and while having a CD in my CD tray (although > unmounted!), if I start agent under wine, I'm able to open and close > my CD tray. However, if I try to use the attachment window to attach > something, the CD-ROM drive spins up, and I'm unable to open it. Even > if I attach nothing, the CD-ROM drive is claimed by wine so that I > can't eject the Drive. Once I exit agent, the drive is released so > that I can open the drive. Note that the CD-ROM was never mounted. > Even a check during the blocked period shows no mounted device, even > though the "eject' command says "device busy." > > Interestingly, when I just tried this again for this email, I noticed > the following output messages (It seems that there are some floppy > drive assumptions, also.) does the attached patch solves the issue ? A+ Index: files/drive.c =================================================================== RCS file: /home/cvs/cvsroot/wine/wine/files/drive.c,v retrieving revision 1.67 diff -u -r1.67 drive.c --- files/drive.c 9 Mar 2002 23:50:37 -0000 1.67 +++ files/drive.c 22 Apr 2002 17:54:52 -0000 @@ -521,6 +521,7 @@ #define DRIVE_SUPER 96 int fd; off_t offs; + int ret = 0; if (memset(buff,0,DRIVE_SUPER)!=buff) return -1; if ((fd=open(DOSDrives[drive].device,O_RDONLY)) == -1) @@ -551,8 +552,16 @@ break; } - if ((offs) && (lseek(fd,offs,SEEK_SET)!=offs)) return -4; - if (read(fd,buff,DRIVE_SUPER)!=DRIVE_SUPER) return -2; + if ((offs) && (lseek(fd,offs,SEEK_SET)!=offs)) + { + ret = -4; + goto the_end; + } + if (read(fd,buff,DRIVE_SUPER)!=DRIVE_SUPER) + { + ret = -2; + goto the_end; + } switch(DOSDrives[drive].type) { @@ -565,20 +574,27 @@ { ERR("The filesystem is not FAT !! (device=%s)\n", DOSDrives[drive].device); - return -3; + ret = -3; + goto the_end; } break; case DRIVE_CDROM: if (strncmp(&buff[1],"CD001",5)) /* Check for iso9660 present */ - return -3; + { + ret = -3; + goto the_end; + } /* FIXME: do we need to check for "CDROM", too ? (high sierra) */ - break; + break; default: - return -3; - break; + ret = -3; + goto the_end; } return close(fd); + the_end: + close(fd); + return ret; }

April 22, 2002

regapi with global registry

by Raul Dias

Hi, I have a global windows fake tree, which every user in the group "wine" can access. However I got a problem dealing with new applications installed. When a user (any user, even root) installs an application, the registry entries goes to $HOME/.wine/*.reg . This also means that other users will not be able to use it because of the missing registry entries. I use the regSet.sh, regFixer.pl and regRestorer.pl to generete a diff .reg file with the changed registries. When a user (even root) uses regapi to add this values: regapi setValue < file.reg The data goes to the user's registry and not to the global registry (even if the user has access to it). Is there a way to tell wine/regapi (or regedit) to add the new values to the global registry? If not, the only solutions I can think of is: 1 - make every user run the regapi command. 2 - * create a new user (or to use a WINEPREFIX var), * change its config to save the whole registry (which would make the global config save under the user's dir). * copy the resulting registry to the global configuration (/etc/wine.*reg) If it isn't really possible to write to the global wine registry using standard wine tools this is really a drawback in wine which would be needed for a wine 0.9 or 1.0 release. That would allow multi-user wine environments to be easier stablished. Regards, Raul Dias

April 22, 2002

Re: Wine not releasing CDROM

by Duane Clark

Tony Lambregts wrote: > > If this is the case then some regression testing is in order. Is it > just in agent or are other programs showing this behavior? I guess I should have mentioned that this was not with agent. It was with a program where I was using the CD, but then could not get the CD out of the drive until exiting the wine program.

April 22, 2002

Re: Wine not releasing CDROM

by Duane Clark

lawson_whitney(a)juno.com wrote: > On Mon, 22 Apr 2002, Oliver Sampson wrote: > > >> Howdy, >> I'm seeing a strange behavior and I thought I'd let the Devel >> community know about it: >> >> While using Agent v1.8, and while having a CD in my CD tray (although >> unmounted!), if I start agent under wine, I'm able to open and close >> my CD tray. However, if I try to use the attachment window to attach >> >>... > > > If you don't want Wine to attempt raw device access, don't give it a > "Device" = in the [Drive X] entry, I think. Your average Windows app is > inquisitive and tries to look at all drives that have defined devices. It appears to me that there is a new behavior just as Oliver describes. I also had problems this weekend with wine grabbing ahold of the CD and not releasing it, which I don't think has ever been a problem before.

April 22, 2002

Re: Wine not releasing CDROM

by Tony Lambregts

Duane Clark wrote: > lawson_whitney(a)juno.com wrote: > >> On Mon, 22 Apr 2002, Oliver Sampson wrote: >> >> >>> Howdy, >>> I'm seeing a strange behavior and I thought I'd let the Devel >>> community know about it: >>> > >> While using Agent v1.8, and while having a CD in my CD tray (although > >>> unmounted!), if I start agent under wine, I'm able to open and close >>> my CD tray. However, if I try to use the attachment window to attach >>> >>> ... >> >> >> >> If you don't want Wine to attempt raw device access, don't give it a >> "Device" = in the [Drive X] entry, I think. Your average Windows app is >> inquisitive and tries to look at all drives that have defined devices. > > > It appears to me that there is a new behavior just as Oliver > describes. I also had problems this weekend with wine grabbing ahold > of the CD and not releasing it, which I don't think has ever been a > problem before. > If this is the case then some regression testing is in order. Is it just in agent or are other programs showing this behavior? Tony Lambregts

April 22, 2002

RE: wine/objects dc.c

by Medland, Bill

This broke our app. Any ideas why? It was the change on line 348; the other three were ok. (The result is it then goes through an attempt to close down windows which aren't even fully open yet so that X11DRV_GetDC is passed a window for which the pDriverData hasn't been set yet.) Bill > -----Original Message----- > From: Alexandre Julliard [mailto:julliard(a)wine.codeweavers.com] > Sent: Sunday, April 21, 2002 3:11 PM > To: wine-cvs(a)winehq.com > Subject: wine/objects dc.c > > > ChangeSet ID: 1019427035919545120866136 > CVSROOT: /opt/cvs-commit > Module name: wine > Changes by: julliard(a)wine.codeweavers.com 02/04/21 17:10:35 > > Modified files: > objects : dc.c > > Log message: > Fixed handling of visible region in Save/RestoreDC. > > Patch: http://cvs.winehq.com/patch.py?id=1019427035919545120866136 > > Revision Changes Path > 1.73 +4 -4 wine/objects/dc.c > >

April 22, 2002

Re: dlls/kernel/comm.c build failure

by Marcus Meissner

On Mon, Apr 22, 2002 at 08:46:03AM +0200, Gerald Pfeifer wrote: > The following patch > > revision 1.56 > date: 2002/04/21 22:06:09; author: julliard; state: Exp; lines: +24 -0 > <wine(a)gc2.kloepfer.org> > Faster serial speed cases for non Linux systems. > > broke dlls/kernel/comm.c on FreeBSD 4.5 (and probably all non-Linux > systems) > > /usr/bin/gcc -c -I. -I. -I../../include -I../../include -g -O2 -Wall -mpreferred-stack-boundary=2 -fPIC -D__WINE__ -D_REENTRANT -I/usr/X11R6/include -o comm.o comm.c > comm.c: In function `SetCommState': > comm.c:1063: `CBR_230400' undeclared (first use in this function) > comm.c:1063: (Each undeclared identifier is reported only once > comm.c:1063: for each function it appears in.) > gmake[2]: *** [comm.o] Error 1 > gmake[2]: Leaving directory `/.amd_mnt/vexpert/files8/test/wine/dlls/kernel' > gmake[1]: *** [kernel/kernel32.dll.so] Error 2 > > apparently because CBR_230400 is not #defined in include/winbase.h. > > The patch below fixes this, but I suppose it's not what will go in > finally... I would suggest just dropping those 2 cases, MSDN does not list them either. - case CBR_230400: - case CBR_460800: Ciao, Marcus

April 22, 2002