April 2002 - Wine-Devel - list.winehq.org

Re: minor regression testing patch

by Alexandre Julliard

Paul Millar <paulm(a)astro.gla.ac.uk> writes: > > Perhaps it would be best to make a test.h somewhere > > and put all of these kind of definitions someplace so we don't need to > > redefine them for each test. > > Hmmm, was there an email about that a while ago? I thought Alexandre > wasn't happy with the idea, but I can't remember why... Version checks are a bad idea because this is not how Wine is implemented. For instance GetLongPathName under Wine doesn't try to fail if you are running with -winver win95, it just works. Adding version checks in the tests just means that some functions won't get tested if you run with the wrong version. The right way is to always call the function no matter the version, and check that the call either succeeds as expected, or fails in the way that it's supposed to fail on a platform that doesn't support it. -- Alexandre Julliard julliard(a)winehq.com

April 24, 2002

wine and aol7 [was: Re: New Winsock2 patch series - now tested]

by Michael Cardenas

Hello Martin. I tested your new series of patches with aol7 and I get a crash. Attached is the output of aol7 with the segfault caused by the last series of patches. The wine debugger comes up and says " Unhandled exception: page fault on read access to 0x00000000 in 32bit code... FILE_GetUnixHandleType+0x4c [file.c: 346] in libntdll.dll.so 346 if (((access & GENERIC_READ) && (*flags & FD_FLAG_RECV_SHUTDOWN) ) ||" I've been working on trying to figure out why aol7 doesn't work under wine for a few weeks, but I was using the old code up until now. Actually, with the current wine tree, you can launch aol and login, but you can't get any web content or your buddy list. I think that both of these operations go through aol's web proxies and require a successful handshake with the proxy to succeed. Getting aol to run under wine is a major priority for us here at Lindows because of 1.) the sheer size of the installed base of aol users, which is in the tens of millions, and 2.) the fact that for people who rely on aol for internet access, linux is basically useless. Basically, what I know is that aol7 uses asynchronous sockets, but doesn't seem to use overlapped io, unless you're on a modem. When aol is trying to connect to it's web proxy it only sends one packet out when running under wine, and then after a while gets an ACK packet in response from the proxy. The one packet that gets sent is completely identical to the one sent under windows. Under windows, it actually sends out three packets in rapid succession, and then gets a response from the proxy. The packets sent are using the AIM protocol and can be examined using ethereal under windows and under linux. The handshake between the aol client and the proxy is as follows: client -> AIM packet, family: 0x5472 client -> AIM packet, family: 0x5472 client -> AIM packet, family: 0x7963 proxy -> AIM packet, family: 0x7963 I looked at the return code from ws2_32.send and it claims that the requested number of bytes were sent successfully. Also, there are no obvious errors around the time that the handshake packets are sent. I can send the output of +winsock once I get this new seg fault resolved. I have to thank you for the amazing work you're doing on sockets and overlapped IO, and for any help you would be so generous as to offer me. Thanks michael On Tuesday 23 April 2002 01:39 pm, Martin Wilck wrote: > Hi, > > I will now start to submit a new series of patches for > Winsock2-related issues. Most of it is for overlapped IO, but there are > some other issues, too. > > I have done a fair bit of testing with 16 and 32 bit network-oriented > Windows apps, and found no regressions (well some apps wouldn't install or > run with either the CVS version or my patched version of wine). -- michael cardenas lead windows compatibility engineer lindows.com "Be the change you want to see in the world" -Mahatma Gandhi

April 24, 2002

RE: minor regression testing patch

by Geoffrey Hausheer

> -----Original Message----- > From: Paul Millar paulm(a)astro.gla.ac.uk {WineHQ-devel} > ... > > Perhaps it would be best to make a test.h somewhere > > and put all of these kind of definitions someplace so we > don't need to > > redefine them for each test. > > Hmmm, was there an email about that a while ago? I thought Alexandre > wasn't happy with the idea, but I can't remember why... > I looked through the archives again, and couldn't find this topic having been discussed before. In any case, there is already wine/test.h, so I think adding some defines in there should be ok (I don't have a copy in front of me, so maybe it's not exactly the right place). If I don't see any further activity on this thread, I'll just stick the required defines in there next time I submit a test, and see if anyone complains. .Geoff

April 24, 2002

Re: Installing MS Office gives error in installer

by Speeddymon

--- Rizsanyi Zsolt <rizsanyi(a)myrealbox.com> wrote: > On Tuesday 23 April 2002 19:51, Speeddymon wrote: > > what i was saying before though was that the > windows > > link files (.lnk extension) weren't being put into > the > > kde menu, i believe it is a bug/problem in > 20020411 > > wine mainly due to that fact that that wine > wouldn't > > install the icons but crossover office wine > > would...who knows, all is well now on my computer > > though. thanks for the help guys. > > The wineshelllink (the script responsible for > installing the lnk files in the > desktop menu) in the cvs wine assumes, that if you > have a .kde directory in > your home, then you have kde 1.x installed. > And install kde 2.x files only if you have a .kde2 > directory in your home > folder. > But on some systems (eg. RedHat), the kde config > files are in .kde in home > directory. That is the reason why the .desktop files > are not installed on > some systems. > > I have fixed wineshelllink in my cvs copy of wine, > but never submitted it, > because, I'm not really sure how to fix it to work > on all the systems (I dont > know how the other packagers do it). > But if somebody needs, it I'm attaching the patch... > > Best regards > Zsolt Rizsanyi hmm that has me wondering... i will take a look at that tonight as i will have more time then (just gonna run home to get my zip disk right now) and see what I can come up with in terms of having wineshelllink finding the correct version..... we may need to remove the direcory checking stuff altogether... i have a couple ideas... 1) explicitly ask them for their kde version the first time wineshelllink is run (but then they would have to manually change the version number if they upgrade it) 2) always ask what the version # is... 3) read a file created by kde that has the version # in it (if one exists) 4) run some kde command with the --version arg and use it's output to get the kde version if possible 1 and 2 could be implemented directly in bash but then you have the problem of what if it doesn't get run in a terminal, so you could also have someone make a gtk/tk program that asks and is called from wineshelllink or you could do both and have 1 run if $display is set and the other one run if it isn't... just some thoughts... -Dustin __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 24, 2002

Re: [PATCH] ./tools/wineinstall *correct (.diff) format*

by Speeddymon

--- Martin Wilck <Martin.Wilck(a)fujitsu-siemens.com> wrote: > On Tue, 23 Apr 2002 ccrayne(a)crayne.org wrote: > > > :I'm thinking maybe it added $libdir to ld.so.conf > but > > :didnt run ldconfig... ? > > What about simply setting LD_LIBRARY_PATH? > > Martin I would except that I was installing in the default dirs...(i.e. --prefix=/usr/local) etc, so there was no need to set LD_LIBRARY_PATH __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 24, 2002

Re: [PATCH] ./tools/wineinstall *correct (.diff) format*

by Speeddymon

> What actually happened is that $libdir was already > in ld.so.conf, so the > script did NOT add it, and therefore, it did NOT run > ldconfig. This > strategy works when one upgrades modules with > identical names, but not > when modules are renamed, as was the case with > libntdll.dll.so replacing > libntdll.so. > > The line in wineinstall which controls this behavior > is: > > if [ -f /etc/ld.so.conf ] && ! grep -qs "$libdir" > /etc/ld.so.conf > > -- Chuck Crayne Ok, so now I'm wondering who set it up to not run ldconfig if $libdir is in there... I will fix that in a minute and submit the patch later today... __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 24, 2002

Re: comm.c: TransmitCommChar

by Mike McCormack

Hi Marcelo, 1. apply my patch 2. test the program 3. if it doesn't work, send me marcelo.log.gz from wine -debugmsg +file,+comm,+server app.exe > marcelo.log obrigado, Mike Marcelo Welter wrote: > If i send this char to the end of current sended string.. > > something like writefile > > i need a way to send this char to serial, and i can't call writefile directly > > anybody help me...???? > > I have a serial printer used in Point-of-Sale and the factory software needs this F$@*# function. > > thanks > > Marcelo >

April 24, 2002

Re: Porting WineLib on PPC, using Bochs for binaries

by Andriy Palamarchuk

Yann, --- KandY <yann.kalemkarian(a)thales-avionics.com> wrote: > Hi everybody, > > I'm currently very interested by porting some of the > Wine tech.on PPC. [... skipped ...] A bug in Wine Bugzilla database is created for this problem, see: http://wine.codeweavers.com/bugs/show_bug.cgi?id=44 Please, document your progress and additional information in the bug description. Thanks, Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Yahoo! Games - play chess, backgammon, pool and more http://games.yahoo.com/

April 24, 2002

Re: minor regression testing patch

by Paul Millar

On Wed, 24 Apr 2002, Geoffrey Hausheer wrote: > NT4.0 has a minor==0, so no, my test will not allow it to pass. Yes, the dangers of sending emails when you're in a rush ... > However, I was not aware of how dwPlatformID was defined (and I miscounted > parentheses in your macro). Its easy to make mistakes (speaking as someone who just made such a mistake :) > I think the method you proposed would be more robust than the way I > implemented the check, but currently my method should work fine for all > availiable MS platforms. Agreed. I probably would be more robust, but I, too, doubt the existing code will cause any problems (once Major>0 is replaced with Minor>0) .. I was just curious. BTW, it's not really my macro, I just translated it from MS's documented example on their page about GetVersionExA. > Perhaps it would be best to make a test.h somewhere > and put all of these kind of definitions someplace so we don't need to > redefine them for each test. Hmmm, was there an email about that a while ago? I thought Alexandre wasn't happy with the idea, but I can't remember why... Cheers, ---- Paul Millar

April 24, 2002

Re: comm.c: TransmitCommChar

by Marcelo Welter

If i send this char to the end of current sended string.. something like writefile i need a way to send this char to serial, and i can't call writefile directly anybody help me...???? I have a serial printer used in Point-of-Sale and the factory software needs this F$@*# function. thanks Marcelo Em Qua 24 Abr 2002 12:10, você escreceu: > On April 24, 2002 10:58 am, Mike McCormack wrote: > > Unfortunately, that probably requires a hack in the serial driver. > > Actually I should get all these hacks together (including the one for > > polling on RTS,DTR,CD,RI deltas) and submit a patch for Linux 2.5.*... > > in my copious amounts of spare time ;-) > > That'd be real nice, as there was much talk in modifying the serial driver > some time ago. It also looks like the kernel people are willing to help > out Wine. Since we've missed 2.4, maybe we can get them in in time for 2.6 > :)

April 24, 2002