April 2002 - Wine-Devel - list.winehq.org

re: 16-bit apps starting and stopping notification

by Joshua Thielen

> Can somebody give me a hint how is better to approach > implementation of > NFY_EXITTASK, NFY_STARTTASK events generation? Does anyone know what ToolHelpHook does (KERNEL.341)? Could this be used by windows to hook a toolhelp notification function into kernel.dll? > How important do you think is to implement this > functionality, since it is for 16-bit apps only? I still use a 16-bit app for school that uses these functions and that doesn't work in wine. I'm not sure if the app does't work because it needs these notifications or if there is another reason. I attempted to implement this a couple of months ago, but it was an ugly hack since I was calling a toolhelp helper function from kernel.dll (or maybe it was ntdll) in order to send the notification. Regards, Josh Thielen

April 13, 2002

Directory reorganization

by Joshua Thielen

Hello everybody, I have an idea for reorganizing some of the directories in wine. I hope I'm not stating an obvious idea here, but I would like to group everything into the following first level directories: dlls documentation include programs server tools I'm not sure, but maybe the following directories should also be included: libtest miscemu ole The point is to keep all related source files together with their dll directory. This way, if a new hacker is hunting for a bug, it is clear where they should begin to look. Also, it is easier to focus on the code for one dll this way. Here is where I would move things: controls --> dlls/user/controls files --> dlls/ntdll/files graphics --> dlls/gdi/graphics if1632 --> dlls/ntdll/if1632 library --> dlls (and possibly rename to wine?) loader --> dlls/ntdll/loader memory --> dlls/ntdll/memory msdos --> dlls/ntdll/msdos relay32 --> dlls/ntdll/relay32 scheduler --> dlls/ntdll/scheduler win32 --> dlls/ntdll/win32 windows --> dlls/user/windows These are the directories I'm not sure about: miscemu --> programs (possibly rename to wine?) ole --> dlls/ntdll/ole (ole is also used by library, maybe it should go to dlls/library?) tsx11 --> dlls/tsx11 (or maybe we should have a 'drivers' top-level directory?) graphics/tsx11 --> dlls/tsx11/graphics windows/tsx11 --> dlls/tsx11/windows unicode --> dlls/unicode Please let me know what you think. Thanks, Josh Thielen

April 13, 2002

building documentation failed

by Stefan Leichter

Hello, when i run make inside the ~wine/documentation directory i get an error when the pdf is created. The fix is easy for me, just an additional parameter (-s) for the command db2pdf. But before i send the attached patch to wine-patches i like to know if anyone can run make successful in the documentation directory. In this case we may have to add a check in the configure script. If someone is able to build the documentation successful please post the output of "db2pdf -v". Thanks Stefan

April 13, 2002

X11 fork available

by Ove Kaaven

Ever since the main Wine tree changed its license to the LGPL, a fork of the tree under the old license had seemed necessary, and been planned. This fork is now ready. If you're a Wine contributor that don't care all that much about forking, you do not need to leave the official LGPL-ed Wine tree to let the X11-licensed fork live. All you have to do is to agree to license your patches under the X11 license, so we are able to pick it up from wine-patches and apply it to the X11 tree whenever possible. This will make your contributions more widely used, so we encourage as many as possible to do so. And if it's out of the question for you, then we encourage you to tell us that, so that we know that we can never apply your patches. The fork's name was decided after a lot of brainstorming by Eric and me, when we found a name which we both liked... ReWind. It can stand for "Re-engineering Windows", or something like "Rewind to the old Windows days". The fork is currently hosted on SourceForge. The homepage is thus http://rewind.sourceforge.net/ for now. It's not a very fancy page, but all the necessary CVS and mailing list information is there. Go there if you're interested in contributing actively to ReWind. Patches known to come from X11-friendly contributors are already applied to the CVS, but many more patches are waiting for the authors to declare a stance. The CVS repository that ReWind is based on is the WineHQ repository, cleansed of all post-LGPL commits (except the Before-LGPL tag), so all the CVS history of the pre-LGPL Wine is present in the ReWind CVS repository. This ensures that no history is lost in the event that the X11 fork prevails over the LGPL fork. Your help to achieve this is welcome. Followups to this post should preferably go to wine-license. Thanks for your attention.

April 13, 2002

Re: Regression tests, UNICODE vs ASCII

by Andriy Palamarchuk

A couple comments: 1) it is useful to check intermixed API calls, like A->W->A to be sure they do conversions correctly. 2) while testing W functions use some Unicode symbols which do not have corresponding ASCII symbols. Andriy Palamarchuk __________________________________________________ Do You Yahoo!? Yahoo! Tax Center - online filing with TurboTax http://taxes.yahoo.com/

April 13, 2002

Looking for help to implement IOCTL_SCSI_PASS_THROUGH_DIRECT

by Laurent Pinchart

Hi, I need to implement IOCTL_SCSI_PASS_THROUGH_DIRECT for cdroms (and a few other IOCTLs, like IOCTL_SCSI_GET_ADDRESS). As I don't have enough SCSI & cdrom handling experience, I wonder if someone could help me getting started. Should I use the linux CDROM_SEND_PACKET ioctl ? If so, how should I handle the 16-byte command from the windows IOCTL_SCSI_PASS_THROUGH_DIRECT, as the command is 12-bytes long for CDROM_SEND_PACKET ? Any help will be appreciated. Laurent Pinchart

April 12, 2002

Re: update to regression testing framework

by Paul Millar

On 11 Apr 2002, Alexandre Julliard wrote: > I think it's much more useful to have line numbers, it makes it much > easier to find the offending test. If they don't have a meaningful name, sure, but if the name is suitably unique then grep -n, /, or Ctrl+S should work. > Most tests scripts will contain > thousands of individual tests and you won't be able to come up with > meaningful names for them anyway. A lot of those are the same test repeated for different parameters. If the name incorporated the parameters (w/ a printf-style expansion) it wouldn't be too hard. Also, any unmodified test would work as before. > For the same reason, I don't think > displaying every successful test is really useful. Traces are a much > better way to see what's going on IMO. It would be nice (for me anyway :) if tests were line-number independent. As naming tests seems to be a stumbling block, I've attached a patch that just allows announcement of successful test results. I'm hoping it's acceptable. Named tests can wait for another day ... ---- Paul Millar

April 12, 2002

Re: Patch series for async socket IO & winsock2

by Paul Rupe

On 12 Apr 2002, Martin.Wilck(a)fujitsu-siemens.com wrote: > As I said in yesterday's "good news/bad news" posting, this is work in > progress and far from being complete. However, I strongly need > feedback and perhaps some testing by adventurous people. > > Anybody out there with an app that uses overlapped socket IO ?? A good one to look at is Hamster, a local newsserver at <http://home.arcor.de/tgl70/misc/hamster_en.htm>. The nice thing about it is the source code (in Delphi) is available as well. It uses overlapped I/O on sockets, is multithreaded (a good thing to test), and has detailed logging you can turn on. I've used it to debug socket-related problems in the past and even worked on the overlapped I/O problem myself briefly. -- Paul Rupe "She smiled, in the end." p r u p e @ m y r e a l b o x . c o m | Oppose government police-ware on your PC! | Stop the Consumer Broadband and Digital Television Promotion Act! | <http://www.eff.org/alerts/20020322_eff_cbdtpa_alert.html>

April 12, 2002

Re: Patch: sock-shutdown.diff (9 in series)

by Dimitrie O. Paun

On April 12, 2002 11:24 am, Martin Wilck wrote: > +/*********************************************************************** > + * WS2_async_shutdown (INTERNAL) > + * > + * On overlapped sockets, shutdown() must be done asynchronously. > + */ > +static void WS2_async_shutdown ( async_private *as ) > +{ > + ws2_async* wsa = (ws2_async*) as; > + int err = 1; > + > + TRACE ( "async %p %d\n", wsa, wsa->async.type ); > + switch ( wsa->async.type ) > + { > + case ASYNC_TYPE_READ: > + err = shutdown ( wsa->async.fd, 0 ); > + break; > + case ASYNC_TYPE_WRITE: > + err = shutdown ( wsa->async.fd, 1 ); > + break; > + default: > + WARN ("invalid type: %d\n", wsa->async.type ); ^^^^ This is an internal function, isn't this an ERR instead? -- Dimi.

April 12, 2002

Re: Patch: sock-shutdown-file.diff (11 in series)

by Dimitrie O. Paun

On April 12, 2002 11:25 am, Martin Wilck wrote: > + if ( flags & FD_FLAG_RECV_SHUTDOWN ) { > + /* Fixme: WSAESHUTDOWN is unavailable */ ^^^^^^ Don't we want these things as FIXME("WSAESHUTDOWN is unavailable") so we see when we need to fix things? -- Dimi.

April 12, 2002