May 2002 - Wine-Devel - list.winehq.org

Re: Stripping of whitespaces at the end of lines

by Dimitrie O. Paun

On May 29, 2002 11:28 am, Jeremy White wrote: > > Warning: Chaos lies ahead this path. And why is that so? I see no chaos ahead, we can start with a recomandation of 4 space indentation... > Oh c'mon, we haven't had a good flame war in *ages* <g>. Indeed! > Every good developer knows that tabs are evil, and that > four space indentation is the way and the truth and the light...<grin> No, no, no!!! Tabs are _not_ evil, tabs "defined" at anything else than 8 spaces *are* evil... The rest are good tabs! -- Dimi "only the good tabs make it" Paun.

May 29, 2002

Re: Stripping of whitespaces at the end of lines

by Jeremy White

> Warning: Chaos lies ahead this path. Oh c'mon, we haven't had a good flame war in *ages* <g>. Every good developer knows that tabs are evil, and that four space indentation is the way and the truth and the light...<grin> Jer

May 29, 2002

Re: Stripping of whitespaces at the end of lines

by Vincent Béron

"Dimitrie O. Paun" a écrit : > > On May 29, 2002 10:58 am, Medland, Bill wrote: > > > At the same time how about agreeing the size of a tab or removing them > > altogether or agreeing always to use tabs for progra, indentation or ....; > > There no need to agree -- tabs are 8 spaces by definition. It's standard. > As for the indentation size, I think it's time to agree on a size. > It seems to me that most of the code is indented to 4 spaces. My very > first contributions were indented to 2 spaces, but I now think that's > a very bad idea, and I have since fixed those to 4 spaces. > > It really helps to have consisten indentation when reading the code, > (it's _much_ easier for the eye to identify patterns this way). Are there > any objections to having the code indented to 4 spaces? (BTW, I'm > not suggesting on agreeing where to but the curly brackets, I know > that one's a stickler! :)) > > -- > Dimi. Warning: Chaos lies ahead this path. That's exactly what I didn't want to see. Let the developper choose the indentation style. But force him (or some janitor can do it) to remove unneeded spaces _after_ the end of the code on each line! This should make consensus. Having said that, here's my take on the subject of indentation: tabs are 8 spaces, and results in smaller files (1 char vs 4). And if 80 chars is not enough, use a bigger window. There's a reason winedbg comes up in a window 132 chars wide. Vincent

May 29, 2002

Re: Stripping of whitespaces at the end of lines

by Vincent Béron

"Medland, Bill" a écrit : > > > -----Original Message----- > > From: Vincent Béron [mailto:vberon(a)mecano.gme.usherb.ca] > > Sent: Tuesday, May 28, 2002 10:44 PM > > To: wine-patches(a)winehq.org > > Subject: Stripping of whitespaces at the end of lines > > > > > > This is the first post in a series of posts about the same > > subject. The > > plan is to post the rest in the following days (as the total is >2MB > > uncompressed, I don't want to send it all at once). Each patch will be > > compressed (diff.gz) for that same reason. > > > > Alexandre, if you don't intend to apply it, please say so (along with > > why), so I won't post some big patches for nothing. > > > > Changelog > > - Strips whitespaces at the end of some C lines. > > > > Vincent > I would have thought it would be safer simply for Alexandre to do the > stripping locally rather than posting a whole load of patches. > > At the same time how about agreeing the size of a tab or removing them > altogether or agreeing always to use tabs for progra, indentation or ....; > > Bill I didn't want to start something about tab dimensions (not _that_ stupid). If we begin something about that, the next subject will be the mandatory use of vi to edit the files ;) But there are a lot (>20000) of lines which have either some spaces/tabs or combination of both after the final ";" (or "," in the case of function arguments splitted on a couple of lines.) IMHO, it'd be better to remove them (although I admit it's mostly for esthetics reasons). On the same vein, there are also a couple of instances where the final semi-colon is doubled, eg: "return S_OK;;". I removed the second one when grep encountered them. If Alexandre wants to do it locally, I support him (our mailboxes will appreciate). Vincent

May 29, 2002

Re: Stripping of whitespaces at the end of lines

by Dimitrie O. Paun

On May 29, 2002 10:58 am, Medland, Bill wrote: > At the same time how about agreeing the size of a tab or removing them > altogether or agreeing always to use tabs for progra, indentation or ....; There no need to agree -- tabs are 8 spaces by definition. It's standard. As for the indentation size, I think it's time to agree on a size. It seems to me that most of the code is indented to 4 spaces. My very first contributions were indented to 2 spaces, but I now think that's a very bad idea, and I have since fixed those to 4 spaces. It really helps to have consisten indentation when reading the code, (it's _much_ easier for the eye to identify patterns this way). Are there any objections to having the code indented to 4 spaces? (BTW, I'm not suggesting on agreeing where to but the curly brackets, I know that one's a stickler! :)) -- Dimi.

May 29, 2002

RE: Stripping of whitespaces at the end of lines

by Uwe Bonnes

>>>>> "Medland," == Medland, Bill <Bill.Medland(a)accpac.com> writes: >> -----Original Message----- From: Vincent Béron Medland,> I would have thought it would be safer simply for Alexandre to Medland,> do the stripping locally rather than posting a whole load of Medland,> patches. Medland,> At the same time how about agreeing the size of a tab or Medland,> removing them altogether or agreeing always to use tabs for Medland,> progra, indentation or ....; And having that ident rules documented bt the appropriate emacs/lint settings. Bye -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

May 29, 2002

RE: Stripping of whitespaces at the end of lines

by Medland, Bill

> -----Original Message----- > From: Vincent Béron [mailto:vberon(a)mecano.gme.usherb.ca] > Sent: Tuesday, May 28, 2002 10:44 PM > To: wine-patches(a)winehq.org > Subject: Stripping of whitespaces at the end of lines > > > This is the first post in a series of posts about the same > subject. The > plan is to post the rest in the following days (as the total is >2MB > uncompressed, I don't want to send it all at once). Each patch will be > compressed (diff.gz) for that same reason. > > Alexandre, if you don't intend to apply it, please say so (along with > why), so I won't post some big patches for nothing. > > Changelog > - Strips whitespaces at the end of some C lines. > > Vincent I would have thought it would be safer simply for Alexandre to do the stripping locally rather than posting a whole load of patches. At the same time how about agreeing the size of a tab or removing them altogether or agreeing always to use tabs for progra, indentation or ....; Bill

May 29, 2002

Re: Main window size difference

by Andriy Palamarchuk

Guy, --- "Guy L. Albertelli" <galberte(a)neo.lrun.com> wrote: > Has anyone else noticed that the size of main > windows under Windows is much > different than under Wine. [skipped] if nobody fixes this issue now I'd recommend you to submit a bug report about this issue, so the information won't be lost. Andriy __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

May 29, 2002

Re: Quick question on the Cygwin/Mingw port

by Andriy Palamarchuk

--- Steven Edwards <Steven_Ed4153(a)yahoo.com> wrote: [skip] > I'm using cygwin to host my mingw WINE devel with > --target=mingw > --host-mingw --build=mingw -mno-cygwin and > -fnative-struct and it is > still linking to cygwin1.dll. I don't really > understand whats going on > because it doesn't seem to be using any of the > exports from cygwin1.dll > but if I try to test the dlls/programs/tools on > another box it bitches > about missing the dll. Linking with only -mno-cygwin option works for me to compile an app on Windows, like: gcc -mno-cygwin $1.o -o $1.exe This is with cygwin toolchain. Not sure if it helps. Andriy __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

May 29, 2002

Re: Idea for people with priveleges

by Andriy Palamarchuk

--- Dustin Navea <speeddymon(a)yahoo.com> wrote: > Anyone that can modify the layout of the BugZilla > site > should take this into consideration: > > People with priveleges as you know can pretty much > do > what they need to with a bug, i.e. if it is resolved > and the person working on it forgot to set it as > resolved, anyone with preveleges can do that. But, > what about if we havent heard from the reporter in a > while and we need to knock the bug out, our only > option is to ask the reporter if it has been > resolved, > tell them to try it with a recent wine build and to > try some of the things mentioned in the comments, > and > then mark it as resolved and them after that mark it > as closed, so it is shown as closed and not resolved > on the bug list... > > why not give people with priveleges the ability to > close it without resolving it, so that they only > have > to make 1 post instead of 2? Plus that way we have > bugs that are actually resolved marked so, and ones > that we are unsure of marked as closed but can > always > be reopened... Why do you want to close such bug in the first place? IMHO it is Ok to put the bug in the RESOLVED state and wait some time if the original reporter provides feedback or more information will become available. Keeping the bug in RESOLVED state will insure that somebody will look at the bug one more time. Is this too many steps? >From Bugzilla docs: "QA looks at resolved bugs and to make sure the appropriate action has been taken. If they agree, the bug is marked VERIFIED. Bugs remain in this state until the product ships, at which time the bug is marked CLOSED." Currently we do not have one more "verification layer" for bugs. Andriy __________________________________________________ Do You Yahoo!? Yahoo! - Official partner of 2002 FIFA World Cup http://fifaworldcup.yahoo.com

May 29, 2002